From nobody Mon Feb 9 21:20:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) client-ip=209.85.128.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=quarantine dis=quarantine) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1642507415; cv=none; d=zohomail.com; s=zohoarc; b=AwJy+iDHdNPFDzxbptfkUyAFBe3ZoblID+r4WIPywEilxLmCTTn/ASbh1/b0AFC1Xma6eT6xxqE8Nn2u7Bt1QLGhTiKL8VYdbabP8K6cG+saPfILNYseKYen5UJ5UsZ+AhhVeybtdYY4VnSl/FdGGETMMPdILs4KEUmVxa86znA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642507415; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LH1np9mC2V/eUKzC6Bkjy+7mnVJOayOIQUCd7oM8o9s=; b=BJ9wNoVWWny5nqDIHeR7LnZZ646nSJXTPIFHvQuF56l76Cyt5CnbQ9X2L4wcg70gAR9G2xuIyaAaUr8QScIzg/v4sTfGjZJv65kEM8M9XpoU6L7ZdOMAVo/GitUYqQ5zRC2PM2sp16U/5GDxLwXYm3Uno+5XcvMwDiqI17OnTqY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by mx.zohomail.com with SMTPS id 1642507415617235.14432827746373; Tue, 18 Jan 2022 04:03:35 -0800 (PST) Received: by mail-wm1-f43.google.com with SMTP id c66so27132334wma.5 for ; Tue, 18 Jan 2022 04:03:35 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (154.red-83-50-83.dynamicip.rima-tde.net. [83.50.83.154]) by smtp.gmail.com with ESMTPSA id y8sm937781wrd.11.2022.01.18.04.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jan 2022 04:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LH1np9mC2V/eUKzC6Bkjy+7mnVJOayOIQUCd7oM8o9s=; b=U4bnjt30y5BZpwtBtsgul8P5+WJaUsyJMcRL9xt9c7IwagHgosPZpmofBf8yzgdXer 5YsKPWmJH3yCmdEry7ZAP0+fGiSgzs9kocfQWfsPd91iB8KgoepIOWSNfJDnexWvWoap nxMKtHgVzyd0q620I3UUDuwcLYhMrvzN9LPI+9MPaHn2d4m0iw9UZNEXhITmKTuCY7J0 ZU6o1EsRjQlRxMYTT+5p4BYEpa1c+BIFEs6AYt3lvTLY4C8Pr8SiSU6KsaVb3k26RGZH 6UzdUa7mWskJcHqBS6DPwbzo1g2xUQZRkftmjwjAMSiMbBzolA0gCDKOBPgwZ2+v0TeY 6N2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=LH1np9mC2V/eUKzC6Bkjy+7mnVJOayOIQUCd7oM8o9s=; b=mp6izDEycxAKDpHJd2t95QSKtxdcbzW84bCznXPvelxNIy7LsU+txOIeC7AWHJyQkq Bih+Ux7kFb2N1tHhdqCZQLWXxyarM+s65cjTp0KXcEvQFcjvoV+NNJhMqhhg/R3VAVPK pUAAtH1bEnUuIR0Wr/fiay01Jgr7COR3+qNs8EpoGrIiZPZ7pnJjSIv3aa7MzIhldxvd ISeKdbIyANrIZrf2bVaxSx9opVGwug1Myob9tkFbycKugt2+0jVUSeUUzjwKg8Q2Mypo HImfQKdeu3iA1LY4AuI+JVFM//vVXDp1Ff5F+UozKF3UfFryFmwGwVpAwD7K565N6N9i C06g== X-Gm-Message-State: AOAM532Nlyg7oo0ZNLhHJbZZnwvpA+4ajkvK9WbseSU4zIZuIpfcx3By FrD/AiTevAI3zgHd62qVaR4= X-Google-Smtp-Source: ABdhPJy8RvtjoWCRRiXB4vExUoY2PnEpXsEipkrsNiGZHHRbfsHc3yvWQCP2wbiMSwDPiyGX0znGjQ== X-Received: by 2002:a05:6000:2c8:: with SMTP id o8mr14092719wry.539.1642507413777; Tue, 18 Jan 2022 04:03:33 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Xu , David Hildenbrand , Paolo Bonzini , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Yuval Shaia , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 13/19] hw/rdma/rdma_utils: Rename rdma_pci_dma_map 'len' argument Date: Tue, 18 Jan 2022 13:02:23 +0100 Message-Id: <20220118120229.196337-14-f4bug@amsat.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220118120229.196337-1-f4bug@amsat.org> References: <20220118120229.196337-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1642507417748100001 From: Philippe Mathieu-Daud=C3=A9 Various APIs use 'pval' naming for 'pointer to val'. rdma_pci_dma_map() uses 'plen' for 'PCI length', but since 'PCI' is already explicit in the function name, simplify and rename the argument 'len'. No logical change. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Reviewed-by: Yuval Shaia Tested-by: Yuval Shaia Message-Id: <20220111184309.28637-7-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/rdma/rdma_utils.h | 2 +- hw/rdma/rdma_utils.c | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/rdma/rdma_utils.h b/hw/rdma/rdma_utils.h index 9fd0efd940b..0c6414e7e0a 100644 --- a/hw/rdma/rdma_utils.h +++ b/hw/rdma/rdma_utils.h @@ -38,7 +38,7 @@ typedef struct RdmaProtectedGSList { GSList *list; } RdmaProtectedGSList; =20 -void *rdma_pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t plen); +void *rdma_pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t len); void rdma_pci_dma_unmap(PCIDevice *dev, void *buffer, dma_addr_t len); void rdma_protected_gqueue_init(RdmaProtectedGQueue *list); void rdma_protected_gqueue_destroy(RdmaProtectedGQueue *list); diff --git a/hw/rdma/rdma_utils.c b/hw/rdma/rdma_utils.c index 98df58f6897..61cb8ede0fd 100644 --- a/hw/rdma/rdma_utils.c +++ b/hw/rdma/rdma_utils.c @@ -17,29 +17,29 @@ #include "trace.h" #include "rdma_utils.h" =20 -void *rdma_pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t plen) +void *rdma_pci_dma_map(PCIDevice *dev, dma_addr_t addr, dma_addr_t len) { void *p; - hwaddr len =3D plen; + hwaddr pci_len =3D len; =20 if (!addr) { rdma_error_report("addr is NULL"); return NULL; } =20 - p =3D pci_dma_map(dev, addr, &len, DMA_DIRECTION_TO_DEVICE); + p =3D pci_dma_map(dev, addr, &pci_len, DMA_DIRECTION_TO_DEVICE); if (!p) { rdma_error_report("pci_dma_map fail, addr=3D0x%"PRIx64", len=3D%"P= RId64, - addr, len); + addr, pci_len); return NULL; } =20 - if (len !=3D plen) { - rdma_pci_dma_unmap(dev, p, len); + if (pci_len !=3D len) { + rdma_pci_dma_unmap(dev, p, pci_len); return NULL; } =20 - trace_rdma_pci_dma_map(addr, p, len); + trace_rdma_pci_dma_map(addr, p, pci_len); =20 return p; } --=20 2.34.1