From nobody Fri Apr 26 01:17:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1642092181; cv=none; d=zohomail.com; s=zohoarc; b=m3uL3D5xOiRMlw/LNLDC1FcFcm2erYRSjx5bNAGs6n2fIAWDzwWCFNjSPkRGPfgVcGbQ6ARmv1DQysDgMVWBnzUiUgTDZJLXiHTPDnXaJRsS68BLVMvrrG6ZoxKyYLq/rVRxpQPAwHmPVj2z1QPsUKyYBaUBPmh5FWBbECkuIUk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642092181; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L9XN2MzcOe3pjNo5kMW55ndRPl2eUs+22EKB+VCTLKA=; b=R9CGA2tH9q5xppaLyvbP0mv+kl+EYJoXrOnk0AZdtWw1sQWaQ+WiTe0BD8aw5sVkks10nNvFSKQUghfoIkRLs0dHcL/KU5u9k0O+Lp0Z4KSsCWTuFbC84ngeqOEZ4PhEBKK/tputAfNiiQLkMg+1fUPwlrNFiikNkfJ+sFLNHgA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1642092181363889.926176250965; Thu, 13 Jan 2022 08:43:01 -0800 (PST) Received: from localhost ([::1]:44068 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n83Bk-0000lQ-Ba for importer@patchew.org; Thu, 13 Jan 2022 11:43:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3zlXgYQcKChECv4AB8vx55x2v.t537v3B-uvCv2454x4B.58x@flex--venture.bounces.google.com>) id 1n838d-0006fS-6P for qemu-devel@nongnu.org; Thu, 13 Jan 2022 11:39:47 -0500 Received: from [2607:f8b0:4864:20::b4a] (port=43778 helo=mail-yb1-xb4a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3zlXgYQcKChECv4AB8vx55x2v.t537v3B-uvCv2454x4B.58x@flex--venture.bounces.google.com>) id 1n838a-0002MA-JS for qemu-devel@nongnu.org; Thu, 13 Jan 2022 11:39:46 -0500 Received: by mail-yb1-xb4a.google.com with SMTP id z23-20020a25ad97000000b00611938ef715so12218925ybi.10 for ; Thu, 13 Jan 2022 08:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc:content-transfer-encoding; bh=L9XN2MzcOe3pjNo5kMW55ndRPl2eUs+22EKB+VCTLKA=; b=XulikX9qEcvJUBwcPeDJxtExgziTrLeOmNgNIvrTmB1DcSpinF4ntSzivBu4dNmgJA Ci4+lWnVte7XbY9Ilwhbg3V7jIRBbw5kqGI68C/gbXwlt7Kk8jZYOPbKT65BzpWiHOAN p6G8Ml1egv3zOLCxzUodCWXlKN1Uh9CvJi2678LappBw0/29iP+qmW9cI7XvgeIzdpgV ihMB9TESYd2GSbfVyvyaJ8JmIvNtZXtPDyK0EdzArtL0uaPpvYdKJXCHtvF0uaZ/16XZ UlLhDNXBy4S2fxRVuVf4Cx7YoC3bPTVJmlvD8PSWWfpAJ5j+BykQUaQC9JdILxW5zy5i NX0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc:content-transfer-encoding; bh=L9XN2MzcOe3pjNo5kMW55ndRPl2eUs+22EKB+VCTLKA=; b=0PYZTQt1MOmo6xvUPxgcF0WSQuFGjoEWyiuJJJTSEbEzWEJ2pgrNgebP0OZVEcUHOy ZuWtyxkwiHQ+phvbY4FuBYth9RYwI9gNsPRurwBR200OdwmJ7xHQzJaxIWYk45Ek5Zl6 kgrqs25/moJ1u3HEZBi19t4KD9Qt/AjFRIeOJRtrSF+D5Iajqf66IxldLZ0w6AdsuGzY Kxr6S3rio7ajfZlFFeSyoU/RhzsYWwPiBBynB3XA+Df89BD4B8x/CSycNtZtIfsEVp5G jQd8dlqkQWK9JSRpzCV5g4b4z61HyXbkeE9IqUqhvYc5D6wfe9ASefjIsV6LzqSXBe4h hgWg== X-Gm-Message-State: AOAM532kej4JDKRha/S/SkRtjGOyeyWg5Q2/QdFxlFyVxMIn5DevhcPl hiorWElyyzT0BYHodZRg14Ox9dZELueZ X-Google-Smtp-Source: ABdhPJxd1o2YF0NdOVX8eUTUOknqOquoR+RlExqQA1leR0/JH2rMjI1XRycPChVQhTmT4TueqL6sl1xEaU8b X-Received: from venture.svl.corp.google.com ([2620:15c:2a3:200:e292:b948:2633:96]) (user=venture job=sendgmr) by 2002:a25:61d8:: with SMTP id v207mr3697066ybb.108.1642091982380; Thu, 13 Jan 2022 08:39:42 -0800 (PST) Date: Thu, 13 Jan 2022 08:39:33 -0800 In-Reply-To: <20220113163934.2556958-1-venture@google.com> Message-Id: <20220113163934.2556958-2-venture@google.com> Mime-Version: 1.0 References: <20220113163934.2556958-1-venture@google.com> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog Subject: [PATCH v3 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface From: Patrick Venture To: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, f4bug@amsat.org, cminyard@mvista.com Cc: qemu-devel@nongnu.org, Hao Wu , Doug Evans Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::b4a (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::b4a; envelope-from=3zlXgYQcKChECv4AB8vx55x2v.t537v3B-uvCv2454x4B.58x@flex--venture.bounces.google.com; helo=mail-yb1-xb4a.google.com X-Spam_score_int: -87 X-Spam_score: -8.8 X-Spam_bar: -------- X-Spam_report: (-8.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1642092184002100001 Content-Type: text/plain; charset="utf-8" From: Hao Wu SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible interface that reports AMD SoC's Ttcl (normalized temperature), and resembles a typical 8-pin remote temperature sensor's I2C interface to BMC. This patch implements a basic AMD SB-TSI sensor that is compatible with the open-source data sheet from AMD and Linux kernel driver. Reference: Linux kernel driver: https://lkml.org/lkml/2020/12/11/968 Register Map: https://developer.amd.com/wp-content/resources/56255_3_03.PDF (Chapter 6) Signed-off-by: Hao Wu Reviewed-by: Doug Evans Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- meson.build | 1 + hw/sensor/trace.h | 1 + include/hw/sensor/sbtsi.h | 45 +++++ hw/sensor/tmp_sbtsi.c | 369 ++++++++++++++++++++++++++++++++++++++ hw/sensor/Kconfig | 4 + hw/sensor/meson.build | 1 + hw/sensor/trace-events | 5 + 7 files changed, 426 insertions(+) create mode 100644 hw/sensor/trace.h create mode 100644 include/hw/sensor/sbtsi.h create mode 100644 hw/sensor/tmp_sbtsi.c create mode 100644 hw/sensor/trace-events diff --git a/meson.build b/meson.build index c1b1db1e28..3634214546 100644 --- a/meson.build +++ b/meson.build @@ -2494,6 +2494,7 @@ if have_system 'hw/rtc', 'hw/s390x', 'hw/scsi', + 'hw/sensor', 'hw/sd', 'hw/sh4', 'hw/sparc', diff --git a/hw/sensor/trace.h b/hw/sensor/trace.h new file mode 100644 index 0000000000..e4721560b0 --- /dev/null +++ b/hw/sensor/trace.h @@ -0,0 +1 @@ +#include "trace/trace-hw_sensor.h" diff --git a/include/hw/sensor/sbtsi.h b/include/hw/sensor/sbtsi.h new file mode 100644 index 0000000000..9073f76ebb --- /dev/null +++ b/include/hw/sensor/sbtsi.h @@ -0,0 +1,45 @@ +/* + * AMD SBI Temperature Sensor Interface (SB-TSI) + * + * Copyright 2021 Google LLC + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, but WIT= HOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * for more details. + */ +#ifndef QEMU_TMP_SBTSI_H +#define QEMU_TMP_SBTSI_H + +/* + * SB-TSI registers only support SMBus byte data access. "_INT" registers = are + * the integer part of a temperature value or limit, and "_DEC" registers = are + * corresponding decimal parts. + */ +#define SBTSI_REG_TEMP_INT 0x01 /* RO */ +#define SBTSI_REG_STATUS 0x02 /* RO */ +#define SBTSI_REG_CONFIG 0x03 /* RO */ +#define SBTSI_REG_TEMP_HIGH_INT 0x07 /* RW */ +#define SBTSI_REG_TEMP_LOW_INT 0x08 /* RW */ +#define SBTSI_REG_CONFIG_WR 0x09 /* RW */ +#define SBTSI_REG_TEMP_DEC 0x10 /* RO */ +#define SBTSI_REG_TEMP_HIGH_DEC 0x13 /* RW */ +#define SBTSI_REG_TEMP_LOW_DEC 0x14 /* RW */ +#define SBTSI_REG_ALERT_CONFIG 0xBF /* RW */ +#define SBTSI_REG_MAN 0xFE /* RO */ +#define SBTSI_REG_REV 0xFF /* RO */ + +#define SBTSI_STATUS_HIGH_ALERT BIT(4) +#define SBTSI_STATUS_LOW_ALERT BIT(3) +#define SBTSI_CONFIG_ALERT_MASK BIT(7) +#define SBTSI_ALARM_EN BIT(0) + +/* The temperature we stored are in units of 0.125 degrees. */ +#define SBTSI_TEMP_UNIT_IN_MILLIDEGREE 125 + +#endif diff --git a/hw/sensor/tmp_sbtsi.c b/hw/sensor/tmp_sbtsi.c new file mode 100644 index 0000000000..d5406844ef --- /dev/null +++ b/hw/sensor/tmp_sbtsi.c @@ -0,0 +1,369 @@ +/* + * AMD SBI Temperature Sensor Interface (SB-TSI) + * + * Copyright 2021 Google LLC + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, but WIT= HOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * for more details. + */ + +#include "qemu/osdep.h" +#include "hw/i2c/smbus_slave.h" +#include "hw/sensor/sbtsi.h" +#include "hw/irq.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qapi/visitor.h" +#include "qemu/log.h" +#include "qemu/module.h" +#include "qom/object.h" +#include "trace.h" + +#define TYPE_SBTSI "sbtsi" +#define SBTSI(obj) OBJECT_CHECK(SBTSIState, (obj), TYPE_SBTSI) + +/** + * SBTSIState: + * temperatures are in units of 0.125 degrees + * @temperature: Temperature + * @limit_low: Lowest temperature + * @limit_high: Highest temperature + * @status: The status register + * @config: The config register + * @alert_config: The config for alarm_l output. + * @addr: The address to read/write for the next cmd. + * @alarm: The alarm_l output pin (GPIO) + */ +typedef struct SBTSIState { + SMBusDevice parent; + + uint32_t temperature; + uint32_t limit_low; + uint32_t limit_high; + uint8_t status; + uint8_t config; + uint8_t alert_config; + uint8_t addr; + qemu_irq alarm; +} SBTSIState; + +#define SBTSI_LIMIT_LOW_DEFAULT (0) +#define SBTSI_LIMIT_HIGH_DEFAULT (560) +#define SBTSI_MAN_DEFAULT (0) +#define SBTSI_REV_DEFAULT (4) +#define SBTSI_ALARM_L "alarm_l" + +/* + * The integer part and decimal of the temperature both 8 bits. + * Only the top 3 bits of the decimal parts are used. + * So the max temperature is (2^8-1) + (2^3-1)/8 =3D 255.875 degrees. + */ +#define SBTSI_TEMP_MAX_IN_MILLIDEGREE 255875 + +/* The integer part of the temperature in terms of 0.125 degrees. */ +static uint8_t get_temp_int(uint32_t temp) +{ + return temp >> 3; +} + +/* + * The decimal part of the temperature, in terms of 0.125 degrees. + * H/W store it in the top 3 bits so we shift it by 5. + */ +static uint8_t get_temp_dec(uint32_t temp) +{ + return (temp & 0x7) << 5; +} + +/* + * Compute the temperature using the integer and decimal part, + * in terms of 0.125 degrees. The decimal part are only the top 3 bits + * so we shift it by 5 here. + */ +static uint32_t compute_temp(uint8_t integer, uint8_t decimal) +{ + return (integer << 3) + (decimal >> 5); +} + +/* Compute new temp with new int part of the temperature. */ +static uint32_t compute_temp_int(uint32_t temp, uint8_t integer) +{ + return compute_temp(integer, get_temp_dec(temp)); +} + +/* Compute new temp with new dec part of the temperature. */ +static uint32_t compute_temp_dec(uint32_t temp, uint8_t decimal) +{ + return compute_temp(get_temp_int(temp), decimal); +} + +/* The integer part of the temperature. */ +static void sbtsi_update_status(SBTSIState *s) +{ + s->status =3D 0; + if (s->alert_config & SBTSI_ALARM_EN) { + if (s->temperature >=3D s->limit_high) { + s->status |=3D SBTSI_STATUS_HIGH_ALERT; + } + if (s->temperature <=3D s->limit_low) { + s->status |=3D SBTSI_STATUS_LOW_ALERT; + } + } +} + +static void sbtsi_update_alarm(SBTSIState *s) +{ + sbtsi_update_status(s); + if (s->status !=3D 0 && !(s->config & SBTSI_CONFIG_ALERT_MASK)) { + qemu_irq_raise(s->alarm); + } else { + qemu_irq_lower(s->alarm); + } +} + +static uint8_t sbtsi_read_byte(SMBusDevice *d) +{ + SBTSIState *s =3D SBTSI(d); + uint8_t data =3D 0; + + switch (s->addr) { + case SBTSI_REG_TEMP_INT: + data =3D get_temp_int(s->temperature); + break; + + case SBTSI_REG_TEMP_DEC: + data =3D get_temp_dec(s->temperature); + break; + + case SBTSI_REG_TEMP_HIGH_INT: + data =3D get_temp_int(s->limit_high); + break; + + case SBTSI_REG_TEMP_LOW_INT: + data =3D get_temp_int(s->limit_low); + break; + + case SBTSI_REG_TEMP_HIGH_DEC: + data =3D get_temp_dec(s->limit_high); + break; + + case SBTSI_REG_TEMP_LOW_DEC: + data =3D get_temp_dec(s->limit_low); + break; + + case SBTSI_REG_CONFIG: + case SBTSI_REG_CONFIG_WR: + data =3D s->config; + break; + + case SBTSI_REG_STATUS: + sbtsi_update_alarm(s); + data =3D s->status; + break; + + case SBTSI_REG_ALERT_CONFIG: + data =3D s->alert_config; + break; + + case SBTSI_REG_MAN: + data =3D SBTSI_MAN_DEFAULT; + break; + + case SBTSI_REG_REV: + data =3D SBTSI_REV_DEFAULT; + break; + + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: reading from invalid reg: 0x%02x\n", + __func__, s->addr); + break; + } + + trace_tmp_sbtsi_read_data(s->addr, data); + return data; +} + +static void sbtsi_write(SBTSIState *s, uint8_t data) +{ + trace_tmp_sbtsi_write_data(s->addr, data); + switch (s->addr) { + case SBTSI_REG_CONFIG_WR: + s->config =3D data; + break; + + case SBTSI_REG_TEMP_HIGH_INT: + s->limit_high =3D compute_temp_int(s->limit_high, data); + break; + + case SBTSI_REG_TEMP_LOW_INT: + s->limit_low =3D compute_temp_int(s->limit_low, data); + break; + + case SBTSI_REG_TEMP_HIGH_DEC: + s->limit_high =3D compute_temp_dec(s->limit_high, data); + break; + + case SBTSI_REG_TEMP_LOW_DEC: + s->limit_low =3D compute_temp_dec(s->limit_low, data); + break; + + case SBTSI_REG_ALERT_CONFIG: + s->alert_config =3D data; + break; + + case SBTSI_REG_TEMP_INT: + case SBTSI_REG_TEMP_DEC: + case SBTSI_REG_CONFIG: + case SBTSI_REG_STATUS: + case SBTSI_REG_MAN: + case SBTSI_REG_REV: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: writing to read only reg: 0x%02x data: 0x%02x\n", + __func__, s->addr, data); + break; + + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: writing to invalid reg: 0x%02x data: 0x%02x\n", + __func__, s->addr, data); + break; + } + sbtsi_update_alarm(s); +} + +static int sbtsi_write_data(SMBusDevice *d, uint8_t *buf, uint8_t len) +{ + SBTSIState *s =3D SBTSI(d); + + if (len =3D=3D 0) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: writing empty data\n", __func_= _); + return -1; + } + + s->addr =3D buf[0]; + if (len > 1) { + sbtsi_write(s, buf[1]); + if (len > 2) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: extra data at end\n", __fu= nc__); + } + } + return 0; +} + +/* Units are millidegrees. */ +static void sbtsi_get_temperature(Object *obj, Visitor *v, const char *nam= e, + void *opaque, Error **errp) +{ + SBTSIState *s =3D SBTSI(obj); + uint32_t temp =3D s->temperature * SBTSI_TEMP_UNIT_IN_MILLIDEGREE; + + visit_type_uint32(v, name, &temp, errp); +} + +/* Units are millidegrees. */ +static void sbtsi_set_temperature(Object *obj, Visitor *v, const char *nam= e, + void *opaque, Error **errp) +{ + SBTSIState *s =3D SBTSI(obj); + uint32_t temp; + + if (!visit_type_uint32(v, name, &temp, errp)) { + return; + } + if (temp > SBTSI_TEMP_MAX_IN_MILLIDEGREE) { + error_setg(errp, "value %" PRIu32 ".%03" PRIu32 " C is out of rang= e", + temp / 1000, temp % 1000); + return; + } + + s->temperature =3D temp / SBTSI_TEMP_UNIT_IN_MILLIDEGREE; + sbtsi_update_alarm(s); +} + +static int sbtsi_post_load(void *opaque, int version_id) +{ + SBTSIState *s =3D opaque; + + sbtsi_update_alarm(s); + return 0; +} + +static const VMStateDescription vmstate_sbtsi =3D { + .name =3D "SBTSI", + .version_id =3D 0, + .minimum_version_id =3D 0, + .post_load =3D sbtsi_post_load, + .fields =3D (VMStateField[]) { + VMSTATE_UINT32(temperature, SBTSIState), + VMSTATE_UINT32(limit_low, SBTSIState), + VMSTATE_UINT32(limit_high, SBTSIState), + VMSTATE_UINT8(config, SBTSIState), + VMSTATE_UINT8(status, SBTSIState), + VMSTATE_UINT8(addr, SBTSIState), + VMSTATE_END_OF_LIST() + } +}; + +static void sbtsi_enter_reset(Object *obj, ResetType type) +{ + SBTSIState *s =3D SBTSI(obj); + + s->config =3D 0; + s->limit_low =3D SBTSI_LIMIT_LOW_DEFAULT; + s->limit_high =3D SBTSI_LIMIT_HIGH_DEFAULT; +} + +static void sbtsi_hold_reset(Object *obj) +{ + SBTSIState *s =3D SBTSI(obj); + + qemu_irq_lower(s->alarm); +} + +static void sbtsi_init(Object *obj) +{ + SBTSIState *s =3D SBTSI(obj); + + /* Current temperature in millidegrees. */ + object_property_add(obj, "temperature", "uint32", + sbtsi_get_temperature, sbtsi_set_temperature, + NULL, NULL); + qdev_init_gpio_out_named(DEVICE(obj), &s->alarm, SBTSI_ALARM_L, 0); +} + +static void sbtsi_class_init(ObjectClass *klass, void *data) +{ + ResettableClass *rc =3D RESETTABLE_CLASS(klass); + DeviceClass *dc =3D DEVICE_CLASS(klass); + SMBusDeviceClass *k =3D SMBUS_DEVICE_CLASS(klass); + + dc->desc =3D "SB-TSI Temperature Sensor"; + dc->vmsd =3D &vmstate_sbtsi; + k->write_data =3D sbtsi_write_data; + k->receive_byte =3D sbtsi_read_byte; + rc->phases.enter =3D sbtsi_enter_reset; + rc->phases.hold =3D sbtsi_hold_reset; +} + +static const TypeInfo sbtsi_info =3D { + .name =3D TYPE_SBTSI, + .parent =3D TYPE_SMBUS_DEVICE, + .instance_size =3D sizeof(SBTSIState), + .instance_init =3D sbtsi_init, + .class_init =3D sbtsi_class_init, +}; + +static void sbtsi_register_types(void) +{ + type_register_static(&sbtsi_info); +} + +type_init(sbtsi_register_types) diff --git a/hw/sensor/Kconfig b/hw/sensor/Kconfig index 9c8a049b06..27f6f79c84 100644 --- a/hw/sensor/Kconfig +++ b/hw/sensor/Kconfig @@ -21,3 +21,7 @@ config ADM1272 config MAX34451 bool depends on I2C + +config AMDSBTSI + bool + depends on I2C diff --git a/hw/sensor/meson.build b/hw/sensor/meson.build index 059c4ca935..f7b0e645eb 100644 --- a/hw/sensor/meson.build +++ b/hw/sensor/meson.build @@ -4,3 +4,4 @@ softmmu_ss.add(when: 'CONFIG_DPS310', if_true: files('dps31= 0.c')) softmmu_ss.add(when: 'CONFIG_EMC141X', if_true: files('emc141x.c')) softmmu_ss.add(when: 'CONFIG_ADM1272', if_true: files('adm1272.c')) softmmu_ss.add(when: 'CONFIG_MAX34451', if_true: files('max34451.c')) +softmmu_ss.add(when: 'CONFIG_AMDSBTSI', if_true: files('tmp_sbtsi.c')) diff --git a/hw/sensor/trace-events b/hw/sensor/trace-events new file mode 100644 index 0000000000..21ab3809e2 --- /dev/null +++ b/hw/sensor/trace-events @@ -0,0 +1,5 @@ +# See docs/devel/tracing.rst for syntax documentation. + +# tmp_sbtsi.c +tmp_sbtsi_write_data(uint8_t addr, uint8_t value) "SBTSI write addr:0x%02x= data: 0x%02x" +tmp_sbtsi_read_data(uint8_t addr, uint8_t value) "SBTSI read addr:0x%02x d= ata: 0x%02x" --=20 2.34.1.575.g55b058a8bb-goog From nobody Fri Apr 26 01:17:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1642092309; cv=none; d=zohomail.com; s=zohoarc; b=kMpK0IeF7vARWb5JNjvAgJqjwNa/K9Gz/lKmRAwaZWVWJ82yyVv0orgTqb7sKm3rKDobHlxYkwoSczRXgi3v8uq6nWhIQmQw8DcadauadwLTr+m+3zvjNl97oLv6XcegG2h94SzOnSWLaVOQfAKny64P0yqdGKlRmFmzFFKqKa0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642092309; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LifCWiTQZmNhrBu401wbAO4/VaPVPFl+xifbloSN9Os=; b=E8+XSVNlvxWu9lUqb1AgEfa8sI6EeZLC/2DyPgx6yNYHpgMd8kOgEZYmkDHYcZuBim6QJvWfSoE8itPOVwsy6e2L5Far0TwfF+jKwLuGNJtam07wvMjqkt8VWIbGMcfLphUkl4ri1tbYLoTri3S/Td5WuWjnI3qBaO/yOc9Jns8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1642092309521688.5834039026; Thu, 13 Jan 2022 08:45:09 -0800 (PST) Received: from localhost ([::1]:48218 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n83Do-0003Y5-Dz for importer@patchew.org; Thu, 13 Jan 2022 11:45:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <30VXgYQcKChQFy7DEBy08805y.w86Ay6E-xyFy578707E.8B0@flex--venture.bounces.google.com>) id 1n838f-0006k5-HC for qemu-devel@nongnu.org; Thu, 13 Jan 2022 11:39:49 -0500 Received: from [2607:f8b0:4864:20::f4a] (port=50141 helo=mail-qv1-xf4a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <30VXgYQcKChQFy7DEBy08805y.w86Ay6E-xyFy578707E.8B0@flex--venture.bounces.google.com>) id 1n838d-0002Ma-L7 for qemu-devel@nongnu.org; Thu, 13 Jan 2022 11:39:49 -0500 Received: by mail-qv1-xf4a.google.com with SMTP id ib7-20020a0562141c8700b0040812bc4425so6208644qvb.16 for ; Thu, 13 Jan 2022 08:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=LifCWiTQZmNhrBu401wbAO4/VaPVPFl+xifbloSN9Os=; b=BdDU8xQwJrziYkpMPT5scs/YareWo4fA8n728+E7WZab9/93blNf/92gpt0j62jTQy IhE0MXSgrlTjdqd0UxflVeY7/E2+c+62Lx76qGl4tNfhTaIcKb5XnWhiD2bBF0TIEs/C kgYqlYoT5WvDlu4beVISyQC3kbvTuOj6e/c8iLcT70diXKHOu0gHBmjrBO4cLBJs+diz 9wtdUXqpvb6kFln9/0/yyqeqNFa0JVvm6uMsVNtFL7Bh13QD5qTrG0CZwIuSdSVSc8rn UoLjknhvbw7DmkETIoqHSyvMu9LHV1282nlCeXhSPJWu/h0SEzTZeg9Qlb+G2yVR3nye U1Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=LifCWiTQZmNhrBu401wbAO4/VaPVPFl+xifbloSN9Os=; b=OY37trvcvwzOLWvgz/zjpndfjMKU/MHIqQiywsDhwCiUJ1EKxkH3I3dnvEC2dERL9G I9QbhupdV9QdDfxQ0zq30euMRGw+2Df1FAQ3wV9+lDvFW0NEny12EFFB9mNBVIoGbEDv MK7C72BJvBxq1kp4FVKWXnuffxAs8ZR4ZOsYMbSK/Y5zQo1D0c61tKKRr/QjwEt27kAS 0T6CoW0A1f+3Ac68T53j2VEdek0vKgv8JiUfs2oui0O9nzBfmx67l2aBj7xtBS1YE1AR sCrrfRFk6QwGEoQk14ROoSZBF0ZBq+P0xlxzYO0T+/cnd2EjPfcMnBQmaKerLMIWSxyL +5zg== X-Gm-Message-State: AOAM532d/h+d/zlbNCanbGq19kASABlQM16mjtItxiKv32ZneUhd9sAy gLBcl3PhAWTyO+CkTaMDrxLRywaciPR2 X-Google-Smtp-Source: ABdhPJziaM1iX12bYgULW0Vx9CHZZdX7SVu9fVMwUAwVP+Hr9IImucMDYDfXw9H3xKDAufg/tMROdK5mWTc5 X-Received: from venture.svl.corp.google.com ([2620:15c:2a3:200:e292:b948:2633:96]) (user=venture job=sendgmr) by 2002:a05:622a:1046:: with SMTP id f6mr4152358qte.517.1642091985787; Thu, 13 Jan 2022 08:39:45 -0800 (PST) Date: Thu, 13 Jan 2022 08:39:34 -0800 In-Reply-To: <20220113163934.2556958-1-venture@google.com> Message-Id: <20220113163934.2556958-3-venture@google.com> Mime-Version: 1.0 References: <20220113163934.2556958-1-venture@google.com> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog Subject: [PATCH v3 2/2] tests: add qtest for hw/sensor/sbtsi From: Patrick Venture To: thuth@redhat.com, lvivier@redhat.com, pbonzini@redhat.com, f4bug@amsat.org, cminyard@mvista.com Cc: qemu-devel@nongnu.org, Hao Wu , Doug Evans , Patrick Venture X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f4a (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::f4a; envelope-from=30VXgYQcKChQFy7DEBy08805y.w86Ay6E-xyFy578707E.8B0@flex--venture.bounces.google.com; helo=mail-qv1-xf4a.google.com X-Spam_score_int: -87 X-Spam_score: -8.8 X-Spam_bar: -------- X-Spam_report: (-8.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1642092311841100001 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Hao Wu Reviewed-by: Doug Evans Signed-off-by: Hao Wu Signed-off-by: Patrick Venture Acked-by: Thomas Huth --- tests/qtest/tmp-sbtsi-test.c | 161 +++++++++++++++++++++++++++++++++++ tests/qtest/meson.build | 1 + 2 files changed, 162 insertions(+) create mode 100644 tests/qtest/tmp-sbtsi-test.c diff --git a/tests/qtest/tmp-sbtsi-test.c b/tests/qtest/tmp-sbtsi-test.c new file mode 100644 index 0000000000..ff1e193739 --- /dev/null +++ b/tests/qtest/tmp-sbtsi-test.c @@ -0,0 +1,161 @@ +/* + * QTests for the SBTSI temperature sensor + * + * Copyright 2020 Google LLC + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, but WIT= HOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * for more details. + */ + +#include "qemu/osdep.h" + +#include "libqtest-single.h" +#include "libqos/qgraph.h" +#include "libqos/i2c.h" +#include "qapi/qmp/qdict.h" +#include "qemu/bitops.h" +#include "hw/sensor/sbtsi.h" + +#define TEST_ID "sbtsi-test" +#define TEST_ADDR (0x4c) + +/* The temperature stored are in units of 0.125 degrees. */ +#define LIMIT_LOW_IN_MILLIDEGREE (10500) +#define LIMIT_HIGH_IN_MILLIDEGREE (55125) + +static uint32_t qmp_sbtsi_get_temperature(const char *id) +{ + QDict *response; + int ret; + + response =3D qmp("{ 'execute': 'qom-get', 'arguments': { 'path': %s, " + "'property': 'temperature' } }", id); + g_assert(qdict_haskey(response, "return")); + ret =3D (uint32_t)qdict_get_int(response, "return"); + qobject_unref(response); + return ret; +} + +static void qmp_sbtsi_set_temperature(const char *id, uint32_t value) +{ + QDict *response; + + response =3D qmp("{ 'execute': 'qom-set', 'arguments': { 'path': %s, " + "'property': 'temperature', 'value': %d } }", id, value= ); + g_assert(qdict_haskey(response, "return")); + qobject_unref(response); +} + +/* + * Compute the temperature using the integer and decimal part and return + * millidegrees. The decimal part are only the top 3 bits so we shift it by + * 5 here. + */ +static uint32_t regs_to_temp(uint8_t integer, uint8_t decimal) +{ + return ((integer << 3) + (decimal >> 5)) * SBTSI_TEMP_UNIT_IN_MILLIDEG= REE; +} + +/* + * Compute the integer and decimal parts of the temperature in millidegree= s. + * H/W store the decimal in the top 3 bits so we shift it by 5. + */ +static void temp_to_regs(uint32_t temp, uint8_t *integer, uint8_t *decimal) +{ + temp /=3D SBTSI_TEMP_UNIT_IN_MILLIDEGREE; + *integer =3D temp >> 3; + *decimal =3D (temp & 0x7) << 5; +} + +static void tx_rx(void *obj, void *data, QGuestAllocator *alloc) +{ + uint16_t value; + uint8_t integer, decimal; + QI2CDevice *i2cdev =3D (QI2CDevice *)obj; + + /* Test default values */ + value =3D qmp_sbtsi_get_temperature(TEST_ID); + g_assert_cmpuint(value, =3D=3D, 0); + + integer =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_INT); + decimal =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_DEC); + g_assert_cmpuint(regs_to_temp(integer, decimal), =3D=3D, 0); + + /* Test setting temperature */ + qmp_sbtsi_set_temperature(TEST_ID, 20000); + value =3D qmp_sbtsi_get_temperature(TEST_ID); + g_assert_cmpuint(value, =3D=3D, 20000); + + integer =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_INT); + decimal =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_DEC); + g_assert_cmpuint(regs_to_temp(integer, decimal), =3D=3D, 20000); + + /* Set alert mask in config */ + i2c_set8(i2cdev, SBTSI_REG_CONFIG_WR, SBTSI_CONFIG_ALERT_MASK); + value =3D i2c_get8(i2cdev, SBTSI_REG_CONFIG); + g_assert_cmphex(value, =3D=3D, SBTSI_CONFIG_ALERT_MASK); + /* Enable alarm_en */ + i2c_set8(i2cdev, SBTSI_REG_ALERT_CONFIG, SBTSI_ALARM_EN); + value =3D i2c_get8(i2cdev, SBTSI_REG_ALERT_CONFIG); + g_assert_cmphex(value, =3D=3D, SBTSI_ALARM_EN); + + /* Test setting limits */ + /* Limit low =3D 10.500 */ + temp_to_regs(LIMIT_LOW_IN_MILLIDEGREE, &integer, &decimal); + i2c_set8(i2cdev, SBTSI_REG_TEMP_LOW_INT, integer); + i2c_set8(i2cdev, SBTSI_REG_TEMP_LOW_DEC, decimal); + integer =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_LOW_INT); + decimal =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_LOW_DEC); + g_assert_cmpuint( + regs_to_temp(integer, decimal), =3D=3D, LIMIT_LOW_IN_MILLIDEGREE); + /* Limit high =3D 55.125 */ + temp_to_regs(LIMIT_HIGH_IN_MILLIDEGREE, &integer, &decimal); + i2c_set8(i2cdev, SBTSI_REG_TEMP_HIGH_INT, integer); + i2c_set8(i2cdev, SBTSI_REG_TEMP_HIGH_DEC, decimal); + integer =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_HIGH_INT); + decimal =3D i2c_get8(i2cdev, SBTSI_REG_TEMP_HIGH_DEC); + g_assert_cmpuint( + regs_to_temp(integer, decimal), =3D=3D, LIMIT_HIGH_IN_MILLIDEGREE); + /* No alert is generated. */ + value =3D i2c_get8(i2cdev, SBTSI_REG_STATUS); + g_assert_cmphex(value, =3D=3D, 0); + + /* Test alert for low temperature */ + qmp_sbtsi_set_temperature(TEST_ID, LIMIT_LOW_IN_MILLIDEGREE); + value =3D i2c_get8(i2cdev, SBTSI_REG_STATUS); + g_assert_cmphex(value, =3D=3D, SBTSI_STATUS_LOW_ALERT); + + /* Test alert for high temperature */ + qmp_sbtsi_set_temperature(TEST_ID, LIMIT_HIGH_IN_MILLIDEGREE); + value =3D i2c_get8(i2cdev, SBTSI_REG_STATUS); + g_assert_cmphex(value, =3D=3D, SBTSI_STATUS_HIGH_ALERT); + + /* Disable alarm_en */ + i2c_set8(i2cdev, SBTSI_REG_ALERT_CONFIG, 0); + value =3D i2c_get8(i2cdev, SBTSI_REG_ALERT_CONFIG); + g_assert_cmphex(value, =3D=3D, 0); + /* No alert when alarm_en is false. */ + value =3D i2c_get8(i2cdev, SBTSI_REG_STATUS); + g_assert_cmphex(value, =3D=3D, 0); +} + +static void sbtsi_register_nodes(void) +{ + QOSGraphEdgeOptions opts =3D { + .extra_device_opts =3D "id=3D" TEST_ID ",address=3D0x4c" + }; + add_qi2c_address(&opts, &(QI2CAddress) { TEST_ADDR }); + + qos_node_create_driver("sbtsi", i2c_device_create); + qos_node_consumes("sbtsi", "i2c-bus", &opts); + + qos_add_test("tx-rx", "sbtsi", tx_rx, NULL); +} +libqos_init(sbtsi_register_nodes); diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 37e1eaa449..21e6152949 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -254,6 +254,7 @@ qos_test_ss.add( 'spapr-phb-test.c', 'tmp105-test.c', 'emc141x-test.c', + 'tmp-sbtsi-test.c', 'usb-hcd-ohci-test.c', 'virtio-test.c', 'virtio-blk-test.c', --=20 2.34.1.575.g55b058a8bb-goog