[PATCH v4 0/5] target/s390x: Fix shift instructions

Ilya Leoshkevich posted 5 patches 2 weeks, 1 day ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20220112165016.226996-1-iii@linux.ibm.com
Maintainers: David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>
target/s390x/cpu-dump.c         |   3 +-
target/s390x/s390x-internal.h   |   3 +-
target/s390x/tcg/cc_helper.c    |  38 +----
target/s390x/tcg/insn-data.def  |  36 ++---
target/s390x/tcg/translate.c    |  53 +++----
tests/tcg/s390x/Makefile.target |   1 +
tests/tcg/s390x/shift.c         | 270 ++++++++++++++++++++++++++++++++
7 files changed, 321 insertions(+), 83 deletions(-)
create mode 100644 tests/tcg/s390x/shift.c

[PATCH v4 0/5] target/s390x: Fix shift instructions

Posted by Ilya Leoshkevich 2 weeks, 1 day ago
v3: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02680.html
v3 -> v4: Simplify cc_calc_sla().
          Free temporaries.

v2: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02488.html
v2 -> v3: Unify CC_OP_SLA_32 and CC_OP_SLA_64.
          Add underscores to test macro parameters.
          Shift CC in test asm.
          Add a second SLAG test.
          Add tags to commit messages.

v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html
v1 -> v2: Fix cc_calc_sla_32().
          Fix cc_calc_sla_64().
          Fix SLDA sign bit index.
          Inline help_l2_shift().
          Fix wout_r1_D32().
          Add all shift instructions to the test.
          Split the series.

Ilya Leoshkevich (5):
  target/s390x: Fix SLDA sign bit index
  target/s390x: Fix SRDA CC calculation
  target/s390x: Fix cc_calc_sla_64() missing overflows
  target/s390x: Fix shifting 32-bit values for more than 31 bits
  tests/tcg/s390x: Test shift instructions

 target/s390x/cpu-dump.c         |   3 +-
 target/s390x/s390x-internal.h   |   3 +-
 target/s390x/tcg/cc_helper.c    |  38 +----
 target/s390x/tcg/insn-data.def  |  36 ++---
 target/s390x/tcg/translate.c    |  53 +++----
 tests/tcg/s390x/Makefile.target |   1 +
 tests/tcg/s390x/shift.c         | 270 ++++++++++++++++++++++++++++++++
 7 files changed, 321 insertions(+), 83 deletions(-)
 create mode 100644 tests/tcg/s390x/shift.c

-- 
2.31.1


Re: [PATCH v4 0/5] target/s390x: Fix shift instructions

Posted by Thomas Huth 1 week, 2 days ago
On 12/01/2022 17.50, Ilya Leoshkevich wrote:
> v3: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02680.html
> v3 -> v4: Simplify cc_calc_sla().
>            Free temporaries.
> 
> v2: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02488.html
> v2 -> v3: Unify CC_OP_SLA_32 and CC_OP_SLA_64.
>            Add underscores to test macro parameters.
>            Shift CC in test asm.
>            Add a second SLAG test.
>            Add tags to commit messages.
> 
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg02035.html
> v1 -> v2: Fix cc_calc_sla_32().
>            Fix cc_calc_sla_64().
>            Fix SLDA sign bit index.
>            Inline help_l2_shift().
>            Fix wout_r1_D32().
>            Add all shift instructions to the test.
>            Split the series.
> 
> Ilya Leoshkevich (5):
>    target/s390x: Fix SLDA sign bit index
>    target/s390x: Fix SRDA CC calculation
>    target/s390x: Fix cc_calc_sla_64() missing overflows
>    target/s390x: Fix shifting 32-bit values for more than 31 bits
>    tests/tcg/s390x: Test shift instructions
> 
>   target/s390x/cpu-dump.c         |   3 +-
>   target/s390x/s390x-internal.h   |   3 +-
>   target/s390x/tcg/cc_helper.c    |  38 +----
>   target/s390x/tcg/insn-data.def  |  36 ++---
>   target/s390x/tcg/translate.c    |  53 +++----
>   tests/tcg/s390x/Makefile.target |   1 +
>   tests/tcg/s390x/shift.c         | 270 ++++++++++++++++++++++++++++++++
>   7 files changed, 321 insertions(+), 83 deletions(-)
>   create mode 100644 tests/tcg/s390x/shift.c

Thanks, queued to my s390x-next branch now:

  https://gitlab.com/thuth/qemu/-/commits/s390x-next/

  Thomas