From nobody Tue Feb 10 01:59:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1641823310; cv=none; d=zohomail.com; s=zohoarc; b=PGD3JaCk7DpiczohchL7gy9JvhWEdfw4j7t4OXixLUu5m+YjMGaMhkeFH3MrRDRwxTMdBfmG2kyGfFnKzdD3/bdy3AGnDvkqZPjHHQ/oFWsgU/QtArx5MT1trjwpoDUJLkIzwkwZUOOWp1n6JK47W6vMVFsCUj3h8+JWr0LTPCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641823310; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GHnS0hrIvnNAbWoQsQXH9Sq+Km55TVnQvEU2Ul/Fv1Q=; b=eATU2ndLDeMo7oXA2RbHwPwyaLflb1NqTOK2NoNxrQ9rPlRQt9AodzvVlhRggzKdu2w+zTpCy1od0czqoa2axYgPLBQbJKreW/Vg33hitHdzuyLIMRTB2BvYhohIMdJepGJ5FMfS2tQmsoCHgNp7/sjvct9enscJEUH1/a0Viys= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1641823309924660.8191218091663; Mon, 10 Jan 2022 06:01:49 -0800 (PST) Received: from localhost ([::1]:43040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n6vF6-000392-SF for importer@patchew.org; Mon, 10 Jan 2022 09:01:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6v0l-00022r-6J for qemu-devel@nongnu.org; Mon, 10 Jan 2022 08:46:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n6v0j-00070I-II for qemu-devel@nongnu.org; Mon, 10 Jan 2022 08:46:58 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-486-BFIfsbIEPymc-moESxLE-w-1; Mon, 10 Jan 2022 08:46:53 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 038D71083F61; Mon, 10 Jan 2022 13:46:53 +0000 (UTC) Received: from kostyanf14nb.Dlink (unknown [10.40.193.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C6677BB41; Mon, 10 Jan 2022 13:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641822414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHnS0hrIvnNAbWoQsQXH9Sq+Km55TVnQvEU2Ul/Fv1Q=; b=DSADdPcRdrCHVG2tN+3YPCQ4GlKl3zihq9lI9qJTdYlzebLp9BhH/f5Rz9gczBua/pDDWa YpnAWvzrGSF6jJ2HqFtov50nniHjq2kHA6lmrDeOWzfCA73O2w440ijcrgs6697zJe8vKB lnBHVOEUmNfeOGP/2r+ebj/J9hfOzqc= X-MC-Unique: BFIfsbIEPymc-moESxLE-w-1 From: Konstantin Kostiuk To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 4/9] gqa-win: get_pci_info: Free parent_dev_info properly Date: Mon, 10 Jan 2022 15:46:39 +0200 Message-Id: <20220110134644.107375-5-kkostiuk@redhat.com> In-Reply-To: <20220110134644.107375-1-kkostiuk@redhat.com> References: <20220110134644.107375-1-kkostiuk@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kkostiuk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.597, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1641823315438100001 From: Kostiantyn Kostiuk In case when the function fails to get parent device data, the parent_dev_info variable will be initialized, but not freed. Signed-off-by: Kostiantyn Kostiuk Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Kostiantyn Kostiuk --- qga/commands-win32.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 93c5375132..f6de9e2676 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -515,6 +515,8 @@ DEFINE_GUID(GUID_DEVINTERFACE_STORAGEPORT, static GuestPCIAddress *get_pci_info(int number, Error **errp) { HDEVINFO dev_info =3D INVALID_HANDLE_VALUE; + HDEVINFO parent_dev_info =3D INVALID_HANDLE_VALUE; + SP_DEVINFO_DATA dev_info_data; SP_DEVICE_INTERFACE_DATA dev_iface_data; HANDLE dev_file; @@ -542,7 +544,6 @@ static GuestPCIAddress *get_pci_info(int number, Error = **errp) PSP_DEVICE_INTERFACE_DETAIL_DATA pdev_iface_detail_data =3D NULL; STORAGE_DEVICE_NUMBER sdn; char *parent_dev_id =3D NULL; - HDEVINFO parent_dev_info; SP_DEVINFO_DATA parent_dev_info_data; DWORD j; DWORD size =3D 0; @@ -744,11 +745,13 @@ static GuestPCIAddress *get_pci_info(int number, Erro= r **errp) break; } } - SetupDiDestroyDeviceInfoList(parent_dev_info); break; } =20 end: + if (parent_dev_info !=3D INVALID_HANDLE_VALUE) { + SetupDiDestroyDeviceInfoList(parent_dev_info); + } if (dev_info !=3D INVALID_HANDLE_VALUE) { SetupDiDestroyDeviceInfoList(dev_info); } --=20 2.25.1