From nobody Mon Feb 9 16:19:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1641747986; cv=none; d=zohomail.com; s=zohoarc; b=Q6M3ZI1BBl12fg2YnhC/p8OLHKzJEL03/zfATjwvJn1ipxTWt2qDaeHHobkmSQ0d2Pz+xzfJnzClIvC160Ksg+7JJSfazN1I0i8XXESBN95Sqr6/MrWots+q+bXuGxLG6Rx+HrpyktGFrlb8vaFYfDbmT4flAA7eeNCppe2/u4U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641747986; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v1XOO+wU3a7QWA1hgiU3Fs3DmTnRjpKCsIn0H4QIOio=; b=MweBZS0iKsMnyLpMcQ3g4L9Xxlrp9pB9IZFjmrjoo5nA8pf+4N+2GYGncB5d8IFcXJXtsg5+JBRIiWbeb9sznRvWWl64kZTp2NY9npHg6RMC080zrOb1ce32IxZCTtu57vVpW5AUXS2nJuQ+RHxkm1EO4RUBHGJrulAbT0Z8AGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 164174798616777.3878860583178; Sun, 9 Jan 2022 09:06:26 -0800 (PST) Received: by mail-wr1-f52.google.com with SMTP id r10so14672696wrc.3 for ; Sun, 09 Jan 2022 09:06:25 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (83.red-83-50-87.dynamicip.rima-tde.net. [83.50.87.83]) by smtp.gmail.com with ESMTPSA id m35sm8167437wms.1.2022.01.09.09.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 09:06:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v1XOO+wU3a7QWA1hgiU3Fs3DmTnRjpKCsIn0H4QIOio=; b=NYrltQvCSoa/CVjyZ3fPA+u4GfE/KEcxgCX8HeD/utW/iDT7baOnztNXscVSICv3ft YtjyoaNvLlOps9Gy5BQknGH9Y7Udj/c3nkHN9L5k8FX8KrFLJh/bEw35sMD3dpGmrG1B mQB/LXvuEwKGRCiwLOZOsEeo8UVY+e3L5nMRnOGwyg7trM8ierv8rluvrDXiRNctNHo+ 95aHVY2teUdEvTFSvCW4Pkj+mkovkC9eHGql4x4KM0ouM1M+0xKaMUc5APOo9i169tPM /jC8DMz7q1evYyJKJcQRrLI+zyrlzfEqgHvQ+UCAY7NaAn1NzYAh7ZvXCZW+LH0o6lwv jftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=v1XOO+wU3a7QWA1hgiU3Fs3DmTnRjpKCsIn0H4QIOio=; b=1VAnQHFY5LBVQr6hkIKQ+Pot2cfxMnsJVIaNmX9Oqch9+vzImkvy3k6eZoSZgzPEEu fs2c5FuiA8uafRKKWoVnll9Phm4Fe3CRoWgyVAkJuXkjr+X3c8SGMhMZv/sSLvLaTD6t 9kSUKPiGplhntPtBSKngupHDudmMnuDlD8UHIq09e+ny98T7mp4fJ/kgQlnJdz/1UQU/ uWjenkt7w1V3IEeTdiofp3OhnNgrlzNP4VxgAzzpxafD8ohU3+CXzMZgGFjdr9X5YjhJ D2uolbTYwaPNH8XwP1uoIBP6TsDRZobTslqSoTWZQSjUT1NFwE2UmsnAqgMnl3VxluBw cGXw== X-Gm-Message-State: AOAM5317s5DYmRXU1zhVoANRLZGRtlwee19fg7qUEEK8AyWVrnDPLUj3 cyOXKewNy2WkeGRz8R1BSg8= X-Google-Smtp-Source: ABdhPJw26C/oEqJjz/QeytaOKAvwqk4D434ffOfoLvVPEkwO9dBvOX1omaqHrkz7saVfX8o15W6Wpw== X-Received: by 2002:a5d:6908:: with SMTP id t8mr130691wru.382.1641747984438; Sun, 09 Jan 2022 09:06:24 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Cameron Esfahani , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Christian Schoenebeck , qemu-block@nongnu.org, Alexander Graf , Roman Bolshakov , Gerd Hoffmann , Akihiko Odaki , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH v2 2/6] audio/coreaudio: Remove a deprecation warning on macOS 12 Date: Sun, 9 Jan 2022 18:06:08 +0100 Message-Id: <20220109170612.574104-3-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220109170612.574104-1-f4bug@amsat.org> References: <20220109170612.574104-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1641747987148100001 When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is dep= recated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ kAudioObjectPropertyElementMain /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Framew= orks/CoreAudio.framework/Headers/AudioHardwareBase.h:208:5: note: 'kAudioOb= jectPropertyElementMaster' has been explicitly marked deprecated here kAudioObjectPropertyElementMaster API_DEPRECATED_WITH_REPLACEMENT("kA= udioObjectPropertyElementMain", macos(10.0, 12.0), ios(2.0, 15.0), watchos(= 1.0, 8.0), tvos(9.0, 15.0)) =3D kAudioObjectPropertyElementMain ^ Use kAudioObjectPropertyElementMain (define it to kAudioObjectPropertyElementMaster on macOS < 12). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- audio/coreaudio.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/audio/coreaudio.c b/audio/coreaudio.c index d8a21d3e507..c836bc9dd37 100644 --- a/audio/coreaudio.c +++ b/audio/coreaudio.c @@ -44,10 +44,14 @@ typedef struct coreaudioVoiceOut { bool enabled; } coreaudioVoiceOut; =20 +#if !defined(MAC_OS_VERSION_12_0) +#define kAudioObjectPropertyElementMain kAudioObjectPropertyElementMaster +#endif + static const AudioObjectPropertyAddress voice_addr =3D { kAudioHardwarePropertyDefaultOutputDevice, kAudioObjectPropertyScopeGlobal, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 static OSStatus coreaudio_get_voice(AudioDeviceID *id) @@ -69,7 +73,7 @@ static OSStatus coreaudio_get_framesizerange(AudioDeviceI= D id, AudioObjectPropertyAddress addr =3D { kAudioDevicePropertyBufferFrameSizeRange, kAudioDevicePropertyScopeOutput, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 return AudioObjectGetPropertyData(id, @@ -86,7 +90,7 @@ static OSStatus coreaudio_get_framesize(AudioDeviceID id,= UInt32 *framesize) AudioObjectPropertyAddress addr =3D { kAudioDevicePropertyBufferFrameSize, kAudioDevicePropertyScopeOutput, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 return AudioObjectGetPropertyData(id, @@ -103,7 +107,7 @@ static OSStatus coreaudio_set_framesize(AudioDeviceID i= d, UInt32 *framesize) AudioObjectPropertyAddress addr =3D { kAudioDevicePropertyBufferFrameSize, kAudioDevicePropertyScopeOutput, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 return AudioObjectSetPropertyData(id, @@ -121,7 +125,7 @@ static OSStatus coreaudio_set_streamformat(AudioDeviceI= D id, AudioObjectPropertyAddress addr =3D { kAudioDevicePropertyStreamFormat, kAudioDevicePropertyScopeOutput, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 return AudioObjectSetPropertyData(id, @@ -138,7 +142,7 @@ static OSStatus coreaudio_get_isrunning(AudioDeviceID i= d, UInt32 *result) AudioObjectPropertyAddress addr =3D { kAudioDevicePropertyDeviceIsRunning, kAudioDevicePropertyScopeOutput, - kAudioObjectPropertyElementMaster + kAudioObjectPropertyElementMain }; =20 return AudioObjectGetPropertyData(id, --=20 2.33.1