From nobody Tue Apr 30 03:11:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1641552868; cv=none; d=zohomail.com; s=zohoarc; b=DHuhfFSvJNYH/fFyH4SIJLPfAuuncfY7g8zIvh0GktnhChXQGAwipoSpwhaloCVC3yYpA4chvf7xdkxzdprRPC1tXUGwzmpal/VNWINUR5J2+xm24VU7nQWrn13j48u3uKDiLjsVE3JL3E1VBeEKUyiq+/g1ZyWb4fCljpW/UO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641552868; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MeEm7h+236b3jz3HgakFoX/GMcHt60JKsq8f9Y3JC/Q=; b=nPz4GpOMmF0SS/jR6+qN6ySv4fP5HvOUDtrFUflmvkGPXHe+G6W3XNhbUtfTVqwrziN9YtTZYeEh3xuUweWSp1RcHWBFvXA0ALSV8PwX3CqKTB9bBosPC1d03byDwvr1HIpEnQ0pa/3JxDnXWqSiaDBnUjLv17zpZwRBRFkzpHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1641552868614941.4491866792125; Fri, 7 Jan 2022 02:54:28 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id r10so2642617wrc.3 for ; Fri, 07 Jan 2022 02:54:28 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (83.red-83-50-87.dynamicip.rima-tde.net. [83.50.87.83]) by smtp.gmail.com with ESMTPSA id az1sm1488090wrb.104.2022.01.07.02.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 02:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MeEm7h+236b3jz3HgakFoX/GMcHt60JKsq8f9Y3JC/Q=; b=JZS1nCmjzBJ3Fo64wGbMf2AyJEz9gH1dvbGJuYkgHsygOi1TZWnmAcj4hfO/rlOVS/ fjaDjlGzC3k4kYIqKnOQWSq90liAKQrRQ3zJT7HiDbg9gvt71TllKgH63qaZn7/WrOY9 zIoXS5dN/TMXgKu0GJL0KMNVkLNq4uArWHljgEJFAEJoDOuyzH7UnEXsYRRR5YhbDcrh RfgMWkR5n08i90URpBjgm9I7fQbC9UpabWOslOdsEiceZoZHLkIxXTxcHr9wlHZGGCHz 1Zqi2Ar/hDYYHVNRp+1q9pNrFutmoLofzrZaU/vr+1Ac+IjlC3kWZ4hIivmRhFtYK5QA 3Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MeEm7h+236b3jz3HgakFoX/GMcHt60JKsq8f9Y3JC/Q=; b=oDIsPOZe7V2I8lJY3rKCykYS2JJebydhaWEUnEO621CaciHwZBBF063UgJVLiNJT/M sYOreXnbPC5VlZbSo0sHVYKFMjg9qN/lWZ8dKz6L9Z1J16nVJ8HyY0yzquWxqkPiOEVv YfA8ZX2ZC1bSNwn5r9gkZLg8QU/Z6Fc8QoqfC8/T/D7BXxqMHI2HywrwPgBqbtUTTTb1 aKIyn6qRNuqtEnhKl1/QLIS/IXNpogAlQhaC7wkJ4HvN5TWelMb9TICBlRX+DBsANUWA RjpIyP6My8A1VUpZaSlHGaQB0iReiuTD8KH/eKf/n4yG8KSGB+jJxfzhdL9Q3wgR75Vw pJ/A== X-Gm-Message-State: AOAM532FjbcC3hW0tS6DV96WtPfcbhbWV0qeyBmw7NdQp1EZI/NyT6GF b8fhY2oI38YEbKYW/Akg2T8= X-Google-Smtp-Source: ABdhPJzZRnWDGjPQnWJbEi3ltwEjYEA91hsss2H6Ml09R3fuClqArdn22OAKTd6fmxBazffVap0eAw== X-Received: by 2002:a05:6000:144d:: with SMTP id v13mr55408646wrx.411.1641552866892; Fri, 07 Jan 2022 02:54:26 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org, Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/3] docs: Correct 'vhost-user-blk' spelling Date: Fri, 7 Jan 2022 11:54:18 +0100 Message-Id: <20220107105420.395011-2-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220107105420.395011-1-f4bug@amsat.org> References: <20220107105420.395011-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1641552869424100001 Reported-by: Eric Blake Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- docs/tools/qemu-storage-daemon.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tools/qemu-storage-daemon.rst b/docs/tools/qemu-storage-d= aemon.rst index 3e5a9dc0320..9b0eaba6e5c 100644 --- a/docs/tools/qemu-storage-daemon.rst +++ b/docs/tools/qemu-storage-daemon.rst @@ -201,7 +201,7 @@ Export raw image file ``disk.img`` over NBD UNIX domain= socket ``nbd.sock``:: --nbd-server addr.type=3Dunix,addr.path=3Dnbd.sock \ --export type=3Dnbd,id=3Dexport,node-name=3Ddisk,writable=3Don =20 -Export a qcow2 image file ``disk.qcow2`` as a vhosts-user-blk device over = UNIX +Export a qcow2 image file ``disk.qcow2`` as a vhost-user-blk device over U= NIX domain socket ``vhost-user-blk.sock``:: =20 $ qemu-storage-daemon \ --=20 2.33.1 From nobody Tue Apr 30 03:11:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1641552873; cv=none; d=zohomail.com; s=zohoarc; b=POOvsSuooJW9ktHaw3VvXoKJBE66VwximxeqRtg4w7DXgXy10JonoDY4a5g+RhNxdHUytf6Ldq7Q3VAGCMIQhONgFIUoDP5QMNkqB4LEZDhtYrqkMxAjAOMDa5euvZmqf4f6AyZHJBblqbdLR+lbMnNjlrGnn4mC5Fm7WB7owkc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641552873; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/ow3SZqynToXpYuYefz018ZnoAMd3khg8ReRtVnTvO0=; b=OtuEfSr9TPRbY62fqcDViqFyr5vhnYwYV4ulgC4hf/Wlgm2iVm3lYeP9iD68e8SCTDhPKqk98DFqdoktHSP7PrCvwluv6Oa69jRKtkgdO63W2EsVHcqJmMZPOCfEbTk1QKx9xQe2/Zw29BmWnIoR89+fCVdr2z4Bvdvm5At/yuM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1641552873340270.2770019007661; Fri, 7 Jan 2022 02:54:33 -0800 (PST) Received: by mail-wm1-f51.google.com with SMTP id c126-20020a1c9a84000000b00346f9ebee43so2639882wme.4 for ; Fri, 07 Jan 2022 02:54:32 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (83.red-83-50-87.dynamicip.rima-tde.net. [83.50.87.83]) by smtp.gmail.com with ESMTPSA id a3sm4302398wrm.52.2022.01.07.02.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 02:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ow3SZqynToXpYuYefz018ZnoAMd3khg8ReRtVnTvO0=; b=YV6B7z3YnN+CO8N6OI8j4BFDuIr4brqE9b5Q62CdiDuPYcjqZEpmOEjqs7gr4vJRt4 0GbeF1Ypjuh3SRb78APDSGtNKvAukxH0mCSKAD7uCX+SwbDAYhcwGwPU/8Gor1R5XGwu WUn9SD2zyj32qi9RITMpCQL27XReHNSE3DGeHOEPtuwCDPR6DQzhYyP6PTGXyJ3Qt/7+ sHlCHIbTrHuHHKtlAsWeETT/Eepudnk3u2bDmMMWvXdD06x7qxygEp5poG02CEZrOmh/ Llvof+5afhk17j0X1A2b36wzSzNYztbwMTxxETU7ntInte7TIAS+QzY4Ua5rX2vbV3n2 a3oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/ow3SZqynToXpYuYefz018ZnoAMd3khg8ReRtVnTvO0=; b=J1LSoqkPmdxF4T+Hga2sbSV1k2BNDuxMvyjbDOkCiNjrWq+JnyYSQsv+8dyDS4bsMj jfAGnWhjdA530IjJ8z+t4JH3fuyxMmOvd9p1CjUmq5vsAV2q0IPIzpi7Vg0kcA7hQAnY MAoYXmB2/ZFpxxfs4en41TZLg/oyiFjj2KH4cWVHhyWzymCl1GVWSzdRjs8hTkNv/nkZ yIa4zrbOgOPVsRZtJP8TC4GCZ9581IURsMCfr4bniHXqTrT5lGMhHKsstJy2VreEgLaG ykmUaYVP1MvDl2w0Ul2pIl0EqgNnsQp3C+VAEsC69t57MY6EkWocuBgA6nZ0MiLBKSk3 LTew== X-Gm-Message-State: AOAM532uBlQ1PYUPEk/32WCJ2F/ifJoZhL2NOlLfAbvFksiy644xNEA9 0Jt93bXjhZJuqHOcuxES4x0= X-Google-Smtp-Source: ABdhPJzFSoJE908mysCrf4VxJuy1jBtMBu13vgSvlrt8sEqy1ApX/Le/tB2bZqT+ZNJUBaMdj8USWg== X-Received: by 2002:a7b:cf33:: with SMTP id m19mr4836106wmg.30.1641552871663; Fri, 07 Jan 2022 02:54:31 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org, Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Qing Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/3] qemu-storage-daemon: Add vhost-user-blk help Date: Fri, 7 Jan 2022 11:54:19 +0100 Message-Id: <20220107105420.395011-3-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220107105420.395011-1-f4bug@amsat.org> References: <20220107105420.395011-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1641552875602100001 From: Philippe Mathieu-Daud=C3=A9 Add missing vhost-user-blk help: $ qemu-storage-daemon -h ... --export [type=3D]vhost-user-blk,id=3D,node-name=3D, addr.type=3Dunix,addr.path=3D[,writable=3Don|off] [,logical-block-size=3D][,num-queues=3D] export the specified block node as a vhosts-user-blk device over UNIX domain socket --export [type=3D]vhost-user-blk,id=3D,node-name=3D, fd,addr.str=3D[,writable=3Don|off] [,logical-block-size=3D][,num-queues=3D] export the specified block node as a vhosts-user-blk device over file descriptor ... Fixes: 90fc91d50b7 ("convert vhost-user-blk server to block export API") Reported-by: Qing Wang Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: Fix 'vhost-user-blk' spelling (eblake) --- storage-daemon/qemu-storage-daemon.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-sto= rage-daemon.c index 52cf17e8ace..9d76d1114d4 100644 --- a/storage-daemon/qemu-storage-daemon.c +++ b/storage-daemon/qemu-storage-daemon.c @@ -104,6 +104,19 @@ static void help(void) " export the specified block node over FUSE\n" "\n" #endif /* CONFIG_FUSE */ +#ifdef CONFIG_VHOST_USER_BLK_SERVER +" --export [type=3D]vhost-user-blk,id=3D,node-name=3D,\n" +" addr.type=3Dunix,addr.path=3D[,writable=3Don|off]= \n" +" [,logical-block-size=3D][,num-queues=3D]\n" +" export the specified block node as a\n" +" vhost-user-blk device over UNIX domain socket\n" +" --export [type=3D]vhost-user-blk,id=3D,node-name=3D,\n" +" fd,addr.str=3D[,writable=3Don|off]\n" +" [,logical-block-size=3D][,num-queues=3D]\n" +" export the specified block node as a\n" +" vhost-user-blk device over file descriptor\n" +"\n" +#endif /* CONFIG_VHOST_USER_BLK_SERVER */ " --monitor [chardev=3D]name[,mode=3Dcontrol][,pretty[=3Don|off]]\n" " configure a QMP monitor\n" "\n" --=20 2.33.1 From nobody Tue Apr 30 03:11:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1641552878; cv=none; d=zohomail.com; s=zohoarc; b=awBriyKAIbemRm/H4r/Qdy5/q5lpPmL7gfbPQaQGeL9r0MECspzkN7IHcWPfUlI4IdmEoMGY0KvkshNq1yMMxtqeYe7gh+EAccMqwahGTwno6FW7Z7ByeulrQPgtSxBo+s/s3nNc/NtW0L0QGJNzepvt7D+iQmfDtThMKWNaUlc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641552878; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pRt1ZQeTh5X10hpoQU2/jHbFxikau/BmnLWyXQMXPG8=; b=lXk/F3CWRtTKohuMQWDRoRT6OwmAZyyIJcdXUrb3SFjLjbI5KBbxzvkPVvbvBQ8zznmCusptLvE+6HoOdwDOl/dnlTcZgnHfM7UgzJRax5TCPHvxf7kcNs4ks2J96tYuM4X4qL1OOQUsswCvqit36bXDV3MlVFidZu0z6GIRbk8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1641552878122480.79730413380696; Fri, 7 Jan 2022 02:54:38 -0800 (PST) Received: by mail-wm1-f52.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso4724393wmj.2 for ; Fri, 07 Jan 2022 02:54:37 -0800 (PST) Return-Path: Return-Path: Received: from nuc.. (83.red-83-50-87.dynamicip.rima-tde.net. [83.50.87.83]) by smtp.gmail.com with ESMTPSA id 1sm5056239wry.33.2022.01.07.02.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 02:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pRt1ZQeTh5X10hpoQU2/jHbFxikau/BmnLWyXQMXPG8=; b=breiJyJCjJdM8/ZoQxm/OE+LnLAIyCDERWzPDsbVHSjr5glfhB5jYXVy0k4q1BgYvZ qthNPf3Iiv7+J1ww8PxmZCTr/I1UhMqgE919Uqwr4mSPiWDuTBgB5Rla73NmXvE7tw7G Yb8fnBd3zO1ttumHDvRkvCc4tHdbc5Kv4HWA4PaHu+wLAK003NxQav7B4CcaFR9FImR3 Dgcgbjep9gcbjc8vMiMWVGNA7ArlNVDpTiqA/LRTCDvAEk9hBSlez2baZETEujHFgi0X fa7ueM3BahFRTH5K/T03Bs/69vhbVq1riLwaw1C+ZseQiF3DqUWvKcmnI9c+hCtXHEVT jdGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=pRt1ZQeTh5X10hpoQU2/jHbFxikau/BmnLWyXQMXPG8=; b=qSz7Q1N8r2Xk4KKajI2Q7XacHBW3Xlnbex2C1RlCD0GU6xddPiI7CIOQ3HsAvJ/pvy UjRV2YQ3dsT4GNsPRuZjC3edJKFiy4wtfRZVTfN5gP2Zb6WRtJqk/UYJRLegW6bvunSW Je8i8tPXdOwFeBgvFM7sxtBzghYgBuB+nV6gU9H2ReGExKBjr9eCFakW/1kQwXAnPRDZ 5ngnGqkFGLlhwfq/eUDx4UZirQ8rl2+B5B3QnUFSNdDktWrBRb3kEK9mZjfuthpA8uGM 8+QvkxTPgQTTG39BaBAT7JQhyfrNADSaDSKMKLxws2mUL20r7t+ao+9VGeV7eLVHVM64 9iCQ== X-Gm-Message-State: AOAM531/FjAQmPMzIZO5ZsDxpeu53Qj/pDIadSMprDFnHK+JMDokZ4/C 5+piQxjZBPgqHhsSEcSUQ8g= X-Google-Smtp-Source: ABdhPJwTMasOAzaXAAtmqkCaQl73LrHm3bplXAks+gJJk8WCU54X+Gu5yiCfkR6yWkaHqoEKstZ8bA== X-Received: by 2002:a7b:c397:: with SMTP id s23mr10763937wmj.162.1641552876396; Fri, 07 Jan 2022 02:54:36 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org, Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 3/3] qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER Date: Fri, 7 Jan 2022 11:54:20 +0100 Message-Id: <20220107105420.395011-4-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220107105420.395011-1-f4bug@amsat.org> References: <20220107105420.395011-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1641552879548100003 From: Philippe Mathieu-Daud=C3=A9 When building QEMU with --disable-vhost-user and using introspection, query-qmp-schema lists vhost-user-blk even though it's not actually available: { "execute": "query-qmp-schema" } { "return": [ ... { "name": "312", "members": [ { "name": "nbd" }, { "name": "vhost-user-blk" } ], "meta-type": "enum", "values": [ "nbd", "vhost-user-blk" ] }, Restrict vhost-user-blk in BlockExportType when CONFIG_VHOST_USER_BLK_SERVER is disabled, so it doesn't end listed by query-qmp-schema. Fixes: 90fc91d50b7 ("convert vhost-user-blk server to block export API") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Reword + restrict BlockExportOptions union (armbru) --- qapi/block-export.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index c1b92ce1c1c..f9ce79a974b 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -277,7 +277,8 @@ # Since: 4.2 ## { 'enum': 'BlockExportType', - 'data': [ 'nbd', 'vhost-user-blk', + 'data': [ 'nbd', + { 'name': 'vhost-user-blk', 'if': 'CONFIG_VHOST_USER_BLK_SERVE= R' }, { 'name': 'fuse', 'if': 'CONFIG_FUSE' } ] } =20 ## @@ -319,7 +320,8 @@ 'discriminator': 'type', 'data': { 'nbd': 'BlockExportOptionsNbd', - 'vhost-user-blk': 'BlockExportOptionsVhostUserBlk', + 'vhost-user-blk': { 'type': 'BlockExportOptionsVhostUserBlk', + 'if': 'CONFIG_VHOST_USER_BLK_SERVER' }, 'fuse': { 'type': 'BlockExportOptionsFuse', 'if': 'CONFIG_FUSE' } } } --=20 2.33.1