From nobody Tue Apr 30 08:00:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1641333031; cv=none; d=zohomail.com; s=zohoarc; b=dplfvOHhHacecaG1SgfCcGyNC/4EBwhMaisCFqt2muieeyICKLDXjHjnLyLExksmrsh6k1Vs1+UxNCwygT1upO4J8I9WbGeLlF99jPxoS4cvnmCIxnCXU9TdFb2GIFOBnhlENJELDrrrydqECYNJ/TvN/DiilEQpDs7SxGuiY8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641333031; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=CKRFGK/nQbJSO9eH4vCzDs3frMk9TG9xrgiou6/dFxQ=; b=Wr6ccgzDfr1caLbzMydLErMSpaaZTpNWiAmgEB5al8csc8cuCYdYsE388B6uDzi0XOz6WdFIPWoZFI/f5uM9+WeJppRSOAZCrgG/yuDlPDY/9FyWhdAiHOTYE1TLGBOe3IFaDVkZs83tPRtV3LqWaGCyoUAYWTKUP3Jo5eglW1E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1641333031111132.95785691965568; Tue, 4 Jan 2022 13:50:31 -0800 (PST) Received: by mail-wr1-f41.google.com with SMTP id v6so17132006wra.8 for ; Tue, 04 Jan 2022 13:50:30 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (83.red-83-50-87.dynamicip.rima-tde.net. [83.50.87.83]) by smtp.gmail.com with ESMTPSA id y1sm38872710wrm.3.2022.01.04.13.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 13:50:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CKRFGK/nQbJSO9eH4vCzDs3frMk9TG9xrgiou6/dFxQ=; b=H+s4xYLBvW4eeeXr3hAw3ptmkPoEOaFbt6nwqLZaPfmfiSzWlg/0kUFzl9tpDVoZI+ QJCk2IYJO6bWK+fpudq3TAIaFVlQqbBdBrRg9dDh8vZR13vS2vHk4vmvcLKwEEZfNR1l UBfQf64EsWqeUrHlGk6r6Xyqj+CgvOJQ7QauYhY4scGakO0XG/fDguFRwhrb3v0mIaKr oCvv+IcBRScP3Cduy24r1yAbqZzw3Ow+M8Z2BdocNXsvNfY0hmkeBVWWtL19vvNnMrZ0 xCS07DZJrKjnzJrrqj/UT7ns3P7ioTPsbIt1JtfF4mpNG41ca63dM26r7rf1kEHiWI6L q70g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=CKRFGK/nQbJSO9eH4vCzDs3frMk9TG9xrgiou6/dFxQ=; b=LREZQvhd6g+3zQfyp+UjKqxNsmmCa90E/6QlOZJMng055iTnAem2WPsq8oR85iYvIL xTaUum+WIe+YAsfWIdTncAS7JQJoRmoR8TSSMkh5IixpBKTrfARmsH8ZbiUbx08Yug2K tv53px2b7P1W7YJDWxtka3cc7NI2s8HCULEtq8NuEi7NJwAC6XzPVihrf+6NSuqW2zki ZS70zf+KyP6LQpjszDtn85cytJpmDUJMQOszN2y82qrNUto8oQy/uOwMzz2WEz+B4SHf n8Kj69qnnrQQUiw2zMuK1t2M7xOnAqE4oHmpoK4bGBe2VPBDH+nHc07bg4kNMIe8CYVc d7sQ== X-Gm-Message-State: AOAM533r4GbjW/A1NXbyRyetHQM+ZCSVPf6+//yc2HkSWScLHIF5Qsf3 U3zZmA04hFpL2++V0Ua+ewo= X-Google-Smtp-Source: ABdhPJyW7nwCVZE03wLWlyJEoM7FjY+evtSXj/v5so2cyHbLiEjhHb8GHQYEDYG5ZuGN7UZ3kwe5nQ== X-Received: by 2002:adf:aac7:: with SMTP id i7mr44556716wrc.537.1641333029395; Tue, 04 Jan 2022 13:50:29 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Michael Tokarev , Laurent Vivier , qemu-trivial@nongnu.org, WANG Xuerui , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Song Gao Subject: [PATCH v2] linux-user: Fix trivial build error on loongarch64 hosts Date: Tue, 4 Jan 2022 22:50:27 +0100 Message-Id: <20220104215027.2180972-1-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1641333035928100001 When building using GCC 8.3.0 on loongarch64 (Loongnix) we get: In file included from ../linux-user/signal.c:33: ../linux-user/host/loongarch64/host-signal.h: In function =E2=80=98host_s= ignal_write=E2=80=99: ../linux-user/host/loongarch64/host-signal.h:57:9: error: a label can onl= y be part of a statement and a declaration is not a statement uint32_t sel =3D (insn >> 15) & 0b11111111111; ^~~~~~~~ We don't use the 'sel' variable more than once, so drop it. Meson output for the record: Host machine cpu family: loongarch64 Host machine cpu: loongarch64 C compiler for the host machine: cc (gcc 8.3.0 "cc (Loongnix 8.3.0-6.lnd.= vec.27) 8.3.0") C linker for the host machine: cc ld.bfd 2.31.1-system Fixes: ad812c3bd65 ("linux-user: Implement CPU-specific signal handler for = loongarch64 hosts") Reported-by: Song Gao Suggested-by: Song Gao Reviewed-by: WANG Xuerui Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- linux-user/host/loongarch64/host-signal.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/linux-user/host/loongarch64/host-signal.h b/linux-user/host/lo= ongarch64/host-signal.h index 05e2c823717..7effa242515 100644 --- a/linux-user/host/loongarch64/host-signal.h +++ b/linux-user/host/loongarch64/host-signal.h @@ -54,9 +54,7 @@ static inline bool host_signal_write(siginfo_t *info, uco= ntext_t *uc) } break; case 0b001110: /* indexed, atomic, bounds-checking memory operations */ - uint32_t sel =3D (insn >> 15) & 0b11111111111; - - switch (sel) { + switch ((insn >> 15) & 0b11111111111) { case 0b00000100000: /* stx.b */ case 0b00000101000: /* stx.h */ case 0b00000110000: /* stx.w */ --=20 2.33.1