From nobody Wed Sep 10 05:57:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640954900; cv=none; d=zohomail.com; s=zohoarc; b=F2fC6vEtjqW4U2Hok9GSpFlwsahrHE8JSh+2s6YaJPAcy2yIYdw/gUMv2IlmM3Q7DhA2q8CmWLYdGC4vWizBWS+wSYJ7hq6C4RewFmq+PMjNEpwwQkeSfQmAc0YHCdF+xNLX4WYnDRTbjTuxVGDv7mAdkbyDIWuuJyyzPde8XFc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640954900; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xmB2pjpPBRixvCwzPKhtMpmRFUaHeigjOeRVD50Cfio=; b=dpfO6/9z+eqXXaOW9QdRGlTxU5SK2a/7sM3lZoFpnk6xbNV/WAP94B5qbCHLIh+Jurz8wfGu3jhJHwbxXAgs6JrCZ6GKbpCr2gQR91i5bxAG+hgNCEVa+mzECjvdVFspq/lcBQ6qhwXR4ZwcCe3ix2S+od36eNGI/DiP00qoGNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640954900760800.1680692689588; Fri, 31 Dec 2021 04:48:20 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-249-JCxV63l-NFSqHW17CZG4UA-1; Fri, 31 Dec 2021 07:48:18 -0500 Received: by mail-wr1-f70.google.com with SMTP id r9-20020adfb1c9000000b001a2981d9356so7542481wra.20 for ; Fri, 31 Dec 2021 04:48:18 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (26.red-83-50-86.dynamicip.rima-tde.net. [83.50.86.26]) by smtp.gmail.com with ESMTPSA id n12sm29245382wrf.29.2021.12.31.04.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 04:48:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640954900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xmB2pjpPBRixvCwzPKhtMpmRFUaHeigjOeRVD50Cfio=; b=S2eJcC8nLqFyPr0p002FeUR7pI/RFZJ+G6WGE/9dMRghQu39BecATaljpg2aULW3AmZMbz GXjGjoEh/cBWBIfgWqD8mJHAEtxI57E16rNW8ta99YPLLmJK9ahvKD5YelJfUWglnGSqpB ruY1iYYPChrGvRmLgNEVHqIdl0r/bQ8= X-MC-Unique: JCxV63l-NFSqHW17CZG4UA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xmB2pjpPBRixvCwzPKhtMpmRFUaHeigjOeRVD50Cfio=; b=D3XYsKCd2YhbHoptXXTMcssI1rZWmSjaY7gK91PMN+du5LKKDu+UR/I54V+t8Z42N2 g5qKEn3teSRfgDm+P4xMNa1QAbWdrVzpKQCto3pzeDucHYt3tAQEyvHrAaqlYmghzc9P XpiPvrNERDoucRVWDbLG2Md59akxew50p0PAYQXlF/uUNPYUCXJXIj0iOCLk0T06JGUM Ciq0Tszkg9DWnUFbCMAssqNskp+ssSJw3czpVFUTlxRtvAM3rH5WdyA6rPNg5i9o3+iw obgIU3td69LvJo1bt1qJwRiGGI5LkLWpks88aXiZ5EqWfzV8krgmbZ8tq+X0J1zbmJG4 aFjg== X-Gm-Message-State: AOAM530hCa8vOiwAGuU2eMD2dZ0mRIcGw8Cyq/N+v0+qbAksXxkL6veW XQyaRT+bGFjQPZjuNzPwA7S9I01DYIfg6MLkNrePCZG+H+0cN+s824O059Rj3vUUxIfCdXLGoiw rSMoPP05EMfQuew== X-Received: by 2002:a05:6000:108a:: with SMTP id y10mr28770147wrw.335.1640954897842; Fri, 31 Dec 2021 04:48:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyGpX+LsFprT8hw+VLP7mQuNE1tHjfABBtig5YpWxcStgP8CjRRA5QN/vTAZNPggMwuurC+fQ== X-Received: by 2002:a05:6000:108a:: with SMTP id y10mr28770140wrw.335.1640954897698; Fri, 31 Dec 2021 04:48:17 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yanan Wang , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 05/20] tests/unit/test-smp-parse: Pass machine type as argument to tests Date: Fri, 31 Dec 2021 13:47:39 +0100 Message-Id: <20211231124754.1005747-6-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211231124754.1005747-1-philmd@redhat.com> References: <20211231124754.1005747-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640954902272000001 Use g_test_add_data_func() instead of g_test_add_func() so we can pass the machine type to the tests (we will soon have different machine types). Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211216132015.815493-2-philmd@redhat.com> --- tests/unit/test-smp-parse.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c index b02450e25a3..37c6b4981db 100644 --- a/tests/unit/test-smp-parse.c +++ b/tests/unit/test-smp-parse.c @@ -487,9 +487,10 @@ static void machine_base_class_init(ObjectClass *oc, v= oid *data) mc->name =3D g_strdup(SMP_MACHINE_NAME); } =20 -static void test_generic(void) +static void test_generic(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -525,9 +526,10 @@ static void test_generic(void) object_unref(obj); } =20 -static void test_with_dies(void) +static void test_with_dies(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -599,8 +601,12 @@ int main(int argc, char *argv[]) =20 g_test_init(&argc, &argv, NULL); =20 - g_test_add_func("/test-smp-parse/generic", test_generic); - g_test_add_func("/test-smp-parse/with_dies", test_with_dies); + g_test_add_data_func("/test-smp-parse/generic", + TYPE_MACHINE, + test_generic); + g_test_add_data_func("/test-smp-parse/with_dies", + TYPE_MACHINE, + test_with_dies); =20 g_test_run(); =20 --=20 2.33.1