From nobody Tue Sep 9 06:44:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640954892; cv=none; d=zohomail.com; s=zohoarc; b=egce2J7K+6RDWunb+Z38IZpstKB1VN4xj5z4dXRKtSKC+miwt2Y9M7Kys6TnsCdRkXINeccVoCpF5O+npQYkkhTR0FQuWE3k19La1aePAzAqHXj2O2ofZkQWK1fibMJHwS8BOTg7Jp5TCw4X+eqa/MsPXB34gUfmu+YDWOb/oWM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640954892; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=JTqiL35hH/fnhlD9CAtxeQRLllRocCsMZlpBqswrwZk=; b=U99ryr6kULsH18XXOH2TsbfKoV/Fr157VKnfyTWIxkn3jE9ZDoFumqDSnGDdcqJDWku7p9m+kz5FrGVrlvKnncC0Y7rXGpg0xFW+b6WRcb/vIwTVYPkcjWKFQoTVSdBtuI0LwPFX0sAou+SPJJVb7Qs7opbgptzj5K2c+3phsmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640954892345587.5832610486789; Fri, 31 Dec 2021 04:48:12 -0800 (PST) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-N1Y9j-_oPP2-pZr3InMgQA-1; Fri, 31 Dec 2021 07:48:10 -0500 Received: by mail-wr1-f71.google.com with SMTP id v15-20020adf8b4f000000b001a24c46d6ceso7535149wra.15 for ; Fri, 31 Dec 2021 04:48:10 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (26.red-83-50-86.dynamicip.rima-tde.net. [83.50.86.26]) by smtp.gmail.com with ESMTPSA id y11sm31550168wry.70.2021.12.31.04.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 04:48:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640954891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JTqiL35hH/fnhlD9CAtxeQRLllRocCsMZlpBqswrwZk=; b=ECoZA3aVdYDNAbEVAnHxFuqa1wG7lG+yfJ7d/4v6cQoWLYbMe252qjx+SQjoRXOtuGIFfA bF/qnVnxFnYXehkOSoKstrv/WaryJ4rorj+O8auI5Qu4Gx82FUmCCKYKfR1wX/1lSRMBpL 8FUne6kLuVQEshrQREk20GaXu/k30No= X-MC-Unique: N1Y9j-_oPP2-pZr3InMgQA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JTqiL35hH/fnhlD9CAtxeQRLllRocCsMZlpBqswrwZk=; b=v7lHpDb/8Mp+Ts4Yak6MBTWUDvYuzoCaix7I8k+3BhMNcIXu9S/1WkNOafHDZspt6w m8wSk1K3VJyChE7RqMc9rwC+ABzhGuDdWsr25XSzrWDzNnnfL18Ryyd3oHfOzQzwlyfz 91Z5O/kC7YVaGWvKgZOkkhP7Ua+6YV+fSIccgujeab367qzhpZ5NkOijdrjEYYoEbNNv GpXyD+jPK2DdVE+aI6vht+c2ghs+p6FNDZscUv0WUeysAA9HImqr5J3ehJuta40Dvjl5 ROKg4CObCIi8fGIPY0MBhSZ4LC9JTyZWaElSRvHAL6J7co1jAugqZ5/9qXxmXD/mEnAq 4xZA== X-Gm-Message-State: AOAM533j3uFHiXyiRSSZCuY8ijQZuc8bl+tDsR84MIJmlkcQmDDXsLjk XTVhmvd2W9gdTweq1J1oxz0pxuDJPQnWNUf+BsXZt6L0RMZKDcL51hgtsjMolcbqDtYvJNtLzxa MRemn2uX4zYV9EA== X-Received: by 2002:a5d:6d8a:: with SMTP id l10mr29419132wrs.527.1640954889202; Fri, 31 Dec 2021 04:48:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJwr/EmqueGAyqLvgcx4UNeUxXdD+Kd40nXpHzxituCIozj2AWoPC+VvUnNH9ocWmeRXHzswhg== X-Received: by 2002:a5d:6d8a:: with SMTP id l10mr29419120wrs.527.1640954889066; Fri, 31 Dec 2021 04:48:09 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yanan Wang , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 03/20] hw/qdev: Correct qdev_connect_gpio_out_named() documentation Date: Fri, 31 Dec 2021 13:47:37 +0100 Message-Id: <20211231124754.1005747-4-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211231124754.1005747-1-philmd@redhat.com> References: <20211231124754.1005747-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640954894796000001 From: Philippe Mathieu-Daud=C3=A9 qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yanan Wang Message-Id: <20211218130437.1516929-4-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/qdev-core.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index dcf20c69b89..424c48daf6e 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -504,7 +504,8 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const= char *name, int n); void qdev_connect_gpio_out(DeviceState *dev, int n, qemu_irq pin); =20 /** - * qdev_connect_gpio_out: Connect one of a device's anonymous output GPIO = lines + * qdev_connect_gpio_out_named: Connect one of a device's named output + * GPIO lines * @dev: Device whose GPIO to connect * @name: Name of the output GPIO array * @n: Number of the anonymous output GPIO line (which must be in range) @@ -526,7 +527,7 @@ void qdev_connect_gpio_out(DeviceState *dev, int n, qem= u_irq pin); * qemu_irqs at once, or to connect multiple outbound GPIOs to the * same qemu_irq; see qdev_connect_gpio_out() for details. * - * For named output GPIO lines, use qdev_connect_gpio_out_named(). + * For anonymous output GPIO lines, use qdev_connect_gpio_out(). */ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, qemu_irq pin); --=20 2.33.1