From nobody Sun Sep 7 19:22:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640954883; cv=none; d=zohomail.com; s=zohoarc; b=QQEjics0MtdXwjafB0nU1bVTlNgyXxrH+aXWa8yaRyUWMZGDP7QanxxGyKSVr+eWnZceOrgcBnIPwIz0MODOVMeR0Mf2MwThVUhkXZy8h2lNj48/5Jpw2MEws978N+15P51Ak6Hh8ChNxkIsU9nzFM6g39f2f1BUi6HkrW4vGSQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640954883; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6NcCg5xKWT+cJ/GsSaNTEefS39uXSXMUdwSN24u99dU=; b=bg/u4hrAfXXSsK4JYp3W6oDaAAvEYfBjvpFDu/e5aSkg8n8P0I2Npy7N6ht7iRgh9zutHhggGFX6PIbQuaXTTvuFV4/3lcBkked7o+lek4CxClu0jf+YMhvBJA6rETJOqAbWOdhu/EJnpLiT0Z5f0agkFz372d0XmRmYKUz53cs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640954883709989.8943983482105; Fri, 31 Dec 2021 04:48:03 -0800 (PST) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-311-8V3TjjHrOf-IYMSNp8YAXQ-1; Fri, 31 Dec 2021 07:48:01 -0500 Received: by mail-wr1-f72.google.com with SMTP id v15-20020adf8b4f000000b001a24c46d6ceso7534990wra.15 for ; Fri, 31 Dec 2021 04:48:01 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (26.red-83-50-86.dynamicip.rima-tde.net. [83.50.86.26]) by smtp.gmail.com with ESMTPSA id z22sm27087048wmp.40.2021.12.31.04.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 04:47:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640954883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6NcCg5xKWT+cJ/GsSaNTEefS39uXSXMUdwSN24u99dU=; b=RAutLF0tQ6EnsZUi2Zt8IatzvF2DN/dd6LwuHXC0uDWAqysrgUyShQyqx6dsZrwfzdPIfu uic9RXuhMdDC59LuaAbzb//ObKbSHa67zufJoQcCVg6LzGNhzcXMjvNJKFl93kQ8yAWNf5 Hao9ZjtmWYC5zHqy4IWpgcDTC0IZlfU= X-MC-Unique: 8V3TjjHrOf-IYMSNp8YAXQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6NcCg5xKWT+cJ/GsSaNTEefS39uXSXMUdwSN24u99dU=; b=KDrHU0KUE9CzJnNSWZ572mgq5YII0t8FICn+h+ClSqwEz8gk+z8VK5+Wr5yMlFAEhN t2FTIvqWZ+VMlC/zGXbZfH0JmELHMNFE4d0GRNZS/uk6hMsQGkrwm1h5RO1+3FYdOlnx 7snTLNkxMifeh5llBgO695bX439Bf82phZcc2BNXhOwxgalsvXVIfIN17E+qosBygIWs lEqWmuuOdSC6xnL1x275UQs3ubLcsjckANX1Px/8j343FRCkQ4ZlpLpSaELkWWcZn78w os0wZxVCH+ufdtldY+nnIFjwkNMdpPYmT6AT0g05RZeR2Q7MGiHW3u9a/Q1HDAdPgJbq UbiQ== X-Gm-Message-State: AOAM530QSw+C+rtHBxib5ZwXfxS2NFw668sGJS2SeaEuHdjJ3SQjnnl3 +2lu8OJfzqW7ZiiaVd0IEIVVh2015XMoN/hIlRuvXIHKlXTqY1ZdI4pj/GBwbhaHBIrTQLeAWzd WwTFzPIHM4e7cCw== X-Received: by 2002:a5d:64aa:: with SMTP id m10mr30161357wrp.500.1640954880465; Fri, 31 Dec 2021 04:48:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpE7zljcX2Zs1AtVs6KxXh79ZF4AojGyjRG+XuQUYtpzNrdxvva9O53mzoMdkLXVEVNKIALA== X-Received: by 2002:a5d:64aa:: with SMTP id m10mr30161345wrp.500.1640954880292; Fri, 31 Dec 2021 04:48:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yanan Wang , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 01/20] hw/qdev: Cosmetic around documentation Date: Fri, 31 Dec 2021 13:47:35 +0100 Message-Id: <20211231124754.1005747-2-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211231124754.1005747-1-philmd@redhat.com> References: <20211231124754.1005747-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640954884216000003 From: Philippe Mathieu-Daud=C3=A9 Add empty lines to have a clearer distinction between different functions declarations. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yanan Wang Message-Id: <20211218130437.1516929-2-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/qdev-core.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 20d3066595e..59a822ffceb 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -321,6 +321,7 @@ compat_props_add(GPtrArray *arr, * The returned object has a reference count of 1. */ DeviceState *qdev_new(const char *name); + /** * qdev_try_new: Try to create a device on the heap * @name: device type to create @@ -329,6 +330,7 @@ DeviceState *qdev_new(const char *name); * does not exist, rather than asserting. */ DeviceState *qdev_try_new(const char *name); + /** * qdev_realize: Realize @dev. * @dev: device to realize @@ -347,6 +349,7 @@ DeviceState *qdev_try_new(const char *name); * qdev_realize_and_unref() instead. */ bool qdev_realize(DeviceState *dev, BusState *bus, Error **errp); + /** * qdev_realize_and_unref: Realize @dev and drop a reference * @dev: device to realize @@ -372,6 +375,7 @@ bool qdev_realize(DeviceState *dev, BusState *bus, Erro= r **errp); * would be incorrect. For that use case you want qdev_realize(). */ bool qdev_realize_and_unref(DeviceState *dev, BusState *bus, Error **errp); + /** * qdev_unrealize: Unrealize a device * @dev: device to unrealize @@ -450,6 +454,7 @@ typedef enum { * For named input GPIO lines, use qdev_get_gpio_in_named(). */ qemu_irq qdev_get_gpio_in(DeviceState *dev, int n); + /** * qdev_get_gpio_in_named: Get one of a device's named input GPIO lines * @dev: Device whose GPIO we want @@ -497,6 +502,7 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const= char *name, int n); * For named output GPIO lines, use qdev_connect_gpio_out_named(). */ void qdev_connect_gpio_out(DeviceState *dev, int n, qemu_irq pin); + /** * qdev_connect_gpio_out: Connect one of a device's anonymous output GPIO = lines * @dev: Device whose GPIO to connect @@ -524,6 +530,7 @@ void qdev_connect_gpio_out(DeviceState *dev, int n, qem= u_irq pin); */ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, qemu_irq pin); + /** * qdev_get_gpio_out_connector: Get the qemu_irq connected to an output GP= IO * @dev: Device whose output GPIO we are interested in @@ -541,6 +548,7 @@ void qdev_connect_gpio_out_named(DeviceState *dev, cons= t char *name, int n, * by the platform-bus subsystem. */ qemu_irq qdev_get_gpio_out_connector(DeviceState *dev, const char *name, i= nt n); + /** * qdev_intercept_gpio_out: Intercept an existing GPIO connection * @dev: Device to intercept the outbound GPIO line from @@ -582,6 +590,7 @@ BusState *qdev_get_child_bus(DeviceState *dev, const ch= ar *name); * hold of an input GPIO line to manipulate it. */ void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n); + /** * qdev_init_gpio_out: create an array of anonymous output GPIO lines * @dev: Device to create output GPIOs for @@ -610,6 +619,7 @@ void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handl= er handler, int n); * handler. */ void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pins, int n); + /** * qdev_init_gpio_out: create an array of named output GPIO lines * @dev: Device to create output GPIOs for @@ -623,6 +633,7 @@ void qdev_init_gpio_out(DeviceState *dev, qemu_irq *pin= s, int n); */ void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins, const char *name, int n); + /** * qdev_init_gpio_in_named_with_opaque: create an array of input GPIO lines * for the specified device --=20 2.33.1