From nobody Tue Feb 10 06:08:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640260865; cv=none; d=zohomail.com; s=zohoarc; b=GQdlmVrkdVx+oPC/dJutoSj+c4fOm59gDP7P8vwmrr5d9cY6frX40O6dTlSFXW/Kp5vTMutNft8CT8KvBPmKPfzn8aoVPkHNzqfxxOGfuxbxZnFT/f3CsTHDo0GTms/QPZTfvt5ObK+neqEYDItbM8TzqB8pgNaZ4mfc2Px9qCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640260865; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Xe1vuKIn+V7zfO3YKXmpVrbFyeoxlWXQr1Mcr+LUv2s=; b=kJ+VnCvSM3w/o477gXoX2L+aGtm3+rp0aSxVM/+FnB1VaV9isu1y1qKik3JPIbpwVnG7cUj/8U6AWthYYlH0+DaxNddX/zUpxk5yYk0Mw7zyl2u7VskOL/Z+ubcneG+HujRJqaVLmWJG9wj0/SK6fwNZV4MuxcLSxAcuM6dGydk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1640260865551239.6540071420718; Thu, 23 Dec 2021 04:01:05 -0800 (PST) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-88-3UqekWj0PPyJjN-KM5NHIA-1; Thu, 23 Dec 2021 07:01:03 -0500 Received: by mail-wm1-f72.google.com with SMTP id c5-20020a1c3505000000b00345c92c27c6so2342390wma.2 for ; Thu, 23 Dec 2021 04:01:02 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (33.red-193-152-124.dynamicip.rima-tde.net. [193.152.124.33]) by smtp.gmail.com with ESMTPSA id l2sm4925992wrs.43.2021.12.23.04.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 04:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640260864; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xe1vuKIn+V7zfO3YKXmpVrbFyeoxlWXQr1Mcr+LUv2s=; b=OduHoNVKM5lUpZHODOYsMjk3X7aKJwtxxNnMoKozvh0wDjtY8lsfTQq32ToFqEZ8Xw6u0X ilV+jxdo0iTZbEARA7Sc2gMgZn8NDULNpKBL8p1fOIrVWSVNkADHCoEp/IwmhSnHfow4fK mWuNPFVfD0PmH2J56e00hUsolUiae6M= X-MC-Unique: 3UqekWj0PPyJjN-KM5NHIA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xe1vuKIn+V7zfO3YKXmpVrbFyeoxlWXQr1Mcr+LUv2s=; b=TCa1qe5r8HpEmsejffVQCcVcrfsGiaSU0XCY1lnB2N3mGUsKzxgsop//z1CbKpk2J/ ZwMGfmMiKjBzY917NI/BTSaHo7Vh/Efz+YGwF9CalwrBpNoee8Qet9Qa+L5VtN3KRsvI N+OFMPsvProQ4RJ9Nhl80evrtZW80rWPRdgg4Qs4LBntaSbED1U3C0QvzAtArqRshJUb OfW9bcwDL6PXEQmPM/D2W8tTLtF82fFP66b2oOJirFjFnB31aw/THtcYakErHJS26WU2 /5s9RndnxG8cjUiVCBZW8DqYNXfknynQgWKjZXM5TiVh6ByunfMKftUfWzxuHmheXCYi eCRA== X-Gm-Message-State: AOAM530yCmCZ1jQws96qPWmcQ34suOC4gPNDD0qJHbdb6BPp85trqbtj UNwgtdLR8gF1ZNJF0+AulrhMbwZrcjYo21MRZpy6Rq6Zqsw3XCvlJVJeuz6+Kd8go7QqxUS9cDJ Ro9WR6uOGp283pg== X-Received: by 2002:a7b:cbc3:: with SMTP id n3mr1580214wmi.90.1640260861978; Thu, 23 Dec 2021 04:01:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlrOWfzUgzbU2x0aJm7EBIoyyeAl+mK7+LF+Bv/edFZaK9HYzsPmOF85+Vj2bXFjyAXF+glQ== X-Received: by 2002:a7b:cbc3:: with SMTP id n3mr1580192wmi.90.1640260861824; Thu, 23 Dec 2021 04:01:01 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Joel Stanley , Richard Henderson , qemu-block@nongnu.org, Jason Wang , Keith Busch , "Michael S. Tsirkin" , Fam Zheng , Alistair Francis , David Hildenbrand , Eduardo Habkost , Havard Skinnemoen , Sven Schnelle , Tyrone Ting , Gerd Hoffmann , Peter Maydell , Beniamino Galvani , Daniel Henrique Barboza , Dmitry Fleytman , John Snow , Bin Meng , Greg Kurz , Eric Auger , Mark Cave-Ayland , "Edgar E. Iglesias" , Andrew Jeffery , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Andrew Baumann , Hannes Reinecke , Paolo Bonzini , Peter Xu , qemu-arm@nongnu.org, Klaus Jensen , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Jan Kiszka , David Gibson Subject: [PATCH v2 22/23] pci: Let st*_pci_dma() propagate MemTxResult Date: Thu, 23 Dec 2021 12:55:53 +0100 Message-Id: <20211223115554.3155328-23-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211223115554.3155328-1-philmd@redhat.com> References: <20211223115554.3155328-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640260866599100001 st*_dma() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/pci/pci.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 7a46c1fa226..c90cecc85c0 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -859,12 +859,12 @@ static inline MemTxResult pci_dma_write(PCIDevice *de= v, dma_addr_t addr, ld##_l##_dma(pci_get_address_space(dev), addr, &val, attrs); \ return val; \ } \ - static inline void st##_s##_pci_dma(PCIDevice *dev, \ - dma_addr_t addr, \ - uint##_bits##_t val, \ - MemTxAttrs attrs) \ + static inline MemTxResult st##_s##_pci_dma(PCIDevice *dev, \ + dma_addr_t addr, \ + uint##_bits##_t val, \ + MemTxAttrs attrs) \ { \ - st##_s##_dma(pci_get_address_space(dev), addr, val, attrs); \ + return st##_s##_dma(pci_get_address_space(dev), addr, val, attrs);= \ } =20 PCI_DMA_DEFINE_LDST(ub, b, 8); --=20 2.33.1