From nobody Tue Feb 10 02:55:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640260796; cv=none; d=zohomail.com; s=zohoarc; b=d+HVqeIEhg81Bw2uOLMcTIR53NzZC06ztp0cF/nrw+qy3hHh1ZJKXvZ5OLRA2JUe3sFUlQCh/BXUY5KlR8Ow/ttIFa3f6hJzHbq7rQc+b+wslhx1f+HvqLdctOY1YYCoobGTSbRXbzluE36S3lu2HJGjI4wkDGsUV2bCHTj79X8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640260796; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=AccLfnY/B/12ZHLoZ2OU6IixKvcUVx9674CliXPrEJo=; b=EBQiJMPjzFWIvZnHbUH2GiYLilfSAkBYk31jN7viIvw4Gj+VwgQr0qlHDBZJJyJqUbNgA1mT3QuaLboVn7h3ezoU/Qhxkh0XxH0iyeHLsChOAEPEP/h4+VUwy3pCuryeqXSVxQ7SLYbOlYLmnZ5niiJHOHsQvXzFN3ZeVkR2IDU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640260796390992.813885252688; Thu, 23 Dec 2021 03:59:56 -0800 (PST) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-489-05o-vAAAPm2WfQJhNLW3gA-1; Thu, 23 Dec 2021 06:59:54 -0500 Received: by mail-wm1-f72.google.com with SMTP id d4-20020a05600c34c400b00345d5d47d54so638300wmq.6 for ; Thu, 23 Dec 2021 03:59:54 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (33.red-193-152-124.dynamicip.rima-tde.net. [193.152.124.33]) by smtp.gmail.com with ESMTPSA id i4sm7759112wmd.34.2021.12.23.03.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Dec 2021 03:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640260795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AccLfnY/B/12ZHLoZ2OU6IixKvcUVx9674CliXPrEJo=; b=Yt0Q84EV+TTM+tQVeUw2MrHn1uzPEocDodtyvb3D7/3ESa19XGN4WSPeLcKwLLurDhKEKe ebBJU4EDAP2vR+X/bA39GExlMsrHIPOESLDf2N0ztqdEBl2uoIGglzwW5Zu0NVmSPpuB/B 7rWorTQoUaNM99aS4K3Nm2Ano2fhdtI= X-MC-Unique: 05o-vAAAPm2WfQJhNLW3gA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AccLfnY/B/12ZHLoZ2OU6IixKvcUVx9674CliXPrEJo=; b=oTGI2yahvjFxGhyoLQ9uMjEBvgZZotNxeHajGA7UOEbFF5LkHXOKGMkFX6U6ZclH3E t8oif00Je2WR3ck9xKA+3x/uR3YkPNAkGGTYFVG0FZerDN9ZvbuyIxJjQ0PfHsVVfyG/ NFHoBIvWgkvuq8aA3TGK5a35NOXCDWZy6vJB1m46Z7LTwlbRjE4x6016lDd45OofwArb jFyapvutGggjXd0OkrdvO0Ok2r29MmJBx3CcBTJN6LMU8sAHrS5Sa0/n1FUPqcYwvBYz njr1kY5LOZMo4KsXFH9UXFfDnZmyEB66o/PoLzu/e3pkf61JwJvugQQbdcZmQPxhRRjQ Kv5A== X-Gm-Message-State: AOAM532StywyJGks79HuavPCpmkXVU5AGnmioeZCAcBvbFMclqmVdOxy aXGeZzaOjzuU7RzO6bhwWE2PHH27abDVZ21L/oJCn6G/p/DydiQS9gXyIOICuatSogkg7bN8Y/a AFpNCUnDfQqJbog== X-Received: by 2002:a05:600c:1f18:: with SMTP id bd24mr1593833wmb.174.1640260793172; Thu, 23 Dec 2021 03:59:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/oJ4qDHZs1qmUK48d0flpcHtTo7uhZOdN58vL8y6w/JcRg0Kb4wZpKSYPbM+SK/9h+ecGLw== X-Received: by 2002:a05:600c:1f18:: with SMTP id bd24mr1593821wmb.174.1640260793042; Thu, 23 Dec 2021 03:59:53 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Joel Stanley , Richard Henderson , qemu-block@nongnu.org, Jason Wang , Keith Busch , "Michael S. Tsirkin" , Fam Zheng , Alistair Francis , David Hildenbrand , Eduardo Habkost , Havard Skinnemoen , Sven Schnelle , Tyrone Ting , Gerd Hoffmann , Peter Maydell , Beniamino Galvani , Daniel Henrique Barboza , Dmitry Fleytman , John Snow , Bin Meng , Greg Kurz , Eric Auger , Mark Cave-Ayland , "Edgar E. Iglesias" , Andrew Jeffery , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Andrew Baumann , Hannes Reinecke , Paolo Bonzini , Peter Xu , qemu-arm@nongnu.org, Klaus Jensen , Stefan Weil , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Jan Kiszka , David Gibson Subject: [PATCH v2 17/23] dma: Let st*_dma() propagate MemTxResult Date: Thu, 23 Dec 2021 12:55:48 +0100 Message-Id: <20211223115554.3155328-18-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211223115554.3155328-1-philmd@redhat.com> References: <20211223115554.3155328-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640260798326100001 dma_memory_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/sysemu/dma.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h index f3cf60d222d..725e8e90f88 100644 --- a/include/sysemu/dma.h +++ b/include/sysemu/dma.h @@ -248,13 +248,13 @@ static inline void dma_memory_unmap(AddressSpace *as, dma_memory_read(as, addr, &val, (_bits) / 8, attrs); \ return _end##_bits##_to_cpu(val); \ } \ - static inline void st##_sname##_##_end##_dma(AddressSpace *as, \ - dma_addr_t addr, \ - uint##_bits##_t val, \ - MemTxAttrs attrs) \ - { \ - val =3D cpu_to_##_end##_bits(val); \ - dma_memory_write(as, addr, &val, (_bits) / 8, attrs); \ + static inline MemTxResult st##_sname##_##_end##_dma(AddressSpace *as, \ + dma_addr_t addr, \ + uint##_bits##_t va= l, \ + MemTxAttrs attrs) \ + { \ + val =3D cpu_to_##_end##_bits(val); \ + return dma_memory_write(as, addr, &val, (_bits) / 8, attrs); \ } =20 static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr, MemTxAtt= rs attrs) @@ -265,10 +265,10 @@ static inline uint8_t ldub_dma(AddressSpace *as, dma_= addr_t addr, MemTxAttrs att return val; } =20 -static inline void stb_dma(AddressSpace *as, dma_addr_t addr, - uint8_t val, MemTxAttrs attrs) +static inline MemTxResult stb_dma(AddressSpace *as, dma_addr_t addr, + uint8_t val, MemTxAttrs attrs) { - dma_memory_write(as, addr, &val, 1, attrs); + return dma_memory_write(as, addr, &val, 1, attrs); } =20 DEFINE_LDST_DMA(uw, w, 16, le); --=20 2.33.1