From nobody Sun May 19 10:01:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1640228606529758.4648499061398; Wed, 22 Dec 2021 19:03:26 -0800 (PST) Received: from localhost ([::1]:36316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0EO5-0008Fi-KI for importer@patchew.org; Wed, 22 Dec 2021 22:03:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0EMh-0006Aj-1v for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:01:59 -0500 Received: from [2607:f8b0:4864:20::636] (port=34353 helo=mail-pl1-x636.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0EMf-00082U-8G for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:01:58 -0500 Received: by mail-pl1-x636.google.com with SMTP id x15so3281401plg.1 for ; Wed, 22 Dec 2021 19:01:53 -0800 (PST) Received: from localhost.localdomain ([156.19.246.20]) by smtp.gmail.com with ESMTPSA id q19sm4248513pfk.83.2021.12.22.19.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 19:01:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WCrXIz6oQFkKNm70zoG/HZSBQOnDEr0Dc7B5UJQw9/s=; b=oF1YlVbOJPaUjGbhNbEDYh+E8M9h96Niab4cUjjyZ93BL7OrgsHB7teHQqpi7xYx0L 3DvnKlqJaxq7/J3zPi9OCr034WQuNovsCr5vtojHbUCMSuCymvIMGyjQc/P42G/ooD0I mb/m1xEN+BZ2HsQd3s7ooXcYoYJvEqoU6tuK3AdmwRSW7bUf5iJnc56IN1diKyz8Gd28 D+wrc8AFKR7EVhLL0XcnwhDjLtK61dErtfkQ7U2b6WlTl8HItitwesP0mFZI8D2P0YY6 +kGqunHEwvgcuv3vSlxgRAGPHwj2yxMUWVh34zPc9lwZ+VZUD4EDkL6FfeAgZglMfrZK Ao3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WCrXIz6oQFkKNm70zoG/HZSBQOnDEr0Dc7B5UJQw9/s=; b=KGdnPw1OwBvUjIpc5aYKq7Fl0frW3k/x8XaqHHs46Aj55ZiN9I3l1e5wJhlzZfQGXX gQ/hv411ekCbMISGFeAnxsf23HXFww3J1RLJdeADudAQOKj0dhbFkmwxeLvfSP7ggoUk ZwHzwFyoTGczg2WOl/0vBKls4tojT6q58g6cvaW7G2wyZHg5U5o7fYsS8d55M04qRxdG M0Q5SpygV8pSWe6YWkIlXCDMsMSDwrpawdaXjaEcDZlO7ru1KYeqqfjP9KYkMSqtI9Mb rL/tPewXy4yre2LBMAwLlujt/f7jWIzpq706de1JFz4trsUyedBAqsfjqWsU5JDDofKY 2JjA== X-Gm-Message-State: AOAM5327jsYDAGLQIaehUWP/9WXsn6FHz1KCJrQoL7YAzfVw3+QPWwSk TDIAcrwgMW43qpuRPy5urFhTls/ec/2p1A== X-Google-Smtp-Source: ABdhPJwzsuTtz50GytEgMsRinQqrlsvhwBsE+jWVPe5rKlOdhDGJ34XhbSRxR9YtMKsb7/7awTFoxw== X-Received: by 2002:a17:902:c215:b0:148:af14:6e96 with SMTP id 21-20020a170902c21500b00148af146e96mr440038pll.80.1640228512109; Wed, 22 Dec 2021 19:01:52 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/3] target/ppc: Cache per-pmc insn and cycle count settings Date: Wed, 22 Dec 2021 19:01:47 -0800 Message-Id: <20211223030149.1947418-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211223030149.1947418-1-richard.henderson@linaro.org> References: <20211223030149.1947418-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::636 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x636.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1640228607240100002 Content-Type: text/plain; charset="utf-8" This is the combination of frozen bit and counter type, on a per counter basis. So far this is only used by HFLAGS_INSN_CNT, but will be used more later. Signed-off-by: Richard Henderson --- target/ppc/cpu.h | 3 +++ target/ppc/power8-pmu.h | 14 +++++------ target/ppc/cpu_init.c | 1 + target/ppc/helper_regs.c | 2 +- target/ppc/machine.c | 2 ++ target/ppc/power8-pmu.c | 51 +++++++++++++++++++++++++++++++--------- 6 files changed, 53 insertions(+), 20 deletions(-) diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index fc66c3561d..a297a52168 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -1144,6 +1144,9 @@ struct CPUPPCState { /* Other registers */ target_ulong spr[1024]; /* special purpose registers */ ppc_spr_t spr_cb[1024]; + /* Composite status for PMC[1-5] enabled and counting insns or cycles.= */ + uint8_t pmc_ins_cnt; + uint8_t pmc_cyc_cnt; /* Vector status and control register, minus VSCR_SAT */ uint32_t vscr; /* VSX registers (including FP and AVR) */ diff --git a/target/ppc/power8-pmu.h b/target/ppc/power8-pmu.h index 3ee4b4cda5..a839199561 100644 --- a/target/ppc/power8-pmu.h +++ b/target/ppc/power8-pmu.h @@ -13,14 +13,12 @@ #ifndef POWER8_PMU #define POWER8_PMU =20 -#include "qemu/osdep.h" -#include "cpu.h" -#include "exec/exec-all.h" -#include "exec/helper-proto.h" -#include "qemu/error-report.h" -#include "qemu/main-loop.h" - void cpu_ppc_pmu_init(CPUPPCState *env); -bool pmu_insn_cnt_enabled(CPUPPCState *env); + +#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) +void pmu_update_summaries(CPUPPCState *env); +#else +static inline void pmu_update_summaries(CPUPPCState *env) { } +#endif =20 #endif diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index 06ef15cd9e..63f9babfee 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -8313,6 +8313,7 @@ static void ppc_cpu_reset(DeviceState *dev) #endif /* CONFIG_TCG */ #endif =20 + pmu_update_summaries(env); hreg_compute_hflags(env); env->reserve_addr =3D (target_ulong)-1ULL; /* Be sure no exception or interrupt is pending */ diff --git a/target/ppc/helper_regs.c b/target/ppc/helper_regs.c index b847928842..8671b7bb69 100644 --- a/target/ppc/helper_regs.c +++ b/target/ppc/helper_regs.c @@ -123,7 +123,7 @@ static uint32_t hreg_compute_hflags_value(CPUPPCState *= env) } =20 #if defined(TARGET_PPC64) - if (pmu_insn_cnt_enabled(env)) { + if (env->pmc_ins_cnt) { hflags |=3D 1 << HFLAGS_INSN_CNT; } #endif diff --git a/target/ppc/machine.c b/target/ppc/machine.c index 93972df58e..756d8de5d8 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machine.c @@ -8,6 +8,7 @@ #include "qapi/error.h" #include "qemu/main-loop.h" #include "kvm_ppc.h" +#include "power8-pmu.h" =20 static void post_load_update_msr(CPUPPCState *env) { @@ -19,6 +20,7 @@ static void post_load_update_msr(CPUPPCState *env) */ env->msr ^=3D env->msr_mask & ~((1ULL << MSR_TGPR) | MSR_HVB); ppc_store_msr(env, msr); + pmu_update_summaries(env); } =20 static int cpu_load_old(QEMUFile *f, void *opaque, int version_id) diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index 08d1902cd5..d547e4c99b 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -11,8 +11,6 @@ */ =20 #include "qemu/osdep.h" - -#include "power8-pmu.h" #include "cpu.h" #include "helper_regs.h" #include "exec/exec-all.h" @@ -20,6 +18,7 @@ #include "qemu/error-report.h" #include "qemu/main-loop.h" #include "hw/ppc/ppc.h" +#include "power8-pmu.h" =20 #if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY) =20 @@ -121,18 +120,47 @@ static PMUEventType pmc_get_event(CPUPPCState *env, i= nt sprn) return evt_type; } =20 -bool pmu_insn_cnt_enabled(CPUPPCState *env) +void pmu_update_summaries(CPUPPCState *env) { - int sprn; + target_ulong mmcr0 =3D env->spr[SPR_POWER_MMCR0]; + target_ulong mmcr1 =3D env->spr[SPR_POWER_MMCR1]; + int ins_cnt =3D 0; + int cyc_cnt =3D 0; =20 - for (sprn =3D SPR_POWER_PMC1; sprn <=3D SPR_POWER_PMC5; sprn++) { - if (pmc_get_event(env, sprn) =3D=3D PMU_EVENT_INSTRUCTIONS || - pmc_get_event(env, sprn) =3D=3D PMU_EVENT_INSN_RUN_LATCH) { - return true; + if (!(mmcr0 & MMCR0_FC14) && mmcr1 !=3D 0) { + target_ulong sel; + + sel =3D extract64(mmcr1, MMCR1_PMC1EVT_EXTR, MMCR1_EVT_SIZE); + switch (sel) { + case 0x02: + case 0xfe: + ins_cnt |=3D 1 << 1; + break; + case 0x1e: + case 0xf0: + cyc_cnt |=3D 1 << 1; + break; } + + sel =3D extract64(mmcr1, MMCR1_PMC2EVT_EXTR, MMCR1_EVT_SIZE); + ins_cnt |=3D (sel =3D=3D 0x02) << 2; + cyc_cnt |=3D (sel =3D=3D 0x1e) << 2; + + sel =3D extract64(mmcr1, MMCR1_PMC3EVT_EXTR, MMCR1_EVT_SIZE); + ins_cnt |=3D (sel =3D=3D 0x02) << 3; + cyc_cnt |=3D (sel =3D=3D 0x1e) << 3; + + sel =3D extract64(mmcr1, MMCR1_PMC4EVT_EXTR, MMCR1_EVT_SIZE); + ins_cnt |=3D ((sel =3D=3D 0xf4) || (sel =3D=3D 0x2)) << 4; + cyc_cnt |=3D (sel =3D=3D 0x1e) << 3; } =20 - return false; + ins_cnt |=3D !(mmcr0 & MMCR0_FC56) << 5; + cyc_cnt |=3D !(mmcr0 & MMCR0_FC56) << 6; + + env->pmc_ins_cnt =3D ins_cnt; + env->pmc_cyc_cnt =3D cyc_cnt; + env->hflags =3D deposit32(env->hflags, HFLAGS_INSN_CNT, 1, ins_cnt != =3D 0); } =20 static bool pmu_increment_insns(CPUPPCState *env, uint32_t num_insns) @@ -264,8 +292,9 @@ void helper_store_mmcr0(CPUPPCState *env, target_ulong = value) =20 env->spr[SPR_POWER_MMCR0] =3D value; =20 - /* MMCR0 writes can change HFLAGS_PMCCCLEAR and HFLAGS_INSN_CNT */ + /* MMCR0 writes can change HFLAGS_PMCC[01] and HFLAGS_INSN_CNT */ hreg_compute_hflags(env); + pmu_update_summaries(env); =20 /* Update cycle overflow timers with the current MMCR0 state */ pmu_update_overflow_timers(env); @@ -278,7 +307,7 @@ void helper_store_mmcr1(CPUPPCState *env, uint64_t valu= e) env->spr[SPR_POWER_MMCR1] =3D value; =20 /* MMCR1 writes can change HFLAGS_INSN_CNT */ - hreg_compute_hflags(env); + pmu_update_summaries(env); } =20 target_ulong helper_read_pmc(CPUPPCState *env, uint32_t sprn) --=20 2.25.1 From nobody Sun May 19 10:01:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1640228630005784.6619228858658; Wed, 22 Dec 2021 19:03:50 -0800 (PST) Received: from localhost ([::1]:36934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0EOS-0000EL-Tt for importer@patchew.org; Wed, 22 Dec 2021 22:03:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0EMi-0006BI-DN for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:02:00 -0500 Received: from [2607:f8b0:4864:20::629] (port=43630 helo=mail-pl1-x629.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0EMf-00082b-8W for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:02:00 -0500 Received: by mail-pl1-x629.google.com with SMTP id m24so3246957pls.10 for ; Wed, 22 Dec 2021 19:01:53 -0800 (PST) Received: from localhost.localdomain ([156.19.246.20]) by smtp.gmail.com with ESMTPSA id q19sm4248513pfk.83.2021.12.22.19.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 19:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QDuAQPTVmudAI86lMWfLhpfjb3KuCOa/GoUZQb+Dyow=; b=X0VvfyZG+NI6MbmOHbdwvOrRR9nTsUf6PxSSi5XNhUiEnDQBixX7Yh7dAZra2VOc38 JXYl+g4UXzDYBofQ+5qxKOkWSgTlEM8jaqj4CEf2O32IRM/J8NHUvEue944YG9/T2Tdm ARUUn2fsW6euK+MU9kMiyhneD3i08sc0EwgwfDxL6KR3oNmg7wyG5ZWimezNBiGFkXRp OUX59HhsvwFjw6azW33yE1ta1uo4CBonCgi8BT5ymOgn2eojIXJbIlgMDOetxL35uOlC IgC+d22/vOLbh8cS3mcUah/yFR1d9bwxesyAP42DJ8X7gt6bxvgS6oOZm/LozWh64Hj2 kOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QDuAQPTVmudAI86lMWfLhpfjb3KuCOa/GoUZQb+Dyow=; b=UVIziMEQn38QF3Q++8R2LYVhxAZdGcLL4pUDxJ4qVnQa6KAGoQOg1gkggQI3drcFnz dWeDLZJ3bUF63EkgLMnVsw9WGpPng1XYGPfd7bXrLekQ2VXrVUK3cZkAl9PC40y2CnSj BSqJW9sJ+PGSS0GPtAWHLeP47gAAFOWQ7nzvGFbW1oIVcgCKsJu5Q0TRFrd30TKQcZSM Kh7DtcCq6Vh5hzdnKTdVPlw/b0Ln3oWCUnYxDEjThNdxtzF0NOWg9xWIQ2eigEiJhjd1 qPFGJ9hFaqiqFyAulubHMNnY324yQPsbW48QnbFNrPdTjMthmAlZYCqY7Y0aSAuHBhsF 2uBQ== X-Gm-Message-State: AOAM530xg/LXEizv7ebEW+RRDR6xJowFFcT92seLrw3FRwTd1PYqwRZJ L2djHsBTzUvcihscbFSRo+ekf8L2TmB4uQ== X-Google-Smtp-Source: ABdhPJwTFDD6XH0FwTZu5sDQnyZ+vlMds7HCdkKuqOC0hpv/jIG87Yd4S/vm1j+intoXEIWQPlHKRg== X-Received: by 2002:a17:902:d503:b0:149:16ed:d15f with SMTP id b3-20020a170902d50300b0014916edd15fmr568925plg.102.1640228513099; Wed, 22 Dec 2021 19:01:53 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/3] target/ppc: Rewrite pmu_increment_insns Date: Wed, 22 Dec 2021 19:01:48 -0800 Message-Id: <20211223030149.1947418-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211223030149.1947418-1-richard.henderson@linaro.org> References: <20211223030149.1947418-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::629 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1640228631841100004 Content-Type: text/plain; charset="utf-8" Use the cached pmc_ins_cnt value. Unroll the loop over the different PMC counters. Treat the PMC4 run-latch specially. Signed-off-by: Richard Henderson --- target/ppc/power8-pmu.c | 76 ++++++++++++++++++++++++++--------------- 1 file changed, 48 insertions(+), 28 deletions(-) diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index d547e4c99b..c60afa56a5 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -165,45 +165,65 @@ void pmu_update_summaries(CPUPPCState *env) =20 static bool pmu_increment_insns(CPUPPCState *env, uint32_t num_insns) { + target_ulong mmcr0 =3D env->spr[SPR_POWER_MMCR0]; + unsigned ins_cnt =3D env->pmc_ins_cnt; bool overflow_triggered =3D false; - int sprn; + target_ulong tmp; =20 - /* PMC6 never counts instructions */ - for (sprn =3D SPR_POWER_PMC1; sprn <=3D SPR_POWER_PMC5; sprn++) { - PMUEventType evt_type =3D pmc_get_event(env, sprn); - bool insn_event =3D evt_type =3D=3D PMU_EVENT_INSTRUCTIONS || - evt_type =3D=3D PMU_EVENT_INSN_RUN_LATCH; - - if (pmc_is_inactive(env, sprn) || !insn_event) { - continue; + if (unlikely(ins_cnt & 0x1e)) { + if (ins_cnt & (1 << 1)) { + tmp =3D env->spr[SPR_POWER_PMC1]; + tmp +=3D num_insns; + if (tmp >=3D PMC_COUNTER_NEGATIVE_VAL && (mmcr0 & MMCR0_PMC1CE= )) { + tmp =3D PMC_COUNTER_NEGATIVE_VAL; + overflow_triggered =3D true; + } + env->spr[SPR_POWER_PMC1] =3D tmp; } =20 - if (evt_type =3D=3D PMU_EVENT_INSTRUCTIONS) { - env->spr[sprn] +=3D num_insns; + if (ins_cnt & (1 << 2)) { + tmp =3D env->spr[SPR_POWER_PMC2]; + tmp +=3D num_insns; + if (tmp >=3D PMC_COUNTER_NEGATIVE_VAL && (mmcr0 & MMCR0_PMCjCE= )) { + tmp =3D PMC_COUNTER_NEGATIVE_VAL; + overflow_triggered =3D true; + } + env->spr[SPR_POWER_PMC2] =3D tmp; } =20 - if (evt_type =3D=3D PMU_EVENT_INSN_RUN_LATCH && - env->spr[SPR_CTRL] & CTRL_RUN) { - env->spr[sprn] +=3D num_insns; + if (ins_cnt & (1 << 3)) { + tmp =3D env->spr[SPR_POWER_PMC3]; + tmp +=3D num_insns; + if (tmp >=3D PMC_COUNTER_NEGATIVE_VAL && (mmcr0 & MMCR0_PMCjCE= )) { + tmp =3D PMC_COUNTER_NEGATIVE_VAL; + overflow_triggered =3D true; + } + env->spr[SPR_POWER_PMC3] =3D tmp; } =20 - if (env->spr[sprn] >=3D PMC_COUNTER_NEGATIVE_VAL && - pmc_has_overflow_enabled(env, sprn)) { + if (ins_cnt & (1 << 4)) { + target_ulong mmcr1 =3D env->spr[SPR_POWER_MMCR1]; + int sel =3D extract64(mmcr1, MMCR1_PMC4EVT_EXTR, MMCR1_EVT_SIZ= E); + if (sel =3D=3D 0x02 || (env->spr[SPR_CTRL] & CTRL_RUN)) { + tmp =3D env->spr[SPR_POWER_PMC4]; + tmp +=3D num_insns; + if (tmp >=3D PMC_COUNTER_NEGATIVE_VAL && (mmcr0 & MMCR0_PM= CjCE)) { + tmp =3D PMC_COUNTER_NEGATIVE_VAL; + overflow_triggered =3D true; + } + env->spr[SPR_POWER_PMC4] =3D tmp; + } + } + } =20 + if (ins_cnt & (1 << 5)) { + tmp =3D env->spr[SPR_POWER_PMC5]; + tmp +=3D num_insns; + if (tmp >=3D PMC_COUNTER_NEGATIVE_VAL && (mmcr0 & MMCR0_PMCjCE)) { + tmp =3D PMC_COUNTER_NEGATIVE_VAL; overflow_triggered =3D true; - - /* - * The real PMU will always trigger a counter overflow with - * PMC_COUNTER_NEGATIVE_VAL. We don't have an easy way to - * do that since we're counting block of instructions at - * the end of each translation block, and we're probably - * passing this value at this point. - * - * Let's write PMC_COUNTER_NEGATIVE_VAL to the overflowed - * counter to simulate what the real hardware would do. - */ - env->spr[sprn] =3D PMC_COUNTER_NEGATIVE_VAL; } + env->spr[SPR_POWER_PMC5] =3D tmp; } =20 return overflow_triggered; --=20 2.25.1 From nobody Sun May 19 10:01:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 164022880865422.949709963873715; Wed, 22 Dec 2021 19:06:48 -0800 (PST) Received: from localhost ([::1]:41680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n0ERL-0003UA-Nk for importer@patchew.org; Wed, 22 Dec 2021 22:06:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n0EMj-0006Ce-F4 for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:02:01 -0500 Received: from [2607:f8b0:4864:20::630] (port=42592 helo=mail-pl1-x630.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n0EMf-00082q-97 for qemu-devel@nongnu.org; Wed, 22 Dec 2021 22:02:01 -0500 Received: by mail-pl1-x630.google.com with SMTP id u16so3254271plg.9 for ; Wed, 22 Dec 2021 19:01:55 -0800 (PST) Received: from localhost.localdomain ([156.19.246.20]) by smtp.gmail.com with ESMTPSA id q19sm4248513pfk.83.2021.12.22.19.01.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Dec 2021 19:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MwC8DfPxtCdA8CUKyYDPaon4yktbu90EwhN6j0mhd+Q=; b=H0wwabzm9z7VIWRw2eP9jJtp8HNh7d0BRi409AIIB0fmNfBdeC9ZqK9jDvXT6TJ1xM jz/KmxW4khR1KiAekJGhZclbNNAgtWsYPPjxClGm11j2BmMcyCXcul31cj0mdsmCLWtj xQvznvo2chkf5o2peEXS4Isw52yH+x8+9pPiL1PHmTiHXr22srFMHKQyT2bHs7RWyTSO +tgBO3+/3gHU5O2CYODpjhV75GRPug/iGfawRgYdW7OTqnmoBj0brVa9hTGNE2sv/AAY o53znBrkdKvdpoJGR2WPctEpjx9+aNnliIHp3xfNhLLfqupE4IXwf3e9VtY3rGfxXlTQ Ww1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MwC8DfPxtCdA8CUKyYDPaon4yktbu90EwhN6j0mhd+Q=; b=HPF7VQ/RuTn/ZJm/V0TjdhXTeNRMexNcJk5Bx15snVnzxpGgBeTZYsxbY+F2/aKcAj CQWa9m40QjCP2xqy1KucuDvf5pICmzVCx3D5vKhnoJVqsyOa6y7tMy4H/c1QpjO+TExP 0YyCs8pX1L47pzG+JDhaEF8oiePzbwrANvNr1a/LPyqUE5W4+KP3ZeuJgo2Py2ujfNWI 0awhz802l/0P0VOi5/iLubrVJOUSu876JqpswcEkdiRsYFEiy4X3DLN0tzQR6fmZrRUN Tu3aoq6eJZMQVztuHTSJeRXhPn/Cki2U6AUK8Iru7IrctG+ORBUSV47AQmUFVoifJza4 nzMA== X-Gm-Message-State: AOAM530LxQVBAr0Iy1sb9q/zRzNnxKMBaKXUOXRDyExRTodopROjqyHD o7AXqxtsTpvGUJQSPBglfu3UrSlz9hSc5Q== X-Google-Smtp-Source: ABdhPJw+fHpiecv1MwBDIMMVKapd583LjTGvQVU4pj8kthHwclBBRQYu7H1C8cp5D/YXa06S6i4mvQ== X-Received: by 2002:a17:902:b189:b0:143:8079:3d3b with SMTP id s9-20020a170902b18900b0014380793d3bmr610609plr.71.1640228514059; Wed, 22 Dec 2021 19:01:54 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/3] target/ppc: Use env->pnc_cyc_cnt Date: Wed, 22 Dec 2021 19:01:49 -0800 Message-Id: <20211223030149.1947418-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211223030149.1947418-1-richard.henderson@linaro.org> References: <20211223030149.1947418-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::630 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1640228810398100001 Content-Type: text/plain; charset="utf-8" Use the cached pmc_cyc_cnt value in pmu_update_cycles and pmc_update_overflow_timer. This leaves pmc_get_event and pmc_is_inactive unused, so remove them. Signed-off-by: Richard Henderson --- target/ppc/power8-pmu.c | 107 ++++------------------------------------ 1 file changed, 9 insertions(+), 98 deletions(-) diff --git a/target/ppc/power8-pmu.c b/target/ppc/power8-pmu.c index c60afa56a5..7859ea24f5 100644 --- a/target/ppc/power8-pmu.c +++ b/target/ppc/power8-pmu.c @@ -24,19 +24,6 @@ =20 #define PMC_COUNTER_NEGATIVE_VAL 0x80000000UL =20 -static bool pmc_is_inactive(CPUPPCState *env, int sprn) -{ - if (env->spr[SPR_POWER_MMCR0] & MMCR0_FC) { - return true; - } - - if (sprn < SPR_POWER_PMC5) { - return env->spr[SPR_POWER_MMCR0] & MMCR0_FC14; - } - - return env->spr[SPR_POWER_MMCR0] & MMCR0_FC56; -} - static bool pmc_has_overflow_enabled(CPUPPCState *env, int sprn) { if (sprn =3D=3D SPR_POWER_PMC1) { @@ -46,80 +33,6 @@ static bool pmc_has_overflow_enabled(CPUPPCState *env, i= nt sprn) return env->spr[SPR_POWER_MMCR0] & MMCR0_PMCjCE; } =20 -/* - * For PMCs 1-4, IBM POWER chips has support for an implementation - * dependent event, 0x1E, that enables cycle counting. The Linux kernel - * makes extensive use of 0x1E, so let's also support it. - * - * Likewise, event 0x2 is an implementation-dependent event that IBM - * POWER chips implement (at least since POWER8) that is equivalent to - * PM_INST_CMPL. Let's support this event on PMCs 1-4 as well. - */ -static PMUEventType pmc_get_event(CPUPPCState *env, int sprn) -{ - uint8_t mmcr1_evt_extr[] =3D { MMCR1_PMC1EVT_EXTR, MMCR1_PMC2EVT_EXTR, - MMCR1_PMC3EVT_EXTR, MMCR1_PMC4EVT_EXTR }; - PMUEventType evt_type =3D PMU_EVENT_INVALID; - uint8_t pmcsel; - int i; - - if (pmc_is_inactive(env, sprn)) { - return PMU_EVENT_INACTIVE; - } - - if (sprn =3D=3D SPR_POWER_PMC5) { - return PMU_EVENT_INSTRUCTIONS; - } - - if (sprn =3D=3D SPR_POWER_PMC6) { - return PMU_EVENT_CYCLES; - } - - i =3D sprn - SPR_POWER_PMC1; - pmcsel =3D extract64(env->spr[SPR_POWER_MMCR1], mmcr1_evt_extr[i], - MMCR1_EVT_SIZE); - - switch (pmcsel) { - case 0x2: - evt_type =3D PMU_EVENT_INSTRUCTIONS; - break; - case 0x1E: - evt_type =3D PMU_EVENT_CYCLES; - break; - case 0xF0: - /* - * PMC1SEL =3D 0xF0 is the architected PowerISA v3.1 - * event that counts cycles using PMC1. - */ - if (sprn =3D=3D SPR_POWER_PMC1) { - evt_type =3D PMU_EVENT_CYCLES; - } - break; - case 0xFA: - /* - * PMC4SEL =3D 0xFA is the "instructions completed - * with run latch set" event. - */ - if (sprn =3D=3D SPR_POWER_PMC4) { - evt_type =3D PMU_EVENT_INSN_RUN_LATCH; - } - break; - case 0xFE: - /* - * PMC1SEL =3D 0xFE is the architected PowerISA v3.1 - * event to sample instructions using PMC1. - */ - if (sprn =3D=3D SPR_POWER_PMC1) { - evt_type =3D PMU_EVENT_INSTRUCTIONS; - } - break; - default: - break; - } - - return evt_type; -} - void pmu_update_summaries(CPUPPCState *env) { target_ulong mmcr0 =3D env->spr[SPR_POWER_MMCR0]; @@ -233,18 +146,16 @@ static void pmu_update_cycles(CPUPPCState *env) { uint64_t now =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); uint64_t time_delta =3D now - env->pmu_base_time; - int sprn; + int sprn, cyc_cnt =3D env->pmc_cyc_cnt; =20 for (sprn =3D SPR_POWER_PMC1; sprn <=3D SPR_POWER_PMC6; sprn++) { - if (pmc_get_event(env, sprn) !=3D PMU_EVENT_CYCLES) { - continue; + if (cyc_cnt & (1 << (sprn - SPR_POWER_PMC1 + 1))) { + /* + * The pseries and powernv clock runs at 1Ghz, meaning + * that 1 nanosec equals 1 cycle. + */ + env->spr[sprn] +=3D time_delta; } - - /* - * The pseries and powernv clock runs at 1Ghz, meaning - * that 1 nanosec equals 1 cycle. - */ - env->spr[sprn] +=3D time_delta; } =20 /* Update base_time for future calculations */ @@ -273,7 +184,7 @@ static void pmc_update_overflow_timer(CPUPPCState *env,= int sprn) return; } =20 - if (pmc_get_event(env, sprn) !=3D PMU_EVENT_CYCLES || + if (!(env->pmc_cyc_cnt & (1 << (sprn - SPR_POWER_PMC1 + 1))) || !pmc_has_overflow_enabled(env, sprn)) { /* Overflow timer is not needed for this counter */ timer_del(pmc_overflow_timer); @@ -281,7 +192,7 @@ static void pmc_update_overflow_timer(CPUPPCState *env,= int sprn) } =20 if (env->spr[sprn] >=3D PMC_COUNTER_NEGATIVE_VAL) { - timeout =3D 0; + timeout =3D 0; } else { timeout =3D PMC_COUNTER_NEGATIVE_VAL - env->spr[sprn]; } --=20 2.25.1