From nobody Sun Feb 8 19:03:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640030444; cv=none; d=zohomail.com; s=zohoarc; b=IOD2TjQfq8ZUc29SWz9Avh6Fx5gtQpYHuvewYZLhclJK/CWVNoMppkcHKScFo7kkZR51mGhSYtTh4G79WYwXgCKwuY2Xfl42KgjQd5Kpg8AYtmerE9suOorPIQQYxGJyMv2fcvAawrJsd3QLcl90UsXw3yI1rWX1AMC2xWvHeDQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640030444; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ayL3Y6gZm6XhBH2r4HXO5sw4wKPzmz4WxHL5sCFdC0w=; b=lFv+KQqWc5RC3D0tPObuGWT54+LSeyQ0XrBH9JWF8Zf/gz/LHrpfZcLHYJxw5Xl3Q3d/zJ9nkgFkDc+RHvPqv1FyoO7E6SJOOP3u0caJCWlScNTCP+H9M+dT5GxhHLmdaK+fHInTZXFWyK55y03/mQwthx2r16ThUHwicuBkjEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640030444902298.74125381012163; Mon, 20 Dec 2021 12:00:44 -0800 (PST) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-ZUQS046fNeasfQZL8qLotw-1; Mon, 20 Dec 2021 15:00:43 -0500 Received: by mail-wm1-f69.google.com with SMTP id b75-20020a1c804e000000b0034569bde713so64305wmd.9 for ; Mon, 20 Dec 2021 12:00:42 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id a22sm291743wme.19.2021.12.20.12.00.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 12:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640030443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ayL3Y6gZm6XhBH2r4HXO5sw4wKPzmz4WxHL5sCFdC0w=; b=T+JAZFUrOWOecZfxRsfIOJ7WwxRr8ILUA5zR+633MT+k1He7BW9PnLpQVYU6QzXxvuGj9i su9R2aGqLQsfF0Xn1ddGyR9HBHaScLGK9NF4zAjrjaXDGWH9/LDkSyAjLEAFcNfT05bYqG sxPtZsEMHUHxhRXxc10aKAPqYPoCeyk= X-MC-Unique: ZUQS046fNeasfQZL8qLotw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ayL3Y6gZm6XhBH2r4HXO5sw4wKPzmz4WxHL5sCFdC0w=; b=mRSpA/RkqY0odSG2sYL938T+8TG2DH91OKefhPv7USSJO09eTQTVq6boW8VMUwiUJy Ot6gt8bVk08y6uPyPZGLOnGB+nDnbw9dhVtsIoKhZEEM9a9RgbdiTwO5IiqH/T1YeuG4 Fqg5YD2UYVhAOn/I8ltvpjIgNdy6bAhJt5WfEca6iODQFXBcq1Mr5qUoqTA6QFV6Yz+h d0KSsnQIlWzF3zGmFGMRsB5ZDAV1JSU1EvVlZdNJZvJzZzM32a6y14bNuOpvOyqaQRpj MEB0unlbMjc6kpj6Q6LqR3laJhvayTpqewVP5TSbKW70AQIuwmpzJoyYJXaqWZ3ukwuE 5nBA== X-Gm-Message-State: AOAM532waIpVGGAQSLnBvuNGjUjDia1F4a+EvBiFA5NH9UxHHcuJ5upY AJKdGDjORRB3AlWKhuFWneOmTUgA1YnRv5nM4vn7UPkGrx9xA3qfKBTPD5GCdPhGnw3bY2djggD pIaaBM5uOLRweXg== X-Received: by 2002:a05:600c:3787:: with SMTP id o7mr500330wmr.41.1640030441398; Mon, 20 Dec 2021 12:00:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkPrcst9q21KRPZPYPKYU6oqIbOGKWi4+CYr42MOCnXy/l0Ei7BprLQicqm7wzEDQ3wYysYQ== X-Received: by 2002:a05:600c:3787:: with SMTP id o7mr500311wmr.41.1640030441170; Mon, 20 Dec 2021 12:00:41 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Eric Blake , qemu-block@nongnu.org, Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Qing Wang Subject: [PATCH 1/2] qemu-storage-daemon: Add vhost-user-blk help Date: Mon, 20 Dec 2021 21:00:33 +0100 Message-Id: <20211220200034.2233987-2-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211220200034.2233987-1-philmd@redhat.com> References: <20211220200034.2233987-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640030445684100001 Add missing vhost-user-blk help: $ qemu-storage-daemon -h ... --export [type=3D]vhost-user-blk,id=3D,node-name=3D, addr.type=3Dunix,addr.path=3D[,writable=3Don|off] [,logical-block-size=3D][,num-queues=3D] export the specified block node as a vhosts-user-blk device over UNIX domain socket --export [type=3D]vhost-user-blk,id=3D,node-name=3D, fd,addr.str=3D[,writable=3Don|off] [,logical-block-size=3D][,num-queues=3D] export the specified block node as a vhosts-user-blk device over file descriptor ... Fixes: 90fc91d50b7 ("convert vhost-user-blk server to block export API") Reported-by: Qing Wang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- storage-daemon/qemu-storage-daemon.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/storage-daemon/qemu-storage-daemon.c b/storage-daemon/qemu-sto= rage-daemon.c index 52cf17e8ace..0c19e128e3f 100644 --- a/storage-daemon/qemu-storage-daemon.c +++ b/storage-daemon/qemu-storage-daemon.c @@ -104,6 +104,19 @@ static void help(void) " export the specified block node over FUSE\n" "\n" #endif /* CONFIG_FUSE */ +#ifdef CONFIG_VHOST_USER_BLK_SERVER +" --export [type=3D]vhost-user-blk,id=3D,node-name=3D,\n" +" addr.type=3Dunix,addr.path=3D[,writable=3Don|off]= \n" +" [,logical-block-size=3D][,num-queues=3D]\n" +" export the specified block node as a\n" +" vhosts-user-blk device over UNIX domain socket\n" +" --export [type=3D]vhost-user-blk,id=3D,node-name=3D,\n" +" fd,addr.str=3D[,writable=3Don|off]\n" +" [,logical-block-size=3D][,num-queues=3D]\n" +" export the specified block node as a\n" +" vhosts-user-blk device over file descriptor\n" +"\n" +#endif /* CONFIG_VHOST_USER_BLK_SERVER */ " --monitor [chardev=3D]name[,mode=3Dcontrol][,pretty[=3Don|off]]\n" " configure a QMP monitor\n" "\n" --=20 2.33.1 From nobody Sun Feb 8 19:03:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1640030452; cv=none; d=zohomail.com; s=zohoarc; b=Wm8uFWNuWQsLLM9/u8VdT1kOteIb6jmqiRRCPei35zdVDfzGZdBeJpgo0Z8ENRVMwwRwtPIQ68KOYQ+S1sKsU/uULJbiTBHAz0+jxEJatO4y2TXe8LvBSJMT/6qG9oRfIssOVKThyyE7OcXKjQPvZzDhky1m8ewqZhj0sjJD2EA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640030452; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Esu57sWgC3/UQ9aIRkG9aAmymu76n4chXDeJH006p+M=; b=iuRZogvlciW8i4UIERePkkMIqLJaUogIeA61RRnYHi7RpR5OGYvAEuOC5OmjiBALtLzAsSNYsCm1RE3Wb76LjsWFf1oww03ct+xwa25USdGpEwZHqZ8jhSrWZovKENkgdqsjGdJiz2XDKzTqcJ5LjItq9xj0QhJaUtzW2ZTyRPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1640030452255126.04091746507868; Mon, 20 Dec 2021 12:00:52 -0800 (PST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-EqeX674YNBqGfbdiBdjpaA-1; Mon, 20 Dec 2021 15:00:47 -0500 Received: by mail-wm1-f71.google.com with SMTP id v190-20020a1cacc7000000b003456d598510so71521wme.6 for ; Mon, 20 Dec 2021 12:00:47 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id f6sm371074wmq.6.2021.12.20.12.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 12:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640030451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Esu57sWgC3/UQ9aIRkG9aAmymu76n4chXDeJH006p+M=; b=fkbTx3Mc8aJoYLDfKmF3msKzcn8yHTchpqDPzzr92BzwUylmlz9ohduwczKvzjExHRHjTE RuhLrlzqkjfmz6gXp+NJPrGigP2YRmQB8oTSHOQa7c0X9Y5HESDTPgDEOLqR4jhNxC3o8t YiRv0cUQzVj4BKnEmppWzHA9qjYN/W0= X-MC-Unique: EqeX674YNBqGfbdiBdjpaA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Esu57sWgC3/UQ9aIRkG9aAmymu76n4chXDeJH006p+M=; b=34YICIS8u2rwfz7d6/JtmYPkUyKvcCOtEZt36idTyUFulxpOugfxfOZA55l91wwyO3 toQNSBIzTJyc/z7MVNahSfTtkN19dqsoiMqMt0p6GrlshXDvVBjmGlgDLLSEUCvqFsbe Mn0Pnm/0UEkxHIaMVEOD9C2ulj4TB2/Y3iMRIhWatY0dJeqwNNMzt974i/T1HyblWqw/ hQtzgNTDCtd9uBOZTKWKq9ffpzEj5cdDlcO9nAcyKqFR3/8x32iANJGHgSORtgU0bccd dyzbnhWkS9GcNpciFvYY6NHWFk3vLCzNgBz78tdrixL+BZRwxdaNLmhK68BUnPa4+afQ r42A== X-Gm-Message-State: AOAM532FHBP4QRWv4IG4DshpfLuK0it2zUZMtcxNws5IzAoRE6niLzFT M1hnbl8ukje3qtiBOyBD616t9Kow3qOGZEz0bDmOIY6QRHtoAnudO9U/iltg/bXDOUXXygw6aX+ rp4lQwQegKhxm1Q== X-Received: by 2002:adf:a489:: with SMTP id g9mr13714440wrb.235.1640030446659; Mon, 20 Dec 2021 12:00:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwh8PZDOsTg1dJfgmw/yZ8CXrnCyp7RYaLkni4pwgCEeO435V/b2DV3M1GuSMwTV9W4JxiQ9w== X-Received: by 2002:adf:a489:: with SMTP id g9mr13714428wrb.235.1640030446532; Mon, 20 Dec 2021 12:00:46 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Eric Blake , qemu-block@nongnu.org, Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/2] qapi/block: Restrict vhost-user-blk to CONFIG_VHOST_USER_BLK_SERVER Date: Mon, 20 Dec 2021 21:00:34 +0100 Message-Id: <20211220200034.2233987-3-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211220200034.2233987-1-philmd@redhat.com> References: <20211220200034.2233987-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1640030454366100001 Do not list vhost-user-blk in BlockExportType when CONFIG_VHOST_USER_BLK_SERVER is disabled. Fixes: 90fc91d50b7 ("convert vhost-user-blk server to block export API") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- qapi/block-export.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index c1b92ce1c1c..6bc29a75dc0 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -277,7 +277,8 @@ # Since: 4.2 ## { 'enum': 'BlockExportType', - 'data': [ 'nbd', 'vhost-user-blk', + 'data': [ 'nbd', + { 'name': 'vhost-user-blk', 'if': 'CONFIG_VHOST_USER_BLK_SERVE= R' }, { 'name': 'fuse', 'if': 'CONFIG_FUSE' } ] } =20 ## --=20 2.33.1