From nobody Tue Feb 10 09:02:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1639832695; cv=none; d=zohomail.com; s=zohoarc; b=lmLh+qMQ/z5rn6OX6keLmWqbfJIHDjcspZHSN0gp++YK8RR0HL8cTZ2Dwo273cgjkXTH4d5Q69dI+ZQJ1KH9eyAZzS0xm7yRC+2Z1EAXwxpcZ5se6R89Se555i2V7MIpDoFbxfsGR43rsILXi8YMuTMseUl12gLYSPT6FrciK00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639832695; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=4bKHxb95nFSAADwowuqlt0XUJr9p4AbCeYHUfbFYBto=; b=SwqJF8ED9OMZFzX3ltZYpXsWzH2eiN3Go3XdEjUZROA0TqejSDuSFS5TALonUyDcB2/bqHzJR1Z22Z4685ZmPW0x7Xn0FImsj8LJal0Ft3xrH9zbMnruh8TZZjiJ6JruILZXpKgpbQVNLzff0mH4Uf5qP27ZN37/v9pR5xsVW8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1639832695770544.0575094378279; Sat, 18 Dec 2021 05:04:55 -0800 (PST) Received: by mail-wm1-f50.google.com with SMTP id a83-20020a1c9856000000b00344731e044bso3275861wme.1 for ; Sat, 18 Dec 2021 05:04:55 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id t8sm13269522wmq.32.2021.12.18.05.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Dec 2021 05:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4bKHxb95nFSAADwowuqlt0XUJr9p4AbCeYHUfbFYBto=; b=Jf/yaXKR2rvRYppPqyZH4KBsZCy9yQjO+3cxiFjbwawun9yI4JlEECT0nuZl9WcQsd El8+wwip2GWXzsPPHfq01s2ZplCCv2UzyutBjegIPwXimuvo3ulGifGUR7n849Q4OoOo ZA50E0LPwLCf+9ADJYw7Gmckjy89NxJlZYhPFrwERsOlEx68UCGKwM2+VQClYXNdGFhN DfVHg8eZ0YScZZFqQv+Q8TFxtgEhpyx6lpUmlzact6wOkwBSNB+OsLTFRVwEgDnb4J2O HJtDFJKWFsXSwYLvU9+fR1tCHzJhnwqpOAglrFmf9jt649KGpq6V0cYX4a2AWyvOpMmY FncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4bKHxb95nFSAADwowuqlt0XUJr9p4AbCeYHUfbFYBto=; b=Dxoo9hFp4cCKaNeY3Ho4wSQH5IvAWhMbCMUdhJTC0VvwxbufVI/c0gSBaJqgIXvavd xBl9WiIBBpwbzcqEzJSnTvhck7KybfAiaGCRgEUOPgktsEobLPLUx8ELrz7Iki5Sfqj7 geUYvAomGjw7au68zOFHn1FcRBPgQbawj6e5/BuMNkVfTvcDEoRLPwOSqcTZSwMpGNQv XdLllPXntYUA4nwkeYM0FY+xpw7VtBytuvbGW+h21DNMgoNovbwDQMTrdZfGTKw5OHsN iINw+pvmDrVC0DNaUTSZFnBufhDeNWelVktMt6srkXGDpJqq1uMBB1GmjXdMr6IabLM/ Bq6Q== X-Gm-Message-State: AOAM532kD/3XS2KCG48QwJ9bIZ53Fmt2Lnt9lwqn4giBVD6X8kodxKRT yp23UvpMqSunekK60LaLJwM= X-Google-Smtp-Source: ABdhPJwm3SrZRDIDHIiDb6y2pSTFlCP+bVQURovf3iLgUgeX8U2ojrNb0PH7baXnn5CYjPVZyE44cw== X-Received: by 2002:a7b:c054:: with SMTP id u20mr6686218wmc.133.1639832693991; Sat, 18 Dec 2021 05:04:53 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Yanan Wang , Richard Henderson , Eduardo Habkost , qemu-trivial@nongnu.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/5] hw/qdev: Correct qdev_connect_gpio_out_named() documentation Date: Sat, 18 Dec 2021 14:04:35 +0100 Message-Id: <20211218130437.1516929-4-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211218130437.1516929-1-f4bug@amsat.org> References: <20211218130437.1516929-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1639832697209100001 qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Yanan Wang --- include/hw/qdev-core.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index dcf20c69b89..424c48daf6e 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -504,7 +504,8 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const= char *name, int n); void qdev_connect_gpio_out(DeviceState *dev, int n, qemu_irq pin); =20 /** - * qdev_connect_gpio_out: Connect one of a device's anonymous output GPIO = lines + * qdev_connect_gpio_out_named: Connect one of a device's named output + * GPIO lines * @dev: Device whose GPIO to connect * @name: Name of the output GPIO array * @n: Number of the anonymous output GPIO line (which must be in range) @@ -526,7 +527,7 @@ void qdev_connect_gpio_out(DeviceState *dev, int n, qem= u_irq pin); * qemu_irqs at once, or to connect multiple outbound GPIOs to the * same qemu_irq; see qdev_connect_gpio_out() for details. * - * For named output GPIO lines, use qdev_connect_gpio_out_named(). + * For anonymous output GPIO lines, use qdev_connect_gpio_out(). */ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, qemu_irq pin); --=20 2.33.1