From nobody Mon Feb 9 04:58:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639782948; cv=none; d=zohomail.com; s=zohoarc; b=IZcdL9+ae0kQkPtH89z+HBKSI7TR4xFT7XiXCPWLzxYByNawWOFNL/3s0ocOSSR9p9UhoDh15WW8vG6GeO/jerOKzw6mJw/HkH8ctf9PCMlQZDEBD8NK0SPqW+ZTGFQ1fGIVH1WoMw6oD6S2qoqWuJsa9YUSO+lkMEh5NdvUa/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639782948; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=iL0P2081J8WaLpt+YEfTZdilM3EPvBPtqroDSbrUA0k=; b=IRGwUzXXOFBwUJ71oksu5zbn6dzBrmkVpniQ7ySlo2D5xJPxkxPEooKWsT5MJLqqFtR2vg59ZO46RLD+q/tp5aeILxbKQFlTO8CrUozCEkN2JJaupw54eb+vvxzntAquqqBNlgeKJRLqJzsqW2bOjT2j27+ydoY23AMhjoE2Idk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639782948840562.1205896245588; Fri, 17 Dec 2021 15:15:48 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-cSphUcnyP8S8rhKm7hfNNg-1; Fri, 17 Dec 2021 18:15:46 -0500 Received: by mail-wr1-f70.google.com with SMTP id v15-20020adf8b4f000000b001a24c46d6ceso1039628wra.15 for ; Fri, 17 Dec 2021 15:15:46 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id a5sm1607248wrt.94.2021.12.17.15.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Dec 2021 15:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639782947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iL0P2081J8WaLpt+YEfTZdilM3EPvBPtqroDSbrUA0k=; b=AiEbHXjmHyO99gdbPIfTFx/2Ty2crMcE3m6avo50FSYlzkJ1zm9U0X0vz3wv1A7dnqEEh+ RbbkLs9001w5ztgp9+Yq/0LoDUxDYAxC14x2SIuhd0N0Dzw2rC09praF2Ejpg1ZH+lSzqH c0MwGx0fdsFYz2exc42+4xPpB+cQK3I= X-MC-Unique: cSphUcnyP8S8rhKm7hfNNg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iL0P2081J8WaLpt+YEfTZdilM3EPvBPtqroDSbrUA0k=; b=l0XmcciPt3ikv2dRM167exFwfhLW0I+9+ER3p9OApJVttUdxDdHGH6UCbEtTQk4E/U aviLTpeyEgRtAPOmXihAcDnXin+N/Lig88MpFVwo+3Ht50+l3fYVEoycrthrX8QyqhAE OdJfE02wtelqv9c19NQ3vtf5QuPMq+6rmxYE3jJPm64IBco+i0l+IztWmh5znOQKhO6T 8uFIwb+xGFvBvcVhFPPkoTPWDzQO8dMc0IuOu5AUgC8YS5j+Dmlxe9mzDEs7zIIYCddi GokfCY87WDMu0RO1Nlb1K87EBsE+ZEuKX7u/k7vdMsawmLUKkT1rkVk4uiRs1UMtsHzV JQnA== X-Gm-Message-State: AOAM5312nmNAzf/XasPc64UMzWiluU6MBx5ZQFY2WHjQA/tjDXl8Qbvb OHBRuskTjKp+ZYwqdMuFRvL6CSHoQvXJ3eB4595oaPkXPW04O7nK1iJINxpEOo5pLcy5eGSIbjp JNZCYK7XgjQn07A== X-Received: by 2002:a05:6000:10c9:: with SMTP id b9mr4161789wrx.539.1639782945541; Fri, 17 Dec 2021 15:15:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJRKKfZelw0LUZNvAEFDEUGVRRT7d2bubtdR+rYrYcEyCjvJwtXRSPY7XwhnGJ9tk38X71JQ== X-Received: by 2002:a05:6000:10c9:: with SMTP id b9mr4161775wrx.539.1639782945290; Fri, 17 Dec 2021 15:15:45 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Hannes Reinecke , qemu-block@nongnu.org, Fam Zheng , qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/scsi/megasas: Simplify using the ldst API Date: Sat, 18 Dec 2021 00:15:42 +0100 Message-Id: <20211217231542.1461286-1-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639782951243100001 This code is easier to review using the load/store API. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/scsi/megasas.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 619b66ef0f3..066f30e3f22 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -375,8 +375,7 @@ static int megasas_setup_inquiry(uint8_t *cdb, int pg, = int len) cdb[1] =3D 0x1; cdb[2] =3D pg; } - cdb[3] =3D (len >> 8) & 0xff; - cdb[4] =3D (len & 0xff); + stw_be_p(&cdb[2], len); return len; } =20 @@ -392,18 +391,8 @@ static void megasas_encode_lba(uint8_t *cdb, uint64_t = lba, } else { cdb[0] =3D READ_16; } - cdb[2] =3D (lba >> 56) & 0xff; - cdb[3] =3D (lba >> 48) & 0xff; - cdb[4] =3D (lba >> 40) & 0xff; - cdb[5] =3D (lba >> 32) & 0xff; - cdb[6] =3D (lba >> 24) & 0xff; - cdb[7] =3D (lba >> 16) & 0xff; - cdb[8] =3D (lba >> 8) & 0xff; - cdb[9] =3D (lba) & 0xff; - cdb[10] =3D (len >> 24) & 0xff; - cdb[11] =3D (len >> 16) & 0xff; - cdb[12] =3D (len >> 8) & 0xff; - cdb[13] =3D (len) & 0xff; + stq_be_p(&cdb[2], lba); + stl_be_p(&cdb[2 + 8], len); } =20 /* --=20 2.33.1