From nobody Mon Feb 9 23:16:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639660833; cv=none; d=zohomail.com; s=zohoarc; b=QhKy1Bs6WYFz2VLYSCOkzs26qc+boGTYbFRF6Y8VFKz2OYd1JAda2GgH97cNzkKzu38NwKpRHILSy7qBDD9B+s2lApVOzDRtkVonTD3vPI9zbv6ZWAbU5qdABov61eN1Nq2yeXQgsNVP6kW5vvH7XY58bILEAO91EcoD2VcaXPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639660833; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=B8NVW8RzFIvlCgYYatO7h0pq6ZyAoX/TkoQJgZPE4KL9pPTnnub4dZKXh3kY1sjcaYJZ5yfAdKS03eNaOPP1YgpS6k3SSBmu4RhmU95ZVvda4ri/Gx0f6+9+vrbeNG+gCwiUjyi8BBvr3r872kpGwj8DuL8Af8GrXjAohhjEZ/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1639660833009155.71424255777526; Thu, 16 Dec 2021 05:20:33 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-457-pcidkIRUPMegwfo0KzVP9Q-1; Thu, 16 Dec 2021 08:20:31 -0500 Received: by mail-wr1-f70.google.com with SMTP id a11-20020adffb8b000000b001a0b0f4afe9so4121378wrr.13 for ; Thu, 16 Dec 2021 05:20:30 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id d13sm622953wru.41.2021.12.16.05.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 05:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639660831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=bQcH1X6TNt2odHXy4h39CyrvoBfwqc0KPN1+AqPIZ0xJX41NhdEiHC9pi5lKZHHGaRkUCa xPZRfGLkvLM6XJTOite0AD4XdUFm5nNqiCh72lpVI6kpY3YljLta0264bjY69n3y0jUn46 QgjdlYx7Xvt+GcXn+5OSt7l5z3r1j2E= X-MC-Unique: pcidkIRUPMegwfo0KzVP9Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=nNlA0cMPQKrbxoW3Q+yfpq1sb4gkMAR+V1N62mMoZZ3/SnQZZ4DY2SL+fYMVbVUwfm DcIg1hoap9+oPjh28jSYqP6nKZTrRWplzY8ed5OPSg6293ApST+MmVOzDh2Haj6nxDj5 LpgOIR9iWFSV737ttxFcuHwRrg+t6dUw1LFwVgf6dGsrFIiyJvq7UD3vWoPJVINXfuuP GD6eqXE+h/VN2eh1pJ6YDCpvqufJihrkVmzzinulCb7b8NLNFAOhAAdxqeLLw5NpKL23 nh0dNNeSqG7azdSlH+7O9lChSzfQSv7LSGAbmctrex41x7uY6PZbXZktwDcpBElVukKB toqg== X-Gm-Message-State: AOAM532C2k5NbdRMPdbjIF07HkLAxBpNeWvnwzeJYNpRA7z5Y6ja+Hb4 tGDkiZIwZPSveqDNWNUHOXIheLCQ6bH5e3bngYGSmunCHxt2bRt3BsuyVdvjJt+FwTEIQXV0RWe bPXnim/2vlEczow== X-Received: by 2002:a5d:4486:: with SMTP id j6mr1263865wrq.160.1639660829883; Thu, 16 Dec 2021 05:20:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQ8DG5F2/GyHtKr4ceY/cv2HsvzJMgdXn0wjTMzUVOvZl4mD4Z+fq+HLBWqw1JPcGEtabUNg== X-Received: by 2002:a5d:4486:: with SMTP id j6mr1263857wrq.160.1639660829743; Thu, 16 Dec 2021 05:20:29 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Richard Henderson , Yanan Wang Subject: [PATCH v6 1/8] tests/unit/test-smp-parse: Pass machine type as argument to tests Date: Thu, 16 Dec 2021 14:20:08 +0100 Message-Id: <20211216132015.815493-2-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211216132015.815493-1-philmd@redhat.com> References: <20211216132015.815493-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639660833715100001 Use g_test_add_data_func() instead of g_test_add_func() so we can pass the machine type to the tests (we will soon have different machine types). Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/unit/test-smp-parse.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c index b02450e25a3..37c6b4981db 100644 --- a/tests/unit/test-smp-parse.c +++ b/tests/unit/test-smp-parse.c @@ -487,9 +487,10 @@ static void machine_base_class_init(ObjectClass *oc, v= oid *data) mc->name =3D g_strdup(SMP_MACHINE_NAME); } =20 -static void test_generic(void) +static void test_generic(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -525,9 +526,10 @@ static void test_generic(void) object_unref(obj); } =20 -static void test_with_dies(void) +static void test_with_dies(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -599,8 +601,12 @@ int main(int argc, char *argv[]) =20 g_test_init(&argc, &argv, NULL); =20 - g_test_add_func("/test-smp-parse/generic", test_generic); - g_test_add_func("/test-smp-parse/with_dies", test_with_dies); + g_test_add_data_func("/test-smp-parse/generic", + TYPE_MACHINE, + test_generic); + g_test_add_data_func("/test-smp-parse/with_dies", + TYPE_MACHINE, + test_with_dies); =20 g_test_run(); =20 --=20 2.33.1