From nobody Tue Feb 10 01:19:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639601840; cv=none; d=zohomail.com; s=zohoarc; b=Bde8yLTizLH8mYQIh/eay012UKeJXZDmapiiHbwV4tTqEJlBgUczMH4A3qETuTjoLnogmaOCFVPd/3756JNtEp/44LNl9WIVogJHP9xRU1HAx7hmb1pzW1ovpV075aQOk0SpQzHmqjzLtowJqc6I1AgSQNil3lYAQuWvdLsdSOE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639601840; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=oSQRyRj2GbkDloms+3kG1uqQcojtiwJxAy2G0BkB6EI=; b=LlSUbt+TS8/56vilD/e67jciakp/Vf78nWTFY8fTFtpLUrg64ELBJ7hNAbabtB5H4Eq/Mp+PkWvplsKAtAzdPhtAo/PYBej8b9+8FdrMuC/dqTt2QpZzYv+3j9Lz4mZ5I03/CkFBLNDJl8obrVnEFXC4KFz8vxhBuxwxFNn5NiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1639601840945416.2332823186572; Wed, 15 Dec 2021 12:57:20 -0800 (PST) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-319-O3azeY84O2-5Ps7q5dch0A-1; Wed, 15 Dec 2021 15:57:18 -0500 Received: by mail-wr1-f69.google.com with SMTP id k8-20020a5d5248000000b001763e7c9ce5so6210250wrc.22 for ; Wed, 15 Dec 2021 12:57:18 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id g124sm5980438wme.28.2021.12.15.12.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 12:57:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639601839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oSQRyRj2GbkDloms+3kG1uqQcojtiwJxAy2G0BkB6EI=; b=GkhBeCBG75UYYR1GbKpyWBzn5GacPGpz8TfcJEJtTjiJIPdQnxvEhGy3ihW+O/zNVgMCSA tDxvF2aOVxluDix+DoHyx5lxGEWbSB5ZKMgvlpWbwlDph9g9Yk9ssnzkmkcT336CM6dZmd p4oDaHfBR4+HI8nIiuTPBGqr0iCkWpY= X-MC-Unique: O3azeY84O2-5Ps7q5dch0A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oSQRyRj2GbkDloms+3kG1uqQcojtiwJxAy2G0BkB6EI=; b=HXbIGBvRnh58sbrSBhS3tfNCd40XLhVVKiVfTeKm2ibSme6Yjk/moeWqalJAl9aBHn UsWH1EMxOusB6I5r9t/AvPDnj8HH62UrjvT+gKB99YdtBPWz8qzaoKtEaCAY9CSLbRCT 5uXNXy5M7wpaFE3OiWgLco58C2YxZDQQ4MOcg9z+ylbIWATEnZF9Nk7FeIn4JoODANBO e5lJXyuvv4sL36A5m9U07METjNpUqJeJeW0A6RF2W4c2/V3NuMlMzK9EoJtrlsEDSP0h VQjz+jN6Qjt/KVEnzivrX3UF7ffvLPK4XUpFIlRbhlM6IPGjGHsGTQRZFCwT4NfM2nqP zCsQ== X-Gm-Message-State: AOAM532+Qb2/tp8Xl4UcJfQUZB7ID2XQlHQkxaW1v5T9slMMzdfEwfRf MebPkHT+wKP3IuGuAopfplpD1cIOKoZB5w2ltmOUWrWUuYTsw+5LjkzK3D9+tSn6kKTqIim8MV7 deGzc4VfXs+avog== X-Received: by 2002:a05:600c:19cc:: with SMTP id u12mr1981838wmq.24.1639601835363; Wed, 15 Dec 2021 12:57:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzb8G+oMVd86cvwguQJsJmKfSEz09jDT1yPJwprMX48giyS9Rnw06hdOAozhRSrnIbC+jMqDg== X-Received: by 2002:a05:600c:19cc:: with SMTP id u12mr1981830wmq.24.1639601835155; Wed, 15 Dec 2021 12:57:15 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Li Qiang , David Hildenbrand , Paolo Bonzini , qemu-block@nongnu.org, Gerd Hoffmann , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Darren Kenny , Peter Maydell , Peter Xu , Jason Wang , Qiuhao Li , Bandan Das , Laurent Vivier , "Edgar E . Iglesias" , Stefan Hajnoczi , Bin Meng , Alexander Bulekov Subject: [RFC PATCH 2/3] hw/sd/sdhci: Prohibit DMA accesses to devices Date: Wed, 15 Dec 2021 21:56:55 +0100 Message-Id: <20211215205656.488940-3-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211215205656.488940-1-philmd@redhat.com> References: <20211215205656.488940-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639601841720100001 From: Philippe Mathieu-Daud=C3=A9 The issue reported by OSS-Fuzz produces the following backtrace: =3D=3D447470=3D=3DERROR: AddressSanitizer: heap-buffer-overflow READ of size 1 at 0x61500002a080 thread T0 #0 0x71766d47 in sdhci_read_dataport hw/sd/sdhci.c:474:18 #1 0x7175f139 in sdhci_read hw/sd/sdhci.c:1022:19 #2 0x721b937b in memory_region_read_accessor softmmu/memory.c:440:11 #3 0x72171e51 in access_with_adjusted_size softmmu/memory.c:554:18 #4 0x7216f47c in memory_region_dispatch_read1 softmmu/memory.c:1424:16 #5 0x7216ebb9 in memory_region_dispatch_read softmmu/memory.c:1452:9 #6 0x7212db5d in flatview_read_continue softmmu/physmem.c:2879:23 #7 0x7212f958 in flatview_read softmmu/physmem.c:2921:12 #8 0x7212f418 in address_space_read_full softmmu/physmem.c:2934:18 #9 0x721305a9 in address_space_rw softmmu/physmem.c:2962:16 #10 0x7175a392 in dma_memory_rw_relaxed include/sysemu/dma.h:89:12 #11 0x7175a0ea in dma_memory_rw include/sysemu/dma.h:132:12 #12 0x71759684 in dma_memory_read include/sysemu/dma.h:152:12 #13 0x7175518c in sdhci_do_adma hw/sd/sdhci.c:823:27 #14 0x7174bf69 in sdhci_data_transfer hw/sd/sdhci.c:935:13 #15 0x7176aaa7 in sdhci_send_command hw/sd/sdhci.c:376:9 #16 0x717629ee in sdhci_write hw/sd/sdhci.c:1212:9 #17 0x72172513 in memory_region_write_accessor softmmu/memory.c:492:5 #18 0x72171e51 in access_with_adjusted_size softmmu/memory.c:554:18 #19 0x72170766 in memory_region_dispatch_write softmmu/memory.c:1504:= 16 #20 0x721419ee in flatview_write_continue softmmu/physmem.c:2812:23 #21 0x721301eb in flatview_write softmmu/physmem.c:2854:12 #22 0x7212fca8 in address_space_write softmmu/physmem.c:2950:18 #23 0x721d9a53 in qtest_process_command softmmu/qtest.c:727:9 A DMA descriptor is previously filled in RAM. An I/O access to the device (frames #22 to #16) start the DMA engine (frame #13). The engine fetch the descriptor and execute the request, which itself accesses the SDHCI I/O registers (frame #1 and #0), triggering a re-entrancy issue. Fix by prohibit transactions from the DMA to devices. The DMA engine is thus restricted to memories. Reported-by: OSS-Fuzz (Issue 36391) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/451 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/sd/sdhci.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index fe2f21f0c37..0e5e988927e 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -741,6 +741,7 @@ static void sdhci_do_adma(SDHCIState *s) { unsigned int begin, length; const uint16_t block_size =3D s->blksize & BLOCK_SIZE_MASK; + const MemTxAttrs attrs =3D { .memory =3D true }; ADMADescr dscr =3D {}; MemTxResult res; int i; @@ -794,7 +795,7 @@ static void sdhci_do_adma(SDHCIState *s) res =3D dma_memory_write(s->dma_as, dscr.addr, &s->fifo_buffer[begin], s->data_count - begin, - MEMTXATTRS_UNSPECIFIED); + attrs); if (res !=3D MEMTX_OK) { break; } @@ -823,7 +824,7 @@ static void sdhci_do_adma(SDHCIState *s) res =3D dma_memory_read(s->dma_as, dscr.addr, &s->fifo_buffer[begin], s->data_count - begin, - MEMTXATTRS_UNSPECIFIED); + attrs); if (res !=3D MEMTX_OK) { break; } --=20 2.33.1