From nobody Mon Feb 9 19:06:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639592678; cv=none; d=zohomail.com; s=zohoarc; b=Vc+1qRnfDWUVCWsQdVUwlfvoeib7N65i1TXpedNn8vnx+/gwTjbS6p8x7lt9GGj2mGcaO5s/uWWCzwj3W1qVCsxqzSWSSUwGiQ9GbAWEXIB6PM4VoF2EQOwhsybT79HizMZ14/fy0l5D7o329J8FUEMSQSXfRu1pp+q61KpuMjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639592678; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7G1VF+PYn/+nnSsAzukj8f/eEEWiK0TuuEhDYLjNh0c=; b=U5DM09NrWbJLqi41q8WleuCEVITSu9g3lrTngocIbAxQXkFctmbsRYH2qgPm1agJyo42Ud040k2PJB8rReqMzaplbQmdd49fKsBK/lZEo1hL0CCx07WCUYHyr63/GN7SxD/XWWjj0LMQd+5fN6273LRJo6bAFBHsel5B6sLrnu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1639592678322868.3327828069786; Wed, 15 Dec 2021 10:24:38 -0800 (PST) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-301-B9ErUUogP32bhIeVS5_1WQ-1; Wed, 15 Dec 2021 13:24:36 -0500 Received: by mail-wm1-f70.google.com with SMTP id ay34-20020a05600c1e2200b00337fd217772so9378491wmb.4 for ; Wed, 15 Dec 2021 10:24:35 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id l7sm3197050wry.86.2021.12.15.10.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 10:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639592677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7G1VF+PYn/+nnSsAzukj8f/eEEWiK0TuuEhDYLjNh0c=; b=Km7DPu+wwqho6VKpaWTKoLY8CyMP8HPZQLqmJU12BQpxXvJd9DZ1nxTpsFueJLE0OxmY77 VFMlEkV56ISdf5NSBiBzwb8t3QkHb2SrjRooxB0Ksc57BdPYDAqRpWDFaZXS1TpcDGbSgQ KJzjBgDauz764yZnEzvSrqThcWZBRJg= X-MC-Unique: B9ErUUogP32bhIeVS5_1WQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7G1VF+PYn/+nnSsAzukj8f/eEEWiK0TuuEhDYLjNh0c=; b=Lpv4Mot5KQAxo1un6zxiWyC5b0tHFHkVud1Gji+R8/Yqz/p2jw2wU25n/DJ2ozzLyh 2uca+1WPMkjEZqQaz4iVCTsWAxEkDOX6VhjffOZZbCJwjHAKDlhEcqmrXV6TaNonrZBp 5m+Gx3ptqXCPwVGtSwOGvE2Y+/R/MQjRU+sggtFJFCguZF27VWqSYI59LkNo2xbPBAfr af4WiUeNGNthhWAksPWxn5hn6fxzYv71mLn8Fe1tbV6RJIqv8IzQITDd8l62YYlJIBKJ 5xEUTgl7dj0zariKgToPu5eAEWlQcaLe2myM8Bu2nHn00c5LY3gqCIa9jtg3HyZTbBch 72LQ== X-Gm-Message-State: AOAM530U4idTTYAPAqOpBWhLjxTQNNHaYT/hXamOVh7EpqkDVU4mqyYx y/MKXT/+xUMo9ABWS6FrA5ExtDKqDOEJS+v9p5qFW765PP8sNtXRt3dFxOAq8LQpLiESKwHwxnK iPilQpvHAj/xbkw== X-Received: by 2002:a5d:6e04:: with SMTP id h4mr5527085wrz.127.1639592674962; Wed, 15 Dec 2021 10:24:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/6tQOC94ZVXRnSKKwJy/xHb6zXg14tepShevZlsuwcw/DDwFxXZmzwxaye+nN9pjDKGEubw== X-Received: by 2002:a5d:6e04:: with SMTP id h4mr5527064wrz.127.1639592674829; Wed, 15 Dec 2021 10:24:34 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alexander Bulekov , Jason Wang , Qiuhao Li , Stefan Hajnoczi , David Hildenbrand , "Edgar E . Iglesias" , Li Qiang , Gerd Hoffmann , qemu-arm@nongnu.org Subject: [RFC PATCH v3 1/3] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR Date: Wed, 15 Dec 2021 19:24:19 +0100 Message-Id: <20211215182421.418374-2-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211215182421.418374-1-philmd@redhat.com> References: <20211215182421.418374-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639592680236100001 Quoting Peter Maydell: "These MEMTX_* aren't from the memory transaction API functions; they're just being used by gicd_readl() and friends as a way to indicate a success/failure so that the actual MemoryRegionOps read/write fns like gicv3_dist_read() can log a guest error." We are going to introduce more MemTxResult bits, so it is safer to check for !MEMTX_OK rather than MEMTX_ERROR. Reviewed-by: Peter Xu Reviewed-by: David Hildenbrand Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/arm_gicv3_redist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c index c8ff3eca085..99b11ca5eee 100644 --- a/hw/intc/arm_gicv3_redist.c +++ b/hw/intc/arm_gicv3_redist.c @@ -462,7 +462,7 @@ MemTxResult gicv3_redist_read(void *opaque, hwaddr offs= et, uint64_t *data, break; } =20 - if (r =3D=3D MEMTX_ERROR) { + if (r !=3D MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest read at offset " TARGET_FMT_plx " size %u\n", __func__, offset, size); @@ -521,7 +521,7 @@ MemTxResult gicv3_redist_write(void *opaque, hwaddr off= set, uint64_t data, break; } =20 - if (r =3D=3D MEMTX_ERROR) { + if (r !=3D MEMTX_OK) { qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid guest write at offset " TARGET_FMT_plx " size %u\n", __func__, offset, size); --=20 2.33.1