From nobody Mon Feb 9 08:57:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639586955; cv=none; d=zohomail.com; s=zohoarc; b=gdKE9V/x9E0JsbMHiC10YD4OTLWCYG03bVAE232CJMkw0JRMfoMCWAncMbNwnKkDw06oWl4RB4GdDYuKeFnwucfH/qr+nuenolsN2wLOy8VLpj+44CcPU34vcMbvSWyllRGpObygsXf7S0PwgmFG0TUrFGnHRgvKxOpM5z6qyak= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639586955; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=ak9Q/20jvoAqmA15kafxqw29GuYhitva5UGtsgzEI1m3xBpG9Yu/yx1vM6PE96mZiD9O3Xrt9dNZZ+0XNCdiy28E6t+vgP7DNaMlsopK0GannWKj3NWZZz5c74MYfj3xRW77Y9v9tn4mHuSK1cFLYNYBd3h9GU5GLcrrVGJt/as= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1639586955701940.5121697053288; Wed, 15 Dec 2021 08:49:15 -0800 (PST) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-7VZ0I3WXMG2623KMip1sHw-1; Wed, 15 Dec 2021 11:49:12 -0500 Received: by mail-wr1-f71.google.com with SMTP id h12-20020adfa4cc000000b001a22dceda69so777678wrb.16 for ; Wed, 15 Dec 2021 08:49:11 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id w17sm2604355wmc.14.2021.12.15.08.49.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639586953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=D6KApL2/N+DpfHszngJAjObY8/+QiSRXh7xt8FJsJU32/i2RoHSDmZ/YYqZZqjlPPYDT8w rY3Kj7zIRi1v9cTLz7Of4MRpq6Mc5VqaslEu+fVS6atXATLJyhDgwj6TaguyR3qhBe6N5Y 1DaFQ21cI8ywmy29aKc2u4x1otrFY60= X-MC-Unique: 7VZ0I3WXMG2623KMip1sHw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t0HaJa5hL0xbci94VgrhNJFI3KFO8etTJC6TchOuXSE=; b=jh+Lwrxq21L1DIgs1vrdTN8ut5GnzTsFkT1mYq1+UulGmOFRKIjvyp7vnPK5dYin7m xgllZz6DjgvpZSroz8pEep0Qg2NvHNvQk+HDf5oehXSqjwx6ipbrm30zud/U91uXm/oV /B5NkrvfAiPC8aylZQaWC0fMXTyWBNwp0XhVoncJa/KEZuplV3dNg7RnlnwbY8knWAPY f4UswJ2fmrgt18phtFlmRePq8PvUFtpMcug0xce5F/+VjExYFkvmMcHvaVN1DCKusfjf 01yca/BDGlbjYbnSbR05c0jXW/9JLzNoSd8OIHms/zeqgER4EKym08Ig+3lSMi0v56cO InnQ== X-Gm-Message-State: AOAM532iHaql70zyxFVwmhfzIIOyAu7o450xGX2XZK7R+kJ89lVahBwi gKK5DiJ5cFyDdX8MA4K58Zga4X6VLdK+HyRVY/73zt88FzEiacWwgac5Cn5NGFXcKKMQQI1S6Qv qlfe8GFTA5vykNg== X-Received: by 2002:adf:ce08:: with SMTP id p8mr5261314wrn.154.1639586950580; Wed, 15 Dec 2021 08:49:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4BJQagz8bKCSuYyL0rib/QaODn0P2WzfvKuta6q12qVha+fVsACKfLrpg4NpukFFKeJht0w== X-Received: by 2002:adf:ce08:: with SMTP id p8mr5261299wrn.154.1639586950448; Wed, 15 Dec 2021 08:49:10 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Yanan Wang Subject: [PATCH v5 1/8] tests/unit/test-smp-parse: Pass machine type as argument to tests Date: Wed, 15 Dec 2021 17:48:49 +0100 Message-Id: <20211215164856.381990-2-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211215164856.381990-1-philmd@redhat.com> References: <20211215164856.381990-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639586995597100001 Use g_test_add_data_func() instead of g_test_add_func() so we can pass the machine type to the tests (we will soon have different machine types). Reviewed-by: Richard Henderson Reviewed-by: Yanan Wang Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/unit/test-smp-parse.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c index b02450e25a3..37c6b4981db 100644 --- a/tests/unit/test-smp-parse.c +++ b/tests/unit/test-smp-parse.c @@ -487,9 +487,10 @@ static void machine_base_class_init(ObjectClass *oc, v= oid *data) mc->name =3D g_strdup(SMP_MACHINE_NAME); } =20 -static void test_generic(void) +static void test_generic(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -525,9 +526,10 @@ static void test_generic(void) object_unref(obj); } =20 -static void test_with_dies(void) +static void test_with_dies(const void *opaque) { - Object *obj =3D object_new(TYPE_MACHINE); + const char *machine_type =3D opaque; + Object *obj =3D object_new(machine_type); MachineState *ms =3D MACHINE(obj); MachineClass *mc =3D MACHINE_GET_CLASS(obj); SMPTestData *data =3D &(SMPTestData){{ }}; @@ -599,8 +601,12 @@ int main(int argc, char *argv[]) =20 g_test_init(&argc, &argv, NULL); =20 - g_test_add_func("/test-smp-parse/generic", test_generic); - g_test_add_func("/test-smp-parse/with_dies", test_with_dies); + g_test_add_data_func("/test-smp-parse/generic", + TYPE_MACHINE, + test_generic); + g_test_add_data_func("/test-smp-parse/with_dies", + TYPE_MACHINE, + test_with_dies); =20 g_test_run(); =20 --=20 2.33.1