From nobody Mon Feb 9 01:48:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1639579644; cv=none; d=zohomail.com; s=zohoarc; b=KOzOOC0cqX/JHzn8px+obNrrLqUNql9+z9Iyv7N2vq9hSoPG5i1WafZZ1sTib+I0KmIDwX07z7dIAiEjH1fsxLveEHfs248AbiZrQiwHPQELGCmSmWCiWayac1ojBjjEqoTclvoSFgrnGOut6dT+7gkGH1VJsmIBlr5TANN3aN0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639579644; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=h46pkJxra3dpp9yKy0ujvp4BfAI+EdRIzO5mZ3dBy9w=; b=Wn2LaQmHv6fkDNghwPLKHM103efv4giqF03m7O4HFhyywDbdiqpALRZ8uvwm67HZEb19NhR3vehJeOkmsCCo35wdPhyCY1yGpe9/u/FqR2D5RTR0H0JuUd0stVTQhaj2vR4WydM1oMzD6r9p9gZZfpivTvAosbRBFBoG1IzEG2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1639579644744537.6315378532635; Wed, 15 Dec 2021 06:47:24 -0800 (PST) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-578-6wZAANIEPA6UcBUwX4NY-w-1; Wed, 15 Dec 2021 09:47:22 -0500 Received: by mail-wr1-f70.google.com with SMTP id b1-20020a5d6341000000b001901ddd352eso5998476wrw.7 for ; Wed, 15 Dec 2021 06:47:22 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id v8sm2145581wrc.114.2021.12.15.06.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 06:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639579643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h46pkJxra3dpp9yKy0ujvp4BfAI+EdRIzO5mZ3dBy9w=; b=LrI8lUwLDZEwWog3EQyN2AAyYnjdJPltVVE4Fa/4VJogvt7erPWiTTj1kZLGYrHEV58QB+ CVDHQBS/ayJdUzxsLLI3RFV9d1a1Yi4F4Yl9VBDOTg4CeCRKVVY0KmXyvvV1Qqlui3e6T0 Z1ylI6N0pyhD6SPBXSTNH+aeY+S+nEQ= X-MC-Unique: 6wZAANIEPA6UcBUwX4NY-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h46pkJxra3dpp9yKy0ujvp4BfAI+EdRIzO5mZ3dBy9w=; b=hgqVKlSzaddPPIrcLfdf/TG1yJs1IEMn/CSKckmg2BQEdAX1hrbOJwwBzG8SLib9dG hk8DEKXhR9f15fLFkkW5A7RhR7lQWw/0IT2evzfcWkoseelxpsAvEfLyEBKQBSHN8xxV xjZr/4NZt3o2y39TmoPysCCPWgmtqzNvhLa8RzpzRsRUrLk0RJsW98ne3KpQbqJ78FXJ 0YhXjjwzDChh5JwZphSSUOgrJ1rpCt/cRvZBy6ITx0YaFGOv2AUF8+xTD3BkRD7HkPms YcIu4N9h2yd2lnRnjM22NKSwY7eHQKasSBDfPYhVj3yPqlXoTz1bkLRSg6umVUQ2zYaJ W13Q== X-Gm-Message-State: AOAM530VKqWiy5EpJcLYAnZ8hs9Xun2Gvif+RpREg9+jCyR5nKJH6ztR uXTpxBatzq5pGZZ+YRZ/aj0QqKC57gCuWld6X5kw2EiopXGxxVLSZAzSDEvHlPPMFrRbihHzDmC lboz3nDJQAy8oAg== X-Received: by 2002:a05:600c:34d6:: with SMTP id d22mr108462wmq.160.1639579640558; Wed, 15 Dec 2021 06:47:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJzyLm09/eHbWzL0hYKYGXZjRHUvBMU3DKHB96PU6DucQIFXAhVmSSquQq30W8089K2xn7QcAg== X-Received: by 2002:a05:600c:34d6:: with SMTP id d22mr108444wmq.160.1639579640326; Wed, 15 Dec 2021 06:47:20 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Dike , Duhao <504224090@qq.com> Subject: [PATCH] hw/net/vmxnet3: Log guest-triggerable errors using LOG_GUEST_ERROR Date: Wed, 15 Dec 2021 15:47:18 +0100 Message-Id: <20211215144718.311979-1-philmd@redhat.com> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1639579645334100001 The "Interrupt Cause" register (VMXNET3_REG_ICR) is read-only. Write accesses are ignored. Log them with as LOG_GUEST_ERROR instead of aborting: [R +0.239743] writeq 0xe0002031 0x46291a5a55460800 ERROR:hw/net/vmxnet3.c:1819:vmxnet3_io_bar1_write: code should not be rea= ched Thread 1 "qemu-system-i38" received signal SIGABRT, Aborted. (gdb) bt #3 0x74c397d3 in __GI_abort () at abort.c:79 #4 0x76d3cd4c in g_assertion_message (domain=3D, file=3D<= optimized out>, line=3D, func=3D, message=3D<= optimized out>) at ../glib/gtestutils.c:3223 #5 0x76d9d45f in g_assertion_message_expr (domain=3D0x0, file=3D0x59fc2e53 "hw/net/vmxnet3.c", line=3D1819, fun= c=3D0x59fc11e0 <__func__.vmxnet3_io_bar1_write> "vmxnet3_io_bar1_write", ex= pr=3D) at ../glib/gtestutils.c:3249 #6 0x57e80a3a in vmxnet3_io_bar1_write (opaque=3D0x62814100, addr=3D56, = val=3D70, size=3D4) at hw/net/vmxnet3.c:1819 #7 0x58c2d894 in memory_region_write_accessor (mr=3D0x62816b90, addr=3D5= 6, value=3D0x7fff9450, size=3D4, shift=3D0, mask=3D4294967295, attrs=3D...)= at softmmu/memory.c:492 #8 0x58c2d1d2 in access_with_adjusted_size (addr=3D56, value=3D0x7fff945= 0, size=3D1, access_size_min=3D4, access_size_max=3D4, access_fn=3D 0x58c2d290 , mr=3D0x62816b90, attrs=3D.= ..) at softmmu/memory.c:554 #9 0x58c2bae7 in memory_region_dispatch_write (mr=3D0x62816b90, addr=3D5= 6, data=3D70, op=3DMO_8, attrs=3D...) at softmmu/memory.c:1504 #10 0x58bfd034 in flatview_write_continue (fv=3D0x606000181700, addr=3D0x= e0002038, attrs=3D..., ptr=3D0x7fffb9e0, len=3D1, addr1=3D56, l=3D1, mr=3D0= x62816b90) at softmmu/physmem.c:2782 #11 0x58beba00 in flatview_write (fv=3D0x606000181700, addr=3D0xe0002031,= attrs=3D..., buf=3D0x7fffb9e0, len=3D8) at softmmu/physmem.c:2822 #12 0x58beb589 in address_space_write (as=3D0x608000015f20, addr=3D0xe000= 2031, attrs=3D..., buf=3D0x7fffb9e0, len=3D8) at softmmu/physmem.c:2914 Reported-by: Dike Reported-by: Duhao <504224090@qq.com> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=3D2032932 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/vmxnet3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index f65af4e9ef2..0b7acf7f895 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1816,7 +1816,9 @@ vmxnet3_io_bar1_write(void *opaque, case VMXNET3_REG_ICR: VMW_CBPRN("Write BAR1 [VMXNET3_REG_ICR] =3D %" PRIx64 ", size %d", val, size); - g_assert_not_reached(); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: write to read-only register VMXNET3_REG_ICR\n", + TYPE_VMXNET3); break; =20 /* Event Cause Register */ --=20 2.33.1