From nobody Mon Feb 9 17:10:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1639572196; cv=none; d=zohomail.com; s=zohoarc; b=epjz5WB3KeUAM/x1l/cN4r+I1U6wCMwc/+UdlLEN1AD95DT4qS5yH2AncIk04eCbo1AY/N6Uc5LTwXsCoh+nsiekZyu/4kgWtpF1Yil6Mjpi0dW1sQkPrggFaKVAxeiesysiUN9xUmcI2x0suGJOTPOeP7ExkSoG1cPmODoJ86U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639572196; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=jes0jaV8C77XuOtNCTS3+rbsCAYxOxrMGO2HrSlqP54=; b=Hoj7xhBcglW/hWYoPvxEa081zhHy98rLXGFzQI+mWipTgxig6Ag91E7jPrmzgIcUPAQEy8m2S7EwBJgLT6I7aeYFSJpvcf9HPBj0FNTBq4vpuTNk1iADQbHhj0r4UvYME1GMKbrn/RsHm7tw7SOhdjxzUJERwEfRWubqLQm5huY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1639572196028755.9501358703673; Wed, 15 Dec 2021 04:43:16 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id a18so37991824wrn.6 for ; Wed, 15 Dec 2021 04:43:15 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (174.red-83-50-185.dynamicip.rima-tde.net. [83.50.185.174]) by smtp.gmail.com with ESMTPSA id j85sm4443864wmj.3.2021.12.15.04.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 04:43:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jes0jaV8C77XuOtNCTS3+rbsCAYxOxrMGO2HrSlqP54=; b=F158Kijv53dICKGtMp9TVkpQPVqXDRmOjoG/ciETNaR6lN9DpHdA8BuAtnnhWQbkL+ aC14od+XUdHffUbDxmh8YOvHt17+xTApjk4Pm3BaHgfcjDqD7Q4xvpgoT9FD999qLUEh gQKog25BhwpZbpthZ+LFB0oWdeP2liBm8vmoV+4vjV23z+9jU97xzajK42JLLA974auW QRlKRdJ05n4gCdzLyzZAQZQCPJ2mjWc5w0/oUo5G07ADysnepiqDJ/tG5y68wKxGsItM 1fe/cl8x7rid4xP+/kBSEPou2XOTGv5kXZ32GJeveD7UnjVsFMYmu/TO7TOp41JXZ8Bx /oww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=jes0jaV8C77XuOtNCTS3+rbsCAYxOxrMGO2HrSlqP54=; b=Snx/omvmkcCAZd8aUXrAVgRQXg/LesqSh1Mu/gX1Qsp4pPvBe9OFx78OTH68VlGtWZ HZNO2KrlDvpay5Z48EAR13EOFlmG1WaYy8mMbVN/yR1FomwE2yM44uEomT08ty+wkVtK iEflZ2WoF2gbfUQQzuSwKuHRyQQOJal0uVNYwYt7okqEDIYTP8SmBefesYIJgrb2t0m0 kfD4VL09BVwoQjaH9I434kE4RfhNd6k3Q0WXswiXOgWJ5FaopSmlCfbmzZtcFvDMy9aB Mu0DtEFsDK9FxnjeyX8BGsBcQxDWltc0/s8Oq/SUBn0Jl6xzTMmTlbZqIv9r2BXrPOjS 0d5w== X-Gm-Message-State: AOAM532Auuu4M04ptlnOkaYIa0n3fDxWdjmJ/r9J4rc0OtOGOsgaEZxU rsN8A/y9UhbPrch4jrlPrao= X-Google-Smtp-Source: ABdhPJyhxTBgLqY/3WXlIc9EReBxaEZoQQgtf5z9BbO8J/w5pp83NX1W/RFnHCiamqXsfWEFRa36SA== X-Received: by 2002:adf:ce03:: with SMTP id p3mr4149517wrn.294.1639572194322; Wed, 15 Dec 2021 04:43:14 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Alistair Francis , Yoshinori Sato , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH] target/rx: Correctly set Error Summary bit in set_fpsw() helper Date: Wed, 15 Dec 2021 13:43:12 +0100 Message-Id: <20211215124312.254042-1-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1639572197639100001 FIELD_DP32() does not update its first argument, so the Floating-Point Error Summary Flag (FS, summary of FV/FO/FZ/FU bits) is never updated to the Floating-Point Status Word (FPSW). Fix by assigning FIELD_DP32() returned value to env->fpsw. Fixes: 075d047e2bd ("target/rx: TCG helpers") Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- target/rx/op_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c index 11f952d3409..431d4ecf707 100644 --- a/target/rx/op_helper.c +++ b/target/rx/op_helper.c @@ -130,8 +130,7 @@ void helper_set_fpsw(CPURXState *env, uint32_t val) fpsw |=3D 0x7fffff03; val &=3D ~0x80000000; fpsw &=3D val; - FIELD_DP32(fpsw, FPSW, FS, FIELD_EX32(fpsw, FPSW, FLAGS) !=3D 0); - env->fpsw =3D fpsw; + env->fpsw =3D FIELD_DP32(fpsw, FPSW, FS, FIELD_EX32(fpsw, FPSW, FLAGS)= !=3D 0); set_float_rounding_mode(roundmode[FIELD_EX32(env->fpsw, FPSW, RM)], &env->fp_status); } --=20 2.33.1