From nobody Mon Feb 9 02:43:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1638788879; cv=none; d=zohomail.com; s=zohoarc; b=P5fwVDyy+ngDKdCHmEkZPsMZnzk+uySKkq7WC8SYTyottMunAA5Fmk8X8DFqeTNNRM25SHxUG/K/XnfcptuOnBTUWuPRxQ2osr2EQq5RBhRTkiFbFHCgDu6P9AM+LF551EE8NBAT9wZtv4+PG7NNnMU1aiuWJUtEIu9/c7KmtrE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1638788879; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/DJj/gxHt6m4FCr9Z7lcL4/ZOvmbUdkOohUSBXdWb/M=; b=UcUzy3g1rVsRDBxMzyKxp8bYW3vwNH2eI6vhM04Om/qXKo1vIY/pM6rAw48f1bZenY29x1mHMqxKK47uEl9RqOjDE4Kv8duI8UGlvW2HyB9Em1NBZfZjSQWmjHLknJiNdEOflb6KelSeVUt4n5sBDRmIdGnMTUzHTvSlJCuYl68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 1638788879752922.584765772974; Mon, 6 Dec 2021 03:07:59 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id r9-20020a7bc089000000b00332f4abf43fso7930159wmh.0 for ; Mon, 06 Dec 2021 03:07:59 -0800 (PST) Return-Path: Return-Path: Received: from x1w.. (82.red-83-50-95.dynamicip.rima-tde.net. [83.50.95.82]) by smtp.gmail.com with ESMTPSA id d6sm11222010wrn.53.2021.12.06.03.07.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 03:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/DJj/gxHt6m4FCr9Z7lcL4/ZOvmbUdkOohUSBXdWb/M=; b=gihBjoMmWb0BRGjgXPVlYMzOUanXZ9OU6pIBOEAWIgxwTh9nKo5cR45jwRAP9X3lnL KJ38ANT3x6J6KaWgCq8WrfmXKcEXPlqp+Za+D58rrGWwmgGGp17ORvTN0vBJYZQw4nfP l3lhwKwOZAMDPYo7/GR+90yU7wY2InZU+ZQeDKhDaRtnLwPbjN31uOJEyHjCXujDEkfl kLIpqrvzgpmywiZKeujrfSNjR4nzRFXKph2lKnoGb5Ztbx2IvkYC3PVtu+AG8PpOQQdK Ee5OrNolICzgr/U10pq4BRFX+8wZA2MgEOCZ31GOlwbIqrNHspV/XFPlOHX8WW3pYcuz MAyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=/DJj/gxHt6m4FCr9Z7lcL4/ZOvmbUdkOohUSBXdWb/M=; b=i7F/6Twg11/7VN4ffG7KNUvR6g53y8DNlRmo5VC8hRADwz7+VLwt2ZYcf5698qkCu8 M1CNJsi7Rnagmgv1TannOfC8kdnEgdtSboCKHi5fMv9s6UpvNNa2smaxP2+AvBRmGqFx ak2ME7uNvnjDvf7k7WHgSZFqEnCcVktr2zWwbApQVDSqeQo3SPbz4bymtU6GyyQyxsLl K9pleErIcj9iAliXLR/icyYxSJqmS/qipiqaVLLnVHF4yC1wLQpsgXd8zEkPO/goC/ay 8i7YKtVm4cwNWxJylAlXy8Fj1Nobk1885yaGFYkqQID6TtwS7WF12RTyXiBEaJFV4bmY 6qLA== X-Gm-Message-State: AOAM532axUBsp4eAFtZoco+fwYIZhD/K4IPX16mJHW3reOnQ4W7tHBFr 2pvp2YEFMwReADFdEk8vScY= X-Google-Smtp-Source: ABdhPJxCBO4b54gH0DVzft2o3jY6g7d1iOtzEKmAxbQpaDWjiXzn9Cgbpi1oMkBRrJxlFB0Uaw9eMA== X-Received: by 2002:a1c:448b:: with SMTP id r133mr38461274wma.85.1638788877970; Mon, 06 Dec 2021 03:07:57 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Jiaxun Yang , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 2/3] hw/mips/boston: Fix load_elf() error detection Date: Mon, 6 Dec 2021 12:07:45 +0100 Message-Id: <20211206110746.360608-3-f4bug@amsat.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211206110746.360608-1-f4bug@amsat.org> References: <20211206110746.360608-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1638788881970100001 From: Jiaxun Yang load_elf() gives negative return in case of error, not zero. Fixes: 10e3f30ff73 ("hw/mips/boston: Allow loading elf kernel and dtb") Signed-off-by: Jiaxun Yang Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211130211729.7116-3-jiaxun.yang@flygoat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/boston.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/mips/boston.c b/hw/mips/boston.c index 0e3cca55118..59ca08b93a9 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -777,14 +777,15 @@ static void boston_mach_init(MachineState *machine) exit(1); } } else if (machine->kernel_filename) { - uint64_t kernel_entry, kernel_high, kernel_size; + uint64_t kernel_entry, kernel_high; + ssize_t kernel_size; =20 kernel_size =3D load_elf(machine->kernel_filename, NULL, cpu_mips_kseg0_to_phys, NULL, &kernel_entry, NULL, &kernel_high, NULL, 0, EM_MIPS, 1, 0); =20 - if (kernel_size) { + if (kernel_size > 0) { int dt_size; g_autofree const void *dtb_file_data, *dtb_load_data; hwaddr dtb_paddr =3D QEMU_ALIGN_UP(kernel_high, 64 * KiB); --=20 2.33.1