From nobody Mon Feb 9 18:45:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1638155730136224.82575233849286; Sun, 28 Nov 2021 19:15:30 -0800 (PST) Received: from localhost ([::1]:53982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrX8b-0000AY-06 for importer@patchew.org; Sun, 28 Nov 2021 22:15:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrWyu-0002Og-Jc for qemu-devel@nongnu.org; Sun, 28 Nov 2021 22:05:28 -0500 Received: from [2607:f8b0:4864:20::52d] (port=42533 helo=mail-pg1-x52d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrWyr-0000IX-Gd for qemu-devel@nongnu.org; Sun, 28 Nov 2021 22:05:27 -0500 Received: by mail-pg1-x52d.google.com with SMTP id s37so4823477pga.9 for ; Sun, 28 Nov 2021 19:05:25 -0800 (PST) Received: from frankchang-ThinkPad-T490.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id oj11sm17904040pjb.46.2021.11.28.19.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Nov 2021 19:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cn/fxJxDqtzMg2Nd2Dj4Np4DlvU0muGWQbxObyTGqag=; b=l1xJy0zdhGW3/DVwGppfK6u+qqqS+eX5z6FlqkDnSw0kDAswuU/W6NRsa8ii+DU7Jb FTcKKt/8BR9nhWcsRtBII0ViUYmW/c30hbIYzk9UE961i0+RFpce3GxnK11WpioYLJmJ QGtjc0huViAEDk6pqAOKVt/ZU7azjvN2ttT5czaCzOiAaA3gohvstcEsYLYHhS1mxLX2 KToFc8RV7cFTFUKjCx/qXzZwcv/AcGJq4zxNSF/1G7b65bAlZqlBc39cUxhQl4vEKShr CU39KFsqAKRq10b6qumbaFQ8eQSnrLMdi+iBbaC30AYoXCENtZ94NAuDLfNSbaR9mqO5 ksxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cn/fxJxDqtzMg2Nd2Dj4Np4DlvU0muGWQbxObyTGqag=; b=iT+uBdMxTl5nkKZmkr7mEC091EJzU7bWpBGGRCCipr7oeEwPsdZmDzH8txSnNsx8qX f4pYUOQE6C/vDZ9HpYGNPqAP8kKgtrf2WBF24auBrHqEbJqXYz13brOF5CCLTCWkUfQx SKWj3Y6IBSx7YLVA0paBs1a+4yJNOJQmm0zHraHdDNimAbp994P2O13LIpcau3qLTGdu 0E/t3fpi4Of9gUlRGYrmo5VrFCwzH7U66QfapaYqV/gYmbICIJvCwve/HDJ6tGCWpgO7 CKD1TxuaWw7PnxipQy6tAzOYzmcfUyO9bmri+1HIcWA9kDoJtM4SAzud0WzGduX2LhP0 aGtQ== X-Gm-Message-State: AOAM530kxk6pMUqs8Np0TvvRU4m3MA55StWXLIDlExDTslwcW41pjoxe zko7n0ejcv8Vyio/QtkS9V1Q1hf2ToMO2bwA X-Google-Smtp-Source: ABdhPJxU/KpJcdYnHhRXza6kWcF1ReeQWnRhcwtC6XFpiT/S5XNQG6kq/RoOcfCGiaJfGqxW19SutA== X-Received: by 2002:a63:91ca:: with SMTP id l193mr19565138pge.488.1638155124025; Sun, 28 Nov 2021 19:05:24 -0800 (PST) From: frank.chang@sifive.com To: qemu-devel@nongnu.org Subject: [PATCH v10 22/77] target/riscv: rvv-1.0: fix address index overflow bug of indexed load/store insns Date: Mon, 29 Nov 2021 11:02:42 +0800 Message-Id: <20211129030340.429689-23-frank.chang@sifive.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211129030340.429689-1-frank.chang@sifive.com> References: <20211129030340.429689-1-frank.chang@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::52d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=frank.chang@sifive.com; helo=mail-pg1-x52d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, Frank Chang , Bin Meng , Richard Henderson , Alistair Francis , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1638155731032100001 Content-Type: text/plain; charset="utf-8" From: Frank Chang Replace ETYPE from signed int to unsigned int to prevent index overflow issue, which would lead to wrong index address. Signed-off-by: Frank Chang Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index df45c1620c1..3da4f3b1e62 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -374,10 +374,10 @@ static target_ulong NAME(target_ulong base, = \ return (base + *((ETYPE *)vs2 + H(idx))); \ } =20 -GEN_VEXT_GET_INDEX_ADDR(idx_b, int8_t, H1) -GEN_VEXT_GET_INDEX_ADDR(idx_h, int16_t, H2) -GEN_VEXT_GET_INDEX_ADDR(idx_w, int32_t, H4) -GEN_VEXT_GET_INDEX_ADDR(idx_d, int64_t, H8) +GEN_VEXT_GET_INDEX_ADDR(idx_b, uint8_t, H1) +GEN_VEXT_GET_INDEX_ADDR(idx_h, uint16_t, H2) +GEN_VEXT_GET_INDEX_ADDR(idx_w, uint32_t, H4) +GEN_VEXT_GET_INDEX_ADDR(idx_d, uint64_t, H8) =20 static inline void vext_ldst_index(void *vd, void *v0, target_ulong base, --=20 2.25.1