From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855002304452.78929141370566; Thu, 25 Nov 2021 07:43:22 -0800 (PST) Received: from localhost ([::1]:40690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGu9-0000IU-0I for importer@patchew.org; Thu, 25 Nov 2021 10:43:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsj-0006ZN-4l for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:53 -0500 Received: from [2a00:1450:4864:20::42c] (port=35821 helo=mail-wr1-x42c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGsh-0002JC-7D for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:52 -0500 Received: by mail-wr1-x42c.google.com with SMTP id i5so12553975wrb.2 for ; Thu, 25 Nov 2021 07:41:50 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id r17sm9577700wmq.5.2021.11.25.07.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 164341FF98; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i6Sa/S7mYt2OQVGTXQQ5ol9j8zL0KNw6Xyxd4wnAmmg=; b=zxn0mXl6jo5xUZG/a6ouevDKUP09VGykBhtkoOq04stxP3+tZaBVDFuMJKOqVqI3mj ffeckEi74ql1Ps6+a6bhoWd04s/nvYul+ehAOua4XFYk1XwPl5ZLKJtc+xvDqc2lsjXl yISQeXcTrIplhpmZp0nCPgj+OLkI4nyq1QYk156Pgs09eIO3EBvoWSskZFMt3g+Xa1jB tU1y7duUu9tmX3DbIeWEWxTaMZbiG5zU4je32Gikl4bXhgtq+XtIMfDM01Hky7VxHPPk v/P+YQ+Sth26s1H181Ebsj41VnxPICyhFI+MGSKgMmIoFEe43PKk/RKt+e+JENmq6MCU y8GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i6Sa/S7mYt2OQVGTXQQ5ol9j8zL0KNw6Xyxd4wnAmmg=; b=nRO31ERchAYIASTnp9HitMbdW3yDfUnMm7mc9PwhKpIaId0Vz4u66+TMd23qSByvb5 m6sTLEXwlmI2spCz0LRNzvYIj8F5GMsURxqRIA8J2RzB9LFAMQzcbhO5osn4ookatIMr 5VMoxOMgAUdPUDYWVr9XOFYqQNgfrLNKMq1/1cr25aINeTKP7KKaSzeU7rensDnI8gdP 4he8Qu9Nam6FVO8977NQz1bSnBowqY0Ws+jhxelBHJW3j/6EkJuMaI0D7M/6yttMBWGe tXJP/Z9JRTYV/1pxeO77Q010DIFhOwhARUmr/667CB+DK6bYkGPysa6mGNOykJr8FWjh ZJRA== X-Gm-Message-State: AOAM53132uZqhfWVBelbiypjR62cs5LnXHbQzntL69bTyL8mMLVzRvxL 2w4j09m3F05z/xGslo4PJRGYAg== X-Google-Smtp-Source: ABdhPJw4aosVE1fDU+xUgZioTVPyJVyVkzvb5dWEt9JXiYsDNBkylFtJ2UreIQt4MkYihM9MNSc2GA== X-Received: by 2002:adf:8010:: with SMTP id 16mr7431949wrk.559.1637854909439; Thu, 25 Nov 2021 07:41:49 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/7] accel/tcg: introduce CF_NOIRQ Date: Thu, 25 Nov 2021 15:41:38 +0000 Message-Id: <20211125154144.2904741-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42c (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855004663100001 Here we introduce a new compiler flag to disable the checking of exit request (icount_decr.u32). This is useful when we want to ensure the next block cannot be preempted by an asynchronous event. Suggested-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- v2 - split from larger patch - reword the check in cpu_handle_interrupt and scope to CF_NOIRQ only --- include/exec/exec-all.h | 1 + include/exec/gen-icount.h | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 6bb2a0f7ec..35d8e93976 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -503,6 +503,7 @@ struct TranslationBlock { #define CF_USE_ICOUNT 0x00020000 #define CF_INVALID 0x00040000 /* TB is stale. Set with @jmp_lock hel= d */ #define CF_PARALLEL 0x00080000 /* Generate code for a parallel contex= t */ +#define CF_NOIRQ 0x00100000 /* Generate an uninterruptible TB */ #define CF_CLUSTER_MASK 0xff000000 /* Top 8 bits are cluster ID */ #define CF_CLUSTER_SHIFT 24 =20 diff --git a/include/exec/gen-icount.h b/include/exec/gen-icount.h index 610cba58fe..c57204ddad 100644 --- a/include/exec/gen-icount.h +++ b/include/exec/gen-icount.h @@ -21,7 +21,6 @@ static inline void gen_tb_start(const TranslationBlock *t= b) { TCGv_i32 count; =20 - tcg_ctx->exitreq_label =3D gen_new_label(); if (tb_cflags(tb) & CF_USE_ICOUNT) { count =3D tcg_temp_local_new_i32(); } else { @@ -42,7 +41,19 @@ static inline void gen_tb_start(const TranslationBlock *= tb) icount_start_insn =3D tcg_last_op(); } =20 - tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + /* + * Emit the check against icount_decr.u32 to see if we should exit + * unless we suppress the check with CF_NOIRQ. If we are using + * icount and have suppressed interruption the higher level code + * should have ensured we don't run more instructions than the + * budget. + */ + if (tb_cflags(tb) & CF_NOIRQ) { + tcg_ctx->exitreq_label =3D NULL; + } else { + tcg_ctx->exitreq_label =3D gen_new_label(); + tcg_gen_brcondi_i32(TCG_COND_LT, count, 0, tcg_ctx->exitreq_label); + } =20 if (tb_cflags(tb) & CF_USE_ICOUNT) { tcg_gen_st16_i32(count, cpu_env, @@ -74,8 +85,10 @@ static inline void gen_tb_end(const TranslationBlock *tb= , int num_insns) tcgv_i32_arg(tcg_constant_i32(num_insns))); } =20 - gen_set_label(tcg_ctx->exitreq_label); - tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + if (tcg_ctx->exitreq_label) { + gen_set_label(tcg_ctx->exitreq_label); + tcg_gen_exit_tb(tb, TB_EXIT_REQUESTED); + } } =20 #endif --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16378551615921003.9876514251121; Thu, 25 Nov 2021 07:46:01 -0800 (PST) Received: from localhost ([::1]:48826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGwi-0005jQ-Hv for importer@patchew.org; Thu, 25 Nov 2021 10:46:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsh-0006Vq-SV for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:51 -0500 Received: from [2a00:1450:4864:20::42d] (port=43590 helo=mail-wr1-x42d.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGse-0002Im-O6 for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:51 -0500 Received: by mail-wr1-x42d.google.com with SMTP id v11so12490748wrw.10 for ; Thu, 25 Nov 2021 07:41:48 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id d6sm3235869wrn.53.2021.11.25.07.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:45 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 2699A1FF99; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WGre360ECFC32is5bfbd0HWJa+SsjO4LmCB6eMj0auw=; b=jxmiqGMcrHKS3U+aDn3SAqkaNB0VXkUzfOIIhSXXmOt/dh2CNY6JmiHRmB45kTFepQ 9Nncig4wIHBZ0yqpiIomLWHAGGYqjEUw6+1OBSCNbWt6d8le6uNm+ygMy5jAk0jM/euO in/FbB+flrzYeCpCs6Jok24b46GwJe0HNi7V4quJdgfkh0hsIaeQqyBKq3gUoTdw0yNF 76/Kvhhy5O68fmhkEgPhotQ7XyKKFQ4l4lBkEixKxMJ5D4Qf+dugiY9sh7tGlOLgNJY2 5FvD9ygFxNNrFV15805VZ/gwTNv9Cn9am0Po5peQsd7wwlLQQVFJM/yuyEzHz4gbc3BR K/Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WGre360ECFC32is5bfbd0HWJa+SsjO4LmCB6eMj0auw=; b=78KlToGsSaRt1KvaGH8pkrR689qXbbvhT8M4JQMQRCQf3XlYT35X/3rOrAYtTiR5oy ILaLkGoBifTJ/KTFaBavh168LaVt6sO3qTYqbv19WZwC2qKR4p5sw2m1ANZfbIpTp6pY CPpVNjWhdDgcDg8jzhpHm/Wm7ZWisJWjfjU0IABgPEYW5lGfaXKzKHatqNCgZyej3Dc0 t06Pw3fFqnbLb2eryZFwPhJMckd8N6K3ZxhKHp5HPRXQcyhekJTTOnMzo6vnY/DwN67c Y8JLkwWhXziaSMMrPgOr3uFZFny0LXWV8niqC0TFpr8KNaHbX9oKeQiSHKr2ZiK4RQWH 4rTQ== X-Gm-Message-State: AOAM531KjIeYUjUn5kyLkj+nC9NjZGkJ3MPvgZ+xdQKU6PXfOUvUC3uX AReIFwiLB5ULCIjlHf1zj4Aieg== X-Google-Smtp-Source: ABdhPJwQhRMRUTD2zxVr4lQNIxe7jVuBlv5H3Qano/YiPQiJzCkiqLubWg1fgqAIKsQ5Eu+7XBW8Bg== X-Received: by 2002:a5d:456e:: with SMTP id a14mr7572748wrc.256.1637854906790; Thu, 25 Nov 2021 07:41:46 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/7] accel/tcg: suppress IRQ check for special TBs Date: Thu, 25 Nov 2021 15:41:39 +0000 Message-Id: <20211125154144.2904741-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42d (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , f4bug@amsat.org, Peter Xu , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Pavel Dovgalyuk , =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855163577100001 When we set cpu->cflags_next_tb it is because we want to carefully control the execution of the next TB. Currently there is a race that causes the second stage of watchpoint handling to get ignored if an IRQ is processed before we finish executing the instruction that triggers the watchpoint. Use the new CF_NOIRQ facility to avoid the race. We also suppress IRQs when handling precise self modifying code to avoid unnecessary bouncing. Signed-off-by: Alex Benn=C3=A9e Cc: Pavel Dovgalyuk Fixes: https://gitlab.com/qemu-project/qemu/-/issues/245 --- v2 - split the CF_NOIRQ implementation - only apply CF_NOIRQ for watchpoints/SMC handling - minor reword of commit --- accel/tcg/cpu-exec.c | 9 +++++++++ accel/tcg/translate-all.c | 2 +- softmmu/physmem.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 2d14d02f6c..409ec8c38c 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -721,6 +721,15 @@ static inline bool need_replay_interrupt(int interrupt= _request) static inline bool cpu_handle_interrupt(CPUState *cpu, TranslationBlock **last_tb) { + /* + * If we have requested custom cflags with CF_NOIRQ we should + * skip checking here. Any pending interrupts will get picked up + * by the next TB we execute under normal cflags. + */ + if (cpu->cflags_next_tb !=3D -1 && cpu->cflags_next_tb & CF_NOIRQ) { + return false; + } + /* Clear the interrupt flag now since we're processing * cpu->interrupt_request and cpu->exit_request. * Ensure zeroing happens before reading cpu->exit_request or diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index bd0bb81d08..1cd06572de 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1738,7 +1738,7 @@ tb_invalidate_phys_page_range__locked(struct page_col= lection *pages, if (current_tb_modified) { page_collection_unlock(pages); /* Force execution of one insn next time. */ - cpu->cflags_next_tb =3D 1 | curr_cflags(cpu); + cpu->cflags_next_tb =3D 1 | CF_NOIRQ | curr_cflags(cpu); mmap_unlock(); cpu_loop_exit_noexc(cpu); } diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 314f8b439c..b43f92e900 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -946,7 +946,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, va= ddr len, cpu_loop_exit(cpu); } else { /* Force execution of one insn next time. */ - cpu->cflags_next_tb =3D 1 | CF_LAST_IO | curr_cflags(cpu); + cpu->cflags_next_tb =3D 1 | CF_LAST_IO | CF_NOIRQ | curr_c= flags(cpu); mmap_unlock(); cpu_loop_exit_noexc(cpu); } --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855111496252.96379886800275; Thu, 25 Nov 2021 07:45:11 -0800 (PST) Received: from localhost ([::1]:46722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGvu-0004JJ-Ew for importer@patchew.org; Thu, 25 Nov 2021 10:45:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsj-0006Zx-En for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:53 -0500 Received: from [2a00:1450:4864:20::436] (port=43599 helo=mail-wr1-x436.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGsh-0002JF-Gq for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:53 -0500 Received: by mail-wr1-x436.google.com with SMTP id v11so12491117wrw.10 for ; Thu, 25 Nov 2021 07:41:51 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p13sm8243188wmi.0.2021.11.25.07.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:46 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3EA301FF9A; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ouEp36joxnPAP6ToPpz7+NhGlX24uSLIBMD0iYKDcl0=; b=ufgFGs3USfyxA5pMJVdlYx2+/RvpPow8mM2nO7AalKA1GdSxmL7nhBvLKI2yOek44B lQlSYGeQaDFXRx+cJ8OXO2HGYyRQMP2fTfIlvMj4mRT/JtD4oFVZU9PayTNdwaYTIo1r cSKjRkXTBTr93LvBvnZk7ItvmXMCU/qTvie+rnU5gYaFtFTrLbn+xOVrsl/YOv80h/o6 Nq1rBoZsfM0GaBd9xvUHaDixHhijstmuEK4tJBftdPPyiH6RTJqhErCwTQX/ngWLl5QV H1FCKGhXTcf+oK9ggnYWDeAnUsCeilPoqprvY+UId8xxwSPBA7GL2UPGnhQrGwS+1Nqv LlpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ouEp36joxnPAP6ToPpz7+NhGlX24uSLIBMD0iYKDcl0=; b=sF1zO8zefsBMFvA5fAZbOasj8wAq4sEev+wNeyEK6JcbsX3SoadFJX+cy8oR4XD+TA YqlUi9cq8bWC82ov2OdD2azERuaTdP/B/eNcneM3QA+qN2SMzr+7RxAWcdoUVTHOEseu LIe9Z5K1vOp9AER/9hJEKzsJE0Y1v5iNuL8qE63GeYPD27vfIJamZ/F+7udlFYNkuT8S WC3qQTQuuZRcQ0r5vHXgJhfpzrjIrJjbZjPL+VScG7k1xU2J2UDalVnEms/j1PVRxUvV KeHyizdrS2WvBcGsfBXN5QmS4Y+vcS99oHZX/ZxsNVAI15vMouiSwPtfg6Y0dS4/10XZ T5SQ== X-Gm-Message-State: AOAM531mkYuovirnh4H88mVbeJRcQjbILRpG2LsKQFPLRK5yfjHgxmuT x41i8IvuJf7oV/cysIEYwEA0XQ== X-Google-Smtp-Source: ABdhPJxpuk5exdp87E4exQMorVIc8Rkqu6LkM0MPGHITyqSt7w9gzpwEf1w9aka2W9DxppeoogF7WQ== X-Received: by 2002:a5d:4d11:: with SMTP id z17mr7453235wrt.458.1637854910126; Thu, 25 Nov 2021 07:41:50 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/7] tests/avocado: fix tcg_plugin mem access count test Date: Thu, 25 Nov 2021 15:41:40 +0000 Message-Id: <20211125154144.2904741-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::436 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , f4bug@amsat.org, Wainer dos Santos Moschetta , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855113947100003 When we cleaned up argument handling the test was missed. Fixes: 5ae589faad ("tests/plugins/mem: introduce "track" arg and make args = not positional") Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211123205729.2205806-4-alex.bennee@linaro.org> --- tests/avocado/tcg_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/avocado/tcg_plugins.py b/tests/avocado/tcg_plugins.py index 9ca1515c3b..642d2e49e3 100644 --- a/tests/avocado/tcg_plugins.py +++ b/tests/avocado/tcg_plugins.py @@ -131,7 +131,7 @@ def test_aarch64_virt_mem_icount(self): suffix=3D".log") =20 self.run_vm(kernel_path, kernel_command_line, - "tests/plugin/libmem.so,arg=3Dboth", plugin_log.name, + "tests/plugin/libmem.so,inline=3Dtrue,callback=3Dtrue"= , plugin_log.name, console_pattern, args=3D('-icount', 'shift=3D1')) =20 --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855298181298.96932569115916; Thu, 25 Nov 2021 07:48:18 -0800 (PST) Received: from localhost ([::1]:54586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGyt-0001GO-U0 for importer@patchew.org; Thu, 25 Nov 2021 10:48:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsl-0006eu-Lt for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:56 -0500 Received: from [2a00:1450:4864:20::430] (port=41771 helo=mail-wr1-x430.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGsj-0002Jh-JF for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:55 -0500 Received: by mail-wr1-x430.google.com with SMTP id a9so12517119wrr.8 for ; Thu, 25 Nov 2021 07:41:53 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z6sm4788300wmp.9.2021.11.25.07.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:46 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 568911FF9B; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBnkomQJkxbzzpqUI0StuDJRpi3gzRMQ5u3DHeZjNiQ=; b=jRA+PfTyJ1fa4QftMk97jcCbITjMbZQyn0BzbHGoY1lmTlKQfXd0Nnf6ugYw+iZHBR ahqWsGIBD7AExrRmk6KIV2nuZ6/+2RS7mbYepamy/+I/4m6bU5anLHJOcYxKotNKEINq QqFltf4jOq0dzm38BhGUJ6A9N7V4MB7G8RE/yk8JvmKl/EGSBJ0/vN9qs3mk5XjKwsZa 3raZ/2f7RtQzHiQYohJ2Ub01vp/v/JtCSuN3RLme9ISRIPQrVvmq1HAXFBIh5w9AScoT ACSvxydKZBQLdFnC9yBR9HdS/1F9ZxX6nQdsR7h18jbHvlx+2JWcZgENHGPHjOt/SL4w Am5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBnkomQJkxbzzpqUI0StuDJRpi3gzRMQ5u3DHeZjNiQ=; b=l0c25io8fygxF1lTxlwqWJVEz7eV6+krVjix6Go8HmaS4JIbSFiTphCrXkGQRuQ+Px GlLjQ1o1MCkyFCw3FFS44yQ4r/tYb5i2f96GXXOtG+tOcN0qjWWOKnHpDaBMEZegLxqr jiEDIZ3POpg6NXUxHWFSvNPtudWrUFLBWylt2RiplQe/xza43DoU6TlOPti2Xo42WC+V dnI3+BdiAYnJW7kRgLnE94huDz+ldGV92DHXgUIKv97HtFr181wcFMX1vbZ0DCr5kgC4 /VcfHo6OMlkHp+rD3BdcnsrbNbkvtuddDQsyKAxikHwT1K8mbXeCnqxLq3YoxeFxD1QP cmjA== X-Gm-Message-State: AOAM530rx2ipfviipJpfiyii5ASU/F7DBkzF+WQVw6EoL+KvDnaAjzLM HmOl/XWbqUNZZkIf4PuH8nm4m1Gbv3xO9A== X-Google-Smtp-Source: ABdhPJxCxm6vuCtGJ+hWDZhyrzwLMeyvoYizrf+tCX2ZfdijjY69ZZKy2MlvbLTZ+fA4A9bWnXptjQ== X-Received: by 2002:a05:6000:2a2:: with SMTP id l2mr7639803wry.110.1637854912194; Thu, 25 Nov 2021 07:41:52 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 4/7] plugins/meson.build: fix linker issue with weird paths Date: Thu, 25 Nov 2021 15:41:41 +0000 Message-Id: <20211125154144.2904741-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::430 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Stefan Weil , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, Mahmoud Mandour , Alexandre Iooss , =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855300840100001 Signed-off-by: Alex Benn=C3=A9e Tested-by: Stefan Weil Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211123205729.2205806-5-alex.bennee@linaro.org> --- plugins/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/meson.build b/plugins/meson.build index aeb386ebae..b3de57853b 100644 --- a/plugins/meson.build +++ b/plugins/meson.build @@ -2,9 +2,9 @@ plugin_ldflags =3D [] # Modules need more symbols than just those in plugins/qemu-plugins.symbols if not enable_modules if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host - plugin_ldflags =3D ['-Wl,--dynamic-list=3D' + (meson.project_build_roo= t() / 'qemu-plugins-ld.symbols')] + plugin_ldflags =3D ['-Wl,--dynamic-list=3Dqemu-plugins-ld.symbols'] elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host - plugin_ldflags =3D ['-Wl,-exported_symbols_list,' + (meson.project_bui= ld_root() / 'qemu-plugins-ld64.symbols')] + plugin_ldflags =3D ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symb= ols'] endif endif =20 --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855436425348.3840221838626; Thu, 25 Nov 2021 07:50:36 -0800 (PST) Received: from localhost ([::1]:33336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqH19-00061j-AX for importer@patchew.org; Thu, 25 Nov 2021 10:50:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsq-0006kn-55 for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:42:01 -0500 Received: from [2a00:1450:4864:20::431] (port=41773 helo=mail-wr1-x431.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGso-0002L2-5G for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:59 -0500 Received: by mail-wr1-x431.google.com with SMTP id a9so12517539wrr.8 for ; Thu, 25 Nov 2021 07:41:57 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id ay21sm7865615wmb.7.2021.11.25.07.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:53 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 624C81FF9C; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bUO0SB+BMTWj4cM859jVLA0edAg0vIZYqctggby2tKg=; b=cOks5faj1ZAeIOESC8RJFn6w4X5WgrioTNGAJyEejDJhhhQ24BnJ1v3uQbcEAvYjUy OxM+su2lMvoLf3brzyI3BCTi45MN4vpk8gAssu23UzWB2jYGKqILq9T72p0qwiZX21Qy mNih0JSAHQNDwE1mPtKNYABdJPLnAEwa6kEz/ywpr4mwhPOMrRK9v+twtMR/CyTGFRfv 91n94onlI/6k9Omrsph+7AUZOsgBYQ78iSvOL4Tlyt+gqBldP4FFoaPtIPvJxeStKqzE owIMC+WZc05+sM2DJ5PvwlTqb3KOpmI0FpidQDC0jjWXCW/NE8wm14880nc6fUBs6e4m uEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bUO0SB+BMTWj4cM859jVLA0edAg0vIZYqctggby2tKg=; b=WhM0+Di9FRb0/u5fHsIgkX8fNkare34D+LiZRomBOQgNo5pmSgL5Pq0GIU+7mh87iO CEqz2CtEI7R5+FzrRMsGYAo3usVrIykpx7/F8Rig2iG5XEqYb9pyDrMpIMBREcRvTzGE vFgoDJerDKr38vt7KYGVf3BeB9FrnIv9HvqB1EfYyRXinAtbGbnF17qMrYAGmjuQikWL LYZEgBwTzqIfQfFHNIyrlKcnA9TJM0UJtQ2HBeUMpzTE3dd4zT+Rb9VmLMEIhlxfaTbN VXAXP6XolMefC4Me6kMtqlxMpiKtjzB4GXgb5rRNaeSGGJW8jYtO8Wv25tmNjxo52/Y2 pvKg== X-Gm-Message-State: AOAM530BnCvfObyFKiW8lmjWJ7iNbIxEVzfsde9aNlFKDpOSPkxH4r80 4MTawMAQqlQDNP9WfLNwWMg4XQ== X-Google-Smtp-Source: ABdhPJyH/ZXGt4RVMG+ovf14hNrAQv0hV/fP59ZuC4hMjuI9daRnwYHlDCw2g6YSZXjQXLryLcxNUw== X-Received: by 2002:a5d:54d0:: with SMTP id x16mr7522187wrv.606.1637854916892; Thu, 25 Nov 2021 07:41:56 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 5/7] gdbstub: handle a potentially racing TaskState Date: Thu, 25 Nov 2021 15:41:42 +0000 Message-Id: <20211125154144.2904741-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::431 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855438336100001 When dealing with multi-threaded userspace programs there is a race condition with the addition of cpu->opaque (aka TaskState). This is due to cpu_copy calling cpu_create which updates the global vCPU list. However the task state isn't set until later. This shouldn't be a problem because the new thread can't have executed anything yet but the gdbstub code does liberally iterate through the CPU list in various places. This sticking plaster ensure the not yet fully realized vCPU is given an pid of -1 which should be enough to ensure it doesn't show up anywhere else. In the longer term I think the code that manages the association between vCPUs and attached GDB processes could do with a clean-up and re-factor. Signed-off-by: Alex Benn=C3=A9e Tested-by: Richard Henderson Reviewed-by: Richard Henderson Cc: Richard Henderson Resolves: https://gitlab.com/qemu-project/qemu/-/issues/730 Message-Id: <20211123205729.2205806-6-alex.bennee@linaro.org> --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 23baaef40e..141d7bc4ec 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -94,7 +94,7 @@ static inline int cpu_gdb_index(CPUState *cpu) { #if defined(CONFIG_USER_ONLY) TaskState *ts =3D (TaskState *) cpu->opaque; - return ts->ts_tid; + return ts ? ts->ts_tid : -1; #else return cpu->cpu_index + 1; #endif --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855005614478.1239905355635; Thu, 25 Nov 2021 07:43:25 -0800 (PST) Received: from localhost ([::1]:41020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGuC-0000VF-FD for importer@patchew.org; Thu, 25 Nov 2021 10:43:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGsn-0006iR-Fg for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:57 -0500 Received: from [2a00:1450:4864:20::435] (port=43599 helo=mail-wr1-x435.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGsl-0002KI-8q for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:57 -0500 Received: by mail-wr1-x435.google.com with SMTP id v11so12491582wrw.10 for ; Thu, 25 Nov 2021 07:41:54 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id t8sm3845319wmq.32.2021.11.25.07.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:52 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 7924E1FF9D; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/izHlYo1eDjiSDXKoXYRwJfwLHOfDK99Sn/yTJcOteo=; b=h/BWDvUaGz+ndnUMUIMQYXbyuqTl33t9VBRCtsGsc11+zvOT3Iic7Rb1lXpDkXiOPW 8GczNjwpQpFUlXjYNoYtUbLyqHRzH33PRZ0hygz/y4vlGLfGszRWyL3eOiaiVGtObApk kyU3D85W3P64PhqxrsGRan4D2iiOypQGr9YHq6PK20ei8UoTqJrtR58JP0unUiUaEjce B7GLnTp8BfBlpRXsOXA1G7m48C1tv+hlc1B56WSlIjiPEq968K/tmje6jfhmDUoT7YWl BHLjweDUBRLGkXAmiH+Ld6QE2B84Sy0DnmENUHQbU/xYYOUEBwjj/7YJ6Sy4fDpK+R34 keEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/izHlYo1eDjiSDXKoXYRwJfwLHOfDK99Sn/yTJcOteo=; b=a4zMo1KRkVwXh1Il1wfTFoYSBlczCAeRiFYTFN0yqo2ijf5ekt8Kr+xMM5FLhq8OcY OQow9wVRvRFDo1pb/UEMzV6zss5d4d9UK0PE+QNJ8EUzYNjXl4LXIG1lko7gIxnTUDxT VF2ID6dBYg0jsiomRoLIF12Me/3eUIuzRGUFCji995KNR9EM+MudqD/sMN9eV2QBrJSK sT/xUAHkVtugeweXWN9tu2dePqNGZSKFpvJORqOdxbyWrbs+2lWX6n6W3KBQZa8EuNp0 dzIWxMEdSM801gpiRWJebdcdMGBoYeA6hv4QvPswZn5VzXRsUR6C4rvoEqxGFNlkdyDS d3Uw== X-Gm-Message-State: AOAM532DXFUd2KfJwVVjuIwGq1b4uFSCt5QOoL5hYxCsDamtKLkBm2WB k1xsGRDkOyloqe+U7aIRViUboA== X-Google-Smtp-Source: ABdhPJwzz5WP5ik/Mqlg8iMzEBLCC8xcW3pFnCtDPE688vgLeODNIpFh29GX/iSQ2WF95HBV6M3h5Q== X-Received: by 2002:a5d:61ca:: with SMTP id q10mr7198109wrv.102.1637854913938; Thu, 25 Nov 2021 07:41:53 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 6/7] MAINTAINERS: Remove me as a reviewer for the build and test/avocado Date: Thu, 25 Nov 2021 15:41:43 +0000 Message-Id: <20211125154144.2904741-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::435 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, berrange@redhat.com, Beraldo Leal , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , f4bug@amsat.org, Willian Rampazzo , stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855006953100001 From: Willian Rampazzo Remove me as a reviewer for the Build and test automation and the Integration Testing with the Avocado Framework and add Beraldo Leal. Signed-off-by: Willian Rampazzo Reviewed-by: Beraldo Leal Message-Id: <20211122191124.31620-1-willianr@redhat.com> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211123205729.2205806-7-alex.bennee@linaro.org> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d3879aa3c1..8f5156bfa7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3469,7 +3469,7 @@ M: Alex Benn=C3=A9e M: Philippe Mathieu-Daud=C3=A9 M: Thomas Huth R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Maintained F: .github/lockdown.yml F: .gitlab-ci.yml @@ -3507,7 +3507,7 @@ W: https://trello.com/b/6Qi1pxVn/avocado-qemu R: Cleber Rosa R: Philippe Mathieu-Daud=C3=A9 R: Wainer dos Santos Moschetta -R: Willian Rampazzo +R: Beraldo Leal S: Odd Fixes F: tests/avocado/ =20 --=20 2.30.2 From nobody Fri Apr 19 11:39:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637855271123116.60961252308607; Thu, 25 Nov 2021 07:47:51 -0800 (PST) Received: from localhost ([::1]:52746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqGyU-0008Ts-21 for importer@patchew.org; Thu, 25 Nov 2021 10:47:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47970) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqGso-0006jI-CE for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:59 -0500 Received: from [2a00:1450:4864:20::335] (port=53936 helo=mail-wm1-x335.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqGsm-0002Kf-Fd for qemu-devel@nongnu.org; Thu, 25 Nov 2021 10:41:58 -0500 Received: by mail-wm1-x335.google.com with SMTP id y196so5935802wmc.3 for ; Thu, 25 Nov 2021 07:41:55 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h22sm3989564wmq.14.2021.11.25.07.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 07:41:53 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 8F5EC1FF9E; Thu, 25 Nov 2021 15:41:45 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RyIHG7rbgW4Ax4rztavLtHw3c5eLl5GAByR6z8d2y5A=; b=sidRM2WpXMytLReznljvBEUHBx2b/gf2yuqTiHLl6GOSexDuLaJMcrhk0eQQ2HYNu9 4mB2d3SOrwIMwMoRBoZZJomQ4QhpOcba5TO3lgJi/NX28Q13ZxZModG3pHXfvA9btdHt 9qxsNFkVZV/3bN64rZV3d6Tm7Clgr3pIBtRt+4Lt80QfjQK6cW5FMjRKe8kEaptEvq/5 nCLJb1F/jdDLZGPIyx5I5w9ZvdU8nzxCNpN5TMD0Se5prTRrl9Aml4yifv+Zlg4V/MtQ i33Q13otOTyesQ5LZK0PE/8jwM79znZ6IjrqODeL8KGJAIE+xOzWRFAj6KNDAC0WPQgD tcwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RyIHG7rbgW4Ax4rztavLtHw3c5eLl5GAByR6z8d2y5A=; b=J11ZbE3mcrX/sU8TuDCUinJF5Fm1tJbBArPo8YDxTdDwlpvXmeXFErdR/yhKM7oeNB oK4BL1j+Nc+xkvJlumtgqo9Q1fn52SvWzHuzf1BtWwwLX8UKHjCcizkCJiG8pvQ2hzi0 7I/GBZ3NhcY+3p/64mccLaiycESk459bvqaboDhohmiAF5QiCcA0DP28+Z+z3ReqcgzL YQM6lpiVPJbmwby4tw1pJKkooAHhmTwhsP0Z0HfRU6nmWN1PMGrXlxKIsNt/sPLzxVZq nC6AA7mX2tVx+I3D9f3tix5k4RU5er/2LMm2EN8HWSzriklCswsl0I6aLBsxE7JXiC/f I/1g== X-Gm-Message-State: AOAM531uAfNotMPbP0CZz4CsSlOM1M1vzileX7+dWOro9V5u5R+zyPbD oEFfFLetbIRwOmuXgKlspJQrow== X-Google-Smtp-Source: ABdhPJzpw4yXeQTSmgX+9tT6/vWmdmVePsfl5O2zYg4EwLG/sOVjruax37AzHECwPlgPEo/vac89Ww== X-Received: by 2002:a05:600c:4f4b:: with SMTP id m11mr8082917wmq.151.1637854914940; Thu, 25 Nov 2021 07:41:54 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v2 7/7] MAINTAINERS: Add section for Aarch64 GitLab custom runner Date: Thu, 25 Nov 2021 15:41:44 +0000 Message-Id: <20211125154144.2904741-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211125154144.2904741-1-alex.bennee@linaro.org> References: <20211125154144.2904741-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::335 (failed) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, Thomas Huth , berrange@redhat.com, f4bug@amsat.org, stefanha@redhat.com, crosa@redhat.com, pbonzini@redhat.com, =?UTF-8?q?Alex=20Benn=C3=A9e?= , aurelien@aurel32.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1637855273392100001 From: Philippe Mathieu-Daud=C3=A9 Add a MAINTAINERS section to cover the GitLab YAML config file containing the jobs run on the custom runner sponsored by the Works On Arm project [*]. [*] https://developer.arm.com/solutions/infrastructure/works-on-arm Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Alex Benn=C3=A9e Message-Id: <20211116163226.2719320-1-f4bug@amsat.org> Message-Id: <20211123205729.2205806-8-alex.bennee@linaro.org> --- MAINTAINERS | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8f5156bfa7..006a2293ba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3511,6 +3511,12 @@ R: Beraldo Leal S: Odd Fixes F: tests/avocado/ =20 +GitLab custom runner (Works On Arm Sponsored) +M: Alex Benn=C3=A9e +M: Philippe Mathieu-Daud=C3=A9 +S: Maintained +F: .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml + Documentation ------------- Build system architecture --=20 2.30.2