From nobody Mon Feb 9 18:21:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1637294775; cv=none; d=zohomail.com; s=zohoarc; b=QK/eSLKr1UgmyEFcZjtsEYnAv4vFyUqBceE/InN2pE87eX437d9qsEHFRmprK4ioT38xkvVebtVE9TGiAwbNHe0SVPoG1YhnCyd5y+7FOUauRTV7u9xd7oyIn7ybsDt1CM+t8pKHaaYdE/rlEcz2fI5JErG/GnS8NZbzpBiCiM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1637294775; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NSNqzMdiYd1AqcnEVTVw0nNmp24RCW0UjMdkXR+jmI8=; b=EFOSlqcasa6Xcr/p0v57LuseEz6FY58dVjyefvlCDnStRJY+pehujSHRXTBEiSlrcDq0tlICygxOYBGhNrqXLeYN3O8Sa1M7nl1uzRTE47k4kV8MQjBcPUY1rqhQUBb4t8jrBh75YKww5kIr9tbJdyQm4FQt395okGCj7QqfpiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1637294775681912.0890775825465; Thu, 18 Nov 2021 20:06:15 -0800 (PST) Received: from localhost ([::1]:44622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnvAE-0002dX-LL for importer@patchew.org; Thu, 18 Nov 2021 23:06:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnv7y-0000Z6-R5 for qemu-devel@nongnu.org; Thu, 18 Nov 2021 23:03:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30091) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnv7v-0006Aa-VW for qemu-devel@nongnu.org; Thu, 18 Nov 2021 23:03:54 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-499-_0mhWNoXPA-pjKG-CXMGVQ-1; Thu, 18 Nov 2021 23:03:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CF86802C91; Fri, 19 Nov 2021 04:03:46 +0000 (UTC) Received: from localhost.localdomain (ovpn-13-18.pek2.redhat.com [10.72.13.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id B8BDF60BF1; Fri, 19 Nov 2021 04:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637294631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSNqzMdiYd1AqcnEVTVw0nNmp24RCW0UjMdkXR+jmI8=; b=Lg4mr/JrDb9g2dKhCWBY+PTHYBtuTFYAW9v3FyvQMzUJ5tf7XiMXH/J3XyR5H7emfig6Yj VroFv7N0q0+NblXiNvcnpqzGUNuHLbgzfO9KJlDG6a1wx5SPvZj53/ovT0kIFRCswQG688 YDWDtRNK+o/ZoNH0j91JmIqq4IWwmw0= X-MC-Unique: _0mhWNoXPA-pjKG-CXMGVQ-1 From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL 2/3] net/colo-compare.c: Fix ACK track reverse issue Date: Fri, 19 Nov 2021 12:03:35 +0800 Message-Id: <20211119040336.14460-3-jasowang@redhat.com> In-Reply-To: <20211119040336.14460-1-jasowang@redhat.com> References: <20211119040336.14460-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhang Chen , Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1637294777022100001 Content-Type: text/plain; charset="utf-8" From: Zhang Chen The TCP protocol ACK maybe bigger than uint32_t MAX. At this time, the ACK will reverse to 0. This patch fix the max_ack and min_ack track issue. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index b8876d7..1225f40 100644 --- a/net/colo-compare.c +++ b/net/colo-compare.c @@ -209,7 +209,8 @@ static void fill_pkt_tcp_info(void *data, uint32_t *max= _ack) =20 pkt->tcp_seq =3D ntohl(tcphd->th_seq); pkt->tcp_ack =3D ntohl(tcphd->th_ack); - *max_ack =3D *max_ack > pkt->tcp_ack ? *max_ack : pkt->tcp_ack; + /* Need to consider ACK will bigger than uint32_t MAX */ + *max_ack =3D pkt->tcp_ack - *max_ack > 0 ? pkt->tcp_ack : *max_ack; pkt->header_size =3D pkt->transport_header - (uint8_t *)pkt->data + (tcphd->th_off << 2); pkt->payload_size =3D pkt->size - pkt->header_size; @@ -413,7 +414,8 @@ static void colo_compare_tcp(CompareState *s, Connectio= n *conn) * can ensure that the packet's payload is acknowledged by * primary and secondary. */ - uint32_t min_ack =3D conn->pack > conn->sack ? conn->sack : conn->pack; + uint32_t min_ack =3D conn->pack - conn->sack > 0 ? + conn->sack : conn->pack; =20 pri: if (g_queue_is_empty(&conn->primary_list)) { --=20 2.7.4