From nobody Mon Apr 7 21:48:42 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1636988268; cv=none; d=zohomail.com; s=zohoarc; b=IUEHQ63eKkoocrnzcrrSElKl6jLHjINJ2PzujzCKXEmQ2+C3yMxflchm8YoNGNOCA5FUk04s1Mrt3kruph2qi5vlzaO8hqIgwT8h2tfxajpl8AlAABbvGMyRpD4R+ERiwaS+fS/Lv8Rv9IeOSW2CjsSw2M8PoYvXYzpXTPHDDI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636988268; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SbGQlYpKcUULcio3TMTlpgBuklIlNQR8vcoKb7irG38=; b=X7RcDiKYyqgo4pkgnro8zDKUMlLzM3iOmSzeW9gnogOMhqzOCbYb+QGVp/jSq2MTAAfCtviL+hc0EB4iCM9NhcYMmb5ipDeq2YYbMEX00v4ZUx0259++eJjRr4+a5avLovyCvsA2u73AiEApZxaWnQOhurOZtRWZkdDh8p4+IRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1636988268815729.4302265578416; Mon, 15 Nov 2021 06:57:48 -0800 (PST) Received: from localhost ([::1]:55496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmdQZ-0000ly-Ok for importer@patchew.org; Mon, 15 Nov 2021 09:57:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmdNY-0003y4-0p for qemu-devel@nongnu.org; Mon, 15 Nov 2021 09:54:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmdNS-0007qf-Lv for qemu-devel@nongnu.org; Mon, 15 Nov 2021 09:54:38 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-2GJ9WrINPDyK9Qd-kbdF4Q-1; Mon, 15 Nov 2021 09:54:28 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3B581006AA1; Mon, 15 Nov 2021 14:54:27 +0000 (UTC) Received: from merkur.fritz.box (unknown [10.39.193.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id C220B19D9F; Mon, 15 Nov 2021 14:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636988074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SbGQlYpKcUULcio3TMTlpgBuklIlNQR8vcoKb7irG38=; b=ZGzgfEeiNCDdjgCmoHmy4v0w0dZtklpUJopgVMS7j/xqzhljF/+fpWtAsQ72pOw9L2wHTM vkw0sp0Vd4LOW1uYKTN9GcW9ta92xVf3gXvMdhSyAazk5OaB/HCYgwMdoa+V8IaK1P1+VR /F6rarNZCFcD49LWPRGlQr0g+BHJk7E= X-MC-Unique: 2GJ9WrINPDyK9Qd-kbdF4Q-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 10/13] iotests/030: Unthrottle parallel jobs in reverse Date: Mon, 15 Nov 2021 15:54:06 +0100 Message-Id: <20211115145409.176785-11-kwolf@redhat.com> In-Reply-To: <20211115145409.176785-1-kwolf@redhat.com> References: <20211115145409.176785-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1636988270552100001 Content-Type: text/plain; charset="utf-8" From: Hanna Reitz See the comment for why this is necessary. Signed-off-by: Hanna Reitz Message-Id: <20211111120829.81329-11-hreitz@redhat.com> Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030 | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/030 b/tests/qemu-iotests/030 index 5fb65b4bef..567bf1da67 100755 --- a/tests/qemu-iotests/030 +++ b/tests/qemu-iotests/030 @@ -251,7 +251,16 @@ class TestParallelOps(iotests.QMPTestCase): speed=3D1024) self.assert_qmp(result, 'return', {}) =20 - for job in pending_jobs: + # Do this in reverse: After unthrottling them, some jobs may finish + # before we have unthrottled all of them. This will drain their + # subgraph, and this will make jobs above them advance (despite th= ose + # jobs on top being throttled). In the worst case, all jobs below= the + # top one are finished before we can unthrottle it, and this makes= it + # advance so far that it completes before we can unthrottle it - w= hich + # results in an error. + # Starting from the top (i.e. in reverse) does not have this probl= em: + # When a job finishes, the ones below it are not advanced. + for job in reversed(pending_jobs): result =3D self.vm.qmp('block-job-set-speed', device=3Djob, sp= eed=3D0) self.assert_qmp(result, 'return', {}) =20 --=20 2.31.1