From nobody Sun Feb 8 12:52:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 163674586801244.25805884343788; Fri, 12 Nov 2021 11:37:48 -0800 (PST) Received: from localhost ([::1]:45498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlcMs-0005Dl-3n for importer@patchew.org; Fri, 12 Nov 2021 14:37:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlcKA-0003Mh-6O for qemu-devel@nongnu.org; Fri, 12 Nov 2021 14:34:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlcK7-0007y2-EU for qemu-devel@nongnu.org; Fri, 12 Nov 2021 14:34:57 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414-HypJtP8UPEafYyulfsG-ng-1; Fri, 12 Nov 2021 14:34:51 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 960411023F4F; Fri, 12 Nov 2021 19:34:50 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DDB119723; Fri, 12 Nov 2021 19:34:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636745692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v7wWWwLuA0w2/3OXVrR2o4AEAv2i1t0oR12O6Lnvd1Y=; b=BN7gTY+nX58RqI6yLfUjAsy9PG315FDs0rZMJYrnaecs6/N2n+Eb7+z36w3j7iEwnmf8z3 GI/JU8TpIUyCYxB0xcuEmbkqs6wlYPyVeGcZW8WAL25cD4ElF4mPrlZFAniWsaUnele7z9 Fp3+r9vAed8KxAcKKSftt9egd12/A+k= X-MC-Unique: HypJtP8UPEafYyulfsG-ng-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 1/2] vdpa: Replace qemu_open_old by qemu_open at Date: Fri, 12 Nov 2021 20:34:30 +0100 Message-Id: <20211112193431.2379298-2-eperezma@redhat.com> In-Reply-To: <20211112193431.2379298-1-eperezma@redhat.com> References: <20211112193431.2379298-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Jason Wang , Cindy Lu , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1636745869002100002 There is no reason to keep using the old one, since we neither use the variadics arguments nor open it with O_DIRECT. Also, net_client_init1, the caller of net_init_vhost_vdpa, wants all net_client_init_fun to use Error API, so it's a good step in that direction. Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- net/vhost-vdpa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 49ab322511..6ffb29f4da 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -261,7 +261,7 @@ int net_init_vhost_vdpa(const Netdev *netdev, const cha= r *name, assert(netdev->type =3D=3D NET_CLIENT_DRIVER_VHOST_VDPA); opts =3D &netdev->u.vhost_vdpa; =20 - vdpa_device_fd =3D qemu_open_old(opts->vhostdev, O_RDWR); + vdpa_device_fd =3D qemu_open(opts->vhostdev, O_RDWR, errp); if (vdpa_device_fd =3D=3D -1) { return -errno; } --=20 2.27.0 From nobody Sun Feb 8 12:52:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1636746029116431.5606774714721; Fri, 12 Nov 2021 11:40:29 -0800 (PST) Received: from localhost ([::1]:49866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlcPU-0008DY-22 for importer@patchew.org; Fri, 12 Nov 2021 14:40:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlcKJ-0003Wg-4s for qemu-devel@nongnu.org; Fri, 12 Nov 2021 14:35:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27930) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlcKG-0007z6-Uq for qemu-devel@nongnu.org; Fri, 12 Nov 2021 14:35:06 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-x2k6HkZrMLm8leF4R445WA-1; Fri, 12 Nov 2021 14:34:57 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4AF7315722; Fri, 12 Nov 2021 19:34:56 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE6F419723; Fri, 12 Nov 2021 19:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636745700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3NlTKCv+dB2uLiS+nu6ZWpM01wn+xk+NhHBbif2PWUE=; b=BuyePA1h9ILeytKtiTI/V7V1OauNmZSfWn8g3F28YECXVa9z1GIb7AZixrdA4RnyzV53UB gDC/lxyMKsMWRbSaEQbGZynISUNzNvhATG99u/qMiNG0+uMciGk9kIa8pdJTuNE4yjsYt6 x7npCu2bGojdkDIdjOFrSph6o5j6XTs= X-MC-Unique: x2k6HkZrMLm8leF4R445WA-1 From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 2/2] vdpa: Check for existence of opts.vhostdev Date: Fri, 12 Nov 2021 20:34:31 +0100 Message-Id: <20211112193431.2379298-3-eperezma@redhat.com> In-Reply-To: <20211112193431.2379298-1-eperezma@redhat.com> References: <20211112193431.2379298-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eperezma@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eperezma@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Jason Wang , Cindy Lu , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1636746029816100003 Since net_init_vhost_vdpa is trying to open it. Not specifying it in the command line crash qemu. Fixes: 7327813d17 ("vhost-vdpa: open device fd in net_init_vhost_vdpa()") Signed-off-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- net/vhost-vdpa.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 6ffb29f4da..bbd3576f23 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -260,6 +260,10 @@ int net_init_vhost_vdpa(const Netdev *netdev, const ch= ar *name, =20 assert(netdev->type =3D=3D NET_CLIENT_DRIVER_VHOST_VDPA); opts =3D &netdev->u.vhost_vdpa; + if (!opts->vhostdev) { + error_setg(errp, "vdpa character device not specified with vhostde= v"); + return -1; + } =20 vdpa_device_fd =3D qemu_open(opts->vhostdev, O_RDWR, errp); if (vdpa_device_fd =3D=3D -1) { --=20 2.27.0