From nobody Tue Feb 10 06:08:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1636132895; cv=none; d=zohomail.com; s=zohoarc; b=iHlkbjL6RRI/Yft67fyMU1D8T8eAMp3Qa1FIKg0nCt10Dm+AKGI5w5cb0XK0TITmoirsj8uGztAfoSnEIbXtP957Ug23u8c5Zr7lZGl4IbRuNXYpzKFS0UxUs6gaIIKChgrldQJ1J73DvpkFCEMa0xmxRAzxOEeCpj/3eiaKEl0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1636132895; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=d3pfBfUWEkr1HXpj/BC7XFNX+5ez4tvt7AfZVzlC78A=; b=BaibsRXbzAu6dCxLKUgYgh24PG13tPbLYOiLQpY9MxBcV9OUNoOh88XCT0DcenrrHxvBq6whZ+BXp1xeLdBpuXP4mCsqdX30hOA02ykEiMo6JwO6m9jPk/5h+WfFLc0c0FCjHAyl1z1CcDieUExgSJJI71XG4ZS5dLyWGNGd3lE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1636132895947725.875645370462; Fri, 5 Nov 2021 10:21:35 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id d27so14821539wrb.6 for ; Fri, 05 Nov 2021 10:21:35 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m125sm11628641wmm.39.2021.11.05.10.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 10:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d3pfBfUWEkr1HXpj/BC7XFNX+5ez4tvt7AfZVzlC78A=; b=KxSOfKAtNVnLsGosZ5y8Vw1xxDNdMoLRzrJB5mLO3F6iAb8SSNUV0ZbpexiCav7Mkn jQoPwJP0KzHa4AN8GfQhNRiskX0ncuVUx8M6xWzs4Yf2FOatyu4H7YlKVJtsHMwdbV0K dK1U/hVJrPDt7XuPE9fk14ewmNrxD+amLQEuYHafH2una/oA0ns4HBrxdAWr7UDQIJol juXpMU1V2U2aY0aaewV7zmE0s7eIrg+rNY5ETGvGswejxpapiI1Zw3Xq8Eup1ucJGUMs 9J4OWPoW+bbbA0WBx7HHOWRsJhXBKFsZrbn2WbvpqKho029yRfDC7bDc2AfoGA3G/FJc Piqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=d3pfBfUWEkr1HXpj/BC7XFNX+5ez4tvt7AfZVzlC78A=; b=yMqoeJrixPnIYBevvx0OkTjG/d81bkA+1dvEOh7TI9tuHdksMz9AmxH4vknIaeP7Q6 nFdvuMCnmq/bmHNG2pisvzWI/rTKISNcDvGRrPt2eVU6GHLmBTiVn2R9yiUeZmSqah72 5INHieZDTYEtSMLCormXTaQ+PB5+4PCVlomd2oD0RcCZqgrdB1PCH12ZPW3wz5QD0jpp w9pmvKTud5TbwqoLrJVWVIBflqNx7i7GglW2+AgG3MNAA64rmfyRlnpPO3S077TJBNFH FJ/9DVIrpADb5VSekWcCYdi0BBulKdIECSiYxVSmGrItFYkJq7nhi2msuSRdcU/XNyK/ +CeA== X-Gm-Message-State: AOAM531kxu9mel/A5gL1N9uEMxmITxIfRFSJsDsCjz5Bo2Nw5O2jURU8 WYh/3QSgKOygrryVo1tDWUU= X-Google-Smtp-Source: ABdhPJxSRofpgzzyLJ/LHocsl6qYthoyntcVE4dyjS02VB4BG3qNEhRDqBzJon9IMtgQzBDT7wMiqw== X-Received: by 2002:adf:f990:: with SMTP id f16mr68147221wrr.128.1636132894197; Fri, 05 Nov 2021 10:21:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Eduardo Habkost , qemu-trivial@nongnu.org, Richard Henderson , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/qdev: Correct qdev_connect_gpio_out_named() documentation Date: Fri, 5 Nov 2021 18:21:25 +0100 Message-Id: <20211105172127.224462-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211105172127.224462-1-f4bug@amsat.org> References: <20211105172127.224462-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1636132896551100001 qdev_connect_gpio_out_named() is described as qdev_connect_gpio_out(), and referring to itself in an endless loop, which is confusing. Fix. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/qdev-core.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 72622bd3370..5b88c8b9dd3 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -497,7 +497,8 @@ qemu_irq qdev_get_gpio_in_named(DeviceState *dev, const= char *name, int n); */ void qdev_connect_gpio_out(DeviceState *dev, int n, qemu_irq pin); /** - * qdev_connect_gpio_out: Connect one of a device's anonymous output GPIO = lines + * qdev_connect_gpio_out_named: Connect one of a device's named output + * GPIO lines * @dev: Device whose GPIO to connect * @name: Name of the output GPIO array * @n: Number of the anonymous output GPIO line (which must be in range) @@ -518,8 +519,6 @@ void qdev_connect_gpio_out(DeviceState *dev, int n, qem= u_irq pin); * It is not valid to try to connect one outbound GPIO to multiple * qemu_irqs at once, or to connect multiple outbound GPIOs to the * same qemu_irq; see qdev_connect_gpio_out() for details. - * - * For named output GPIO lines, use qdev_connect_gpio_out_named(). */ void qdev_connect_gpio_out_named(DeviceState *dev, const char *name, int n, qemu_irq pin); --=20 2.31.1