From nobody Tue Feb 10 14:32:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860603; cv=none; d=zohomail.com; s=zohoarc; b=UTh0fEeC0ASfNMoCGDStDJEdvjTn4AlkAspADwFWBs1tCrQj8pHioxJUFolUG+9cz4ISjkEdbspbKLNra/eH/2S4welkkbtiE2mxAuCoSHay3Lvk6CE+av5XS4Ze4hI/s7hLFGcda+fUia0cCi/Lxl0VjG2kJW9ydx/SNmdq2mc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vrlE266b7OXg2/V52v1brIFbPFZKEknGt9V0I3M5muc=; b=nSOe8p4JmzzCcN54v8kaH6wnCQ9o/hc3NX4mqfxh3TWhryve/TAU4V4XoT/f4qrkOCwzCYweuqNLKShzvIqzWbS19hCXBjoK8yOyP6ONOX0xWdTqA+vRp96monRe+XB8orh5yQ1S/Cj018hmAllxGlQX5zF/TeWpREGwLs6NDFg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1635860603044515.2868327083959; Tue, 2 Nov 2021 06:43:23 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id z200so14804701wmc.1 for ; Tue, 02 Nov 2021 06:43:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id p12sm5997845wrr.10.2021.11.02.06.43.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vrlE266b7OXg2/V52v1brIFbPFZKEknGt9V0I3M5muc=; b=NO1AUGGw7Md3Y3jN74ibN+c+Zz5HwY+s/ahJRo2a+QNKtshx3l8jbekZcwmX8nmzMA 4JPyjt8nbYvgHlfuq03LS0sVGav8DbAMasFwEoctBOXYNFYf1+lz9E1V19iDXMhoBC4+ yo1vjz6o16sHlHMR98zovtIgoKyQ0uX6sETUSKJM6HSMUrKG9pGQM2Y1GujKyOXvbOSO gm1VoWjorxCWP1rSAgoJCdBuPq8HAA+pZZY//qua/ey8APtJpcS+HRSl5OwztpeXn/yC fI3e/B07PUTLNR5ny/PJBIJs4jaY7mX3CQj4cRDnKyWTdMKi/0QDAeyOlwrN7VzE7Ml4 HKPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=vrlE266b7OXg2/V52v1brIFbPFZKEknGt9V0I3M5muc=; b=51iB78stQGPmjKbg8RbB88LcOwZ41BnWFcCzPXqj7CUQQ8HFDE4QlhYEkJfuvwWcHv xOBiQyjL2dhVEGU044N38DDqZSJKa1JDA5Iydb+UkCFMx6xBb7a8Ofc3fS1+O9+X34kt +CtBRC0aULbqbXxrNecB/hMnBXyKldRh/TmQ2s8YB1momM7LRCaEsHdV6YRnvWNqNgxl 86+Mk/RHzPi/s3ehLu4+GIjxT0wVXp5wh5CAL982OV4zc3qXKDZKJGwxBvdEVGZKQ3sq gK4noyx9HyDrx5V8OIbM9ISTwCgoDANQUmdVGLyjFpvAj9MyWAg3ckii69tV5AoCAlju ncXA== X-Gm-Message-State: AOAM532dHWo93dGBULnXiR69p3mT/exB73Pth7sbvOMSg/6XZVUA7uVQ yjL/9lct2xGXk4ZHyF21Dlg= X-Google-Smtp-Source: ABdhPJxBYpLiFOjYIfks7nyUBYUI+fo1UwPsKDQ95alpb5e9bNDYn3LjLJDdVkaPUwrsRyfpqQ1ULw== X-Received: by 2002:a05:600c:4fd4:: with SMTP id o20mr6956863wmq.175.1635860601287; Tue, 02 Nov 2021 06:43:21 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 08/41] target/mips: Have check_msa_access() return a boolean Date: Tue, 2 Nov 2021 14:42:07 +0100 Message-Id: <20211102134240.3036524-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860604851100001 Have check_msa_access() return a boolean value so we can return early if MSA is not enabled (the instruction got decoded properly, but we raised an exception). Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-6-f4bug@amsat.org> --- target/mips/tcg/msa_translate.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index b135c58fd4f..e0ccd8c1cb8 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -295,19 +295,24 @@ void msa_translate_init(void) } } =20 -static inline int check_msa_access(DisasContext *ctx) +/* + * Check if MSA is enabled. + * This function is always called with MSA available. + * If MSA is disabled, raise an exception. + */ +static inline bool check_msa_enabled(DisasContext *ctx) { if (unlikely((ctx->hflags & MIPS_HFLAG_FPU) && !(ctx->hflags & MIPS_HFLAG_F64))) { gen_reserved_instruction(ctx); - return 0; + return false; } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { generate_exception_end(ctx, EXCP_MSADIS); - return 0; + return false; } - return 1; + return true; } =20 static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, @@ -339,7 +344,9 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, in= t s16, TCGCond cond) { TCGv_i64 t0; =20 - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -371,7 +378,9 @@ static bool trans_BNZ_V(DisasContext *ctx, arg_msa_bz *= a) =20 static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) { - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -2143,7 +2152,9 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { uint32_t opcode =3D ctx->opcode; =20 - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 switch (MASK_MSA_MINOR(opcode)) { case OPC_MSA_I8_00: --=20 2.31.1