From nobody Tue Feb 10 06:58:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) client-ip=209.85.221.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860598; cv=none; d=zohomail.com; s=zohoarc; b=WuAtJHa4XnYpWb5jS2s3pWpwTIQrwcDEppMWwZH3PDL3pAYfwwzmigTI9jO+/voNfs1BEQaI6irk17CRsVpV0XKOu1lG4Jy5uLW/t0AYshPqS6dVf/u38RhBCS56mSFal92bZzwqr9E0Ub4NhW28l3wz0qiaDBvMGXVXC9azDxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cqMjHHYN10H3op3QY78nRkjwyRaM4nA6KOm3QFWkggo=; b=Nge44OopV+KHCUlqsCDRiCBnR2JWp6IEizO+p3GZzkXDm/Sm57aw/oznM0vt1wiKE5dY11Etir9l2b+ysTQF7KRvFwJibXMNzHp5bZ05PJqoeMe0zZf6zE+gMeOVS35BUi6ehX2FWTsPuKX2s4cptAd9zbbWb++Q23bXsGn3XL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.zohomail.com with SMTPS id 1635860598366153.5638642812737; Tue, 2 Nov 2021 06:43:18 -0700 (PDT) Received: by mail-wr1-f49.google.com with SMTP id b12so28953782wrh.4 for ; Tue, 02 Nov 2021 06:43:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id j38sm2614285wms.29.2021.11.02.06.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cqMjHHYN10H3op3QY78nRkjwyRaM4nA6KOm3QFWkggo=; b=ebPrOGqR+jFCdtjYa8fhw8ZKVIMlJm/11ws1hcFZ/RkzQtPq93/y1+nnxWZM50s39i GTqVfnCmuT0iJ5lV/78aUf1Wb8hpuvzHPeD/MgDIFZGsIPjEsqu0vjowbaAm4d85uYVM vaXJ7yqLtVSOfrMYxNSk7QSaX7AibPht0+goNwJ2IYp3qNB1/4MachooV9aOSyZlYSnn MO1FvBHRbcgs0Ou6I75GoLszLpa1TzVfJDGH0ySQigeBrGxfI5tfESOho3rn7Rd27nuh tNbtUKs+rngOrxyg0vUzBIzjBOB+1/czA6CQAOvH+Wpmg5inGztIfRqduToTeE5F4OD6 tu6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=cqMjHHYN10H3op3QY78nRkjwyRaM4nA6KOm3QFWkggo=; b=bgAWOw17+4F+NlGLAPeN0v60mk5NvJMKi9PW3AM9wMeUgMHAFWriJOyqjP6Hkgkl4J GWPfpnTWmsduZUc4SRo61niU/O1XpIV3PqVtXCLxzqfnh2sI+XBeKEB8foQ9pCntcVH0 zPv1RBj5jMOwcgO7WqFRjcOpoZ0SOCXXRGMEn3mxzQvc17gq50mkDumDKe+JmNYyuP8o x9XlK8HN7TgJeurqCa9nRg1mMDQRLWcFC/CIOLJ4mO/ZIMC/LN/urduC27xjKOCIh41T 7UcLLG4r/6aVASgbfk+yIgaCiNJvAjLorzU/ucMU8YMKs2rWl5T29fwRhLZwqhiOwlI2 SvcA== X-Gm-Message-State: AOAM530exZYzBIIRKZItgLRFY4n+eKlvkNWsNbjHYSi6+LD7f/iPqKHi DrWKLzqMO5Mi3NYkV4DdcRk= X-Google-Smtp-Source: ABdhPJzhwyo4vZwVoFFnQrj8JV+RIiOW+tnhV5PN8fc6Qfmi8wi1FwUG4OHZ2AS3v0oaB0xBE7Rz1g== X-Received: by 2002:adf:ded0:: with SMTP id i16mr42517579wrn.335.1635860596651; Tue, 02 Nov 2021 06:43:16 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 07/41] target/mips: Use dup_const() to simplify Date: Tue, 2 Nov 2021 14:42:06 +0100 Message-Id: <20211102134240.3036524-8-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860600238100001 The dup_const() helper makes the code easier to follow, use it. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20211028210843.2120802-5-f4bug@amsat.org> --- target/mips/tcg/msa_translate.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3aa15e147c2..b135c58fd4f 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -315,28 +315,11 @@ static void gen_check_zero_element(TCGv tresult, uint= 8_t df, uint8_t wt, { /* generates tcg ops to check if any element is 0 */ /* Note this function only works with MSA_WRLEN =3D 128 */ - uint64_t eval_zero_or_big =3D 0; - uint64_t eval_big =3D 0; + uint64_t eval_zero_or_big =3D dup_const(df, 1); + uint64_t eval_big =3D eval_zero_or_big << ((8 << df) - 1); TCGv_i64 t0 =3D tcg_temp_new_i64(); TCGv_i64 t1 =3D tcg_temp_new_i64(); - switch (df) { - case DF_BYTE: - eval_zero_or_big =3D 0x0101010101010101ULL; - eval_big =3D 0x8080808080808080ULL; - break; - case DF_HALF: - eval_zero_or_big =3D 0x0001000100010001ULL; - eval_big =3D 0x8000800080008000ULL; - break; - case DF_WORD: - eval_zero_or_big =3D 0x0000000100000001ULL; - eval_big =3D 0x8000000080000000ULL; - break; - case DF_DOUBLE: - eval_zero_or_big =3D 0x0000000000000001ULL; - eval_big =3D 0x8000000000000000ULL; - break; - } + tcg_gen_subi_i64(t0, msa_wr_d[wt << 1], eval_zero_or_big); tcg_gen_andc_i64(t0, t0, msa_wr_d[wt << 1]); tcg_gen_andi_i64(t0, t0, eval_big); --=20 2.31.1