From nobody Tue Feb 10 13:18:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860593; cv=none; d=zohomail.com; s=zohoarc; b=iQYp8cVDzfjWYxWbjzAe6bIYo3VsWjniA6NKgf+339nBBSxkXNT8IlNy9V7yVDuu8vA2YXZvuKPpyogMEN9hfu7LXvfuVhpcHDZ9hnAoPFd1Ht5YtVyS/au5sgW6AUF0/+QtbvdQTNBxBcI7g0rmatvK5DyPgzXohDyKs8qFGvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860593; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+/Q/nSxAuHlXOdojOuByNBLGz7XClzU1ZplGkXdajAo=; b=LfVyU3F1qXDstRZRuo2UcYNP4rRcBsKNSK8skrYYXZ4VmEzn4boBJHMuub56pM/fQiLTjktM/KU9sSv7c2zYe/61urh8S3AvxKW9ctwC5OhvNuteLE+7Ua8E6cBdHoV8hb9aRBAgv+y1CuCjENqRUNdi0O+HCWUddFzqRJZcDHw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 163586059340333.306227892820175; Tue, 2 Nov 2021 06:43:13 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id u18so33416992wrg.5 for ; Tue, 02 Nov 2021 06:43:12 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id o20sm2493624wmq.47.2021.11.02.06.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+/Q/nSxAuHlXOdojOuByNBLGz7XClzU1ZplGkXdajAo=; b=GZuBFBhQl/iJ2xjJfGP0496QSXIwBGCftp52KiNCfLnNo3vRKhaeDVtkywWcPtW6Kl Ddv+ImPCiKsgxuyQu89+BMfBbhenG3DJzMPWVZ64JBKiaGx7fNAlMUWoYWuaNZh1bAH9 D/bd5XTRTAn38on8aJZtcSwB8UGnh3Ht8WtQtdYyWONCX/g9znAtctLvx7JbNqUBrzHd mopmC5hGYilkQ+ZLGJAflxH1cfN1n8St2XH9IV2bAtQ+akzYchENbnelccAX0LY3p6Ch MuE0H14Dm7m+AR7SaQ0r+Lfesz/oizyK5JpdmjabApVlsVfvXcJe7Nknaa+VJBbiVlYY DxdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+/Q/nSxAuHlXOdojOuByNBLGz7XClzU1ZplGkXdajAo=; b=PDo/YQw8JUNSUrkIq958ilbSvmd/7Nt9WNuWolqBC8nWg5NWxZHN69fFFILnmbHfkQ 7MiaCc0GNpUemRFOMzM5x3WO26lhcOFzMTSbYYNfyXjfKfuv5ETCLJpxtYykoRtuPahl SzaJ9z207MgqUvVlyO3QM05fR1N6eQ5sp3oCJ8yUPHcYbLdDGN3DDtGHefeEhc8t1SHa cFy+Z/ffEn3scBzBANlW4hjg4RduG+MsOBHrYFk7X+hLvOappgy1jdKHb5XgcYzRHX0c 7joGQg24x/QsC2Kh3H9C9GXRdHVIxwliKY8tQcRYCtSGPNc4Im/yytfwy1AHuAhI+ogW MCOw== X-Gm-Message-State: AOAM530Tw9i5QsOINXshCc4u+tQJwYJTAIGV8J63EhtF6NAZP5N2fRIv L/tWX1HjwD4xbSA4Cy7ZHhM= X-Google-Smtp-Source: ABdhPJwRdJP8UPFKxxTJ3DGMMfslstX2hCU/194kof1zRYCVVWCS7/moVreSKjhdfSXqTVhFqjt0mw== X-Received: by 2002:a5d:4d81:: with SMTP id b1mr4720753wru.366.1635860591632; Tue, 02 Nov 2021 06:43:11 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 06/41] target/mips: Adjust style in msa_translate_init() Date: Tue, 2 Nov 2021 14:42:05 +0100 Message-Id: <20211102134240.3036524-7-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860595533100001 While the first 'off' variable assignment is unused, it helps to better understand the code logic. Move the assignation where it would have been used so it is easier to compare the MSA registers based on FPU ones versus the MSA specific registers. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211023214803.522078-34-f4bug@amsat.org> --- target/mips/tcg/msa_translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3ef912da6b8..3aa15e147c2 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -280,13 +280,15 @@ void msa_translate_init(void) int i; =20 for (i =3D 0; i < 32; i++) { - int off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); + int off; =20 /* * The MSA vector registers are mapped on the * scalar floating-point unit (FPU) registers. */ + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[0]); msa_wr_d[i * 2] =3D fpu_f64[i]; + off =3D offsetof(CPUMIPSState, active_fpu.fpr[i].wr.d[1]); msa_wr_d[i * 2 + 1] =3D tcg_global_mem_new_i64(cpu_env, off, msaregnames[i * 2 + 1= ]); --=20 2.31.1