From nobody Tue Feb 10 13:17:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) client-ip=209.85.221.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860584; cv=none; d=zohomail.com; s=zohoarc; b=b9Aef5EBqmBeiCNAgXW69Bfbsgar2D+zIAOOMTPbQ8T0MgOMLc1FBbTXGFF2JjxG6B2YdNmki4iOkWmZbeu6mMKN9CX/zrHZQEwHhyCe73wfrRgWme+0k/K9zZ+JJVfDy8hRs1o5qB6OJD1B6da60OHP3rlObBLR/E0fRixxRV8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860584; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9kD5AmlRz7msVGq9htNUWCOsA1AE3Dw4ZHbCNXBATxA=; b=P8V1PHr6zwbh9eylABp8k3uA34AVqANDZsoGKiICvE+pZn7i84glejk7XUg5gvqYAmo9CUXRgFcp+bMVTUFH9/ppAyejiVhF8ZSh+kLHbXYIzyTsGbOwo4uCzkcisEmYhv7EVHUEjsH2mdK2O22Eeoc8uIymZQWgabKqHV6aQ3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.zohomail.com with SMTPS id 1635860584167976.5249268699644; Tue, 2 Nov 2021 06:43:04 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id d24so2814232wra.0 for ; Tue, 02 Nov 2021 06:43:03 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id x1sm2220087wru.40.2021.11.02.06.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9kD5AmlRz7msVGq9htNUWCOsA1AE3Dw4ZHbCNXBATxA=; b=Gem0gLsRrbCrAmqyoA/mxgug2PsrSsOSAQ9msDFD9yT5lilFq1NQFHdsMTIxALAwZq fpCXuiVxspsYKwsvRmyhitdTM/2cXRX68WXuoUJUjClttHlTXNe6wEyFaqUzL/wfYGwv htScOn+J93pjJbvuxTVi0bRL0pA26azJCE9GBEWqlseHaXVvyANAd9i8RJBsEyn3UvgW UgYGA0GYWgHDpANCEEA+2w2iJAv5346uG93uSK0HQZInUUv+HzEVg/cK/szNRQWxD9WI O0v7d2CZp7G51wgnNVYUFbz4Ge80sln9t7xhBirdTH0n/WJGTcGKJDA6Ldh40Ch73331 wgYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9kD5AmlRz7msVGq9htNUWCOsA1AE3Dw4ZHbCNXBATxA=; b=cabmaUhONQOCzvMS9betiOkaSlzWp1l1E5k6ouRepFhbkyFSG2fe31pxQeLhL0HCIE 9NJV4lU3FSxhoFmBAgRHaNsd7CFQP3hFoHl7XWQr3nIClwjAvCFOatlqhNlhHy27Uxnx IrHZl91zLXSYoLxwu9OUSFF5cQvE4vbNuySUa0Ko0zXq7WjEVDjiO320gdM5Nyda2kLv EYxgfJ29E3Id1yTmDcGf3NTm9/I8wPTx3a039tJEKXWuf3+loP2NAUtR/ObfAYH6XSif fo/64/x7hxlUN5yVXy8YxsShsvniltzNmuCwIw4T1laS9YMz7rU3c4BRR1zU85ql0hZv WVww== X-Gm-Message-State: AOAM532rDNkAN/n2s2699ScpNoI13TjNr4b4sBV8PY4epuu6K3ejYH6l VEcdIDFrveQ4n7RNH93VNiY= X-Google-Smtp-Source: ABdhPJw2cKgieGqnZs0sHlwc8e3ugR3ohEzw6JNxVhM9iI1NI+gzdMmEQapR7eC4VWZHiguMa+r1dg== X-Received: by 2002:a05:6000:18ad:: with SMTP id b13mr12944591wri.195.1635860582353; Tue, 02 Nov 2021 06:43:02 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 04/41] target/mips: Fix MSA MADDV.B opcode Date: Tue, 2 Nov 2021 14:42:03 +0100 Message-Id: <20211102134240.3036524-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860586358100001 The result of the 'Vector Multiply and Add' opcode is incorrect with Byte vectors. Probably due to a copy/paste error, commit 7a7a162adde mistakenly used the $wt (target register) instead of $wd (destination register) as first operand. Fix that. Cc: Aleksandar Rikalo Fixes: 7a7a162adde ("target/mips: msa: Split helpers for MADDV.") Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-2-f4bug@amsat.org> --- target/mips/tcg/msa_helper.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index e40c1b70575..d978909527f 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -3231,22 +3231,22 @@ void helper_msa_maddv_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 - pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwt->b[0], pws->b[0], pwt->b[0]= ); - pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwt->b[1], pws->b[1], pwt->b[1]= ); - pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwt->b[2], pws->b[2], pwt->b[2]= ); - pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwt->b[3], pws->b[3], pwt->b[3]= ); - pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwt->b[4], pws->b[4], pwt->b[4]= ); - pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwt->b[5], pws->b[5], pwt->b[5]= ); - pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwt->b[6], pws->b[6], pwt->b[6]= ); - pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwt->b[7], pws->b[7], pwt->b[7]= ); - pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwt->b[8], pws->b[8], pwt->b[8]= ); - pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwt->b[9], pws->b[9], pwt->b[9]= ); - pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwt->b[10], pws->b[10], pwt->b[10= ]); - pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwt->b[11], pws->b[11], pwt->b[11= ]); - pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwt->b[12], pws->b[12], pwt->b[12= ]); - pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwt->b[13], pws->b[13], pwt->b[13= ]); - pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwt->b[14], pws->b[14], pwt->b[14= ]); - pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwt->b[15], pws->b[15], pwt->b[15= ]); + pwd->b[0] =3D msa_maddv_df(DF_BYTE, pwd->b[0], pws->b[0], pwt->b[0]= ); + pwd->b[1] =3D msa_maddv_df(DF_BYTE, pwd->b[1], pws->b[1], pwt->b[1]= ); + pwd->b[2] =3D msa_maddv_df(DF_BYTE, pwd->b[2], pws->b[2], pwt->b[2]= ); + pwd->b[3] =3D msa_maddv_df(DF_BYTE, pwd->b[3], pws->b[3], pwt->b[3]= ); + pwd->b[4] =3D msa_maddv_df(DF_BYTE, pwd->b[4], pws->b[4], pwt->b[4]= ); + pwd->b[5] =3D msa_maddv_df(DF_BYTE, pwd->b[5], pws->b[5], pwt->b[5]= ); + pwd->b[6] =3D msa_maddv_df(DF_BYTE, pwd->b[6], pws->b[6], pwt->b[6]= ); + pwd->b[7] =3D msa_maddv_df(DF_BYTE, pwd->b[7], pws->b[7], pwt->b[7]= ); + pwd->b[8] =3D msa_maddv_df(DF_BYTE, pwd->b[8], pws->b[8], pwt->b[8]= ); + pwd->b[9] =3D msa_maddv_df(DF_BYTE, pwd->b[9], pws->b[9], pwt->b[9]= ); + pwd->b[10] =3D msa_maddv_df(DF_BYTE, pwd->b[10], pws->b[10], pwt->b[10= ]); + pwd->b[11] =3D msa_maddv_df(DF_BYTE, pwd->b[11], pws->b[11], pwt->b[11= ]); + pwd->b[12] =3D msa_maddv_df(DF_BYTE, pwd->b[12], pws->b[12], pwt->b[12= ]); + pwd->b[13] =3D msa_maddv_df(DF_BYTE, pwd->b[13], pws->b[13], pwt->b[13= ]); + pwd->b[14] =3D msa_maddv_df(DF_BYTE, pwd->b[14], pws->b[14], pwt->b[14= ]); + pwd->b[15] =3D msa_maddv_df(DF_BYTE, pwd->b[15], pws->b[15], pwt->b[15= ]); } =20 void helper_msa_maddv_h(CPUMIPSState *env, --=20 2.31.1