From nobody Tue Feb 10 11:14:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) client-ip=209.85.128.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860741; cv=none; d=zohomail.com; s=zohoarc; b=Q0DkKd4ymiHrLtXzAzU1MPZgyh3NCos602E+tgVLlIeCJAeXqMjxa12gPzVX1yRvcq8l6QfiswH3ZLFPQqvuTtt9uTNoCOyFI6OJH8hfg4R6vXSqOUoFqTeuHhiGnufzlydByS1rrt/DzhgYapVA42aR2FwAUzt5Uez0a85Dyic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860741; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q3s3GZhFWrGY7gjToiSxwFx4tiZft1tygbK630ikQq4=; b=EBXGLqxPSpDf7Meen0podJWmrY6PFou2RZ9cQVzfE9q4o2sK1Vj8lnkqw563beLjbIJ16lBsQZ4RW7REGKv4BuU02NT5cy8THka7kpwuaosih/v36Zyq85VXw/tEl7/pWo7d9OymRIZ7/R3Yl3dn+n+ZszdavH4YTMDsLYJQWIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.zohomail.com with SMTPS id 1635860741810393.4401137561496; Tue, 2 Nov 2021 06:45:41 -0700 (PDT) Received: by mail-wm1-f54.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso2158010wmf.0 for ; Tue, 02 Nov 2021 06:45:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id n4sm1914383wri.41.2021.11.02.06.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q3s3GZhFWrGY7gjToiSxwFx4tiZft1tygbK630ikQq4=; b=c7Qxh2W/gvJC+ZMbM9AIK5MB27JSopJ7oBjsjfZkFk6diZvgJxApW9r34awjtXzalu 96lFEhEzysywCG6mhgc++D2QeBFrF8+tzQdZrcLtJ63HgrzD297KIu5fil0cfwXqRaZW CTZj0rdMtNYFPU2da273WapIP0MgRTyhpPQMKoeVI8hr+DLkChyFFFxUHXd84PIcY8Pu GjOqJ+ZNRGUdKbg8iskGU0SXJy2idiw6CoFBFl4uBxvh1v23GxaiyOPJJIs6SKIgnlMC iCOqt3n321TT8MYiqxb2/M7eaNRdOjTAEHbKp6j5LdSdIqO0zR7vsDSx4xCe6gQml1Xv 9KjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Q3s3GZhFWrGY7gjToiSxwFx4tiZft1tygbK630ikQq4=; b=PqkTWrXLJFpJ6bKz46LZGrjukYFrE1cHomSM3ujTZrKj+x2jyJkNO2Ep5OP3RLvR6N vqIKFpgn+29ywoXgdAF4Unowe3z15oPjIctj/UphsAMv9fKkPAa01KLTi8Mxs1PGzDMh KEH1YfcBtQkCYCFNuNC3G74CPIVXRlMkbsfNu18SsY6r7UxJ0tLvMauGgQ3mSBGSIVTp biizK1TuYrwcvAcjbvM3v9XOGRZBMkh/fqowEhhp389csyzfupGUW5+zABWyOIRGhjKT 4fbpHzx0Vu37KWldMqte3L2NB8jJEIuLYXvyNtISpcHICoeLiN/z/oLhaA7ZAZ4PJDvc rxvw== X-Gm-Message-State: AOAM533/eKMm8Njo30Qu+9/Pyp9Z9v08EPuuSQeFBORGvgwm1wYWCqNW MlrcD6iUo5oHkbHm1Htxxm0= X-Google-Smtp-Source: ABdhPJxVhrZr5cPgss8IK5GR/TPqyAJTlEqc1/8SCbxMCmgQKEzFEFSTXZ5/QG+ZeLOfw2wjjw7h7A== X-Received: by 2002:a05:600c:35d0:: with SMTP id r16mr6644516wmq.24.1635860740035; Tue, 02 Nov 2021 06:45:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , BALATON Zoltan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 37/41] usb/uhci: Misc clean up Date: Tue, 2 Nov 2021 14:42:36 +0100 Message-Id: <20211102134240.3036524-38-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860743000100001 From: BALATON Zoltan Fix a comment for coding style so subsequent patch will not get checkpatch error and simplify and shorten uhci_update_irq(). Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-uhci.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 0cb02a64321..c557566ec26 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -290,7 +290,7 @@ static UHCIAsync *uhci_async_find_td(UHCIState *s, uint= 32_t td_addr) =20 static void uhci_update_irq(UHCIState *s) { - int level; + int level =3D 0; if (((s->status2 & 1) && (s->intr & (1 << 2))) || ((s->status2 & 2) && (s->intr & (1 << 3))) || ((s->status & UHCI_STS_USBERR) && (s->intr & (1 << 0))) || @@ -298,8 +298,6 @@ static void uhci_update_irq(UHCIState *s) (s->status & UHCI_STS_HSERR) || (s->status & UHCI_STS_HCPERR)) { level =3D 1; - } else { - level =3D 0; } pci_set_irq(&s->dev, level); } @@ -1170,8 +1168,7 @@ void usb_uhci_common_realize(PCIDevice *dev, Error **= errp) =20 pci_conf[PCI_CLASS_PROG] =3D 0x00; /* TODO: reset value should be 0. */ - pci_conf[USB_SBRN] =3D USB_RELEASE_1; // release number - + pci_conf[USB_SBRN] =3D USB_RELEASE_1; /* release number */ pci_config_set_interrupt_pin(pci_conf, u->info.irq_pin + 1); =20 if (s->masterbus) { --=20 2.31.1