From nobody Tue Feb 10 09:40:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) client-ip=209.85.128.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860708; cv=none; d=zohomail.com; s=zohoarc; b=UV1Vg6cmm6KXpIQ7+xgwxikhWwWqsnureTWtK0SVG5WGRPGAA9sMfmNul91lSst/qL734ERDLUaX4MLYV3qaB7QFuw7HT/wDWgzm4UkWxPXMpIRPwD5WAW8hGZKosD4y6RHTBsJpXsL4g7n778tThuWdxD6c2AJKxbLJtn69mCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860708; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GUGgh2ZiJsyEFdQJYG8F4ULR7JtEFx+5xt/bY9ZTqpU=; b=hPk1Fsw0TDilIffbBPplQJ79shOJFW1wSlnVMUhfN3DY1pHkGYRwlO0GrCQjf1JsugGczI+Ciotu1tu+PHVX9S5HTCr2SZLZ5vn6pEJI/iyKIxljrTmbsr0Bbuy9U1xCx1MPVak+t+bjnUycoBPgh77FXIPhMMRPvIf5vIVBkBM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.zohomail.com with SMTPS id 1635860708110485.32969579701046; Tue, 2 Nov 2021 06:45:08 -0700 (PDT) Received: by mail-wm1-f51.google.com with SMTP id 133so6468561wme.0 for ; Tue, 02 Nov 2021 06:45:07 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id h14sm2878687wmq.34.2021.11.02.06.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:45:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GUGgh2ZiJsyEFdQJYG8F4ULR7JtEFx+5xt/bY9ZTqpU=; b=d9rL1/+E6ljvYmBJGePgDy6gZN+WUK9uCPEELKAWoN5IbjdWkjGhH101/zrol5hB0D +rmxHIxcWd6Fgb40S1wLt/NOH3Kch7FAqFdpJwdsRSkKJXu01ftGfNpvCErI5TmXxaHs oSKnWK9KLjT/rnoV9Ly8ok36R0XihHp8mTBx775vT2sLGpyIahgf5cXqKCKJjQctEsmO 7Oc4L6uEXTNGINxQR2ROqv8TrSe/x2SZnYA2IWyRk5AfSyz9ljoXOWJfjc8Ago5l3H2V 7nAgXsvUJz3Zif7JqhsTa6XDEv/R8RveMg4pnLV/A1VDhCezYBM6C2AstohSu65Xqfyy BcoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GUGgh2ZiJsyEFdQJYG8F4ULR7JtEFx+5xt/bY9ZTqpU=; b=TZ0iMt42PocdKXfqktELTW4d8+JiajMB4cMTgin7eqtmS6iyDc7OAbKlKFa2sLMLOd ka05cvCSECb8Md3Bdb0Pds6OiSDpD0EJRtPRMcOSMhh3tnZrQvnRQqf5D6wnUBa5fwEP PWXa16kvhG8Vaq7MDYU9hQDRa15mPLNjRNyl0W23aaYnFLUyNTd30dpEZTw2x7uNwc11 y7QW3HaBEDuw+i0XHG+BHx8DzAwZ2bmcVSDx3PBgDR/OuhcfPelrJGeDDXL5o5IgQ0ej zKif0qvwOS57rNUuCW79anE6oksspO51XTTTcb50vtc81t9D9LLQLdNQwVgqHVU5oMVp 3okg== X-Gm-Message-State: AOAM532VEe9gYbWJa/Zy3S5NuQlbMVHUSMxHRY6Jk9p8UWbuqUdB09gj P7rmOjAB6Jtfv8grcsJLP4Q= X-Google-Smtp-Source: ABdhPJzzv5q/MpCKoEuD1HAdFi30Eyg3bjXaKS8LukJDuxWyCju+icXK7j2OVkjORCbIEjW/OGe1hA== X-Received: by 2002:a05:600c:24d:: with SMTP id 13mr6752647wmj.156.1635860706389; Tue, 02 Nov 2021 06:45:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 30/41] target/mips: Convert MSA MOVE.V opcode to decodetree Date: Tue, 2 Nov 2021 14:42:29 +0100 Message-Id: <20211102134240.3036524-31-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860710265100003 Convert the MOVE.V opcode (Vector Move) to decodetree. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-28-f4bug@amsat.org> --- target/mips/tcg/msa.decode | 7 ++++++- target/mips/tcg/msa_translate.c | 19 ++++++++++++++----- 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 9aac6808fc5..d1b6a63b526 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -19,6 +19,7 @@ &msa_i df wd ws sa &msa_bit df wd ws m &msa_elm_df df wd ws n +&msa_elm wd ws =20 %elm_df 16:6 !function=3Delm_df %elm_n 16:6 !function=3Delm_n @@ -33,6 +34,7 @@ @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz @elm_df ...... .... ...... ws:5 wd:5 ...... &msa_elm_df df= =3D%elm_df n=3D%elm_n +@elm ...... .......... ws:5 wd:5 ...... &msa_elm @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... . ws:5 wd:5 ...... &msa_r wt=3D0 = df=3D%2r_df_w @@ -167,7 +169,10 @@ BNZ 010001 111 .. ..... ..............= .. @bz =20 SLDI 011110 0000 ...... ..... ..... 011001 @elm_df SPLATI 011110 0001 ...... ..... ..... 011001 @elm_df - COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + { + MOVE_V 011110 0010111110 ..... ..... 011001 @elm + COPY_S 011110 0010 ...... ..... ..... 011001 @elm_df + } COPY_U 011110 0011 ...... ..... ..... 011001 @elm_df INSERT 011110 0100 ...... ..... ..... 011001 @elm_df INSVE 011110 0101 ...... ..... ..... 011001 @elm_df diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 6a034831efd..ea572413ed6 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -46,7 +46,6 @@ enum { /* ELM instructions df(bits 21..16) =3D _b, _h, _w, _d */ OPC_CTCMSA =3D (0x0 << 22) | (0x3E << 16) | OPC_MSA_ELM, OPC_CFCMSA =3D (0x1 << 22) | (0x3E << 16) | OPC_MSA_ELM, - OPC_MOVE_V =3D (0x2 << 22) | (0x3E << 16) | OPC_MSA_ELM, }; =20 static const char msaregnames[][6] =3D { @@ -533,6 +532,19 @@ TRANS_DF_iii_b(HADD_U, trans_msa_3r, gen_helper_msa= _hadd_u); TRANS_DF_iii_b(HSUB_S, trans_msa_3r, gen_helper_msa_hsub_s); TRANS_DF_iii_b(HSUB_U, trans_msa_3r, gen_helper_msa_hsub_u); =20 +static bool trans_MOVE_V(DisasContext *ctx, arg_msa_elm *a) +{ + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_move_v(cpu_env, + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws)); + + return true; +} + static void gen_msa_elm_3e(DisasContext *ctx) { #define MASK_MSA_ELM_DF3E(op) (MASK_MSA_MINOR(op) | (op & (0x3FF << 16))) @@ -551,9 +563,6 @@ static void gen_msa_elm_3e(DisasContext *ctx) gen_helper_msa_cfcmsa(telm, cpu_env, tsr); gen_store_gpr(telm, dest); break; - case OPC_MOVE_V: - gen_helper_msa_move_v(cpu_env, tdt, tsr); - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -654,7 +663,7 @@ static void gen_msa_elm(DisasContext *ctx) uint8_t dfn =3D (ctx->opcode >> 16) & 0x3f; =20 if (dfn =3D=3D 0x3E) { - /* CTCMSA, CFCMSA, MOVE.V */ + /* CTCMSA, CFCMSA */ gen_msa_elm_3e(ctx); return; } else { --=20 2.31.1