From nobody Tue Feb 10 09:40:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860673; cv=none; d=zohomail.com; s=zohoarc; b=OPj4q2/TNI02gFy+/p0CPlNc3kcUKRGupuq9fFVDhE4ZKNCI+jWz2zj4/8K3IbJOxyU7A/REts+5qy+j+cI5aKi1SigruE0CiGGBBJu31vltBrvqsJ0Ql2iSvn4frdU1uux1GIAptclVwBPH4Ug63UN80dP/cpRmycQm6JYTIRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860673; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MGPPdDv44Azgq0M48n6usoTw5HxNRsR6KRQigT+f3mI=; b=L8fMp3AJvTmvHFzF9BVO/2GilAA/KiIB5ShnmQlHOV8eMWsSQ/BdZCbcOfPPZrNaFsKDAS3Y/aLtJW4+JDTRYqBpjydzfEDdaUC2naFQKKJffXQy+hZ7s3lGfjC7zM2UY8/DdHqjgIqlot4vFtjjn7QD5SryLVjEPTGRCrMg48k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1635860673695665.9676299259515; Tue, 2 Nov 2021 06:44:33 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id u18so33423164wrg.5 for ; Tue, 02 Nov 2021 06:44:33 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id 9sm11535068wry.0.2021.11.02.06.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MGPPdDv44Azgq0M48n6usoTw5HxNRsR6KRQigT+f3mI=; b=HqR4nGClorEzF4G0S21wo3DF6CJb6BATo46WN49PAZVg4adTOSaEW+6jf1opr6aRYF yb4es8bDLAWfU2asW/Z2uabB5u3Z1wCY7PcroF51rJH157FkvY+3yNOrFz7OCY7YpFTs 4okjtsW7DuWaO4CEjaF58YX8EgZnyzuWvutXmRnoK/t37iq/fUZBEa3vVX4PNlcVQFac zQe+6IArCn1BwkRAlJTEPrltYtm0dV8LICQb1oO/qMo/3Oqx6D/mO6KpLWMQEAmxUlOU wcHMppeyEHB1hl0knxmDmKq4u1vXPBihlhZRuk1kt9+k1Vbs+2QLMB8xWnxbt9X5PAYi BmMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MGPPdDv44Azgq0M48n6usoTw5HxNRsR6KRQigT+f3mI=; b=z9qF0TiwDNBaq0pi9dqn23lgILDuFbMykRpt2Ki3Sz46XBtE9LNGiUZCSeEkYh6tHv XZY8prROHuq3pC19sShcz0xRqzCK6Mo43aWQ0mb6PvC9v77xdEUuYmPNbuz+3Qze9aa8 OLsXHTf2U5PMp/IYtBAwBKvApupzY2gauDQRfdGGt6/1rdSWWbLTAzNHv4k0ae6a6onT 74RYFi1dvtw0bhGjY0pTnRy9L2hXk5nwiuYIqCdpMiXyZGJ+oJiwzeN6nTjrkzJB0cMV UTJWjgiI3UkQbFTmYUSTIJ0ilVXbu9BMWOtbq2LKdJcQNyVzJ0gVLn2CbnuRz1Kya3rl J1+A== X-Gm-Message-State: AOAM5327jYXZyqBMc5rkVSsdx2vXXxYRSHIN+0oXjddvTtwEmG/SZNKx 1hXFPg6nnOglDbP2aCOtFTTsxGkkLcw= X-Google-Smtp-Source: ABdhPJy8IoR2ehSqd1fwR3R+PDwsyUwtiHx2DKMBCj3iv2rhxYLeth98L3jzi3OcfSgQAj/2b4jrxA== X-Received: by 2002:a5d:4411:: with SMTP id z17mr27126253wrq.59.1635860671958; Tue, 02 Nov 2021 06:44:31 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 23/41] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) Date: Tue, 2 Nov 2021 14:42:22 +0100 Message-Id: <20211102134240.3036524-24-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860674048100001 Convert 3-register operations to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Note, the format definition could be named @3rf_b (for 3R with a df field BYTE-based) but since the instruction class is named '3R', we simply call the format @3r to ease reviewing the msa.decode file. However we directly call the trans_msa_3rf() function, which handles the BYTE-based df field. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-21-f4bug@amsat.org> --- target/mips/tcg/msa.decode | 6 ++++++ target/mips/tcg/msa_translate.c | 17 +++++------------ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 1d6ada4c142..4b14acce26f 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -32,6 +32,7 @@ @vec ...... ..... wt:5 ws:5 wd:5 ...... &msa_r df=3D0 @2r ...... ........ df:2 ws:5 wd:5 ...... &msa_r wt=3D0 @2rf ...... ......... . ws:5 wd:5 ...... &msa_r wt=3D0 = df=3D%2r_df_w +@3r ...... ... df:2 wt:5 ws:5 wd:5 ...... &msa_r @3rf_h ...... .... . wt:5 ws:5 wd:5 ...... &msa_r df=3D%3= r_df_h @3rf_w ...... .... . wt:5 ws:5 wd:5 ...... &msa_r df=3D%3= r_df_w @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_i @@ -88,6 +89,11 @@ BNZ 010001 111 .. ..... ................= @bz SRARI 011110 010 ....... ..... ..... 001010 @bit SRLRI 011110 011 ....... ..... ..... 001010 @bit =20 + SLD 011110 000 .. ..... ..... ..... 010100 @3r + SPLAT 011110 001 .. ..... ..... ..... 010100 @3r + + VSHF 011110 000 .. ..... ..... ..... 010101 @3r + FCAF 011110 0000 . ..... ..... ..... 011010 @3rf_w FCUN 011110 0001 . ..... ..... ..... 011010 @3rf_w FCEQ 011110 0010 . ..... ..... ..... 011010 @3rf_w diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 26d05a87c89..ddc0bd08ddf 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -58,15 +58,12 @@ enum { OPC_SUBS_S_df =3D (0x0 << 23) | OPC_MSA_3R_11, OPC_MULV_df =3D (0x0 << 23) | OPC_MSA_3R_12, OPC_DOTP_S_df =3D (0x0 << 23) | OPC_MSA_3R_13, - OPC_SLD_df =3D (0x0 << 23) | OPC_MSA_3R_14, - OPC_VSHF_df =3D (0x0 << 23) | OPC_MSA_3R_15, OPC_SRA_df =3D (0x1 << 23) | OPC_MSA_3R_0D, OPC_SUBV_df =3D (0x1 << 23) | OPC_MSA_3R_0E, OPC_ADDS_A_df =3D (0x1 << 23) | OPC_MSA_3R_10, OPC_SUBS_U_df =3D (0x1 << 23) | OPC_MSA_3R_11, OPC_MADDV_df =3D (0x1 << 23) | OPC_MSA_3R_12, OPC_DOTP_U_df =3D (0x1 << 23) | OPC_MSA_3R_13, - OPC_SPLAT_df =3D (0x1 << 23) | OPC_MSA_3R_14, OPC_SRAR_df =3D (0x1 << 23) | OPC_MSA_3R_15, OPC_SRL_df =3D (0x2 << 23) | OPC_MSA_3R_0D, OPC_MAX_S_df =3D (0x2 << 23) | OPC_MSA_3R_0E, @@ -505,6 +502,11 @@ TRANS(BMNZ_V, trans_msa_3r, gen_helper_msa= _bmnz_v); TRANS(BMZ_V, trans_msa_3r, gen_helper_msa_bmz_v); TRANS(BSEL_V, trans_msa_3r, gen_helper_msa_bsel_v); =20 +TRANS(SLD, trans_msa_3rf, gen_helper_msa_sld_df); +TRANS(SPLAT, trans_msa_3rf, gen_helper_msa_splat_df); + +TRANS(VSHF, trans_msa_3rf, gen_helper_msa_vshf_df); + static void gen_msa_3r(DisasContext *ctx) { #define MASK_MSA_3R(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) @@ -1255,12 +1257,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SLD_df: - gen_helper_msa_sld_df(cpu_env, tdf, twd, tws, twt); - break; - case OPC_VSHF_df: - gen_helper_msa_vshf_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBV_df: switch (df) { case DF_BYTE: @@ -1293,9 +1289,6 @@ static void gen_msa_3r(DisasContext *ctx) break; } break; - case OPC_SPLAT_df: - gen_helper_msa_splat_df(cpu_env, tdf, twd, tws, twt); - break; case OPC_SUBSUS_U_df: switch (df) { case DF_BYTE: --=20 2.31.1