From nobody Tue Feb 10 10:03:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860631; cv=none; d=zohomail.com; s=zohoarc; b=bJPiyilnCuUiqoOFCCmF/dY40rIhiUBcPvk289B1khUixYNPuq/xHN3eAaa7Cc2oY9w0THSqS/ucRhiYdsS/YZ5XsTRMEFOULJNjY7Hxpe5hJ2yCCCpKNHR4vXCd3x/WvU59AdyHOi9hN4u8+TqvbqPGw5U3Bj5bbr8BGXdzFPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860631; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ipjpFsMVBwISznamvW72G3eAUzuzbTQFyEPgUOroDE0=; b=GEzR7TdeSF0VV3psRS5nrWluCD7SZnR3OG9CLU4FUSvE9hIez7bKEdRpwT8MyiEXJIgfsY8eiD6A8PNR5Esz+cHQYmUnAFpb+hi8vEbb5jwfsxKIxc898JgR4wuwtLVxNUop99IVDXph8AK1Yl3HAoKe2UCwlO/gYaeTHKGTnZM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1635860631310201.1564696614679; Tue, 2 Nov 2021 06:43:51 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id d5so18096975wrc.1 for ; Tue, 02 Nov 2021 06:43:50 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id e12sm1803969wrq.20.2021.11.02.06.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ipjpFsMVBwISznamvW72G3eAUzuzbTQFyEPgUOroDE0=; b=fvIOkjENbuBv/6tUBDs2Q7772a4ImEcSzaJU5xI4w5hNGyyRqhMs9tY4MP9QGWSYlu rLxt6jtd0VsDngiPMe63JUs0ulHRVtxwB+Nj0IshvdF41geFZ32XTprrfL+6rFnbxGas AAhBdtjKfaJoi2rKAYSu9Ze3in95JD7+8SuakSjC0U+5EPi50vn5uiPuGBcgqzShw+Fd XbuURIfgIcu/6jWwUdpQO7Gu1uFFmKWxBc2LU4a6rCn1p84wDJDlaz7hEnkqcswFigOy T4K1HRcnVaJNLxAmb/vyYdtwwakgFG95GYc+Kh8j681Eez57HIgY3QOJZCtpZMcNwsFR W6cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ipjpFsMVBwISznamvW72G3eAUzuzbTQFyEPgUOroDE0=; b=1mDHXy9JPwSZwaY4M6ii03IMQG3lU8Rk3Nh0PiwcrJiLsL7W4JPXePv7V/UsOs0e0k QBQ5vbelqLwcZ5Em635a+gpGk9u0aWXyq/SNNo+SutMM/5QkbpD9wFeUWy1rTS6RQ7Gs 9VPFEdmPIOmYEOvcM7A+eNHSzrEwFWQj1tFjHTxtoFUCeNAGkOSRqwTJFrKiqrzZrVf2 HC+ibhSrMRgLnMQZukVy7emCFwLzREyAAs6NnVvTXEDpdJwkQLNVu69Gh4MiMObTuWGG URBKwD4FDI3Dc++QgVnhk2Ip5BKxHv3ZSfPvH54SAxVhxyLcGD8JXiJNDdTOXy0QbdDN fkPg== X-Gm-Message-State: AOAM533ocJv9QM98r7wtKo1FLbA43vu97skmuQB03WRZcVe1J0yF5wh9 nCKCXCNM2dTdct1UtQeqymvWQSG7es0= X-Google-Smtp-Source: ABdhPJwkI7pIEaAYsv6ZHWGjOmUNNgRhBeNYQTz2K3ExM6yXphxQ0MCRXpmpx41NQcRaqSEzia7oBQ== X-Received: by 2002:a05:6000:1449:: with SMTP id v9mr48068418wrx.137.1635860629616; Tue, 02 Nov 2021 06:43:49 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 14/41] target/mips: Convert MSA SHF opcode to decodetree Date: Tue, 2 Nov 2021 14:42:13 +0100 Message-Id: <20211102134240.3036524-15-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860632459100001 Convert the SHF opcode (Immediate Set Shuffle Elements) to decodetree. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-12-f4bug@amsat.org> --- target/mips/tcg/msa.decode | 3 +++ target/mips/tcg/msa_translate.c | 36 +++++++++++++++++---------------- 2 files changed, 22 insertions(+), 17 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 3d6c6faf688..8e887f54ad5 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -26,6 +26,7 @@ @bz ...... ... df:2 wt:5 sa:16 &msa_bz @u5 ...... ... df:2 sa:5 ws:5 wd:5 ...... &msa_i @s5 ...... ... df:2 sa:s5 ws:5 wd:5 ...... &msa_i +@i8_df ...... df:2 sa:s8 ws:5 wd:5 ...... &msa_i @ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldi @bit ...... ... ....... ws:5 wd:5 ...... &msa_bit df=3D= %bit_df m=3D%bit_m =20 @@ -38,6 +39,8 @@ BZ 010001 110 .. ..... ................ = @bz BNZ 010001 111 .. ..... ................ @bz =20 { + SHF 011110 .. ........ ..... ..... 000010 @i8_df + ADDVI 011110 000 .. ..... ..... ..... 000110 @u5 SUBVI 011110 001 .. ..... ..... ..... 000110 @u5 MAXI_S 011110 010 .. ..... ..... ..... 000110 @s5 diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 9c1a24eb251..1b1d88ac646 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -60,13 +60,10 @@ enum { /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, OPC_BMNZI_B =3D (0x0 << 24) | OPC_MSA_I8_01, - OPC_SHF_B =3D (0x0 << 24) | OPC_MSA_I8_02, OPC_ORI_B =3D (0x1 << 24) | OPC_MSA_I8_00, OPC_BMZI_B =3D (0x1 << 24) | OPC_MSA_I8_01, - OPC_SHF_H =3D (0x1 << 24) | OPC_MSA_I8_02, OPC_NORI_B =3D (0x2 << 24) | OPC_MSA_I8_00, OPC_BSELI_B =3D (0x2 << 24) | OPC_MSA_I8_01, - OPC_SHF_W =3D (0x2 << 24) | OPC_MSA_I8_02, OPC_XORI_B =3D (0x3 << 24) | OPC_MSA_I8_00, =20 /* VEC/2R/2RF instruction */ @@ -465,20 +462,6 @@ static void gen_msa_i8(DisasContext *ctx) case OPC_BSELI_B: gen_helper_msa_bseli_b(cpu_env, twd, tws, ti8); break; - case OPC_SHF_B: - case OPC_SHF_H: - case OPC_SHF_W: - { - uint8_t df =3D (ctx->opcode >> 24) & 0x3; - if (df =3D=3D DF_DOUBLE) { - gen_reserved_instruction(ctx); - } else { - TCGv_i32 tdf =3D tcg_const_i32(df); - gen_helper_msa_shf_df(cpu_env, tdf, twd, tws, ti8); - tcg_temp_free_i32(tdf); - } - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -490,6 +473,25 @@ static void gen_msa_i8(DisasContext *ctx) tcg_temp_free_i32(ti8); } =20 +static bool trans_SHF(DisasContext *ctx, arg_msa_i *a) +{ + if (a->df =3D=3D DF_DOUBLE) { + return false; + } + + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_shf_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->ws), + tcg_constant_i32(a->sa)); + + return true; +} + static bool trans_msa_i5(DisasContext *ctx, arg_msa_i *a, gen_helper_piiii *gen_msa_i5) { --=20 2.31.1