From nobody Wed Feb 11 04:19:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635860617; cv=none; d=zohomail.com; s=zohoarc; b=BgDaGqBwmtRLtny8aQd99COFb1ULsASzeOS0sQBrLH+Np43qy/nbVCQbucyrtBgu+uBpmJKDu6sNBjiTFHjZa/Fv0rw/8l1ZHc+DrboVy1gg8gS5LzB+sMlLAgdXann3MfuJlbEBch8Jc63zHIu8WKi8YeTgMsOHjKltdpMr8U8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635860617; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yq0hPXTClhBJmAxr5iw2vWW8JkXa0mJtI91u85gGNks=; b=RtcCdANvfNopCBXWF1c2V5KgMYJ42MX4P2p9DhLPswPr3wl+EAWccJOqJCKtUAgXmu5qPI2D2Q2GUv+lz8iZjSIfX/Zh0fhNMj3tprzL/eElZwmrTGIZ4953PR1pD0GxCuMYwDYrV1HEhE/RAgjgeGmjjkbHK3udZBg4yCcRayM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 1635860617165223.34080129269273; Tue, 2 Nov 2021 06:43:37 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id d72-20020a1c1d4b000000b00331140f3dc8so2128803wmd.1 for ; Tue, 02 Nov 2021 06:43:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id j134sm2775088wmj.3.2021.11.02.06.43.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 06:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yq0hPXTClhBJmAxr5iw2vWW8JkXa0mJtI91u85gGNks=; b=kr9J4dDjXll1fGeo1zTsWMgVzOWhM5oDXuglzJXrRi9sNKV30NeofFMfk6fxLaqaNY 7kAA9WJmUoAUvw7q+AFkkFirMRsXHzGjwij7IqD0/rIW8LA71cG9s9HB90fyPncwAptF fQTMErypBHQVJsLCVvgfnZ1GZt4aYKeQfj2XTs4jT1Tjtt0BNbdxUql38kF6NRyhvRav FkhqDxk2/RBQp4O0XEy/CUnxSteBFwkQpulxZIt0KtRBiC7rX4mkHJHQy+c/vD+c4vGI MwP9VoeJzzqc/v2WmOr8PlNauCX3rVHnleRkpF+bNNADY2oIDCdqea6tHaJSpLqEfmM+ wYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=yq0hPXTClhBJmAxr5iw2vWW8JkXa0mJtI91u85gGNks=; b=ZIpBCgPzRiS18VTfv62+K8FpB+tEs+tzu2dydvkwZ85PncLEkBY3ncquVfiNmqsPPx ITGODvLZfbhXvidlvyEfj5pLqSn00HxA9vrUOvxLhiu868PnDkIBBlNykKD4U6lBWxxM efNnJhlfBUfwrqqqtzpG5iuiX+xeBo1CI9tSgUvuaD+BH7HodD13Hnr+3P66dOHwzqu2 thYWQLyaJ+jN6LUmTywDeNSmwiTW0G12EPpdlmm4avc14h181KXrDEtd5U2Ksj1hcDY8 rFhCTd3rV8HrNn6HnyUOlRurvVz4HoEXSwP+gulPShPjq02UPzH4Dw/FaRNcD6TDsM6k FCRw== X-Gm-Message-State: AOAM531FhcnUsRWfQATHqViQMq9M3F/JGkeDHlVO2t+EVrEOfkVK0Yog Is32ECjP+ZxLAmpQgmQsag2L9kVUeas= X-Google-Smtp-Source: ABdhPJzr3GduIii2P6xK6SL7GJzKaDTlTgIDsUCri+d7qKcNxGu9pHSMAARjv6wu23jijMcLEdW0Ag== X-Received: by 2002:a05:600c:202:: with SMTP id 2mr7023665wmi.167.1635860615385; Tue, 02 Nov 2021 06:43:35 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 11/41] target/mips: Convert MSA LDI opcode to decodetree Date: Tue, 2 Nov 2021 14:42:10 +0100 Message-Id: <20211102134240.3036524-12-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211102134240.3036524-1-f4bug@amsat.org> References: <20211102134240.3036524-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635860618775100001 Convert the LDI opcode (Immediate Load) to decodetree. Since it overlaps with the generic MSA handler, use a decodetree overlap group. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20211028210843.2120802-9-f4bug@amsat.org> --- target/mips/tcg/msa.decode | 8 +++++++- target/mips/tcg/msa_translate.c | 22 ++++++++++++++-------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 56419a24eb9..bdfe5a24cb3 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -14,10 +14,12 @@ &r rs rt rd sa =20 &msa_bz df wt sa +&msa_ldi df wd sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldi =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa @@ -27,4 +29,8 @@ BNZ_V 010001 01111 ..... ................ = @bz_v BZ 010001 110 .. ..... ................ @bz BNZ 010001 111 .. ..... ................ @bz =20 -MSA 011110 -------------------------- +{ + LDI 011110 110 .. .......... ..... 000111 @ldi + + MSA 011110 -------------------------- +} diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 8311730f0a5..94c69a668da 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -70,7 +70,6 @@ enum { OPC_CLEI_S_df =3D (0x4 << 23) | OPC_MSA_I5_07, OPC_MINI_U_df =3D (0x5 << 23) | OPC_MSA_I5_06, OPC_CLEI_U_df =3D (0x5 << 23) | OPC_MSA_I5_07, - OPC_LDI_df =3D (0x6 << 23) | OPC_MSA_I5_07, =20 /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, @@ -515,13 +514,6 @@ static void gen_msa_i5(DisasContext *ctx) case OPC_CLEI_U_df: gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); break; - case OPC_LDI_df: - { - int32_t s10 =3D sextract32(ctx->opcode, 11, 10); - tcg_gen_movi_i32(timm, s10); - gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -534,6 +526,20 @@ static void gen_msa_i5(DisasContext *ctx) tcg_temp_free_i32(timm); } =20 +static bool trans_LDI(DisasContext *ctx, arg_msa_ldi *a) +{ + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_ldi_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->sa)); + + return true; +} + static void gen_msa_bit(DisasContext *ctx) { #define MASK_MSA_BIT(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) --=20 2.31.1