From nobody Tue Feb 10 12:59:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1635789232; cv=none; d=zohomail.com; s=zohoarc; b=D2rgf0rAoFwDyt5ztFvex+uGSJ8UmoKyYXcODJcrrMaase7QX2xi+G1m4pw3D9wC4wNmYguivgpG4/BKsPl2Lbm0ERfNR3DuWguw+PzjrNVfxPgPwTj63sjjC2n9q27vvKA5JM5kRbj5QeH8/x8Qq1l95I30RHfvwSOLNs8HRuI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635789232; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z8ecs4LTwGjkTaIMjFwaDU18rjRNxTTeFlYdhpfOXR8=; b=A7ENTKJLNE+FrcWknNfY0JAr10L3BYbxw3NL9d1mTGIxxMzF/R/nHS65Ess9vfo7FAftQDnav6CoSm0MbdzcF/Jz5hj1TZ9VHVpp4pmSTDcWLdNb2GywboYlpJFpeoTl4MwXnj492jpdrcoWunc3b+/IlfXEj0qLEuxvobwOHmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635789232329490.74041629007536; Mon, 1 Nov 2021 10:53:52 -0700 (PDT) Received: from localhost ([::1]:48020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhbVH-0003Z8-8W for importer@patchew.org; Mon, 01 Nov 2021 13:53:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhb6C-0003o5-7p for qemu-devel@nongnu.org; Mon, 01 Nov 2021 13:27:57 -0400 Received: from mail-qk1-x733.google.com ([2607:f8b0:4864:20::733]:33602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhb63-0000eV-KF for qemu-devel@nongnu.org; Mon, 01 Nov 2021 13:27:55 -0400 Received: by mail-qk1-x733.google.com with SMTP id a132so16129125qkg.0 for ; Mon, 01 Nov 2021 10:27:46 -0700 (PDT) Received: from localhost.localdomain (rrcs-172-254-253-57.nyc.biz.rr.com. [172.254.253.57]) by smtp.gmail.com with ESMTPSA id t5sm6075331qkf.34.2021.11.01.10.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 10:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z8ecs4LTwGjkTaIMjFwaDU18rjRNxTTeFlYdhpfOXR8=; b=LmMbj8qzjRgQykPT4dCwpD/o7dhNRuK8kbb845YFRuC5ISdf0yKGyyToIO6la0qbiY cozeBZgvDYwx9Qc4JZ91TKs1WYB/bmRDaEMfn1EzK9IEcJ+Pu+RybkbmedUzHMPYA43u V3MsgoFcPJRna06gS5X/aA5OpiagMsxqp+8PLGdYV2aPle8cfu1Gjj6sMby9ry1WHYEt SYGBG7HtFbCkEP2XEzySjo8u+p9RywQDuCLa6NXPTj56rQyD1ziDft8SeLqn3bvhIcWB Xeypwx3QGULOLwbSPtdqR3WXSw0kpzs+mIinRgU1ViqvUbU/dlIugKajRNON9wGDiFAR 5crw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z8ecs4LTwGjkTaIMjFwaDU18rjRNxTTeFlYdhpfOXR8=; b=rksJ3bs8eDX87JodZRD8KAdQr9K/HnbbNRRQ9ylGzAwrOZ8XxxEfvCEDzoLcMzOXRN S7+snZn4ZjDYmXmT2pz1PIyk161QQ3UO0F22M+5nUDPAkXuRszZrUyq4PRWZI7+wmjLz apz9PoYxaObXVUiDcAmVpVwC0OolCvezoMslKkzQsSijAoMOe4/P0rBoWNm0Vk4LlyOz jvo+ksV9MI3f9sH87Ml1rTUx55/QesxpVMQl6DtgaqRHZ4OU86pJluSUfXtnWSiiMEoK ffOu5uxkLnAuUW+1HgT6nVCcw/7K0jGjPmSAbSqBqC45Oove45CrDGQplBctf8lDkE5r FayQ== X-Gm-Message-State: AOAM533p93cIgD2kX0bmIDd/IwcBm96fS6uC2/B5Zv66r2/4rekowwVe aZ3TB36PLuv+/kQhrs/69yW4zrdMwLjV9w== X-Google-Smtp-Source: ABdhPJyy4O6V1oGFXBif7f3pvaMu+LPtoRg0nLPzY79yQwNk+26OeWFbNxTyCcKnVDPPREN7lEcCkA== X-Received: by 2002:a37:ae83:: with SMTP id x125mr24420977qke.37.1635787665694; Mon, 01 Nov 2021 10:27:45 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v7 25/60] target/hexagon: Remove hexagon_cpu_tlb_fill Date: Mon, 1 Nov 2021 13:26:54 -0400 Message-Id: <20211101172729.23149-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211101172729.23149-1-richard.henderson@linaro.org> References: <20211101172729.23149-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::733; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x733.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Taylor Simpson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1635789234166100001 Content-Type: text/plain; charset="utf-8" The fallback code in cpu_loop_exit_sigsegv is sufficient for hexagon linux-user. Remove the code from cpu_loop that raises SIGSEGV. Reviewed-by: Taylor Simpson Signed-off-by: Richard Henderson --- linux-user/hexagon/cpu_loop.c | 24 +----------------------- target/hexagon/cpu.c | 23 ----------------------- 2 files changed, 1 insertion(+), 46 deletions(-) diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c index bee2a9e4ea..6b24cbaba9 100644 --- a/linux-user/hexagon/cpu_loop.c +++ b/linux-user/hexagon/cpu_loop.c @@ -28,8 +28,7 @@ void cpu_loop(CPUHexagonState *env) { CPUState *cs =3D env_cpu(env); - int trapnr, signum, sigcode; - target_ulong sigaddr; + int trapnr; target_ulong syscallnum; target_ulong ret; =20 @@ -39,10 +38,6 @@ void cpu_loop(CPUHexagonState *env) cpu_exec_end(cs); process_queued_cpu_work(cs); =20 - signum =3D 0; - sigcode =3D 0; - sigaddr =3D 0; - switch (trapnr) { case EXCP_INTERRUPT: /* just indicate that signals should be handled asap */ @@ -65,12 +60,6 @@ void cpu_loop(CPUHexagonState *env) env->gpr[0] =3D ret; } break; - case HEX_EXCP_FETCH_NO_UPAGE: - case HEX_EXCP_PRIV_NO_UREAD: - case HEX_EXCP_PRIV_NO_UWRITE: - signum =3D TARGET_SIGSEGV; - sigcode =3D TARGET_SEGV_MAPERR; - break; case EXCP_ATOMIC: cpu_exec_step_atomic(cs); break; @@ -79,17 +68,6 @@ void cpu_loop(CPUHexagonState *env) trapnr); exit(EXIT_FAILURE); } - - if (signum) { - target_siginfo_t info =3D { - .si_signo =3D signum, - .si_errno =3D 0, - .si_code =3D sigcode, - ._sifields._sigfault._addr =3D sigaddr - }; - queue_signal(env, info.si_signo, QEMU_SI_KILL, &info); - } - process_pending_signals(env); } } diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 3338365c16..160a46a3d5 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -245,34 +245,11 @@ static void hexagon_cpu_init(Object *obj) qdev_property_add_static(DEVICE(obj), &hexagon_lldb_stack_adjust_prope= rty); } =20 -static bool hexagon_tlb_fill(CPUState *cs, vaddr address, int size, - MMUAccessType access_type, int mmu_idx, - bool probe, uintptr_t retaddr) -{ -#ifdef CONFIG_USER_ONLY - switch (access_type) { - case MMU_INST_FETCH: - cs->exception_index =3D HEX_EXCP_FETCH_NO_UPAGE; - break; - case MMU_DATA_LOAD: - cs->exception_index =3D HEX_EXCP_PRIV_NO_UREAD; - break; - case MMU_DATA_STORE: - cs->exception_index =3D HEX_EXCP_PRIV_NO_UWRITE; - break; - } - cpu_loop_exit_restore(cs, retaddr); -#else -#error System mode not implemented for Hexagon -#endif -} - #include "hw/core/tcg-cpu-ops.h" =20 static const struct TCGCPUOps hexagon_tcg_ops =3D { .initialize =3D hexagon_translate_init, .synchronize_from_tb =3D hexagon_cpu_synchronize_from_tb, - .tlb_fill =3D hexagon_tlb_fill, }; =20 static void hexagon_cpu_class_init(ObjectClass *c, void *data) --=20 2.25.1