From nobody Tue Feb 10 21:41:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635613676; cv=none; d=zohomail.com; s=zohoarc; b=YVYUQwTW+idded7mLdPrn5eKKk1qwmNqLbtbsQZjxNau4Y0O/ZBaLhjPmTOwC+zVKWXZR2+smBICyNmbxp6nMHRzCt+cbPFvzIhvSAF/yCznL805GLaaWUZNb9grflY5K9FjdNgJOHK6xQGqRRTcLWiW0qjOMfYjnnBDZnkOT3E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635613676; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OfIDcUaHl1YMEOQAd+ZkSpOLG2BS5BHqKSe+gt8Sd1A=; b=Qr9I0RR/EBk1+FR7ZLWLrg96r7os3NrEk7TkqNF+zvhT1Q07nNi/xW/kfpNHwTTTgrailK07N0PF1f5r/RIPXSH4grqksBL1H0krZyGU0MtWb81BnoTMkiJsvu66VvTXpVgHPxFIPG89i1qgP+uXecaZkkoA67cyGrWJ7BYeZCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635613676863702.182354346542; Sat, 30 Oct 2021 10:07:56 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id m22so21722100wrb.0 for ; Sat, 30 Oct 2021 10:07:56 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id e18sm7241717wrs.48.2021.10.30.10.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 10:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OfIDcUaHl1YMEOQAd+ZkSpOLG2BS5BHqKSe+gt8Sd1A=; b=gtFPsvX7lV/2G4XmdKGgicdldsQE1DUaHWa2X+lCuhaSA2NFs+kC1LpAAk/j6kauyr GXtsUmPVEJ41IyOvF1uu3ZXFyHA9wGv6it5FvU59IqkYa7qIFFQNEn5r8BsXNKD4B3SB Pj0gL/5G19g6yD3a4kt1nuJOb/QeUgw9i2Nc3CGzIQR1VSi0/epg8Osd0E7fQBcQvB/Y 0J3fWmcT/21YhsGLbVhmuUR+Ilg+e0nmeTV5alAmSmV5UJnVClN+oJMItKqsXR+dqj01 /OC3zZKv2mJQSGYtnZp4FMLaaM5vuHZ/xA3vKzWVfnC22FS+DViukcHzS4vJzoNWUeHO U91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=OfIDcUaHl1YMEOQAd+ZkSpOLG2BS5BHqKSe+gt8Sd1A=; b=Xd+ERysnMPuwFoGq/b6TCpVxVAZ+CO6IHboZ0nUX7Y8diSovKqcIOLx60QADggLkM6 h7DH8FO99udg+mXxFhbtqwTFRftc7YIuPAVfOrvawhRh877lW7/YY2Z+S8G43aDRIl+y 29ho6f+RG6woW1NZyPSB1f2/p1HOp3Nelr0OBql40VxWQsjZZE7C+pXf1KOz+emfRrmA R2jJyfIhOoMI7/GFKjoy5HaCgVdkkXzTP0QStJ+hUwjg3oSDHEkBqY9wwW6DfOHoKDsg Ryr9wfAcgJV271GoiSQnJLBP1wojC9lv5NBFQwWg4NEvgqNkoMkBlhF/pk1/xBJCXKDP YhVg== X-Gm-Message-State: AOAM531LBhHJUmXCiPNaPm0YzwgYGdkp00Kjw9kEr0GcqbR1wfHW30nt k/o7zCD7GTJ55yTR7vvkBu4= X-Google-Smtp-Source: ABdhPJx7yRSrsgG1BHrOPtVtwEcXZrh1Eandb5GMhZ9jwm1iB2Ep0tYzT6oFyZdYs2BCPDFsxvQOVg== X-Received: by 2002:a5d:5646:: with SMTP id j6mr23245989wrw.320.1635613675186; Sat, 30 Oct 2021 10:07:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Yoshinori Sato , Magnus Damm , Paolo Bonzini , BALATON Zoltan , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 20/30] hw/intc/sh_intc: Remove excessive parenthesis Date: Sat, 30 Oct 2021 19:06:05 +0200 Message-Id: <20211030170615.2636436-21-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211030170615.2636436-1-f4bug@amsat.org> References: <20211030170615.2636436-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635613678571100001 From: BALATON Zoltan Drop unneded parenthesis and split up one complex expression to write it with less brackets so it's easier to follow. Signed-off-by: BALATON Zoltan Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/intc/sh_intc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c index 1a2824f8e0c..416581dc07a 100644 --- a/hw/intc/sh_intc.c +++ b/hw/intc/sh_intc.c @@ -23,7 +23,7 @@ void sh_intc_toggle_source(struct intc_source *source, int pending_changed =3D 0; int old_pending; =20 - if ((source->enable_count =3D=3D source->enable_max) && (enable_adj = =3D=3D -1)) { + if (source->enable_count =3D=3D source->enable_max && enable_adj =3D= =3D -1) { enable_changed =3D -1; } source->enable_count +=3D enable_adj; @@ -68,7 +68,7 @@ void sh_intc_toggle_source(struct intc_source *source, static void sh_intc_set_irq(void *opaque, int n, int level) { struct intc_desc *desc =3D opaque; - struct intc_source *source =3D &(desc->sources[n]); + struct intc_source *source =3D &desc->sources[n]; =20 if (level && !source->asserted) { sh_intc_toggle_source(source, 0, 1); @@ -163,7 +163,7 @@ static void sh_intc_locate(struct intc_desc *desc, *modep =3D mode | INTC_MODE_IS_PRIO; *datap =3D &pr->value; *enums =3D pr->enum_ids; - *first =3D (pr->reg_width / pr->field_width) - 1; + *first =3D pr->reg_width / pr->field_width - 1; *width =3D pr->field_width; return; } @@ -244,7 +244,8 @@ static void sh_intc_write(void *opaque, hwaddr offset, } =20 for (k =3D 0; k <=3D first; k++) { - mask =3D ((1 << width) - 1) << ((first - k) * width); + mask =3D (1 << width) - 1; + mask <<=3D (first - k) * width; =20 if ((*valuep & mask) =3D=3D (value & mask)) { continue; --=20 2.31.1