From nobody Tue Feb 10 20:31:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635613627; cv=none; d=zohomail.com; s=zohoarc; b=FFPl+i6yKGh2XrJf8N2HkRAMidq+SEbwW4L9M8vEoEQ/gowpd3IXr2rM7vqrrzMUfQOuk5JRdkqH8yw4+zPymwLOW5cmjEM5WPOPeaIJJZlCuTZI66Ef3SBIIXL6vHVa7Tsd3cmqubBVDO+quLedROaKkkrUyrOuOIaToD/ntfs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635613627; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TSjS4mG+FduSZwcDdM9xHRv0BrOwT/zdGTxWqIBFem0=; b=iishcPQbuTqbdW+NSCNTtccaje/NkVFNZdo45sB2jN3IcEFtl0137drHAmwll4vgHl+ahLl0xjki3CxFIIRoz4GHOmItWkph73+nmXxPW0dsSjAvFqqV5Nj5eJpbPrwYca/bzmEvfyg/i09iquJPwWDZe3YGr6ZaCwxpAQZCGJ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1635613627681873.0235501599941; Sat, 30 Oct 2021 10:07:07 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id g13so2149896wmg.2 for ; Sat, 30 Oct 2021 10:07:07 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id h27sm2841146wmc.43.2021.10.30.10.07.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Oct 2021 10:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TSjS4mG+FduSZwcDdM9xHRv0BrOwT/zdGTxWqIBFem0=; b=jJEhm6kwb2z2zrN9JANcMv4Jak/IWaoqUmkegotqlwWx4q4wb2N4f53iaZqCyKjlrz IRHJhCML5Ya3Ns3c83LlzK7Ka836x4LqxSQTKQyA8uwvGYr66qXV8U6dHwbNXV8iw/of Iz7hcZ5bq2D0AoKRjeJt4lAmOEJKXKRAvTMXI0pUJD+2bZiSK59eO7rfEO3sKspDX63J 483Nn4vT4ql2pFyCuYEAFd7w/6xSlvzQ7E26I7X4fAsc3sG6BxJ/Iyct/lYWs2n3yEsG nJN4IwlMbDTL96ijzTvjt7QlxpN9q1D/Rv4o0A1qhaQT15xUkFuIaDQdZNaZZfh3OT4I zdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=TSjS4mG+FduSZwcDdM9xHRv0BrOwT/zdGTxWqIBFem0=; b=TrBBO3Ki7lEw8ylpFVAcW6WKDk6P+OtmmB7AFLxGmY7qsBvUqHw6UBY+zqtTnxKbN3 iN2jGQUXvCkV0tFqhpu5jV7uKDMpRAwddqaq4fjrYHmvmejg8NXGHVqb84pbtogE5VEB NHm4OJgzTp7g8Av9oRDtNXgY0Wn8u0MZZz2MKzGJMkGRcI29HWZw+85AB+YYXGN2s8Sr 8NQ2JqWgPK17V175eooeLhI2o80S4rwpFMVM3nGUwHV9uWPOPXeoVShBjtMm17/A39Z/ U9OID0IeGVNrfP8HnDFJlFI9uT4ymehdtEpjg3Pv3WFQVfx1fHcJLlfDBipw6exH/x21 j5TA== X-Gm-Message-State: AOAM533bQhpAI1tvMjEF/sj56vrxwTgUUfegUUEM9BVs1VIBp19lTMfl lMlZX5iRt14rcmQALj70t9I= X-Google-Smtp-Source: ABdhPJwjpDk5OHkfkQWoIB/C/xVYCfB8be/gwCkBfm+3hIw99WjX06/J7lEVfbz141yDYafIVPQL4A== X-Received: by 2002:a1c:a711:: with SMTP id q17mr9718680wme.158.1635613625952; Sat, 30 Oct 2021 10:07:05 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Yoshinori Sato , Magnus Damm , Paolo Bonzini , BALATON Zoltan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 10/30] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState Date: Sat, 30 Oct 2021 19:05:55 +0200 Message-Id: <20211030170615.2636436-11-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211030170615.2636436-1-f4bug@amsat.org> References: <20211030170615.2636436-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635613629349100001 From: BALATON Zoltan Coding style says types should be camel case. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <0f185653528c99eeeb2b4e4afb8b818d93298c20.1635541329.git.balato= n@eik.bme.hu> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/sh_serial.c | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c index 2d6ea0042ed..bc5e0c44048 100644 --- a/hw/char/sh_serial.c +++ b/hw/char/sh_serial.c @@ -73,9 +73,9 @@ typedef struct { qemu_irq txi; qemu_irq tei; qemu_irq bri; -} sh_serial_state; +} SHSerialState; =20 -static void sh_serial_clear_fifo(sh_serial_state *s) +static void sh_serial_clear_fifo(SHSerialState *s) { memset(s->rx_fifo, 0, SH_RX_FIFO_LENGTH); s->rx_cnt =3D 0; @@ -86,7 +86,7 @@ static void sh_serial_clear_fifo(sh_serial_state *s) static void sh_serial_write(void *opaque, hwaddr offs, uint64_t val, unsigned size) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; unsigned char ch; =20 trace_sh_serial_write(size, offs, val); @@ -204,7 +204,7 @@ static void sh_serial_write(void *opaque, hwaddr offs, static uint64_t sh_serial_read(void *opaque, hwaddr offs, unsigned size) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; uint32_t ret =3D UINT32_MAX; =20 #if 0 @@ -309,12 +309,12 @@ static uint64_t sh_serial_read(void *opaque, hwaddr o= ffs, return ret; } =20 -static int sh_serial_can_receive(sh_serial_state *s) +static int sh_serial_can_receive(SHSerialState *s) { return s->scr & (1 << 4); } =20 -static void sh_serial_receive_break(sh_serial_state *s) +static void sh_serial_receive_break(SHSerialState *s) { if (s->feat & SH_SERIAL_FEAT_SCIF) { s->sr |=3D (1 << 4); @@ -323,13 +323,13 @@ static void sh_serial_receive_break(sh_serial_state *= s) =20 static int sh_serial_can_receive1(void *opaque) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; return sh_serial_can_receive(s); } =20 static void sh_serial_timeout_int(void *opaque) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; =20 s->flags |=3D SH_SERIAL_FLAG_RDF; if (s->scr & (1 << 6) && s->rxi) { @@ -339,7 +339,7 @@ static void sh_serial_timeout_int(void *opaque) =20 static void sh_serial_receive1(void *opaque, const uint8_t *buf, int size) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; =20 if (s->feat & SH_SERIAL_FEAT_SCIF) { int i; @@ -369,7 +369,7 @@ static void sh_serial_receive1(void *opaque, const uint= 8_t *buf, int size) =20 static void sh_serial_event(void *opaque, QEMUChrEvent event) { - sh_serial_state *s =3D opaque; + SHSerialState *s =3D opaque; if (event =3D=3D CHR_EVENT_BREAK) { sh_serial_receive_break(s); } @@ -390,9 +390,7 @@ void sh_serial_init(MemoryRegion *sysmem, qemu_irq tei_source, qemu_irq bri_source) { - sh_serial_state *s; - - s =3D g_malloc0(sizeof(sh_serial_state)); + SHSerialState *s =3D g_malloc0(sizeof(*s)); =20 s->feat =3D feat; s->flags =3D SH_SERIAL_FLAG_TEND | SH_SERIAL_FLAG_TDE; --=20 2.31.1