hmp: Add shortcut to stop command to match cont

[PATCH v2] hmp: Add shortcut to stop command to match cont

Posted by BALATON Zoltan 2 years, 5 months ago

Some commands such as quit or cont have one letter alternatives but
stop is missing that. Add stop|s to match cont|c for consistency and
convenience.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
c2: Fixed typo in commit title

 hmp-commands.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index cf723c69ac..07a738a8e2 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -382,7 +382,7 @@ SRST
 ERST
 
     {
-        .name       = "stop",
+        .name       = "stop|s",
         .args_type  = "",
         .params     = "",
         .help       = "stop emulation",
@@ -390,7 +390,7 @@ ERST
     },
 
 SRST
-``stop``
+``stop`` or ``s``
   Stop emulation.
 ERST
 
-- 
2.21.4

Re: [PATCH v2] hmp: Add shortcut to stop command to match cont

Posted by Daniel P. Berrangé 2 years, 5 months ago

On Sat, Oct 30, 2021 at 11:49:37AM +0200, BALATON Zoltan wrote:
> Some commands such as quit or cont have one letter alternatives but
> stop is missing that. Add stop|s to match cont|c for consistency and
> convenience.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> c2: Fixed typo in commit title
> 
>  hmp-commands.hx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH v2] hmp: Add shortcut to stop command to match cont

Posted by BALATON Zoltan 2 years, 5 months ago

Ping? This is really simple addition that sholdn't take long to review.

On Sat, 30 Oct 2021, BALATON Zoltan wrote:
> Some commands such as quit or cont have one letter alternatives but
> stop is missing that. Add stop|s to match cont|c for consistency and
> convenience.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> c2: Fixed typo in commit title
>
> hmp-commands.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index cf723c69ac..07a738a8e2 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -382,7 +382,7 @@ SRST
> ERST
>
>     {
> -        .name       = "stop",
> +        .name       = "stop|s",
>         .args_type  = "",
>         .params     = "",
>         .help       = "stop emulation",
> @@ -390,7 +390,7 @@ ERST
>     },
>
> SRST
> -``stop``
> +``stop`` or ``s``
>   Stop emulation.
> ERST
>
>

Re: [PATCH v2] hmp: Add shortcut to stop command to match cont

Posted by Laurent Vivier 2 years, 5 months ago

Le 01/11/2021 à 23:56, BALATON Zoltan a écrit :
> Ping? This is really simple addition that sholdn't take long to review.
> 
> On Sat, 30 Oct 2021, BALATON Zoltan wrote:
>> Some commands such as quit or cont have one letter alternatives but
>> stop is missing that. Add stop|s to match cont|c for consistency and
>> convenience.
>>
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> c2: Fixed typo in commit title
>>
>> hmp-commands.hx | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index cf723c69ac..07a738a8e2 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -382,7 +382,7 @@ SRST
>> ERST
>>
>>     {
>> -        .name       = "stop",
>> +        .name       = "stop|s",
>>         .args_type  = "",
>>         .params     = "",
>>         .help       = "stop emulation",
>> @@ -390,7 +390,7 @@ ERST
>>     },
>>
>> SRST
>> -``stop``
>> +``stop`` or ``s``
>>   Stop emulation.
>> ERST
>>
>>
> 

Applied to my trivial-patches branch.

I'll do a new PR before the hard freeze.

Thanks,
Laurent