From nobody Tue Feb 10 10:03:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549542; cv=none; d=zohomail.com; s=zohoarc; b=D4TXaYJxvM+9KibHgRHSDh3+BSsOdtuM/71gm3pf2jcXgo5h4XR4Wg7bT1pRrdQzzvSJo5A8/4FDP0opNpdCAcUR3W2xsdOvRpDwT/r8vtBZ3AUrfz45Rn0Odk7vaynVPe3doXyXAHFsJW3gVvs2MC2ex/g7olMD08yt4q/w3kg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549542; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=H165jyj+0ikouKRyHfDySD7H7c8FAy6K0GMN+HxJ7PuSu2chmBD8aHy9ZDhQ+BBeL9u66sxAPGHogKIu3ypWf/v3aZuZ1dxWS/m2gWMuUUAqn5F92Yc4Ghmo01G/E/25/uzFsO+ALzKVBhgidUzDDAJCKjScefo+6FOco400rzk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635549542936692.1702151286783; Fri, 29 Oct 2021 16:19:02 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id d13so19118840wrf.11 for ; Fri, 29 Oct 2021 16:19:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m31sm6101077wms.25.2021.10.29.16.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=M6SfMHp4Zc6aXXjB4JyAWmmq/OmIVjg17/xj/sQneHpq9G53s60ZDJL0bX34rBFFBL C1o4RFQBs0J+9NizVoz7+br9VJqHQivGhsdwiaJkbrCI31CW01VT3i6KbYjW8IdpM/NO ysyt3ji5QNxekGvzWChvSWZL+4EZAEToRNsDqAlCYF/o+7dNBxYZCKX9XNXkEQK3NbF9 9HE2LB3Ut6O97U2H9Ii1ftYmn15O9LVo58Fuh/6ic4ri0XPTzc7J5BA53Lf+VIfHfthG yjNkxQRggc00bfFYNRWBtlqEkL3amuX12GJUflQkl1CDEOHxPY4vUlEMJmp/UtqzEYdX s0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=uqklnpFf56K31xorx2LjISyL4moM+8EyOkLmtE/QJUZ5VdOxpt47FgUtDXxJgnSzPR XZ2bKR8d1rl6OaeZ61sKIxpWhoNvxv9eyJcPLgyPoCT5zEL0p4RXGxghHKyC4ENPr923 aw5yTNkinBWDdG7a/hAkuNqtQy4QcPmn28ZOFb1Fc7A+v82v9fxGRRukASfnlpRQHGjG RglkiGnpOECC2zc/8bJFgvitiy+dtA6pDL9YgqWzKhm8oln4nWjiqZO236Z0oLuoJv3T 34QqqtobDBV6lyaM6VQQi6ibPq4iyWwpa89+ELhF+2lJuTk1NYWXek1bDGnydZbBU5Ln WixA== X-Gm-Message-State: AOAM533MMBMFYpSItaUiUsuOcBqKj3dWt1+pyMv/XrjOrt/o+tl+Ttxn TjHvewp2vny0JBRbG7/4JM0= X-Google-Smtp-Source: ABdhPJybpCFo2JuRbV13PP3ytPacRhElX+Ik/UdY6qq4B2n5zhXKPGu82zvLmPFGiE6uly4ph2QlzA== X-Received: by 2002:a1c:750b:: with SMTP id o11mr14551589wmc.5.1635549541257; Fri, 29 Oct 2021 16:19:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 5/5] target/arm: Use tcg_constant_i32() in gen_rev16() Date: Sat, 30 Oct 2021 01:18:34 +0200 Message-Id: <20211029231834.2476117-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549544769100001 Since the mask is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 52ba562c96b..98f59259284 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -388,13 +388,12 @@ static void gen_smul_dual(TCGv_i32 a, TCGv_i32 b) void gen_rev16(TCGv_i32 dest, TCGv_i32 var) { TCGv_i32 tmp =3D tcg_temp_new_i32(); - TCGv_i32 mask =3D tcg_const_i32(0x00ff00ff); + TCGv_i32 mask =3D tcg_constant_i32(0x00ff00ff); tcg_gen_shri_i32(tmp, var, 8); tcg_gen_and_i32(tmp, tmp, mask); tcg_gen_and_i32(var, var, mask); tcg_gen_shli_i32(var, var, 8); tcg_gen_or_i32(dest, var, tmp); - tcg_temp_free_i32(mask); tcg_temp_free_i32(tmp); } =20 --=20 2.31.1