From nobody Tue Feb 10 12:42:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549523; cv=none; d=zohomail.com; s=zohoarc; b=EPImxeERYX5RiMbspXi1YOaol5skfkm2xgRcjW5o9PamPwr5a6HvMFjmMxfNdY4jK3NPiqHcHsBOr1279k0X91qY8fzgXnRUNHAIGnNAklGHT4e0jybmzwseb6kR7n/9mHRYsT7EiWdFBbXtLMEUIZqqNlaLiLWR1PvGSPPfBcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549523; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=crzdnS8kq/jWE2/JuOZfhgKbfgSUSMIx0sJY3rPQlOKBXkl+rGuWFKo8a/hASZICdCwD9IoRL+AaYxgTkOXAEIR+WSM6E3xHaSXTs+n9qqcPhfl1OGhAi0WR4IfrtHR7Wmth+JBP+UJE36VwVwGLjsMNKHyjVGjmUTCxpLGrfJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1635549523721870.398960194666; Fri, 29 Oct 2021 16:18:43 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id k7so19063559wrd.13 for ; Fri, 29 Oct 2021 16:18:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id r10sm6894065wrl.92.2021.10.29.16.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=J4Iykq4QB5zQtPouXxEGI3R/wbKU4to04JUk4VDaeH0ISOaMify3nHBI4oll8ttpzq IA11pkuJYaBxcAQLcqCqj5IZmmkP6kn3ZiRHFpnKu1k5x5Pw2AvUx9GLAW6dbxxi6wfW 1eFx7abc0HUhAGQRN7IKDcQ6oXYARP2OJ0XhPO3UXcN7PoHGlyyfrfPYVHm/DMqSNgSw CxQ7mWugEueKTXxF6tncBuCE+XyPhuXslb5md7Rm9dpyjNeqf/bmRd0APSRQXj3/Wrd/ iGy78lZQxKsfqWmA7sTr6VRaFUzBea5bVdmqm09PE180kQHpn85h3Sc8RLVZq7QuxQun wcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=Cex41tu5zf0gNyhLMveogcp3gg3LWzdCzzrPhGizqO5kAPJKCMsPE2abcG5a/cEX9M 7VpRGbhxz4ZhtmdqB3AxvOL3s+R1Rb+jFW8XltCbxsL92mlL4KQz7PTuvuKAC13668j0 6TUm3sob9NTvkkfgEyALdv4KXsjLTRsugemAPjsm/ScWkfQmtzkY612JC41/UTLG5Za/ vqR3RDT+Y+xkvRKVNcV6sjcLsbRU9j+qwLQPiZSrgT76Q+Q3kOE4cwLlI0PE13TiPxW/ 4OgoO7C7MiJ38fEIrn/3g2kR8PHlh0XyMJ5QMg6AwUVDsuLBkVu0JvKHHCRANTiBOugH HGrQ== X-Gm-Message-State: AOAM533053leke3NBCSXLR49MEV1Ka2QvvvcfGMbT4r3aYyoYMz3DL2R x/HFiaFG45hyK0UO4MdiDrM= X-Google-Smtp-Source: ABdhPJysT8T5b44SJnh/1M5c0X0VIoWSAzyfmwxurJO659FjqHig6K1wBKhslhSvdVmSJALCPGko4w== X-Received: by 2002:a5d:680b:: with SMTP id w11mr10648818wru.345.1635549522086; Fri, 29 Oct 2021 16:18:42 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/5] target/arm: Use tcg_constant_i32() in op_smlad() Date: Sat, 30 Oct 2021 01:18:30 +0200 Message-Id: <20211029231834.2476117-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549525615100001 Avoid using a TCG temporary for a read-only constant. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d6af5b1b039..083a6d6ed77 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7849,10 +7849,9 @@ static bool op_smlad(DisasContext *s, arg_rrrr *a, b= ool m_swap, bool sub) t3 =3D tcg_temp_new_i32(); tcg_gen_sari_i32(t3, t1, 31); qf =3D load_cpu_field(QF); - one =3D tcg_const_i32(1); + one =3D tcg_constant_i32(1); tcg_gen_movcond_i32(TCG_COND_NE, qf, t2, t3, one, qf); store_cpu_field(qf, QF); - tcg_temp_free_i32(one); tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); } --=20 2.31.1