From nobody Mon Feb 9 11:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549523; cv=none; d=zohomail.com; s=zohoarc; b=EPImxeERYX5RiMbspXi1YOaol5skfkm2xgRcjW5o9PamPwr5a6HvMFjmMxfNdY4jK3NPiqHcHsBOr1279k0X91qY8fzgXnRUNHAIGnNAklGHT4e0jybmzwseb6kR7n/9mHRYsT7EiWdFBbXtLMEUIZqqNlaLiLWR1PvGSPPfBcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549523; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=crzdnS8kq/jWE2/JuOZfhgKbfgSUSMIx0sJY3rPQlOKBXkl+rGuWFKo8a/hASZICdCwD9IoRL+AaYxgTkOXAEIR+WSM6E3xHaSXTs+n9qqcPhfl1OGhAi0WR4IfrtHR7Wmth+JBP+UJE36VwVwGLjsMNKHyjVGjmUTCxpLGrfJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1635549523721870.398960194666; Fri, 29 Oct 2021 16:18:43 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id k7so19063559wrd.13 for ; Fri, 29 Oct 2021 16:18:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id r10sm6894065wrl.92.2021.10.29.16.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=J4Iykq4QB5zQtPouXxEGI3R/wbKU4to04JUk4VDaeH0ISOaMify3nHBI4oll8ttpzq IA11pkuJYaBxcAQLcqCqj5IZmmkP6kn3ZiRHFpnKu1k5x5Pw2AvUx9GLAW6dbxxi6wfW 1eFx7abc0HUhAGQRN7IKDcQ6oXYARP2OJ0XhPO3UXcN7PoHGlyyfrfPYVHm/DMqSNgSw CxQ7mWugEueKTXxF6tncBuCE+XyPhuXslb5md7Rm9dpyjNeqf/bmRd0APSRQXj3/Wrd/ iGy78lZQxKsfqWmA7sTr6VRaFUzBea5bVdmqm09PE180kQHpn85h3Sc8RLVZq7QuxQun wcKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Zo5TdWihX0fqFGQkJwGnLAD68vX5IqLcZuqWCOpy/Ho=; b=Cex41tu5zf0gNyhLMveogcp3gg3LWzdCzzrPhGizqO5kAPJKCMsPE2abcG5a/cEX9M 7VpRGbhxz4ZhtmdqB3AxvOL3s+R1Rb+jFW8XltCbxsL92mlL4KQz7PTuvuKAC13668j0 6TUm3sob9NTvkkfgEyALdv4KXsjLTRsugemAPjsm/ScWkfQmtzkY612JC41/UTLG5Za/ vqR3RDT+Y+xkvRKVNcV6sjcLsbRU9j+qwLQPiZSrgT76Q+Q3kOE4cwLlI0PE13TiPxW/ 4OgoO7C7MiJ38fEIrn/3g2kR8PHlh0XyMJ5QMg6AwUVDsuLBkVu0JvKHHCRANTiBOugH HGrQ== X-Gm-Message-State: AOAM533053leke3NBCSXLR49MEV1Ka2QvvvcfGMbT4r3aYyoYMz3DL2R x/HFiaFG45hyK0UO4MdiDrM= X-Google-Smtp-Source: ABdhPJysT8T5b44SJnh/1M5c0X0VIoWSAzyfmwxurJO659FjqHig6K1wBKhslhSvdVmSJALCPGko4w== X-Received: by 2002:a5d:680b:: with SMTP id w11mr10648818wru.345.1635549522086; Fri, 29 Oct 2021 16:18:42 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/5] target/arm: Use tcg_constant_i32() in op_smlad() Date: Sat, 30 Oct 2021 01:18:30 +0200 Message-Id: <20211029231834.2476117-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549525615100001 Avoid using a TCG temporary for a read-only constant. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index d6af5b1b039..083a6d6ed77 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -7849,10 +7849,9 @@ static bool op_smlad(DisasContext *s, arg_rrrr *a, b= ool m_swap, bool sub) t3 =3D tcg_temp_new_i32(); tcg_gen_sari_i32(t3, t1, 31); qf =3D load_cpu_field(QF); - one =3D tcg_const_i32(1); + one =3D tcg_constant_i32(1); tcg_gen_movcond_i32(TCG_COND_NE, qf, t2, t3, one, qf); store_cpu_field(qf, QF); - tcg_temp_free_i32(one); tcg_temp_free_i32(t3); tcg_temp_free_i32(t2); } --=20 2.31.1 From nobody Mon Feb 9 11:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549528; cv=none; d=zohomail.com; s=zohoarc; b=AAjI/k9ACGpCGCaVbPTvP7Gwknpo0nIeixgeTenxt9os7zpl8h6kweY0pR+fn8OW2V1PR8f5DV+6ZR0/29wuUfS+TPs5fEXKDLYlxqvFoG/LazLQIqT7xc/BgtyNPMN30+0X8Rwr46+rC9Crf3awsWOvwNLVqIm3E0trBZ6YzAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549528; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3IMxeujrA9pkHzGmlQQ3ZftEGFPf6+T20rNX3ir1Ss0=; b=dJrI/CTvDCVBpzIzvf22EgQaCHyAl1YC5aw615MvbMqLS3X/JUcrrQKVRz7ev0P4Y06RoIz8DBgFp5TFrNh8YevBu8rAlcEsw+bg7qZoiyVxJ74LIWoHrFbZGeCkLt9pSxcUHFfIthSlNnm0CAMvr+Bbiyz2Ms5iUvVBXb1b/BA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1635549528545314.71580233431405; Fri, 29 Oct 2021 16:18:48 -0700 (PDT) Received: by mail-wr1-f45.google.com with SMTP id m22so19240471wrb.0 for ; Fri, 29 Oct 2021 16:18:48 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id i7sm2023213wmb.20.2021.10.29.16.18.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3IMxeujrA9pkHzGmlQQ3ZftEGFPf6+T20rNX3ir1Ss0=; b=n5bGVif8D3yLen/dDyF0GTte3SsTHLjO/RYMesICC77h7js6EO8LEuedJ4dN5ufOLa XzJoWryiZ77TmEbbH2eM/S+tDsBJ2LHj6Takv6D9oasyzki5uGc1VSb1l+acrtFh01L+ jSK5yEHMrjBuiWfxsLTOI0muJQOdQmpsFYVkv0HIU5qXDh3wLMgTFUTAt9NrLGi+AqRD 5wZaIl4ak/A+lHmkG9NWglqrJiffy19vZ2gYFbmpPzxzM8ArPZrdqs3XJjNXIBZHXXCN 0lv7dKcMOKZYM026zZeLUHmuoTglPMLeIFwSV3k67Lt0EICcUbQ/3f8GoPONPh/9Grg9 X0tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3IMxeujrA9pkHzGmlQQ3ZftEGFPf6+T20rNX3ir1Ss0=; b=N8Y+33F3zoxMzooPPXtmarEHNE25I7fFDu5QRvT86w98tgKpIqg2Gcgk+zIbhtndMf G8GhYCbuXwJ7gaf5tqMlpkPnsqp51vnU1b7CxmCBk48lujXT/lZiqeHNg87Aul2egHe9 /QgVTuG/6dN2HyRv4SNcy47CKu8hGovsEXWPoYcMcUEYyw7UYTZYpEg7DZIs1NSZUsCo avU2DDwpHfQz8f4KxY1gPktsXr67uPjZcsNz3JQ9/dluyPYWFiiqsip6cHvSVIoQa8tZ ZFHZOT6WCbuRbk6NN5IOrqojf88hVHIf/tf85FhpXkPqdrG0/f4R1PGXK+nVIU9Mb+4k nf3A== X-Gm-Message-State: AOAM530EFtgfgeiSVzCHGW6f1lT/llDS2lPePmq6/MrMuegTf+fdQViB 10IHpy6VVeKDgRvN1z0YXW4= X-Google-Smtp-Source: ABdhPJyP2Dnck145zvnW0eMTZy1ceYVCl2Mdd2RyPC6uRZ//52TA1tmnAjfnhU99jsDmRsOwtJydkQ== X-Received: by 2002:a05:600c:2505:: with SMTP id d5mr14526418wma.194.1635549526879; Fri, 29 Oct 2021 16:18:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/5] target/arm: Introduce store_cpu_field_constant() helper Date: Sat, 30 Oct 2021 01:18:31 +0200 Message-Id: <20211029231834.2476117-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549529875100001 Similarly to the store_cpu_field() helper which takes a TCG temporary, store its value to the CPUState, introduce the store_cpu_field_constant() helper which store a constant to CPUState (without using any TCG temporary). Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate-a32.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/translate-a32.h b/target/arm/translate-a32.h index 88f15df60e8..17af8dc95a8 100644 --- a/target/arm/translate-a32.h +++ b/target/arm/translate-a32.h @@ -70,6 +70,9 @@ static inline void store_cpu_offset(TCGv_i32 var, int off= set) #define store_cpu_field(var, name) \ store_cpu_offset(var, offsetof(CPUARMState, name)) =20 +#define store_cpu_field_constant(val, name) \ + tcg_gen_st_i32(tcg_constant_i32(val), cpu_env, offsetof(CPUARMState, n= ame)) + /* Create a new temporary and set it to the value of a CPU register. */ static inline TCGv_i32 load_reg(DisasContext *s, int reg) { --=20 2.31.1 From nobody Mon Feb 9 11:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549533; cv=none; d=zohomail.com; s=zohoarc; b=cWdYwMQVAhcPAehx6Qe0m8KQoif/CM7y80VhEwSeJsT6dxkJ9pcyNraOQv7n5yYIYlRmcfy8jO+fiAPCa2Tg/VqEFXLkrylExBvpmpwL+24IFCWaeO4gi+9rytuDbvXVqogxtXM4TSG/bsKnX5cfqpL+zFL37Z8r1GcTO/Ubya4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549533; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=swq+ujz87mpmAn8eQLeFpgy6KxnzzsPRpEtfSs0XAHY=; b=Z4MR0+Vx64M9apcS4+eete9DP/KZXIqSWPQiqQBxe5pz5OQbcYXL3sUKcCj//3vRSMUn48dcROX0OYABDVWHw4SOqWkgBKoKJ13w5v4ERxE9JH5sKyYRJc4+Oe7CWl7+mvxWxlwpKtyuM/QlRVuPEoADnQJvq+7rVKYh/3mirOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635549533289328.80089547976615; Fri, 29 Oct 2021 16:18:53 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id b12so14707877wrh.4 for ; Fri, 29 Oct 2021 16:18:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m31sm6100870wms.25.2021.10.29.16.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:18:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=swq+ujz87mpmAn8eQLeFpgy6KxnzzsPRpEtfSs0XAHY=; b=hBLWTMcI9nGwK869dA11CYAtPpX7tsO3zpRct5cSs1OAGg4mI9sPnC7hiOv15E8+0P YpEGuMk4+7mMyGTXCWxQEDZlVPeoachUvsIcc5eRPQyxAU6QeW3Ie51MjLgTuaa9e/cl B+3apkTZG9JVkg3Gl/NbgXiL9yot5MZjnVlD6LCZ+Bn08Vx1DXO8pl+j2vGAGHlKInE7 FfyjnuH+Z9AEl7ozyt07sXw9Fiu2k9PSHFlW0RzPxJakRN9JkpiM56bZmc4lh0wZRNFl owQcymVFrpZwY4FdEi12x8KtknEADMzaSKfGOtSUs7VfCNuhYLh9tropkN18kRqpaj55 hb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=swq+ujz87mpmAn8eQLeFpgy6KxnzzsPRpEtfSs0XAHY=; b=jrToekxBLE4XK/iUlaAQ7laz0/9sTfliqtUXNrmfxP4tF/nnfvXx74Q+kUdBwtauLw fIjBOgh74iOzMIVi2v6XnAkiNi1ZVzGgpd2PdlVy9JItOmWh+3EVa0AVcHD3qmRHggZ9 WRQU5MzUDsT/0+CPvZ5pimcD2yCPsM9kx6IaT/8caxNBtxtS9jPwPvMWsi7sTAGYshUN a3CKd6PRQheh1kNkRcohCe8VnRMESQmNCNnhl1JoaChK/wbyPXwcxFvjiDsud173k3TT 04jo++KYJlEumY5Zx2roEatF5l/8bIcYj37JoaytYH34svuiBhX4qcQxp6pXRQr0b/rp A9qw== X-Gm-Message-State: AOAM532Q3u/JZZEM4yOtfwGCNq9IPWOLGaxq5/CSnYRe4xeKmuL6CO6F UWXttr84wTHM9ae3L+aiDZ0= X-Google-Smtp-Source: ABdhPJxCl3XpP87KaeIVEvRLEHoA72YYpRjrhrob7D/Ucv602WXdrEeEPaHhToi/vsY39ImcqsEuiw== X-Received: by 2002:a7b:c5d9:: with SMTP id n25mr23034500wmk.139.1635549531585; Fri, 29 Oct 2021 16:18:51 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 3/5] target/arm: Use the constant variant of store_cpu_field() when possible Date: Sat, 30 Oct 2021 01:18:32 +0200 Message-Id: <20211029231834.2476117-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549534161100001 When using a constant variable, we can replace the store_cpu_field() call by store_cpu_field_constant() which avoid using TCG temporaries. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 083a6d6ed77..52ba562c96b 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -364,8 +364,7 @@ void clear_eci_state(DisasContext *s) * multiple insn executes. */ if (s->eci) { - TCGv_i32 tmp =3D tcg_const_i32(0); - store_cpu_field(tmp, condexec_bits); + store_cpu_field_constant(0, condexec_bits); s->eci =3D 0; } } @@ -740,9 +739,8 @@ void gen_set_condexec(DisasContext *s) { if (s->condexec_mask) { uint32_t val =3D (s->condexec_cond << 4) | (s->condexec_mask >> 1); - TCGv_i32 tmp =3D tcg_temp_new_i32(); - tcg_gen_movi_i32(tmp, val); - store_cpu_field(tmp, condexec_bits); + + store_cpu_field_constant(val, condexec_bits); } } =20 @@ -8362,8 +8360,6 @@ static bool trans_BL(DisasContext *s, arg_i *a) =20 static bool trans_BLX_i(DisasContext *s, arg_BLX_i *a) { - TCGv_i32 tmp; - /* * BLX would be useless on M-profile; the encoding space * is used for other insns from v8.1M onward, and UNDEFs before that. @@ -8377,8 +8373,7 @@ static bool trans_BLX_i(DisasContext *s, arg_BLX_i *a) return false; } tcg_gen_movi_i32(cpu_R[14], s->base.pc_next | s->thumb); - tmp =3D tcg_const_i32(!s->thumb); - store_cpu_field(tmp, thumb); + store_cpu_field_constant(!s->thumb, thumb); gen_jmp(s, (read_pc(s) & ~3) + a->imm); return true; } @@ -8677,7 +8672,6 @@ static bool trans_LCTP(DisasContext *s, arg_LCTP *a) * doesn't cache branch information, all we need to do is reset * FPSCR.LTPSIZE to 4. */ - TCGv_i32 ltpsize; =20 if (!dc_isar_feature(aa32_lob, s) || !dc_isar_feature(aa32_mve, s)) { @@ -8688,8 +8682,7 @@ static bool trans_LCTP(DisasContext *s, arg_LCTP *a) return true; } =20 - ltpsize =3D tcg_const_i32(4); - store_cpu_field(ltpsize, v7m.ltpsize); + store_cpu_field_constant(4, v7m.ltpsize); return true; } =20 @@ -9487,9 +9480,7 @@ static void arm_tr_tb_start(DisasContextBase *dcbase,= CPUState *cpu) /* Reset the conditional execution bits immediately. This avoids complications trying to do it at the end of the block. */ if (dc->condexec_mask || dc->condexec_cond) { - TCGv_i32 tmp =3D tcg_temp_new_i32(); - tcg_gen_movi_i32(tmp, 0); - store_cpu_field(tmp, condexec_bits); + store_cpu_field_constant(0, condexec_bits); } } =20 --=20 2.31.1 From nobody Mon Feb 9 11:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549538; cv=none; d=zohomail.com; s=zohoarc; b=iitbkvk8nZEAu9W3yXvHNLvokjcpx5xvIZzkXD24P037FWHuldFxKBpLEpm4xRFaAfQoDVceQRMlWqQG5MxYvWETkoNfc+TN8hiejgl4hdAe5GyoyMo32K1N4UelMUfSXBsjdCfLzhvHYKR1N3n1og+jGJ4okd/mBblluq1iWnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549538; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MY9quCqJ/2Bz6tK8Zx9ZzguPdmzXrHRSyEOAkDlUTqE=; b=Yj0px0MB6jb71FWwZWLKIFb6QXScj2Z8A8nl6llvzxnq7TTF9vq8Ylb0TCwdDXEYOMHasupN5SAVK9o9/wv5FrVdaRmXP/TwuHMKwOC/2LVh7clzzphu3IM/nvok0nz6ecZnmP1G/sqGVpIo3MM6AdcLq7Oj75a2Z6bud5UotiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1635549538365663.2050053702778; Fri, 29 Oct 2021 16:18:58 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id r8so6348129wra.7 for ; Fri, 29 Oct 2021 16:18:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id r11sm6588586wrt.42.2021.10.29.16.18.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MY9quCqJ/2Bz6tK8Zx9ZzguPdmzXrHRSyEOAkDlUTqE=; b=lNarN3wuSC4YDnLa0xvKEKXbmxO4J9zrq2P/0W6YJbryUerWu8qlqhlSGRTFcyP06W CFTa4WivDsVZgdaovZoPE5vpYn0KGfszueFmDEk/OX5BKYCy5+LNq2hTCLLcy8gBKW7/ feSmeASjMW2B+gfhgrNcQAGvaGHRv9gXm0c2pzXzfvGCshrtRM+i8fXGki3709iq79c9 d69uv6zvGVtFQ2v8Rkdcxs7Wy8eoMqdtna7CIgq0O13CBoTQKlUFkmb5JN4a2c8DNG5a lYl5u6l9/SJIA5iHFeNgW79S8mOYxhEpDkLIK44U8KIYPJqUWmcmmdEHQmt2afUmFW4o 6rbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MY9quCqJ/2Bz6tK8Zx9ZzguPdmzXrHRSyEOAkDlUTqE=; b=19pF2HbNlkVg0oHRN2CrwlFTG0NVRgv+7bftuZ2103RmA4e+Eeyg4BJYlYzV4Yaoh8 /8l1trkiEtTYMVGFZLSq7PFS3Aei0VmX6BJ0mMyvARRp+mw7ADw+vuclA0FYSTOvTxvq 28tbbG4Bp2Q7/8zyvOxh62IX4FsBq4flVsC4jz52TMCrc3IDRU1+9mb3UJTL4Uz+YJMT Vn2b1cLMK6Tp31irL8z2cwPCEFdI92p8CuQqpGFaDfMYP07I+XHZG/mNWHgrgHnNE1BW uJtYJ8i45YzrYC+x18+27ds+rBbd8qj76bD4uz0iey++EDunuq9nW2EqtpsruXN5nsHY HUyw== X-Gm-Message-State: AOAM530CnXxSbHTJ3zV5zMYjO2req/xDxXQvxBoUp/yHzRp2rPiJaMsz KsTC5657sXPZyMFnYK/hVpT3tnUfbhE= X-Google-Smtp-Source: ABdhPJxebAJZSh5pCFFKXlC5/mX/OX+LffRnk4wyXHnV6YlCZS0gKMGb27L8ekma7Wean/5+MznR4g== X-Received: by 2002:a5d:6e91:: with SMTP id k17mr17735855wrz.260.1635549536702; Fri, 29 Oct 2021 16:18:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 4/5] target/arm: Use tcg_constant_i64() in do_sat_addsub_64() Date: Sat, 30 Oct 2021 01:18:33 +0200 Message-Id: <20211029231834.2476117-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549540409100001 The immediate value used for comparison is constant and read-only. Move it to the constant pool. This frees a TCG temporary for unsigned saturation opcodes. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/translate-sve.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index bc91a641711..76b5fe9f313 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -1943,20 +1943,20 @@ static void do_sat_addsub_32(TCGv_i64 reg, TCGv_i64= val, bool u, bool d) static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 val, bool u, bool d) { TCGv_i64 t0 =3D tcg_temp_new_i64(); - TCGv_i64 t1 =3D tcg_temp_new_i64(); TCGv_i64 t2; =20 if (u) { if (d) { tcg_gen_sub_i64(t0, reg, val); - tcg_gen_movi_i64(t1, 0); - tcg_gen_movcond_i64(TCG_COND_LTU, reg, reg, val, t1, t0); + t2 =3D tcg_constant_i64(0); + tcg_gen_movcond_i64(TCG_COND_LTU, reg, reg, val, t2, t0); } else { tcg_gen_add_i64(t0, reg, val); - tcg_gen_movi_i64(t1, -1); - tcg_gen_movcond_i64(TCG_COND_LTU, reg, t0, reg, t1, t0); + t2 =3D tcg_constant_i64(-1); + tcg_gen_movcond_i64(TCG_COND_LTU, reg, t0, reg, t2, t0); } } else { + TCGv_i64 t1 =3D tcg_temp_new_i64(); if (d) { /* Detect signed overflow for subtraction. */ tcg_gen_xor_i64(t0, reg, val); @@ -1966,7 +1966,7 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64 v= al, bool u, bool d) =20 /* Bound the result. */ tcg_gen_movi_i64(reg, INT64_MIN); - t2 =3D tcg_const_i64(0); + t2 =3D tcg_constant_i64(0); tcg_gen_movcond_i64(TCG_COND_LT, reg, t0, t2, reg, t1); } else { /* Detect signed overflow for addition. */ @@ -1977,13 +1977,12 @@ static void do_sat_addsub_64(TCGv_i64 reg, TCGv_i64= val, bool u, bool d) =20 /* Bound the result. */ tcg_gen_movi_i64(t1, INT64_MAX); - t2 =3D tcg_const_i64(0); + t2 =3D tcg_constant_i64(0); tcg_gen_movcond_i64(TCG_COND_LT, reg, t0, t2, t1, reg); } - tcg_temp_free_i64(t2); + tcg_temp_free_i64(t1); } tcg_temp_free_i64(t0); - tcg_temp_free_i64(t1); } =20 /* Similarly with a vector and a scalar operand. */ --=20 2.31.1 From nobody Mon Feb 9 11:45:04 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635549542; cv=none; d=zohomail.com; s=zohoarc; b=D4TXaYJxvM+9KibHgRHSDh3+BSsOdtuM/71gm3pf2jcXgo5h4XR4Wg7bT1pRrdQzzvSJo5A8/4FDP0opNpdCAcUR3W2xsdOvRpDwT/r8vtBZ3AUrfz45Rn0Odk7vaynVPe3doXyXAHFsJW3gVvs2MC2ex/g7olMD08yt4q/w3kg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635549542; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=H165jyj+0ikouKRyHfDySD7H7c8FAy6K0GMN+HxJ7PuSu2chmBD8aHy9ZDhQ+BBeL9u66sxAPGHogKIu3ypWf/v3aZuZ1dxWS/m2gWMuUUAqn5F92Yc4Ghmo01G/E/25/uzFsO+ALzKVBhgidUzDDAJCKjScefo+6FOco400rzk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1635549542936692.1702151286783; Fri, 29 Oct 2021 16:19:02 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id d13so19118840wrf.11 for ; Fri, 29 Oct 2021 16:19:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id m31sm6101077wms.25.2021.10.29.16.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=M6SfMHp4Zc6aXXjB4JyAWmmq/OmIVjg17/xj/sQneHpq9G53s60ZDJL0bX34rBFFBL C1o4RFQBs0J+9NizVoz7+br9VJqHQivGhsdwiaJkbrCI31CW01VT3i6KbYjW8IdpM/NO ysyt3ji5QNxekGvzWChvSWZL+4EZAEToRNsDqAlCYF/o+7dNBxYZCKX9XNXkEQK3NbF9 9HE2LB3Ut6O97U2H9Ii1ftYmn15O9LVo58Fuh/6ic4ri0XPTzc7J5BA53Lf+VIfHfthG yjNkxQRggc00bfFYNRWBtlqEkL3amuX12GJUflQkl1CDEOHxPY4vUlEMJmp/UtqzEYdX s0ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ieQbVDxIHnha6cbVzHSPGmTvFgdN0qxlT4jv5otEkqQ=; b=uqklnpFf56K31xorx2LjISyL4moM+8EyOkLmtE/QJUZ5VdOxpt47FgUtDXxJgnSzPR XZ2bKR8d1rl6OaeZ61sKIxpWhoNvxv9eyJcPLgyPoCT5zEL0p4RXGxghHKyC4ENPr923 aw5yTNkinBWDdG7a/hAkuNqtQy4QcPmn28ZOFb1Fc7A+v82v9fxGRRukASfnlpRQHGjG RglkiGnpOECC2zc/8bJFgvitiy+dtA6pDL9YgqWzKhm8oln4nWjiqZO236Z0oLuoJv3T 34QqqtobDBV6lyaM6VQQi6ibPq4iyWwpa89+ELhF+2lJuTk1NYWXek1bDGnydZbBU5Ln WixA== X-Gm-Message-State: AOAM533MMBMFYpSItaUiUsuOcBqKj3dWt1+pyMv/XrjOrt/o+tl+Ttxn TjHvewp2vny0JBRbG7/4JM0= X-Google-Smtp-Source: ABdhPJybpCFo2JuRbV13PP3ytPacRhElX+Ik/UdY6qq4B2n5zhXKPGu82zvLmPFGiE6uly4ph2QlzA== X-Received: by 2002:a1c:750b:: with SMTP id o11mr14551589wmc.5.1635549541257; Fri, 29 Oct 2021 16:19:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Peter Maydell , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 5/5] target/arm: Use tcg_constant_i32() in gen_rev16() Date: Sat, 30 Oct 2021 01:18:34 +0200 Message-Id: <20211029231834.2476117-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029231834.2476117-1-f4bug@amsat.org> References: <20211029231834.2476117-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635549544769100001 Since the mask is a constant value, use tcg_constant_i32() instead of a TCG temporary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate.c b/target/arm/translate.c index 52ba562c96b..98f59259284 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -388,13 +388,12 @@ static void gen_smul_dual(TCGv_i32 a, TCGv_i32 b) void gen_rev16(TCGv_i32 dest, TCGv_i32 var) { TCGv_i32 tmp =3D tcg_temp_new_i32(); - TCGv_i32 mask =3D tcg_const_i32(0x00ff00ff); + TCGv_i32 mask =3D tcg_constant_i32(0x00ff00ff); tcg_gen_shri_i32(tmp, var, 8); tcg_gen_and_i32(tmp, tmp, mask); tcg_gen_and_i32(var, var, mask); tcg_gen_shli_i32(var, var, 8); tcg_gen_or_i32(dest, var, tmp); - tcg_temp_free_i32(mask); tcg_temp_free_i32(tmp); } =20 --=20 2.31.1