From nobody Mon Feb 9 16:19:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635548531; cv=none; d=zohomail.com; s=zohoarc; b=DR+351hxXyeiMnrn3SWtsXq1GR6jyvrQZAbZZHgD7Wo+of1QJwxQpd8Hrfx9T+aUDYgZDAwzrIrcAHRfbwPW3XuS89ieT7QXWcDVLmDluDYsbkQAk+FT6n76yX7x3fSZfOyZxTeh/kpCpeN5TS+yjRf+3xf4S+jOtJjMLvMIzn0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635548531; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fr5VMOOKt0GVUz4qiC1RIeVWBlnPu1If/ZrGlw1UN7k=; b=PbX/FwuWq6RRyFZr04SnUDlst34nflXBrjBV+poIGcN8wWweo0AD3PPyBKDRP4HZuoo+T4kFAlq+fuHTM0dg8dk3WveFvswBL7Cpm7qc4RNkdw460QZZwda7GB8muVP5oOewtvDak9Jk7XJdhlxgxbRZNG/yAXTS7MF1SnZ0RYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1635548531170367.11447121943604; Fri, 29 Oct 2021 16:02:11 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-352-5c1CRdgzMa-TkR5c-1gUOA-1; Fri, 29 Oct 2021 19:02:08 -0400 Received: by mail-wr1-f72.google.com with SMTP id d13-20020adfa34d000000b00160aa1cc5f1so4144822wrb.14 for ; Fri, 29 Oct 2021 16:02:08 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id t15sm5909999wmi.24.2021.10.29.16.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Oct 2021 16:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635548530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fr5VMOOKt0GVUz4qiC1RIeVWBlnPu1If/ZrGlw1UN7k=; b=FTn//fCrcFP+cOMAgkptdzfz8w51wtrnADx5bA2N/pnN6UOejJLcj+tFtLwWOtQKJ/fVSP XMLJ+amm7zELwbvpfFp4YyylO2pS1Y0LrXsJ7XZYDFgM6mDJEnNOCcy8awA/1wW/wF/F9w 7viSCahMVdyk4DUvn0Ln3fTVyqEtxB4= X-MC-Unique: 5c1CRdgzMa-TkR5c-1gUOA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fr5VMOOKt0GVUz4qiC1RIeVWBlnPu1If/ZrGlw1UN7k=; b=atlP6BC+KfBmLK9bD4WfsOMgso329OOxIfkl6weKBq9TsCeDu/GT6e+netwq+u88xJ HH1mYFaqup3ZS0SIgBYmLOxEWYYyPaCzwUz/6NP1G7DCKl6Ohpht2Ta7QEtmkeL4uD85 OjIFPFWoQ6PgFMTcsWWELQR2o176LHTeQhNhldTtFTTelmnpfNOhoRRefMXSP8QTI5Rs sEatpfzHm6sIWoPX+ZO9HHADgtjPUwm/vtFYOyLsCb6Dr2m441FoDISuWpuHKxP6p/zE tZGZjWncnFZiTXvcM0P63h2EcANZvsz/VLbjL0slIKljSzsODj6DEZ0vwxmRhM3jl8lG votQ== X-Gm-Message-State: AOAM531PQdWa7vRSNPBZi+DHGO+x1ZLR8AZf8uS21cFwa37wIXah2ATb /DS26BioLLeG+i9uqYazFSf+NzDi1wqblba3pjMLyz9v864Wjgw4gx9mJ2ndxkUc1eIK/a/R/NS UL19h2L5uz6WS7g== X-Received: by 2002:a05:600c:a42:: with SMTP id c2mr22554139wmq.154.1635548527607; Fri, 29 Oct 2021 16:02:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrpGWrJ5Q0pokQ5CxmKPkdczx/jh1JX9VeyM4eidl/CsZRs06Mr2UwFWc0wU0GO0poqdcoCw== X-Received: by 2002:a05:600c:a42:: with SMTP id c2mr22554117wmq.154.1635548527432; Fri, 29 Oct 2021 16:02:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Dr. David Alan Gilbert" , Marcel Apfelbaum , Damien Hedde , Eduardo Habkost , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Armbruster , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini Subject: [PATCH 4/5] hw/core: Remove uses of QERR_PROPERTY_VALUE_BAD Date: Sat, 30 Oct 2021 01:01:46 +0200 Message-Id: <20211029230147.2465055-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211029230147.2465055-1-philmd@redhat.com> References: <20211029230147.2465055-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635548532599100003 QERR_PROPERTY_VALUE_BAD definition is obsolete since 2015 (commit 4629ed1e989, "qerror: Finally unused, clean up"). Replace the two uses and drop the definition. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qapi/qmp/qerror.h | 3 --- hw/core/qdev-properties.c | 2 +- target/i386/cpu.c | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index f49ae01cdb0..a3f44fc4a1e 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -50,9 +50,6 @@ #define QERR_PERMISSION_DENIED \ "Insufficient permission to perform this operation" =20 -#define QERR_PROPERTY_VALUE_BAD \ - "Property '%s.%s' doesn't take value '%s'" - #define QERR_PROPERTY_VALUE_OUT_OF_RANGE \ "Property %s.%s doesn't take value %" PRId64 " (minimum: %" PRId64 ", = maximum: %" PRId64 ")" =20 diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index c34aac6ebc9..dbea4cf8e5e 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -663,7 +663,7 @@ void error_set_from_qdev_prop_error(Error **errp, int r= et, Object *obj, break; default: case -EINVAL: - error_setg(errp, QERR_PROPERTY_VALUE_BAD, + error_setg(errp, "Property '%s.%s' doesn't take value '%s'", object_get_typename(obj), name, value); break; case -ENOENT: diff --git a/target/i386/cpu.c b/target/i386/cpu.c index fc3ed80ef1e..bc63b80e5bd 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4469,7 +4469,7 @@ static void x86_cpuid_set_vendor(Object *obj, const c= har *value, int i; =20 if (strlen(value) !=3D CPUID_VENDOR_SZ) { - error_setg(errp, QERR_PROPERTY_VALUE_BAD, "", "vendor", value); + error_setg(errp, "Property '.vendor' doesn't take value '%s'", val= ue); return; } =20 --=20 2.31.1