From nobody Mon Feb 9 11:06:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1635448003; cv=none; d=zohomail.com; s=zohoarc; b=W++yvPwnbSwtBR/tMTELn0TaI1bJ4edQ8TAHYlV7N7mr2awC+NtBFAeVCSSxJRwMOYYr3F789wJ1z61UKzH6DVitIpfUpv/fb7uW5AwMyPhvqOYkPtVEqDNCKRf1xR2Ml2lwTb/3IfM/prXYYVTpuqLU+lqQDllFI0WiMlywzqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635448003; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9yhi8L4C4GnMYKVMPV4uZwu5G4WEZ36IdMhnOK6XKYI=; b=UxXmUdnR+yibY8fMsVdi8nyPqW3mKSMnAGoByBPOUjRXZ5KrUQyGT3vIH7Lwop2zOn7/KgZ8EzhTs62l6KLjO8ocz+FNNMR/qcgAROXc7PpgurRGhQwpu6WGeL0NoMqC2WYpQUg1/d/XRRyiA6lzKjKz9vWhA7ZJ7HaDBiuoz+g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635448003356753.2529021905709; Thu, 28 Oct 2021 12:06:43 -0700 (PDT) Received: from localhost ([::1]:46664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mgAja-0002yE-BX for importer@patchew.org; Thu, 28 Oct 2021 15:06:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgAcl-0003NY-KR for qemu-devel@nongnu.org; Thu, 28 Oct 2021 14:59:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mgAca-0008Cv-9s for qemu-devel@nongnu.org; Thu, 28 Oct 2021 14:59:39 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-OV6OIQR3Py28SyEU2N53tg-1; Thu, 28 Oct 2021 14:59:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49446112C14B for ; Thu, 28 Oct 2021 18:59:22 +0000 (UTC) Received: from thuth.com (unknown [10.39.193.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81F815BAF0; Thu, 28 Oct 2021 18:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635447564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9yhi8L4C4GnMYKVMPV4uZwu5G4WEZ36IdMhnOK6XKYI=; b=UmJuwj5phDpI71DPEFuIo9chmWHX2FNnZb8SJHVDhTkKJ3q5vnh7ka8WGjnO2MN3VMX61M FbJxBo6srEsoFuBBjlghPyee5nsZZGbmdmqg+E/BE46vxLyvyOU1IIpmY1T66saaCK8URv dlRh8bCgrsdAqwOW9QgCvExy9pKjtCQ= X-MC-Unique: OV6OIQR3Py28SyEU2N53tg-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH 2/4] Move the l2tpv3 test from configure to meson.build Date: Thu, 28 Oct 2021 20:59:08 +0200 Message-Id: <20211028185910.1729744-3-thuth@redhat.com> In-Reply-To: <20211028185910.1729744-1-thuth@redhat.com> References: <20211028185910.1729744-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1635448004181100001 Content-Type: text/plain; charset="utf-8" And while we're at it, also provide a proper entry for this feature in meson_options.txt, so that people who don't need it have a knob to disable this feature. Signed-off-by: Thomas Huth --- configure | 17 ----------------- meson.build | 8 ++++++++ meson_options.txt | 2 ++ net/meson.build | 4 +++- scripts/meson-buildoptions.sh | 3 +++ 5 files changed, 16 insertions(+), 18 deletions(-) diff --git a/configure b/configure index 8fe03b6230..170b1b237a 100755 --- a/configure +++ b/configure @@ -1907,20 +1907,6 @@ if test -z "$want_tools"; then fi fi =20 -########################################## -# L2TPV3 probe - -cat > $TMPC < -#include -int main(void) { return sizeof(struct mmsghdr); } -EOF -if compile_prog "" "" ; then - l2tpv3=3Dyes -else - l2tpv3=3Dno -fi - ######################################### # vhost interdependencies and host support =20 @@ -3544,9 +3530,6 @@ if test "$slirp_smbd" =3D "yes" ; then echo "CONFIG_SLIRP_SMBD=3Dy" >> $config_host_mak echo "CONFIG_SMBD_COMMAND=3D\"$smbd\"" >> $config_host_mak fi -if test "$l2tpv3" =3D "yes" ; then - echo "CONFIG_L2TPV3=3Dy" >> $config_host_mak -fi if test "$gprof" =3D "yes" ; then echo "CONFIG_GPROF=3Dy" >> $config_host_mak fi diff --git a/meson.build b/meson.build index 2c5b53cbe2..5bb6b901b0 100644 --- a/meson.build +++ b/meson.build @@ -1678,6 +1678,13 @@ config_host_data.set('HAVE_MLOCKALL', cc.links(gnu_s= ource_prefix + ''' return mlockall(MCL_FUTURE); }''')) =20 +have_l2tpv3 =3D false +if not get_option('l2tpv3').disabled() and have_system + have_l2tpv3 =3D (cc.has_header_symbol('sys/socket.h', 'struct mmsghdr') + and cc.has_header('linux/ip.h')) +endif +config_host_data.set('CONFIG_L2TPV3', have_l2tpv3) + have_netmap =3D false if not get_option('netmap').disabled() and have_system have_netmap =3D cc.compiles(''' @@ -3394,6 +3401,7 @@ summary_info +=3D {'JACK support': jack} summary_info +=3D {'brlapi support': brlapi} summary_info +=3D {'vde support': vde} summary_info +=3D {'netmap support': have_netmap} +summary_info +=3D {'l2tpv3 support': have_l2tpv3} summary_info +=3D {'Linux AIO support': libaio} summary_info +=3D {'Linux io_uring support': linux_io_uring} summary_info +=3D {'ATTR/XATTR support': libattr} diff --git a/meson_options.txt b/meson_options.txt index 4ab4570125..e740dce2a5 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -141,6 +141,8 @@ option('u2f', type : 'feature', value : 'auto', description: 'U2F emulation support') option('usb_redir', type : 'feature', value : 'auto', description: 'libusbredir support') +option('l2tpv3', type : 'feature', value : 'auto', + description: 'l2tpv3 network backend support') option('netmap', type : 'feature', value : 'auto', description: 'netmap network backend support') option('vde', type : 'feature', value : 'auto', diff --git a/net/meson.build b/net/meson.build index 94383e7460..847bc2ac85 100644 --- a/net/meson.build +++ b/net/meson.build @@ -18,7 +18,9 @@ softmmu_ss.add(files( =20 softmmu_ss.add(when: 'CONFIG_TCG', if_true: files('filter-replay.c')) =20 -softmmu_ss.add(when: 'CONFIG_L2TPV3', if_true: files('l2tpv3.c')) +if have_l2tpv3 + softmmu_ss.add(files('l2tpv3.c')) +endif softmmu_ss.add(when: slirp, if_true: files('slirp.c')) softmmu_ss.add(when: vde, if_true: files('vde.c')) if have_netmap diff --git a/scripts/meson-buildoptions.sh b/scripts/meson-buildoptions.sh index c795a13020..55b8a78560 100644 --- a/scripts/meson-buildoptions.sh +++ b/scripts/meson-buildoptions.sh @@ -49,6 +49,7 @@ meson_options_help() { printf "%s\n" ' iconv Font glyph conversion support' printf "%s\n" ' jack JACK sound support' printf "%s\n" ' kvm KVM acceleration support' + printf "%s\n" ' l2tpv3 l2tpv3 network backend support' printf "%s\n" ' libdaxctl libdaxctl support' printf "%s\n" ' libiscsi libiscsi userspace initiator' printf "%s\n" ' libnfs libnfs block device driver' @@ -166,6 +167,8 @@ _meson_option_parse() { --disable-jack) printf "%s" -Djack=3Ddisabled ;; --enable-kvm) printf "%s" -Dkvm=3Denabled ;; --disable-kvm) printf "%s" -Dkvm=3Ddisabled ;; + --enable-l2tpv3) printf "%s" -Dl2tpv3=3Denabled ;; + --disable-l2tpv3) printf "%s" -Dl2tpv3=3Ddisabled ;; --enable-libdaxctl) printf "%s" -Dlibdaxctl=3Denabled ;; --disable-libdaxctl) printf "%s" -Dlibdaxctl=3Ddisabled ;; --enable-libiscsi) printf "%s" -Dlibiscsi=3Denabled ;; --=20 2.27.0