From nobody Mon Feb 9 18:18:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358092; cv=none; d=zohomail.com; s=zohoarc; b=E46Mxq1A66FdLENXI5GQYuazcORO0ZYT/uBfUWAtvs8OruQONCImP3gJfftwqLL3iBqYqK0UNpuyRXFgwckk9Ea2WSUgeS97bttwUx3eORCI4Ex+kcrBalq8BEteG2S0ll0rUz4vbf5J+7ZA2qZ77c64hKvHgNMYfaK+d4BJXh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358092; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SBiknKQuhfDEYQrYt1q9LI2OLCw/EZSt3fd0UGk9Wxo=; b=UbO9qphzgnpkjQUdFtSNM5oGsPCnKZxaW6MX7SyzRBTD1yeowk7DPXUzMukubG+JXMDlX1+F4sgPhY7cte7lPLJRreqcTjpEMwH3uzHx/KQ/Tpo8gK4TljvJi8zuQwkmWoPYbwlcFj0LJKiTJoUYqAohb5NT08d5H/KgH+JqhWw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1635358092391916.556697558348; Wed, 27 Oct 2021 11:08:12 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id o14so5553862wra.12 for ; Wed, 27 Oct 2021 11:08:11 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id u16sm3990173wmc.21.2021.10.27.11.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SBiknKQuhfDEYQrYt1q9LI2OLCw/EZSt3fd0UGk9Wxo=; b=hF31FRUO9LfcZ0iKyYkvJ6lGypiOO6yYJDuUqD5Zyj3KtUVeFymIrUgmzFCJkfpqej qUkgGgkKWKUo3rR9Q28DPfWnYxyZyCkB5AELwyfAAb/SULepkb1RHJWm1hoq0mvuEICc /BMFkO0bOV2gRGANDANAHSRZbJ9EW0w33znD36uGQkfsBVoKSeSfaaeuW9NxZmMZm6Ep E2/wrRyqFRfZgr+VdRKlqnRE9O74xiQ7PjMNFuBTRgmuEokCJEdBrE0JN94kKIFHzd08 UjbVzbXPqqjjY8KEVHXHsiTqTCxNPdy1MMpC0p2uRSRECW4XUhSlBCmvNpRVIUuQLFly 5Q8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=SBiknKQuhfDEYQrYt1q9LI2OLCw/EZSt3fd0UGk9Wxo=; b=nCVPIWfjUVgrkGdWIWoY77cl0cJtrSgpAdrjuTAHklhktP4TMnH4vV2Ubg06nARN26 8BZaWtmrB40/WSkBxpmLj9UeXjRwa0Gb19ZQyU8pYJ+2fCuPNhmRcUW3W8ZDt670WHaM Sn+EIV+LwjW3NUmPLpgI4Xy3NRNJ0u3AI9xFHMDz5JIztBcydRVAaKcc4BOalfZGr8Oj Qht/T8HmmHrk83JLDS7MUtu2OxNcE/qjDOSvl4SSTi8WFZBrnLlcBTV0l+e507iTqtSV 42sPB3PQhmTgmC7AZN45R1lQ6bsjFkGkE/cWj7lG7jR4mw3LVyB7fuKXqfaGhMaybhAD ETXA== X-Gm-Message-State: AOAM531/nV2VyEXx3vepuIEYpkPVDsmWqnzDOrl06gOHXMN0qLvn1F7+ 1xkTDSiwn166HdXgyd+VFck= X-Google-Smtp-Source: ABdhPJy3W8i8a9+97ZAInCLuulVSfzjVngu5FXh6VgeYLnm23R/Ax9dDfce/cHYdpmUNCShBOw5OSQ== X-Received: by 2002:a5d:6a91:: with SMTP id s17mr15225190wru.18.1635358090697; Wed, 27 Oct 2021 11:08:10 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH v2 08/32] target/mips: Convert MSA LDI opcode to decodetree Date: Wed, 27 Oct 2021 20:07:06 +0200 Message-Id: <20211027180730.1551932-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358094109100001 Convert the LDI opcode (Immediate Load) to decodetree. Since it overlaps with the generic MSA handler, use a decodetree overlap group. Since the 'data format' field is a constant value, use tcg_constant_i32() instead of a TCG temporary. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v2: - add &msa_ldi format - !check_msa_enabled -> return true - TCG timm is constant --- target/mips/tcg/msa.decode | 8 +++++++- target/mips/tcg/msa_translate.c | 22 ++++++++++++++-------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/target/mips/tcg/msa.decode b/target/mips/tcg/msa.decode index 56419a24eb9..bdfe5a24cb3 100644 --- a/target/mips/tcg/msa.decode +++ b/target/mips/tcg/msa.decode @@ -14,10 +14,12 @@ &r rs rt rd sa =20 &msa_bz df wt sa +&msa_ldi df wd sa =20 @lsa ...... rs:5 rt:5 rd:5 ... sa:2 ...... &r @bz_v ...... ... .. wt:5 sa:16 &msa_bz df=3D3 @bz ...... ... df:2 wt:5 sa:16 &msa_bz +@ldi ...... ... df:2 sa:s10 wd:5 ...... &msa_ldi =20 LSA 000000 ..... ..... ..... 000 .. 000101 @lsa DLSA 000000 ..... ..... ..... 000 .. 010101 @lsa @@ -27,4 +29,8 @@ BNZ_V 010001 01111 ..... ................ = @bz_v BZ 010001 110 .. ..... ................ @bz BNZ 010001 111 .. ..... ................ @bz =20 -MSA 011110 -------------------------- +{ + LDI 011110 110 .. .......... ..... 000111 @ldi + + MSA 011110 -------------------------- +} diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 0aaf441f359..46f5ba092e1 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -70,7 +70,6 @@ enum { OPC_CLEI_S_df =3D (0x4 << 23) | OPC_MSA_I5_07, OPC_MINI_U_df =3D (0x5 << 23) | OPC_MSA_I5_06, OPC_CLEI_U_df =3D (0x5 << 23) | OPC_MSA_I5_07, - OPC_LDI_df =3D (0x6 << 23) | OPC_MSA_I5_07, =20 /* I8 instruction */ OPC_ANDI_B =3D (0x0 << 24) | OPC_MSA_I8_00, @@ -513,13 +512,6 @@ static void gen_msa_i5(DisasContext *ctx) case OPC_CLEI_U_df: gen_helper_msa_clei_u_df(cpu_env, tdf, twd, tws, timm); break; - case OPC_LDI_df: - { - int32_t s10 =3D sextract32(ctx->opcode, 11, 10); - tcg_gen_movi_i32(timm, s10); - gen_helper_msa_ldi_df(cpu_env, tdf, twd, timm); - } - break; default: MIPS_INVAL("MSA instruction"); gen_reserved_instruction(ctx); @@ -532,6 +524,20 @@ static void gen_msa_i5(DisasContext *ctx) tcg_temp_free_i32(timm); } =20 +static bool trans_LDI(DisasContext *ctx, arg_msa_ldi *a) +{ + if (!check_msa_enabled(ctx)) { + return true; + } + + gen_helper_msa_ldi_df(cpu_env, + tcg_constant_i32(a->df), + tcg_constant_i32(a->wd), + tcg_constant_i32(a->sa)); + + return true; +} + static void gen_msa_bit(DisasContext *ctx) { #define MASK_MSA_BIT(op) (MASK_MSA_MINOR(op) | (op & (0x7 << 23))) --=20 2.31.1