From nobody Mon Feb 9 17:59:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358084; cv=none; d=zohomail.com; s=zohoarc; b=bO1gcvmElc0Za2zNyXq+ypF6yJE2lZDj8Om09KUEwESRoEFu6T+7QicBagtc6hW4Swtzs8pOKbUYUKs3QibHclVHhluFqQYaSnNxmdjiIUA7PSV0SL7J0pHd/iWNwbc53QGelTAGyBe/O5MW/KQhjYYyvYwjW4F3PyTOcwEyaZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358084; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fKRBUC8ZqKhsjXxFp/06594igJCBInZgNfHicCGq+Zo=; b=EvCf3S7p8oSPRtPCLQjQ0l3ZWGSmwD+Td2D6tm0DaBrwhCYaETQy2R2fOeYBdiI+nU8bD+AjWdjNywVKbWI2G80a+3CLcb839mN/VibkX2jShvskbEHE0wdvx2DMJsU+Xb1bRXA4OqGdvq2u6ecnTB8Lm0ziIJVsoyPrj1pbLVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1635358084298684.5087913972131; Wed, 27 Oct 2021 11:08:04 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id d13so5568065wrf.11 for ; Wed, 27 Oct 2021 11:07:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id u16sm601816wrt.97.2021.10.27.11.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fKRBUC8ZqKhsjXxFp/06594igJCBInZgNfHicCGq+Zo=; b=IuKrI5Hr/bgNaNRs4kwYP/lPiQ3ImH8fiE2PIsORxlh/+UqT5w+7j2ZJzC5f/xkAIM 5poB7jcA76IORdudHLeRGczGUOU/g/VNEovYDTQBCS3YhBwwBMutqB3PJimR1GZ+nLpA DCMQtqFS6V+ECrBPT7jNIEKhSEc+XL9axGUAzXJpb3l7yeYE5ZlvtglLJh1ypvAOFp7j elZKMtDKX+EmqhiXsk5/MUfcUVZF3E0SwnfIGDyyu0D8ALMzinwq6/OUqoH5yKK59xhK w09DNw+bOoM3jMpZI9XuGTwLCp4+FP7p8q1xmI9lTOXLlaQ1+qS+eLhzSvjOWJwSDRBQ yPtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fKRBUC8ZqKhsjXxFp/06594igJCBInZgNfHicCGq+Zo=; b=IPAhW+U3E/89BRNl4RcUmXLXYTbdJahVY5Ggz3yLQToFKu8McAXWKbxCTiUHXGzLze zXpQT56JnQ9q9Y6DBBxtsg3StUAGoif1+hSZfzA6mfIsTid2fyJ1qbguYYoe3PQyApg3 +SwjKqUW4kAKDXQ75Rjuo0bvaEo/4Pjun6Hwt24uoHAupM8qQG++VexBOl6X/HwzKDU0 IfDqGqQzabbDL6zInZ/f5CsqPw/DOw8XDw/ED3FiDzQLjpICrJWbc50+JXUWHREW051M QCbCCtlvM941cTAl1JQ1Arup+UBYuQhwOCQz9ZvJKAuvG1aHyNJVPlmJ8jM7CoH6Thp3 dM0w== X-Gm-Message-State: AOAM531tXtETCCgyPAsSyw9mFT1MAMyND7JalLVwtWd9gpEIDRpnybyq 73f9kJUHQCiApLqNhykDnU0= X-Google-Smtp-Source: ABdhPJyPRxANg8HFgyNkMdsN3dUHJU7LvWlI72S7ZvKg09rnrwNgaWRFjgEJZAkQysiZQSKJn5mu0Q== X-Received: by 2002:adf:d1c3:: with SMTP id b3mr19421949wrd.273.1635358076692; Wed, 27 Oct 2021 11:07:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH v2 05/32] target/mips: Have check_msa_access() return a boolean Date: Wed, 27 Oct 2021 20:07:03 +0200 Message-Id: <20211027180730.1551932-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358085038100002 Have check_msa_access() return a boolean value so we can return early if MSA is not enabled (the instruction got decoded properly, but we raised an exception). Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v2: return true (opcode decoded) because the opcode is decoded, reword --- target/mips/tcg/msa_translate.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index bc57e06d923..5acb27f1d71 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -293,19 +293,24 @@ void msa_translate_init(void) } } =20 -static inline int check_msa_access(DisasContext *ctx) +/* + * Check if MSA is enabled. + * This function is always called with MSA available. + * If MSA is disabled, raise an exception. + */ +static inline bool check_msa_enabled(DisasContext *ctx) { if (unlikely((ctx->hflags & MIPS_HFLAG_FPU) && !(ctx->hflags & MIPS_HFLAG_F64))) { gen_reserved_instruction(ctx); - return 0; + return false; } =20 if (unlikely(!(ctx->hflags & MIPS_HFLAG_MSA))) { generate_exception_end(ctx, EXCP_MSADIS); - return 0; + return false; } - return 1; + return true; } =20 static void gen_check_zero_element(TCGv tresult, uint8_t df, uint8_t wt, @@ -337,7 +342,9 @@ static bool gen_msa_BxZ_V(DisasContext *ctx, int wt, in= t s16, TCGCond cond) { TCGv_i64 t0; =20 - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -369,7 +376,9 @@ static bool trans_BNZ_V(DisasContext *ctx, arg_msa_bz *= a) =20 static bool gen_msa_BxZ(DisasContext *ctx, int df, int wt, int s16, bool i= f_not) { - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 if (ctx->hflags & MIPS_HFLAG_BMASK) { gen_reserved_instruction(ctx); @@ -2141,7 +2150,9 @@ static bool trans_MSA(DisasContext *ctx, arg_MSA *a) { uint32_t opcode =3D ctx->opcode; =20 - check_msa_access(ctx); + if (!check_msa_enabled(ctx)) { + return true; + } =20 switch (MASK_MSA_MINOR(opcode)) { case OPC_MSA_I8_00: --=20 2.31.1