From nobody Mon Feb 9 17:25:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1635358073; cv=none; d=zohomail.com; s=zohoarc; b=BiqoIYPcIaBMlkdF6rEoC1wINjj/DA5qkTi7YGSN+HXO8e1s5T/oz6wykgw0+emPsBgyxsJsCxxFjwSuRxVGw9jm7YWU01/7fNQRwZk2HpVg1pgl7hUyVFGzh0bRNgNh0eiz3QPF3WtHxw9ZJBPuZkYo4AsQTXMb8y7Oeza8Otk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1635358073; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w1WlsmvsxrgkCAUcSauJsghkKBvyVMTDwpkFjialjgo=; b=MIzzbiShgLj3C+tZyrtQiar6PvX0EKgchAmvAWGs7wRko759e1YSeink5Okz9XCmDzoUnBxWz4zZUneJclIr7ZHOdiup/Iwj2iv5LJZnE3eQgXPw32/KMzfZTZFh4yHZ9SRMQdnKePySaMOmQUWinKEi3qhR7eQSQ2PnAsptvjA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1635358073955419.4743209282093; Wed, 27 Oct 2021 11:07:53 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id j35-20020a05600c1c2300b0032caeca81b7so3359501wms.0 for ; Wed, 27 Oct 2021 11:07:53 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id g19sm527171wmg.34.2021.10.27.11.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 11:07:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w1WlsmvsxrgkCAUcSauJsghkKBvyVMTDwpkFjialjgo=; b=bPy5lemmKeRXFUW+DmRo4st0ui6UCkx/H1jRlJZtsVrQ+u85vCx+9RpJqyot0CJwYP uu3WHtOIO841tPijZEE6a6KJ/qGVjl6nGFh81iVaLSNv6M8bCgQN8DdXhnQeQHHZLplS Z1VsM/8hGSSFNAjurbDc1GM2l+nacXpyyThp1GD64BR8CfjNHPAdlFq8LV/0qZD1eJ62 Hf8ZaSN/uQ4aJ48LHDk5teCv3Bq3PSMtVEBhPrGKI4Iv5RCIfF/KuonjVNbz2ELDn1D1 k4D87U+WbHW0Kv5Czy/iLfSytbdOn84AlYpFpcSQiJ/oTZNn6PdwJGbU+AyKbsc9qwcr 9OYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=w1WlsmvsxrgkCAUcSauJsghkKBvyVMTDwpkFjialjgo=; b=3JWlcURpuNcFnPerQb8OppBR1ppt7zzeJ6b62+o/WUQWu+/tQCzO+IOCD6i7JxW763 SKzFgqWkdumw3UfVEY7SqLIAav3JWPYjLdIEcDdqk6LX52scxH6+G15EHjiimmXZAZw3 azBRuiBcA5+dYTHGAIEdIQg8ntNm2x0qW5qUABadw2zXxeD49bFprfm3UXL0WIfHpjJw oT4xc79keXSHjeooZkPb4cfGPq01upgQPnTsIqz83phWt8XUimhxZxyIPlQJ4hfyYG82 Gaa3XzuOWSH+uc4EHrkFOaBOcXXMooWfDqXhMqApA/K6HtKdw4Ef+tLt+RqjLbsL78Hs qrww== X-Gm-Message-State: AOAM531zD3pxILJUi7ttGhgo1ZqsGS9p7M3PGpkXbJigdjMaS5rd37nz CxBODoyFSaV7BmTYJSl5y3dcfMtCRhM= X-Google-Smtp-Source: ABdhPJwj7ei661WUAceyBFYCC+HmqQ4IPO7yEjITfI0I/UMCSu57fmKDD1z6MFIMLN2gvDXd5AZ22Q== X-Received: by 2002:a7b:c103:: with SMTP id w3mr7349823wmi.145.1635358072231; Wed, 27 Oct 2021 11:07:52 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH v2 04/32] target/mips: Use dup_const() to simplify Date: Wed, 27 Oct 2021 20:07:02 +0200 Message-Id: <20211027180730.1551932-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211027180730.1551932-1-f4bug@amsat.org> References: <20211027180730.1551932-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1635358075883100002 The dup_const() helper makes the code easier to follow, use it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_translate.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index 3ef912da6b8..bc57e06d923 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -313,28 +313,11 @@ static void gen_check_zero_element(TCGv tresult, uint= 8_t df, uint8_t wt, { /* generates tcg ops to check if any element is 0 */ /* Note this function only works with MSA_WRLEN =3D 128 */ - uint64_t eval_zero_or_big =3D 0; - uint64_t eval_big =3D 0; + uint64_t eval_zero_or_big =3D dup_const(df, 0x01); + uint64_t eval_big =3D dup_const(df, 0x80); TCGv_i64 t0 =3D tcg_temp_new_i64(); TCGv_i64 t1 =3D tcg_temp_new_i64(); - switch (df) { - case DF_BYTE: - eval_zero_or_big =3D 0x0101010101010101ULL; - eval_big =3D 0x8080808080808080ULL; - break; - case DF_HALF: - eval_zero_or_big =3D 0x0001000100010001ULL; - eval_big =3D 0x8000800080008000ULL; - break; - case DF_WORD: - eval_zero_or_big =3D 0x0000000100000001ULL; - eval_big =3D 0x8000000080000000ULL; - break; - case DF_DOUBLE: - eval_zero_or_big =3D 0x0000000000000001ULL; - eval_big =3D 0x8000000000000000ULL; - break; - } + tcg_gen_subi_i64(t0, msa_wr_d[wt << 1], eval_zero_or_big); tcg_gen_andc_i64(t0, t0, msa_wr_d[wt << 1]); tcg_gen_andi_i64(t0, t0, eval_big); --=20 2.31.1